Summary: This diff converts the CrashReporter plugin to Sandy. The main driver is that it allows us to fix the connection management of logs in a next diff. There are few changes to highlight: * A bunch of the old unit tests are removed, as they primarily verified that persistedState abstraction works, a concept that doesn't exist anymore with Sandy (as a result all the logic in error handling and crash reporter plugin has become a lot more trivial as well) * Added additional unit tests to verify that the integration with notifications from Sandy, and the integration of crashes in combination with CrashReporter plugin works (this wasn't the case before) * Plugin errors were always suppressed in production builds of Flipper. However, that makes error reporting pretty pointless in the first place, so enabled it by default, but made it a setting in case this results in too many errors suddenly. * The integration with clicking OS crash notification -> bringing the user to a sensible place _doesn't_ work, but it didn't work before this diff either, so will address that later * This doesn't upgrade the Crash reporter UI to sandy yet, will do that later in a separate diff Changelog: Crash reporter will now report errors triggered from the device / client plugins by default. This can be disabled in settings. Reviewed By: priteshrnandgaonkar Differential Revision: D27044507 fbshipit-source-id: 8233798f5cce668d61460c948c24bdf92ed7c834
41 lines
890 B
JSON
41 lines
890 B
JSON
{
|
|
"$schema": "https://fbflipper.com/schemas/plugin-package/v2.json",
|
|
"name": "flipper-plugin-crash-reporter",
|
|
"id": "CrashReporter",
|
|
"pluginType": "device",
|
|
"supportedDevices": [
|
|
{
|
|
"os": "Android",
|
|
"type": "emulator"
|
|
},
|
|
{
|
|
"os": "Android",
|
|
"type": "physical"
|
|
},
|
|
{
|
|
"os": "iOS",
|
|
"type": "emulator"
|
|
}
|
|
],
|
|
"version": "0.0.0",
|
|
"description": "A plugin which will display a crash",
|
|
"main": "dist/bundle.js",
|
|
"flipperBundlerEntry": "index.tsx",
|
|
"repository": "https://github.com/facebook/flipper",
|
|
"license": "MIT",
|
|
"keywords": [
|
|
"flipper-plugin"
|
|
],
|
|
"title": "Crash Reporter",
|
|
"bugs": {
|
|
"email": "prit91@fb.com",
|
|
"url": "https://fb.workplace.com/groups/220760072184928/"
|
|
},
|
|
"dependencies": {
|
|
"unicode-substring": "^1.0.0"
|
|
},
|
|
"peerDependencies": {
|
|
"flipper-plugin": "0.0.0"
|
|
}
|
|
}
|