ff076d9dcd
Summary: If an exception is thrown from the plugin, FlipperClient.cpp will catch it and respond with an error response. If the object goes out of scope with no response being returned, then return a success response in the destructor. Reviewed By: passy Differential Revision: D14024259 fbshipit-source-id: 52e419dd23fc3882e8b92b593e8c1e1ea90e2b26
86 lines
2.7 KiB
C++
86 lines
2.7 KiB
C++
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the LICENSE
|
|
* file in the root directory of this source tree.
|
|
*/
|
|
#include <Flipper/FlipperResponderImpl.h>
|
|
#include "yarpl/Flowable.h"
|
|
#include "yarpl/Single.h"
|
|
#include "yarpl/single/SingleTestObserver.h"
|
|
|
|
#include <folly/json.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace facebook {
|
|
namespace flipper {
|
|
namespace test {
|
|
|
|
using folly::dynamic;
|
|
|
|
void assertIsSuccess(folly::dynamic d);
|
|
void assertIsError(folly::dynamic d);
|
|
|
|
TEST(FlipperResponderImplTest, testSuccessWrapper) {
|
|
auto dynamicSingle =
|
|
yarpl::single::Single<folly::dynamic>::create([](auto observer) mutable {
|
|
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
|
|
auto responder = std::make_shared<FlipperResponderImpl>(observer);
|
|
responder->success(folly::dynamic::object("my", "object"));
|
|
});
|
|
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
|
|
dynamicSingle->subscribe(to);
|
|
|
|
to->awaitTerminalEvent();
|
|
auto output = to->getOnSuccessValue();
|
|
assertIsSuccess(output);
|
|
EXPECT_EQ(output["success"]["my"], "object");
|
|
}
|
|
|
|
TEST(FlipperResponderImplTest, testErrorWrapper) {
|
|
auto dynamicSingle =
|
|
yarpl::single::Single<folly::dynamic>::create([](auto observer) mutable {
|
|
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
|
|
auto responder = std::make_shared<FlipperResponderImpl>(observer);
|
|
responder->error(folly::dynamic::object("my", "object"));
|
|
});
|
|
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
|
|
dynamicSingle->subscribe(to);
|
|
|
|
to->awaitTerminalEvent();
|
|
auto output = to->getOnSuccessValue();
|
|
assertIsError(output);
|
|
EXPECT_EQ(output["error"]["my"], "object");
|
|
}
|
|
|
|
TEST(FlipperResponderImplTest, testNoExplicitResponseReturnsSuccess) {
|
|
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
|
|
{
|
|
auto dynamicSingle = yarpl::single::Single<folly::dynamic>::create(
|
|
[](auto observer) mutable {
|
|
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
|
|
auto responder = std::make_shared<FlipperResponderImpl>(observer);
|
|
});
|
|
dynamicSingle->subscribe(to);
|
|
}
|
|
|
|
to->awaitTerminalEvent();
|
|
auto output = to->getOnSuccessValue();
|
|
assertIsSuccess(output);
|
|
EXPECT_TRUE(output["success"].empty());
|
|
}
|
|
|
|
void assertIsSuccess(folly::dynamic d) {
|
|
EXPECT_NE(d.find("success"), d.items().end());
|
|
EXPECT_EQ(d.find("error"), d.items().end());
|
|
}
|
|
|
|
void assertIsError(folly::dynamic d) {
|
|
EXPECT_NE(d.find("error"), d.items().end());
|
|
EXPECT_EQ(d.find("success"), d.items().end());
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace flipper
|
|
} // namespace facebook
|