661bea1d5b
Summary: Converted the Navigation plugin to Sandy, and updated Locations bookmark accordingly. This is a prerequisite step of supporting the bookmarkswidgetin the new AppInspect tab. Updated LocationsButton accordingly, and overal simplified implementation a bit; locationsbutton now reuses the logic of the NavigationPlugin, rather than reimplemting it. This reduces code duplication and also makes sure the state between plugin and location button stays in sync. Made sure that search providers are derived and cached rather than stored, again simplifying logic That being said, the navigation plugin is buggy, but all these things failed before this diff as well: * No events happening when using iOS, despite the plugin being enabled. But these seems to be a long time know issue, looks like it was never implemented * Not sure if the parameterized bookmarks is working correctly * screenshots not always happening at the right time (but fixed a race condition where the wrong bookmark might get updated) * Locations button doesn't show up if the navigation plugin is supported but not enabled (will try to fix in next diff) Would be great if bnelo12 could do some exploratory testing to verify what ought to be working, but currently isn't. Reviewed By: cekkaewnumchai Differential Revision: D24860757 fbshipit-source-id: e4b56072de8c42af2ada0f5bb022cb9f8c04bb47
105 lines
3.3 KiB
TypeScript
105 lines
3.3 KiB
TypeScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
import {Bookmark} from '../types';
|
|
|
|
const FLIPPER_NAVIGATION_PLUGIN_DB = 'flipper_navigation_plugin_db';
|
|
const FLIPPER_NAVIGATION_PLUGIN_DB_VERSION = 1;
|
|
|
|
const BOOKMARKS_KEY = 'bookmarks';
|
|
|
|
const createBookmarksObjectStore = (db: IDBDatabase) => {
|
|
return new Promise<void>((resolve, reject) => {
|
|
if (!db.objectStoreNames.contains(BOOKMARKS_KEY)) {
|
|
const bookmarksObjectStore = db.createObjectStore(BOOKMARKS_KEY, {
|
|
keyPath: 'uri',
|
|
});
|
|
bookmarksObjectStore.transaction.oncomplete = () => resolve();
|
|
bookmarksObjectStore.transaction.onerror = () =>
|
|
reject(bookmarksObjectStore.transaction.error);
|
|
} else {
|
|
resolve();
|
|
}
|
|
});
|
|
};
|
|
|
|
const initializeNavigationPluginDB = (db: IDBDatabase) => {
|
|
return Promise.all([createBookmarksObjectStore(db)]);
|
|
};
|
|
|
|
const openNavigationPluginDB: () => Promise<IDBDatabase> = () => {
|
|
return new Promise((resolve, reject) => {
|
|
const openRequest = window.indexedDB.open(
|
|
FLIPPER_NAVIGATION_PLUGIN_DB,
|
|
FLIPPER_NAVIGATION_PLUGIN_DB_VERSION,
|
|
);
|
|
openRequest.onupgradeneeded = () => {
|
|
const db = openRequest.result;
|
|
initializeNavigationPluginDB(db).then(() => resolve(db));
|
|
};
|
|
openRequest.onerror = () => reject(openRequest.error);
|
|
openRequest.onsuccess = () => resolve(openRequest.result);
|
|
});
|
|
};
|
|
|
|
export const writeBookmarkToDB = (bookmark: Bookmark) => {
|
|
return new Promise((resolve, reject) => {
|
|
openNavigationPluginDB()
|
|
.then((db: IDBDatabase) => {
|
|
const bookmarksObjectStore = db
|
|
.transaction(BOOKMARKS_KEY, 'readwrite')
|
|
.objectStore(BOOKMARKS_KEY);
|
|
const request = bookmarksObjectStore.put(bookmark);
|
|
request.onsuccess = () => resolve();
|
|
request.onerror = () => reject(request.error);
|
|
})
|
|
.catch(reject);
|
|
});
|
|
};
|
|
|
|
export const readBookmarksFromDB: () => Promise<Map<string, Bookmark>> = () => {
|
|
return new Promise((resolve, reject) => {
|
|
const bookmarks = new Map();
|
|
openNavigationPluginDB()
|
|
.then((db: IDBDatabase) => {
|
|
const bookmarksObjectStore = db
|
|
.transaction(BOOKMARKS_KEY)
|
|
.objectStore(BOOKMARKS_KEY);
|
|
const request = bookmarksObjectStore.openCursor();
|
|
request.onsuccess = () => {
|
|
const cursor = request.result;
|
|
if (cursor) {
|
|
const bookmark = cursor.value;
|
|
bookmarks.set(bookmark.uri, bookmark);
|
|
cursor.continue();
|
|
} else {
|
|
resolve(bookmarks);
|
|
}
|
|
};
|
|
request.onerror = () => reject(request.error);
|
|
})
|
|
.catch(reject);
|
|
});
|
|
};
|
|
|
|
export const removeBookmarkFromDB: (uri: string) => Promise<void> = (uri) => {
|
|
return new Promise<void>((resolve, reject) => {
|
|
openNavigationPluginDB()
|
|
.then((db: IDBDatabase) => {
|
|
const bookmarksObjectStore = db
|
|
.transaction(BOOKMARKS_KEY, 'readwrite')
|
|
.objectStore(BOOKMARKS_KEY);
|
|
const request = bookmarksObjectStore.delete(uri);
|
|
request.onsuccess = () => resolve();
|
|
request.onerror = () => reject(request.error);
|
|
})
|
|
.catch(reject);
|
|
});
|
|
};
|