4a3de26a88
Summary: Flipper exposes a call() api to plugins which lets them call their sdk component, and it returns a promise with the response. Currently this is done by sending a fireAndForget request, noting the id of the request, and then receiving fireAndForget requests and matching up the ids to give the result back to the right plugin promise. Instead, it will be simpler to use rsocket requestResponse, instead of fireAndForget, which is for this exact use case. This diff adds a requestResponse handler to the SDK, so that it can deal with such requests and respond accordingly, while preserving the current functionality if it receives a fireAndForget. So this part is backwards compatible and should be safe to land in isolation. A later diff will change the desktop app to use requestResponse, which may not be backwards compatible, so that will have to be deployed more carefully. Reviewed By: passy Differential Revision: D13974049 fbshipit-source-id: b371d94a86b1f186375161ed8f2242a462ce418f
44 lines
1.3 KiB
C++
44 lines
1.3 KiB
C++
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the LICENSE
|
|
* file in the root directory of this source tree.
|
|
*/
|
|
#pragma once
|
|
|
|
#include <folly/io/async/EventBase.h>
|
|
#include <folly/json.h>
|
|
#include <rsocket/RSocketResponder.h>
|
|
#include "FlipperConnectionManager.h"
|
|
#include "FlipperResponder.h"
|
|
|
|
namespace facebook {
|
|
namespace flipper {
|
|
|
|
/* Responder to encapsulate yarpl observables and hide them from flipper core +
|
|
* plugins */
|
|
class FlipperResponderImpl : public FlipperResponder {
|
|
public:
|
|
FlipperResponderImpl(
|
|
std::shared_ptr<yarpl::single::SingleObserver<folly::dynamic>>
|
|
downstreamObserver)
|
|
: downstreamObserver_(downstreamObserver) {}
|
|
|
|
void success(const folly::dynamic& response) const override {
|
|
const folly::dynamic message = folly::dynamic::object("success", response);
|
|
downstreamObserver_->onSuccess(message);
|
|
}
|
|
|
|
void error(const folly::dynamic& response) const override {
|
|
const folly::dynamic message = folly::dynamic::object("error", response);
|
|
downstreamObserver_->onSuccess(message);
|
|
}
|
|
|
|
private:
|
|
std::shared_ptr<yarpl::single::SingleObserver<folly::dynamic>>
|
|
downstreamObserver_;
|
|
};
|
|
|
|
} // namespace flipper
|
|
} // namespace facebook
|