c628ad7cbd
Summary: There was a error on bundling plugins which references a shared lib, because of wrong check during babel transformation. Reviewed By: passy Differential Revision: D22041443 fbshipit-source-id: c157675c05e9d9653b65ed30293e3b8b09bae260
76 lines
2.3 KiB
TypeScript
76 lines
2.3 KiB
TypeScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
import {CallExpression, Identifier, isStringLiteral} from '@babel/types';
|
|
import {NodePath} from '@babel/traverse';
|
|
import {resolve, dirname} from 'path';
|
|
|
|
import {
|
|
tryReplaceFlipperRequire,
|
|
tryReplaceGlobalReactUsage,
|
|
} from './replace-flipper-requires';
|
|
|
|
// do not apply this transform for these paths
|
|
const EXCLUDE_PATHS = [
|
|
'/node_modules/react-devtools-core/',
|
|
'relay-devtools/DevtoolsUI',
|
|
];
|
|
function isExcludedPath(path: string) {
|
|
for (const epath of EXCLUDE_PATHS) {
|
|
if (path.indexOf(epath) > -1) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
module.exports = () => ({
|
|
visitor: {
|
|
CallExpression(path: NodePath<CallExpression>, state: any) {
|
|
if (isExcludedPath(state.file.opts.filename)) {
|
|
return;
|
|
}
|
|
if (!tryReplaceFlipperRequire(path)) {
|
|
const node = path.node;
|
|
const args = node.arguments || [];
|
|
if (
|
|
node.callee.type === 'Identifier' &&
|
|
node.callee.name === 'require' &&
|
|
args.length === 1 &&
|
|
isStringLiteral(args[0]) &&
|
|
// require a file not a pacakge
|
|
args[0].value.indexOf('/') > -1 &&
|
|
// in the plugin itself and not inside one of its dependencies
|
|
state.file.opts.filename.startsWith(state.file.opts.root) &&
|
|
// the resolved path for this file is outside the plugins root
|
|
!resolve(dirname(state.file.opts.filename), args[0].value).startsWith(
|
|
state.file.opts.root,
|
|
)
|
|
) {
|
|
throw new Error(
|
|
`Plugins cannot require files from outside their folder. ` +
|
|
`Attempted to require "${args[0].value}" ` +
|
|
`from file "${state.file.opts.filename}" resolved to ` +
|
|
`"${resolve(
|
|
dirname(state.file.opts.filename),
|
|
args[0].value,
|
|
)}" ` +
|
|
`which isn't inside plugin dir "${state.file.opts.root}".`,
|
|
);
|
|
}
|
|
}
|
|
},
|
|
Identifier(path: NodePath<Identifier>, state: any) {
|
|
if (isExcludedPath(state.file.opts.filename)) {
|
|
return;
|
|
}
|
|
tryReplaceGlobalReactUsage(path);
|
|
},
|
|
},
|
|
});
|