jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
2564bce5a00f190fbc6a30bc096896316d79cfcf
flipper/src/ui/components
History
JianyingLi 2564bce5a0 Fix DataInspector Component diff some problems. (#397) 
Summary:
1. In `diffMetadataExtractor` function, when the `data` or `diff` is `null`, it diff view does not display correctly.

```jsx

<Panel floating={false} heading={'Test'}>
  <ManagedDataInspector
    diff={{
      auth: null
    }}
    data={{
      auth: {
        user: {
          name: 'JianyingLi'
        }
      }
    }}
    expandRoot={true}
  />
</Panel>
```

Before:
![2561552808023_ pic](https://user-images.githubusercontent.com/3889523/54486986-db383b80-48ca-11e9-9869-a008f72f4324.jpg)

After:
![2551552807969_ pic](https://user-images.githubusercontent.com/3889523/54486992-ea1eee00-48ca-11e9-90b0-7fd043f1c2bd.jpg)

2. Status `added`(green) and `removed`(red) should be the opposite

```jsx
<ManagedDataInspector
  diff={{
    user: {
      name: 'Leo'
    }
  }}
  data={{
    user: {
      name: 'JianyingLi'
    }
  }}
  expandRoot={true}
/>
```

Before:
![2591552808195_ pic](https://user-images.githubusercontent.com/3889523/54487019-35390100-48cb-11e9-8c20-1526aeae52a1.jpg)

After:
![2581552808145_ pic](https://user-images.githubusercontent.com/3889523/54487022-3c600f00-48cb-11e9-9ea9-75a8c8490c22.jpg)
Pull Request resolved: https://github.com/facebook/flipper/pull/397

Reviewed By: danielbuechele

Differential Revision: D14505757

Pulled By: passy

fbshipit-source-id: 35ca1bf8721468fdde13f3a9ede75cb72a59caea
2019-03-19 17:04:15 -07:00
..
__tests__
MarkerTimeline
2018-12-14 10:35:12 -08:00
data-inspector
Fix DataInspector Component diff some problems. (#397)
2019-03-19 17:04:15 -07:00
elements-inspector
Run prettier fix
2019-03-15 05:13:30 -07:00
filter
table filter and icons enhancements
2018-09-21 10:52:02 -07:00
intro
rename fill attribute
2018-10-22 09:54:59 -07:00
searchable
remove console.log
2019-02-25 03:01:30 -08:00
table
createPaste
2019-02-28 07:28:25 -08:00
Block.js
convert to emotion
2018-08-23 09:42:18 -07:00
Box.js
convert to emotion
2018-08-23 09:42:18 -07:00
Button.js
adding primary and compact buttons
2018-12-18 08:37:28 -08:00
ButtonGroup.js
updating UI documentation
2018-11-05 03:12:23 -08:00
ButtonNavigationGroup.js
updating UI documentation
2018-11-05 03:12:23 -08:00
Checkbox.js
updating UI documentation
2018-11-05 03:12:23 -08:00
CodeBlock.js
convert to emotion
2018-08-23 09:42:18 -07:00
colors.js
Improve CrashReporter UI for the latest crash
2019-03-19 08:18:13 -07:00
console.js
rename fill attribute
2018-10-22 09:54:59 -07:00
ContextMenu.js
Enable override of context menu on ManagedTable. (#352)
2019-01-09 03:52:56 -08:00
ContextMenuProvider.js
updating UI documentation
2018-11-05 03:12:23 -08:00
desktop-toolbar.js
convert to emotion
2018-08-23 09:42:18 -07:00
ErrorBlock.js
updating UI documentation
2018-11-05 03:12:23 -08:00
ErrorBoundary.js
updating UI documentation
2018-11-05 03:12:23 -08:00
File.js
updating UI documentation
2018-11-05 03:12:23 -08:00
FileList.js
updating UI documentation
2018-11-05 03:12:23 -08:00
FlexBox.js
updating UI documentation
2018-11-05 03:12:23 -08:00
FlexCenter.js
Fixed typos in Flex* component documentation
2019-01-11 02:58:16 -08:00
FlexColumn.js
Fixed typos in Flex* component documentation
2019-01-11 02:58:16 -08:00
FlexRow.js
Fixed typos in Flex* component documentation
2019-01-11 02:58:16 -08:00
FocusableBox.js
convert to emotion
2018-08-23 09:42:18 -07:00
Glyph.js
adding primary and compact buttons
2018-12-18 08:37:28 -08:00
Heading.js
updating UI documentation
2018-11-05 03:12:23 -08:00
HorizontalRule.js
convert to emotion
2018-08-23 09:42:18 -07:00
Input.js
convert to emotion
2018-08-23 09:42:18 -07:00
Interactive.js
fix imports
2019-01-29 09:32:05 -08:00
Label.js
convert to emotion
2018-08-23 09:42:18 -07:00
Link.js
convert to emotion
2018-08-23 09:42:18 -07:00
LoadingIndicator.js
convert to emotion
2018-08-23 09:42:18 -07:00
MarkerTimeline.js
MarkerTimeline
2018-12-14 10:35:12 -08:00
ModalOverlay.js
convert to emotion
2018-08-23 09:42:18 -07:00
Orderable.js
convert to emotion
2018-08-23 09:42:18 -07:00
Panel.js
fix colorpicker in panel. Fixes #396
2019-03-19 04:17:40 -07:00
PathBreadcrumbs.js
Initial commit 🎉
2018-06-01 11:03:58 +01:00
Popover.js
add litho accessibility rendering to Flipper accessibility mode [1/2]
2018-09-07 14:58:00 -07:00
ResizeSensor.js
updating UI documentation
2018-11-05 03:12:23 -08:00
Select.js
UI fixes
2018-11-07 06:27:33 -08:00
Sheet.js
Sheet component for plugins
2019-01-09 10:48:18 -08:00
Sidebar.js
convert to emotion
2018-08-23 09:42:18 -07:00
SidebarLabel.js
convert to emotion
2018-08-23 09:42:18 -07:00
StackTrace.js
StackTrace
2018-12-14 10:35:12 -08:00
Tab.js
updating UI documentation
2018-11-05 03:12:23 -08:00
Tabs.js
rename fill attribute
2018-10-22 09:54:59 -07:00
Text.js
convert to emotion
2018-08-23 09:42:18 -07:00
Textarea.js
convert to emotion
2018-08-23 09:42:18 -07:00
TextParagraph.js
convert to emotion
2018-08-23 09:42:18 -07:00
ToggleSwitch.js
Rename package to 'flipper'
2018-09-18 07:01:16 -07:00
Toolbar.js
convert to emotion
2018-08-23 09:42:18 -07:00
Tooltip.js
updating UI documentation
2018-11-05 03:12:23 -08:00
TooltipProvider.js
Update Tooltip implementation for Flipper
2018-09-04 10:44:12 -07:00
VerticalRule.js
convert to emotion
2018-08-23 09:42:18 -07:00
View.js
rename fill attribute
2018-10-22 09:54:59 -07:00
ViewWithSize.js
Initial commit 🎉
2018-06-01 11:03:58 +01:00
VirtualList.js
rename fill attribute
2018-10-22 09:54:59 -07:00