02d695cb28
Summary:
This diff changes directory structure for installed plugins to allow installation of multiple versions simultaneously, e.g. to to allow downloading new plugin version while user is still using the previous one, and to have possibility of fast rollback to the previous installed if necessary. The new folder for installed plugins is located in `~/.flipper/installed-plugins` and has the following structure:
flipper-plugin-reactotron
1.0.0
...
package.json
1.0.1
...
package.json
flipper-plugin-network
0.67.1
...
package.json
0.67.2
...
package.json
The tricky part here is that we also need to migrate already installed plugins from the old folder `~/.flipper/thirdparty` to the new folder and maintain the new structure for them.
Another tricky part is that we need to periodically cleanup old versions. For now we will just keep 2 versions of each plugin. Cleanup is performed in background right after Flipper startup.
Reviewed By: mweststrate
Differential Revision: D25393474
fbshipit-source-id: 26617ac26114148f797cc3d6765a42242edc205e
114 lines
3.4 KiB
TypeScript
114 lines
3.4 KiB
TypeScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
jest.mock('flipper-plugin-lib');
|
|
|
|
import {default as PluginInstaller} from '../PluginInstaller';
|
|
import React from 'react';
|
|
import {render, waitForElement} from '@testing-library/react';
|
|
import configureStore from 'redux-mock-store';
|
|
import {Provider} from 'react-redux';
|
|
import type {PluginDetails} from 'flipper-plugin-lib';
|
|
import {getUpdatablePlugins, UpdatablePluginDetails} from 'flipper-plugin-lib';
|
|
import {Store} from '../../../reducers';
|
|
import {mocked} from 'ts-jest/utils';
|
|
|
|
const getUpdatablePluginsMock = mocked(getUpdatablePlugins);
|
|
|
|
function getStore(installedPlugins: PluginDetails[] = []): Store {
|
|
return configureStore([])({
|
|
application: {sessionId: 'mysession'},
|
|
pluginManager: {installedPlugins},
|
|
}) as Store;
|
|
}
|
|
|
|
const samplePluginDetails1: UpdatablePluginDetails = {
|
|
name: 'flipper-plugin-hello',
|
|
entry: './test/index.js',
|
|
version: '0.1.0',
|
|
specVersion: 2,
|
|
main: 'dist/bundle.js',
|
|
dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-sample1',
|
|
source: 'src/index.js',
|
|
id: 'Hello',
|
|
title: 'Hello',
|
|
description: 'World?',
|
|
isDefault: false,
|
|
updateStatus: {
|
|
kind: 'not-installed',
|
|
version: '0.1.0',
|
|
},
|
|
};
|
|
|
|
const samplePluginDetails2: UpdatablePluginDetails = {
|
|
name: 'flipper-plugin-world',
|
|
entry: './test/index.js',
|
|
version: '0.2.0',
|
|
specVersion: 2,
|
|
main: 'dist/bundle.js',
|
|
dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-sample2',
|
|
source: 'src/index.js',
|
|
id: 'World',
|
|
title: 'World',
|
|
description: 'Hello?',
|
|
isDefault: false,
|
|
updateStatus: {
|
|
kind: 'not-installed',
|
|
version: '0.2.0',
|
|
},
|
|
};
|
|
|
|
const SEARCH_RESULTS = [samplePluginDetails1, samplePluginDetails2];
|
|
|
|
afterEach(() => {
|
|
getUpdatablePluginsMock.mockClear();
|
|
});
|
|
|
|
test('load PluginInstaller list', async () => {
|
|
getUpdatablePluginsMock.mockReturnValue(Promise.resolve(SEARCH_RESULTS));
|
|
const component = (
|
|
<Provider store={getStore()}>
|
|
<PluginInstaller
|
|
// Bit ugly to have this as an effectively test-only option, but
|
|
// without, we rely on height information from Electron which we don't
|
|
// have, causing no items to be rendered.
|
|
autoHeight={true}
|
|
/>
|
|
</Provider>
|
|
);
|
|
const {container, getByText} = render(component);
|
|
await waitForElement(() => getByText('hello'));
|
|
expect(getUpdatablePluginsMock.mock.calls.length).toBe(1);
|
|
expect(container).toMatchSnapshot();
|
|
});
|
|
|
|
test('load PluginInstaller list with one plugin installed', async () => {
|
|
getUpdatablePluginsMock.mockReturnValue(
|
|
Promise.resolve([
|
|
{...samplePluginDetails1, updateStatus: {kind: 'up-to-date'}},
|
|
samplePluginDetails2,
|
|
]),
|
|
);
|
|
const store = getStore([samplePluginDetails1]);
|
|
const component = (
|
|
<Provider store={store}>
|
|
<PluginInstaller
|
|
// Bit ugly to have this as an effectively test-only option, but
|
|
// without, we rely on height information from Electron which we don't
|
|
// have, causing no items to be rendered.
|
|
autoHeight={true}
|
|
/>
|
|
</Provider>
|
|
);
|
|
const {container, getByText} = render(component);
|
|
await waitForElement(() => getByText('hello'));
|
|
expect(getUpdatablePluginsMock.mock.calls.length).toBe(1);
|
|
expect(container).toMatchSnapshot();
|
|
});
|