Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5000
Reviewed By: lblasa
Differential Revision: D48268231
Pulled By: passy
fbshipit-source-id: 9f28d68aeeca2c921a9298cbfad7c13e261b6900
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4994
Reviewed By: mweststrate
Differential Revision: D48112730
Pulled By: passy
fbshipit-source-id: 1429d64dc5c200a8af3eb162702cf81e1c9af72a
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4973
Reviewed By: lblasa
Differential Revision: D47916691
Pulled By: passy
fbshipit-source-id: c9f752b8c452b6b4dab0b550b5d12de31db106c0
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4971
Reviewed By: lblasa
Differential Revision: D47829475
Pulled By: passy
fbshipit-source-id: 6e897ecb76776be3b36de590fe76afa233e2e435
Summary:
UI Debugger initialisation is defined in two places. Internally, done inside:
fb/FlipperKitUIDebuggerPluginInit.mm
OSS:
FlipperKitUIDebuggerPluginInit.mm
Contents of `fb/` directory are not synced in OSS. OSS file is excluded internally as it doesn't use the XPlugins.
Reviewed By: aigoncharov
Differential Revision: D47759035
fbshipit-source-id: 3578be076525f05b530a0d129b5c37e48572d58e
Summary:
Use the application key window bounds if possible.
In the case where the application is not using the entire screen,
like in Split View on an iPad, the running application is
not using the entire screen thus the snapshot stretches to
fill the screen size which is incorrect.
Reviewed By: LukeDefeo
Differential Revision: D47793033
fbshipit-source-id: d6c7932d35bad13752713772d078f94bad530b09
Summary: When the length of `pkcs12.second.c_str()` is equal to `length`, strncpy won't write a null-terminator at the end of the destination string, making the destination unsafe to read and potentially cause an overflow.
Reviewed By: lblasa
Differential Revision: D46934320
fbshipit-source-id: 5e7acd49523b80105bcc47471facd9ff23b8a2b8
Summary: Set delegate and close inside the operation's queue as to make it safer i.e. all socket related operations are done inside the queue.
Reviewed By: ivanmisuno
Differential Revision: D47124235
fbshipit-source-id: 48b53db1cd47d017a26186a156046ba68fe358b7
Summary:
About to release React Native 0.72.1. This version of React Native has to depend on SocketRocket 0.7.0, released yesterday.
Cocoapods is failing to install dependencies with the following error:
```
In snapshot (Podfile.lock):
SocketRocket (= 0.7.0)
In Podfile:
FlipperKit/FlipperKitReactPlugin (= 0.182.0) was resolved to 0.182.0, which depends on
FlipperKit/Core (= 0.182.0) was resolved to 0.182.0, which depends on
SocketRocket (~> 0.6.0)
React-Core/RCTWebSocket (from `../react-native/`) was resolved to 1000.0.0, which depends on
SocketRocket (= 0.7.0)
React-CoreModules (from `../react-native/React/CoreModules`) was resolved to 1000.0.0, which depends on
SocketRocket
```
By bumping the SocketRocket dependencies and publishing a new version of FlipperKit, we would be able to release React Native.
Reviewed By: passy, cipolleschi
Differential Revision: D47125059
fbshipit-source-id: d0797880c502c14db9f0261c3e8abf2652e7bba2
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4890
Reviewed By: ivanmisuno
Differential Revision: D47091378
Pulled By: passy
fbshipit-source-id: 254b1a6ca737c2ccfa40db3bae147d0db1b1594b
Summary:
Never really liked this code. Before this change, calls to connect were blocking.
Because of this, we had to make use of promises and a bit of really not that good-looking code.
So, this change makes connect non-blocking meaning that we make full use of our event handler.
These changes contain:
- CSR is not getting generated after each failed attempt.
- Connect is no longer blocking.
- Do not report events via the handler when explicitly disconnecting.
Reviewed By: jknoxville
Differential Revision: D46853228
fbshipit-source-id: 00e6a9c7c039a756175fe14982959e078d92bacb
Summary: Expose the newly created `isConnected` API to iOS FlipperClient API.
Reviewed By: antonk52
Differential Revision: D46841190
fbshipit-source-id: c36eb08427d60c73fad8f92100df5d012149b4a8
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4836
Reviewed By: lblasa
Differential Revision: D46756889
Pulled By: passy
fbshipit-source-id: 8151a079e6a80a7bdd729bb836cdfeb6cc331994
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4830
YogaKit is a library which allows integrating Yoga layouts directly with UIKit. It is not used by higher level libraries like ComponentKit or React Native, but is used by a smattering of surfaces and shared components in Origami Studio and Instagram. See the following search for `YogaKit/UIView+Yoga.h`.
{F1026467213}
It is not really being developed anymore, and doesn't have much of a future, so I am deprecating it in OSS, to remove after the next OSS Yoga release. This means Flipper in OSS will not be able to rely on it.
Instead of special-casing for OSS vs not, this change removes the current YogaKit integration with the layout plugin, since it sounds like we are building a new layout plugin anyway, and I'm not aware of any new surfaces being built on top of YogaKit.
Removing Yoga as a dependency from Flipper should also allow us to fixup the current OSS Flipper build, along with a whole bunch of hacks RN's open source build currently does to produce a Yoga pod compatible with both RN and Flipper.
There are probably some OSS related lockfiles that can be updated after this, for things like the FlipperKit sample app. I did not do that as part of this change, since I don't know how healthy all of that infra is or how it integrates with the offline mirror used.
Reviewed By: passy
Differential Revision: D46664918
fbshipit-source-id: 9d4dd56aa4c7f55e97ac643aa6e4deb9375e582c
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4826
Reviewed By: lblasa
Differential Revision: D46679156
Pulled By: passy
fbshipit-source-id: 81cf60d16ea7ce2954ce16896f2dec84b11119c2
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4794
Reviewed By: antonk52
Differential Revision: D46355046
Pulled By: passy
fbshipit-source-id: e676d4c9d8bef0b3ab29bc9e6cb23838b262c5bf
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4661
Reviewed By: ivanmisuno
Differential Revision: D44995374
Pulled By: passy
fbshipit-source-id: 4c93a3750da5ae9977e62451e0bf7f3717b8c233
Summary:
The 14.3 toolchain includes `-Wstrict-prototypes` in `-Wall`. Add it to the default warning list to ensure the code is buildable with the 14.3 toolchain.
Please forward fix any build breakage introduced by this change.
Reviewed By: NSProgrammer
Differential Revision: D44371491
fbshipit-source-id: 257c7f7748b079a34ffd5c041339d518bef9d1e5
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4624
Reviewed By: passy
Differential Revision: D44301473
Pulled By: aigoncharov
fbshipit-source-id: 8edee27e69b441aed959e9555a1fe5e1d1582e88
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4604
Reviewed By: mweststrate
Differential Revision: D44131877
Pulled By: passy
fbshipit-source-id: b1ce5dd121c077e88db2c9d916edd79b7d383f18
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4528
Reviewed By: ivanmisuno
Differential Revision: D43974467
Pulled By: passy
fbshipit-source-id: b2a0b3539add658f59221acadc6701bdcae3238c
Summary: This appears to be unreferenced and it constantly confuses our header autocomplete. Remove.
Reviewed By: d16r
Differential Revision: D43408140
fbshipit-source-id: ff6db8e5e4bbda394197168680cf8d15b07666c3
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4522
^
A codemod changed the name of `CKMountable` for the OSS ComponentKit integration, this is a breaking change as we are pinned to a specific Cocoapods version of CK.
Reviewed By: passy
Differential Revision: D43303489
fbshipit-source-id: 4d8ad472735414ca8e67a8ce4409efe84aab3e94
Summary:
This change mainly removes the connection timeout period as it may introduce a race condition in which slow server connections get terminated potentially creating connection loops.
Also, suspend and wait for all operations to complete once a socket is disconnected.
Reviewed By: ivanmisuno
Differential Revision: D43048252
fbshipit-source-id: 64c28a3d3d2fd4e065084d5f55a17444385c07e0
Summary:
^
Revert as to validate this is not causing regressions: T143523262
Reviewed By: passy
Differential Revision: D42800560
fbshipit-source-id: 8db61454eabfdb259637bb97c2bb4754984ecf6f
Summary:
^
SKDescriptorMapper owns the SKNodeDescriptor instances. SKNodeDescriptor instances should only have a weak reference to the mapper as to avoid retain cycles.
Reviewed By: passy
Differential Revision: D42673698
fbshipit-source-id: 8c98709b28fc3c711dc56c179c7c362417fa1f9d
Summary:
A few changes that should make our connect/disconnect more robust:
* Certificate provider handler should be set directly to and managed by the policy.
* Instantiate the socket once, synchronously on the connect method. Explicit deallocation once, synchronously on the disconnect method.
* Clear handlers on disconnect after clearing the delegate.
* Wait for the operation queue to drain before returning.
Reviewed By: passy
Differential Revision: D42664724
fbshipit-source-id: bd482acbb64a9bc9e36fb3418d4c81afa2109305
Summary:
The diagnostics controller is not the best crafted UIViewController. It has many things that should be improved.
- This diff just sets the background of the root view to white. At least, that will ensure that its text content is always shown if the screen background happens to be black (same as font colour).
- Correct offset calculation, used for scrolling. Effectively, only set it if the content to be displayed no longer fits in the scrollview viewport.
Reviewed By: LukeDefeo
Differential Revision: D41876904
fbshipit-source-id: e2a89d8f6001e5b626c8df1d0832e77783999b81
Summary:
On Android we already had an API to send raw arguments i.e. raw json as params.
This just adds feature parity on iOS.
Reviewed By: LukeDefeo
Differential Revision: D41433777
fbshipit-source-id: abd47f987b9e2b451100e81acf6fea61cd876807
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4271
Reviewed By: passy
Differential Revision: D40755392
Pulled By: aigoncharov
fbshipit-source-id: f296fe36535ff8744ddee6b6f9d2575d71c429f9
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4238
Reviewed By: aigoncharov
Differential Revision: D40636695
Pulled By: nikoant
fbshipit-source-id: fda37eba37dd286affe977d7a9046945c8aaaab8
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4235
Reviewed By: antonk52
Differential Revision: D40471242
Pulled By: aigoncharov
fbshipit-source-id: c8028f0b4be05ff5b9156443c52a86def4d1e179
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4210
Reviewed By: mweststrate
Differential Revision: D40341306
Pulled By: aigoncharov
fbshipit-source-id: 1383835dce4ede179cb49598f0b57840712975a9
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4176
Reviewed By: cekkaewnumchai
Differential Revision: D40095627
Pulled By: cekkaewnumchai
fbshipit-source-id: c37e6c148fb346a20e7c39a112ba7a441a81e386
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4156
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Static Docs Site previews have moved into the custom phabricator field "Static Docs", and will no longer modify test plans after 5th October 2022.
Reviewed By: antonk52
Differential Revision: D39931809
Pulled By: antonk52
fbshipit-source-id: eb234e760e9a6be321b7290ff20b5232e9840fed
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4025
Reviewed By: lblasa
Differential Revision: D38979176
Pulled By: cekkaewnumchai
fbshipit-source-id: d455bbdb5390340cd2b310d9be5045b088dbb994
Summary:
Plumbs through an optional name for FollyScopedThreadScheduler.
This allows the threads to be named in XCode/lldb.
Differential Revision: D38582449
fbshipit-source-id: 1de50d25c0f91e7003cf81cb22faf4b10a8e23a8
Summary: In a previous diff D32278523 (8764da7c0b) The desktop request was changed from send to call. Call expects a response and not all code paths return a response. Most calls to set highlight are timing out.
Reviewed By: mweststrate
Differential Revision: D38074704
fbshipit-source-id: 6e85416d6b6470efaa177ad1b74420c8237366d5
