Summary: We removed the console already from the client side. So this causes all calls to isConsoleEnabled to fail. This diffs removes these calls.
Reviewed By: passy
Differential Revision: D15449571
fbshipit-source-id: b702a8fbc80af002e1d8b7d37d5acc664ea5be99
Summary: When a node invalidates, all its children need to be updated. This was the case in v1 of Layout Inspector (3141b954bf/src/plugins/layout/index.js (L684-L692)) but got lost when writing v2.
Reviewed By: passy
Differential Revision: D15469096
fbshipit-source-id: 9ef5368387ccbce6e5c71de28c24f5790906cee9
Summary:
Fresco plugin on the desktop side used to ask for all the image list along with the metadata when it was mounted. The mobile side never sent the image list and other information if not requested from it. That means, although Fresco plugin is a background plugin, there weren't any messages sent from the mobile side. Thus there was no trace available for Images plugin when the trace was exported. This diff, adds a hook which gets called before the export, where we request all the metadata from the mobile SDK.
BUG:
{F159305887}
Reviewed By: passy
Differential Revision: D15407962
fbshipit-source-id: 0012de2ab29d0f62e92d00f4926b04b1e394b62a
Summary: Exports the `WASTED_BYTES` metric for the Images plugin. Currently its not possible to export the trace for Images Plugin, as all its listeners are setup in the init function of the component. Also it follows "pull" strategy, i.e Flipper asks for the data at component initialization. I will work on asking for the Fresco data when we terminate the headless, just like Layout Plugin.
Reviewed By: oprisnik
Differential Revision: D15393752
fbshipit-source-id: 4f0717ac5fb70a82aab5c803a4f92708d1faa9df
Summary: Add option to focus a view from the context menu.
Reviewed By: passy
Differential Revision: D15294182
fbshipit-source-id: f03db136e8365833beee3b4883d2114e98a280bd
Summary: This was already implemented in the old versin of layout inspector and got lost during the refactoring. When using talkback, the focused view is highlighted in green in the a11y inspector.
Reviewed By: passy
Differential Revision: D15294025
fbshipit-source-id: 92cc015e4bc726515e433b7b96f924246916972d
Summary: Fix the format of the export. Due to unknown reason the changes done in the D14933499 was [reverted back](https://our.intern.facebook.com/intern/diff/D14933499/?src_number=80619316) on the same diff. Thus this diff fixes the format of the metrics export
Reviewed By: passy
Differential Revision: D15239653
fbshipit-source-id: b9416f89e1b0022000d6201eb08ca1f456d5ed2e
Summary: Pushing all new rows into an array could result in duplicate entries. Now the data is stored in an object, using the row's id as a key. This deduplicates the data.
Reviewed By: jknoxville
Differential Revision: D15200794
fbshipit-source-id: 6afa2b7d02c1bdb796c250400938c38c51fdd207
Summary: In this step, we want to visualize our mammals in a custom card view. For this reason, we need to replace `createTablePlugin` with a React component that extends `FlipperPlugin`.
Reviewed By: jknoxville
Differential Revision: D15183324
fbshipit-source-id: 329cdc5c6cbd7e1435538e8cdddf049d914ff221
Summary: Per title. It's very basic, which is exactly the point.
Reviewed By: jknoxville
Differential Revision: D15182335
fbshipit-source-id: f70f8cd0510a605879dccb9f909f84971a4eedc3
Summary: Makes the API a bit easier to use. Don't have to build an empty sidebar if you don't want one.
Reviewed By: passy
Differential Revision: D15064205
fbshipit-source-id: bd31c1aa97fd6d1c93717c10b268f49e44eb1299
Summary:
I haven't done this at the platform level (plugin.js) because the persistedStateReducer method signature prevents it unfortunately.
We might want to add a different method type at some point, like this one so you don't need to do this unsafe casting in the plugin itself, but for now, just doing it here.
Reviewed By: danielbuechele
Differential Revision: D15080331
fbshipit-source-id: c51749ac84cd38559d85089557f44ace8ae6e08b
Summary:
This diff makes headless flipper accept `metrics` argument. Once this is passed. The headless flipper will terminate to export the metrics of the plugins, the type of the export looks like the following.
```
export type MetricType = {[metricName: string]: number};
type MetricPluginType = {[pluginID: string]: MetricType};
export type ExportMetricType = {[clientID: string]: MetricPluginType};
```
This diff, uses the store to export the metrics. I will modify the logic to accept the data which gets exported through `exportData`
Reviewed By: passy
Differential Revision: D14933499
fbshipit-source-id: dade5b7bc59ea4beb6d16c5ef471737e8597358a
Summary: Separating out the types and utils for work I'm doing on https://github.com/facebook/flipper/pull/415 / D14973754. This will make the request to curl utility function much cleaner
Reviewed By: jknoxville
Differential Revision: D14976747
fbshipit-source-id: cc15c10103ea75945d0a2ebaaa6d32a376192961
Summary:
We've had a bunch of different options that were all binary
switches with very different ways of displaying them.
This consolidates them all to use ToggleSwitches. I think it
may still make sense to move them all to a sidebar as it's
the case for the Analytics plugin, but that's for another diff.
Reviewed By: danielbuechele
Differential Revision: D14933392
fbshipit-source-id: 7ef286b61142a564a7cde6de875266ac8641704b
Summary:
As seen in https://our.intern.facebook.com/intern/bug/653953588368620/,
the network plugin can crash if content doesn't look like a URI.
Ideally, we'd be more granular in catching this, but for now skipping
that content seems better than crashing the entire plugin page.
Reviewed By: danielbuechele
Differential Revision: D14971610
fbshipit-source-id: 2708e5c0d4d1f584419d24c7dc38438009015565
Summary: the simpliest approach to render this metadata for debugging purpose
Reviewed By: bcuccioli
Differential Revision: D14974129
fbshipit-source-id: d816d1ef8dcd1bc333c4d0cdf70d6d9fb925bc03
Summary:
The crash logged from `ErrorReporterRunnable` wasn't detailed. For example look at the following video.
Also for some reason the `FlipperConnection` interface doesn't have an argument for crash name. Thus I changed the js side of the plugin to accept `crash.name` to be undefined.
{F155526537}
Reviewed By: passy
Differential Revision: D14852561
fbshipit-source-id: 6daf9847535b4508fa312b4f940b014911aae2e5
Summary:
I dislike the sprinkled eslint ignores. Let's put this
in one place and just depend on isProduction().
Reviewed By: jknoxville
Differential Revision: D14913057
fbshipit-source-id: 2f5a98b7dba1ac1829eaeab24290d2f66820edf9
Summary: I though I already did this, when releasing it. Apparently not.
Reviewed By: jknoxville
Differential Revision: D14854810
fbshipit-source-id: 4da61866925e06a415bfaed0f48e5434e769ec39
Summary: Adds ability to add things above and below the table when using native plugins.
Reviewed By: passy
Differential Revision: D14850839
fbshipit-source-id: cc7fa6d8055900c29f5af6f3460bc280c0a4a675
Summary: Before expanding what a table plugin can do, I'm extracting the createTablePlugin functionality into the native plugin component, so it can evolve independently without lots of forks in the code.
Reviewed By: passy
Differential Revision: D14800313
fbshipit-source-id: dbb34fe974c507663151daeb6631d1911b46f6df
Summary:
The reason was getting truncated, even though it had space to show the message. Look at the screenshot
BUG:
{F155254538}
Reviewed By: jknoxville
Differential Revision: D14775792
fbshipit-source-id: d18a458150c272c0c4e22cda9ea6459f96a70ea3
Summary:
For the native crash, the crash log is logged as seperate messages. So crash reporter plugin merges them together and fires one notification. The merrging logic is timer based, so if multiple crash log message is posted in 50ms, it will be combined in one notification.
For the above case, the "Open in Logs" functionality was broken, as we used to compare the entire callstack in one entry rather than in the multiple rows. This diff fixes this issue.
Bug:
{F155167144}
Reviewed By: jknoxville
Differential Revision: D14748956
fbshipit-source-id: d24db6d47fa3cd633a9002ac77f37c267ca4924f
Summary:
This adds an optional exit strategy that reacts to the client disconnecting rather than a `SIGINT` which can be used for integration tests.
`MiddlewareAPI` is a subset of `Store` and required to work here.
Annoyingly, it's not quite clear to me why this does not work as part of an event loop cycle and requires a `setTimeout`. This doesn't have any negative effects and works in the same way that the SIGINT interruption works, but it's a bit of an eyesore.
Reviewed By: danielbuechele
Differential Revision: D14622111
fbshipit-source-id: e2caca056e478428d977565dc9bc09eefca4230c
Summary:
Adds ability to send sidebar sections from the mobile app.
Currently implemented sections are json blob, and toolbar (row of buttons).
Note that I have not tested the toolbar with more than one button. I'm currently implementing features as needed so this should be considered alpha support at the moment.
Reviewed By: passy
Differential Revision: D14642879
fbshipit-source-id: 84876935337741422242285dc48da79af3a1d5ee
Summary: This diff allows user to copy crash name and crash reason in the clipboard
Reviewed By: jknoxville
Differential Revision: D14594212
fbshipit-source-id: 88a99af70e0e1aa5950e144a9072a8d96d7d3fc3
Summary:
Before this diff the notification fired for crash reporter had the entire callstack as its message, which is actually not required and it also makes a UI not good.
This diff just limits the message length
BUG:
{F154537911}
Reviewed By: passy
Differential Revision: D14594189
fbshipit-source-id: 663710e3e80be4367d0cc2a532fd4aa312cc0c1e
Summary:
This diff parses the `Date` from the crash log, so that the `Date` shown on the UI matches with the actual crash log
Bug:
{F154301489}
Added test too
Reviewed By: danielbuechele
Differential Revision: D14563053
fbshipit-source-id: b9dc7de11d7f17d6c7aa2afe5106b8f85c0a535c
Summary: This diff adds support to show multiple crashes in the crash reporter plugin. You can also select crashes from the list of the dropdown.
Reviewed By: danielbuechele
Differential Revision: D14513401
fbshipit-source-id: 621d32c5971519e5046daec76ec2f9b32ba4d8ce
Summary:
Native plugins are plugins that can be written in mobile code alone (java/objc), provided they conform to a template, currently table is the only implemented template.
This adds support to flipper for handling them.
Reviewed By: danielbuechele
Differential Revision: D14502188
fbshipit-source-id: a96be9b06de1cecf7977c4ef2fd05b168f7f1330
Summary: I have updated the UI of the crash reporter. It doesn't show the multiple crashes now. I will work on that in other diff. This diff just updates the current UI that shows the latest crash, as per the [design](https://our.intern.facebook.com/intern/px/p/pJ11/)
Reviewed By: danielbuechele
Differential Revision: D14399400
fbshipit-source-id: f6f28c2c6d386f4cd99a257922993ef355b1059b
Summary: Should also fix the build.
Reviewed By: jknoxville
Differential Revision: D14477777
fbshipit-source-id: 01fcfb2321c9b7a12acdf079473d91b6805d4dda
Summary:
Due to faulty condition default state was not being added in the persistedState, which casued the following bug.
{F153286217}
Reviewed By: danielbuechele
Differential Revision: D14425166
fbshipit-source-id: 557dc3717b650dae90dc44ad12970a684cecbf24
Summary: As per title. Target mode and Alignment mode doesn't make sense for archived devices.
Reviewed By: danielbuechele
Differential Revision: D14407780
fbshipit-source-id: cf6f56456674ad8fec422d6f84d58c6d5b211c25
Summary:
Bug: On search, the accessibility views didn't used to expand.Look at the following video to understand the bug
{F153135892}
Reviewed By: danielbuechele
Differential Revision: D14407511
fbshipit-source-id: 011bf31b5bd10f5a7dad3d5d30703ec3bdeaf9c1
Summary: Enables Import and Export for all the nodes for android. Also search and Accessibility feature works
Reviewed By: danielbuechele
Differential Revision: D14406016
fbshipit-source-id: 8976db66d1ca91e98c52983a31ea584764bde0f6
Summary:
Enables search on the imported layout data. The way search is implemented is that the Flipper app asks for the search results from the mobile clients. Since mobile client will not exist in the archived case, the search won't work. To solve this problem I added a proxy client which will get all the messages fired by the Layout Inspector and it will accordingly revert back with the responses. In the case of search, it will give back the search result tree for a particular query.
Also added extensive tests for the proxy client
Reviewed By: danielbuechele
Differential Revision: D14281856
fbshipit-source-id: 651436084ebacd57f86e4fe9bb2036e7f666880c
Summary:
For gzipped requests, the decoding of unicode characters was failing, because it was was done, before decompressing the response payload.
In this diff, the payload is first decompressed and decoded afterwards. For the calculation of the response size, this is removed, because it doesn't matter for the calculation of the size to correctly decode unicode characters. However, there might be a problem with displaying the correct size. This is tracked in T41427687.
Reviewed By: jknoxville
Differential Revision: D14366841
fbshipit-source-id: e375df1ec44505f6315dedbe71b3b62eac0f281a
Summary:
Extended the linter to check for the title attribute, too, and fixed
all violations. Linter will follow in next diff.
Reviewed By: jknoxville
Differential Revision: D14366410
fbshipit-source-id: b4de3592f2537e2bb16d4c2af231e5bee45346e4
Summary:
Fixes a bug which happened when the selected plugin was layout and the flipper trace was imported. While importing the trace in the mentioned scenario, the redux store didn't used to get updated in the first render but got updated in the second render. Due to which the persisted state passed in the props was undefined. Look at the attached video to understand the bug.
BUG:
{F152642401}
Reviewed By: passy
Differential Revision: D14343465
fbshipit-source-id: 59110fd6ee5839f2e3944792e1c288d2388d3340
