Summary: When clicking a node in the tree, currently it expands or collapses the subtree under it. This adds a chevron button which only handles the expansion functionality, and clicking on the label with the Section name will show info about that Section in the side panel.
Reviewed By: fabiomassimo
Differential Revision: D17165150
fbshipit-source-id: ac6b6c127b68274f53523b3ea62422ff96116e9b
Summary: z-index for titlebar was not high enough to cover the modal sheet
Reviewed By: jknoxville
Differential Revision: D17165223
fbshipit-source-id: 5ae30b6e55a1f69d653db509a08a8aa80a6f10fd
Summary:
I've added in a timeline line. Getting the CSS for this to work perfectly was tricky, but in the end this result looks pretty good. I've opted for the unknown events to have a smaller circle.
Edit:
I have fixed the border radius issue with the img element:
{F206482232}
And Unknown events are better aligned:
{F206482255}
Reviewed By: jknoxville
Differential Revision: D17180819
fbshipit-source-id: c318d2721adde758494267095524961c796f7a54
Summary: You need to use a type guard when narrowing types in a filter.
Reviewed By: danielbuechele
Differential Revision: D17163782
fbshipit-source-id: aa78bdd392653ebf1080a04e62e131b607e5181b
Summary:
This is a UI ovehaul for the Navigation plugin, taking inspiration from the Notifications page in Flipper.
We now display a timestamp, open page and bookmark are more clearly identified, screenshots are organized more neatly, and parameters are displayed in a table.
If the class name of the ViewController is available, that will also be displayed.
Edit:
Adding in some of the requested changes.
Improved UI:
https://pxl.cl/K0h9
Scroll on opening a page:
https://pxl.cl/K0hQ
Reviewed By: danielbuechele
Differential Revision: D17161734
fbshipit-source-id: e5e054bf87f540964e90da3a798fd0c23df86540
Summary:
This makes the implementation of static view generic. Right now the only non-plugin view which is shown is the WelcomeScreen. The implementation it is hardcoded. I want to make it generic, so that we can show the bug request screen too.
This diff sets the default value of the `staticView` to `WelcomeScreen`, which will be set to null when the `selectedDevice` is set. And viceversa, it will be assigned back to `WelcomScreen`, when the `selectedDevice` is set to `null`
Reviewed By: danielbuechele
Differential Revision: D16965734
fbshipit-source-id: 69d700184f44d4e5ab531f5f8fc0e23bafa07e72
Summary: Migrate CPU plugin to use TypeScript
Reviewed By: danielbuechele
Differential Revision: D17072709
fbshipit-source-id: d9acf172af08d764216e7b79b79994199dc83f5c
Summary:
Generics on static methods don't seem to work the way we are using them.
I looked into how react types getDerivedStateFromProps as this is a very similar concept, and they don't seem to type it at all. For that reason I've given up and just type the persistedState passed to our static methods as `Object`.
Reviewed By: passy
Differential Revision: D17152767
fbshipit-source-id: d9c2159be26fa341c5411dd0b40895d4c8ddf71e
Summary:
Logs plugin expected the default icons size to be 16 and therefor didn't set it explicitly. However, with the TS migration we lost the default size.
This adds back the default size for icons.
Reviewed By: jknoxville
Differential Revision: D17156747
fbshipit-source-id: a37f3a2bd189a56019aee1939618caf21122a397
Summary: I've made some slight changes to how bookmarks are displayed in the app, and added the ability to remove them from the tab.
Reviewed By: danielbuechele
Differential Revision: D17154083
fbshipit-source-id: 587e1e0f6f79f461c92e4866f4a59608a6173ccb
Summary: This functionality already existed in FlexColumn by adding the prop grow.
Reviewed By: danielbuechele
Differential Revision: D17132219
fbshipit-source-id: d284f2c5e219beff743525abd344a8b9d1955d0b
