Summary: For view pager we just want to draw the content in the center
Reviewed By: lblasa
Differential Revision: D40478266
fbshipit-source-id: 4fac7e897a0569fed59ef5810ba15300ebe87b5d
Summary:
Android does not set the top/left of the child of view pager. I attempted to solve this by grabbing the offset from the scrollview and passing it down via offset child. The issue is offsetchild has a lot of problems with the partial layout traversal. If the child of the scroll view is an observer root then the layout traversal with short circuit and setup a new observer for the child but we lose the offset child in the process.
This solution is a little dirty but it is functional for now
Reviewed By: lblasa
Differential Revision: D40430778
fbshipit-source-id: 7ad53b2a4818b55515e7662272548e2ce17e6b44
Summary: Getting the boxes to line up is quite hard to do right and has undetermined value
Reviewed By: mihaelao
Differential Revision: D40430776
fbshipit-source-id: 6093c4874f39ecf0c673407da2bd03ef06ca017e
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/ed
It does not make too much sense to have 2 different entry points to export Flipper debug data and to create a support request. It only creates ambiguity for our users. We could open the support request form automatically for them every time. In those rare cases when they try to attach new data to an existing support request, they can always not submit the form.
Reviewed By: passy
Differential Revision: D40632145
fbshipit-source-id: 6ca454d6e885493b32ac3aad008482045dccf51d
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Attach what we can to the universal export file if any of the steps time out
CHANGELOG: Add a universal debug export button
Reviewed By: passy
Differential Revision: D40552235
fbshipit-source-id: 775afccacf053fbcf764d1f39e93a89ad20dee0a
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Some files on the devices could be unavailable due to lack of permissions (hello SELinux and enterprise builds of iOS apps). Instead of failing the export, we should fetch what we can.
Reviewed By: passy
Differential Revision: D40551931
fbshipit-source-id: 698e157b1283b9e959909b6439cd09d2dc8dc8d6
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Exporting all files form a device and export Flipper's own state could take a long time. We need to keep our users updated on the status.
Reviewed By: passy
Differential Revision: D40551661
fbshipit-source-id: d5c94fb99d4bc8b4495ce463915b77c475548f01
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
In later diffs, we'll start fetching the actual files as well. The list of available files itself might be useful already to see what we have in our folder on the device
Reviewed By: passy
Differential Revision: D40508960
fbshipit-source-id: 96193fef3fed64d509cd3397513ae3e94438ae22
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Add a button to export all possible debug data at once. IN subsequent diffs, I'll add more extensive data collection.
Reviewed By: antonk52
Differential Revision: D40467606
fbshipit-source-id: 6a4225945b1feb6c1a8073b5209a62ba0beb6148
Summary:
Getting the active child was only ever returning the actual active View.
This is correct. However, if the View is backed by a Fragment, then the child is reported as Fragment instead of the actual View.
This was an issue as effectively, the reported children (fragments) were never going to match the active child (view).
Additionally in this change, report back the name of the node even if not active.
Reviewed By: LukeDefeo
Differential Revision: D40632526
fbshipit-source-id: 3560b193b370f19ceabe66980fe23f55ec887274
Summary:
Replace draft inspectors with read-only components.
This is a first step into having a richer UI. At the moment, these are read-only components but will likely be extended in the future as to allow editing of values.
Reviewed By: LukeDefeo
Differential Revision: D40345016
fbshipit-source-id: a6aef5861474b4aa8353c00ef257ab17b4cff00e
Summary:
Utility function that transforms lower camel case attribute names to a more readable name.
e.g. sizeToFit -> Size To Fit
Reviewed By: antonk52
Differential Revision: D40344715
fbshipit-source-id: f0745b892a78cc262133197a4d4b7624a7e2141d
Summary:
^
This laids the foundation for the inspector. It just reorganises a few bits.
Reviewed By: LukeDefeo
Differential Revision: D40319611
fbshipit-source-id: 8cf9b151c631faa1f26a7a6dfaa86b01abc42fe5
Summary:
There were some situations were we would hang waiting for new clients but one had connected.
Additionally the old approach would close and reopen the dialog every time a state update happened in the redux store which was a little jarring. Now the polling of the update is independant the dialog
The dialog still flashes for other parts of the flow (when scanning for devices) and would be nice to fix this too in the future
Reviewed By: mweststrate
Differential Revision: D40477502
fbshipit-source-id: d1ff161f262493cf5b3fb74e22b49ed65de8c292
Summary: We were incorrectly assuming a client did not support a plugin because it was not fully initialized. This issue was only apparant on start deep links
Reviewed By: mweststrate
Differential Revision: D40477503
fbshipit-source-id: 5fd9db765f559b8eb80cc3680ee694dfd2cf9a37
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4238
Reviewed By: aigoncharov
Differential Revision: D40636695
Pulled By: nikoant
fbshipit-source-id: fda37eba37dd286affe977d7a9046945c8aaaab8
Summary: pull/push might fail when run-as fails on insufficient permissions. When this happens, try to perform the command as root.
Reviewed By: aigoncharov
Differential Revision: D40623363
fbshipit-source-id: a4cc71d70f83ce1a390b14c9af9d3a3fa09f1307
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4235
Reviewed By: antonk52
Differential Revision: D40471242
Pulled By: aigoncharov
fbshipit-source-id: c8028f0b4be05ff5b9156443c52a86def4d1e179
Summary:
allow-large-files
Bumps [react-native](https://github.com/facebook/react-native) from 0.68.2 to 0.68.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p>
<blockquote>
<h2>0.68.4</h2>
<h3>Changed</h3>
<ul>
<li>Bump version of <code>promise</code> from 8.0.3 to 8.2.0, enabling <code>Promise.allSettled</code> (<a href="951538c080">951538c080</a> by <a href="https://github.com/retyui"><code>@retyui</code></a>)</li>
<li>Bump react-native-codegen to 0.0.18 (<a href="40a3ae3613">40a3ae3613</a> by <a href="https://github.com/dmytrorykun"><code>@dmytrorykun</code></a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Correctly resolve classes with FindClass(..) (<a href="361b310bcc">361b310bcc</a> by <a href="https://github.com/evancharlton"><code>@evancharlton</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Codegen should ignore <code>.d.ts</code> files (<a href="0f0d52067c">0f0d52067c</a> by <a href="https://github.com/tido64"><code>@tido64</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Fix the way the orientation events are published (<a href="7d42106d4c">7d42106d4c</a> by <a href="https://github.com/lbaldy">lbaldy</a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release in this <a href="https://github.com/reactwg/react-native-releases/discussions/37">discussion</a></p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> ⚛️</p>
<hr />
<p>You can find the whole changelog history in the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">changelog.md file</a></p>
<h2>0.68.3</h2>
<h3>Changed</h3>
<h4>Android specific</h4>
<ul>
<li>Let's not build reactnativeutilsjni shared library (<a href="af9225ec5f">af9225ec5f</a> by <a href="https://github.com/SparshaSaha"><code>@SparshaSaha</code></a>)</li>
<li>Modified <strong>getDefaultJSExecutorFactory</strong> method (<a href="87cfd386cb">87cfd386cb</a> by <a href="https://github.com/KunalFarmah98"><code>@KunalFarmah98</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Use monotonic clock for performance.now() (<a href="114d31feee">114d31feee</a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Logging a soft error when ReactRootView has an id other than -1 instead of crashing the app in hybrid apps (<a href="1ca2c24930">1ca2c24930</a> by <a href="https://github.com/Kunal-Airtel2022"><code>@Kunal-Airtel2022</code></a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release in this <a href="https://github.com/reactwg/react-native-releases/discussions/29">discussion</a></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">react-native's changelog</a>.</em></p>
<blockquote>
<h2>v0.68.4</h2>
<h3>Changed</h3>
<ul>
<li>Bump version of <code>promise</code> from 8.0.3 to 8.2.0, enabling <code>Promise.allSettled</code> (<a href="951538c080">951538c080</a> by <a href="https://github.com/retyui"><code>@retyui</code></a>)</li>
<li>Bump react-native-codegen to 0.0.18 (<a href="40a3ae3613">40a3ae3613</a> by <a href="https://github.com/dmytrorykun"><code>@dmytrorykun</code></a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Correctly resolve classes with FindClass(..) (<a href="361b310bcc">361b310bcc</a> by <a href="https://github.com/evancharlton"><code>@evancharlton</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Codegen should ignore <code>.d.ts</code> files (<a href="0f0d52067c">0f0d52067c</a> by <a href="https://github.com/tido64"><code>@tido64</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Fix the way the orientation events are published (<a href="7d42106d4c">7d42106d4c</a> by <a href="https://github.com/lbaldy">lbaldy</a>)</li>
</ul>
<h2>v0.68.3</h2>
<h3>Changed</h3>
<h4>Android specific</h4>
<ul>
<li>Let's not build reactnativeutilsjni shared library (<a href="af9225ec5f">af9225ec5f</a> by <a href="https://github.com/SparshaSaha"><code>@SparshaSaha</code></a>)</li>
<li>Modified <strong>getDefaultJSExecutorFactory</strong> method (<a href="87cfd386cb">87cfd386cb</a> by <a href="https://github.com/KunalFarmah98"><code>@KunalFarmah98</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Use monotonic clock for performance.now() (<a href="114d31feee">114d31feee</a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Logging a soft error when ReactRootView has an id other than -1 instead of crashing the app in hybrid apps (<a href="1ca2c24930">1ca2c24930</a> by <a href="https://github.com/Kunal-Airtel2022"><code>@Kunal-Airtel2022</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b55518c4bf"><code>b55518c</code></a> [0.68.4] Bump version numbers</li>
<li><a href="40a3ae3613"><code>40a3ae3</code></a> Bump react-native-codegen to 0.0.18</li>
<li><a href="782e0bff4a"><code>782e0bf</code></a> Add support <code>Promise.allSettled</code> out of box (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/34544">#34544</a>)</li>
<li><a href="e22ed7d676"><code>e22ed7d</code></a> fix: Correctly resolve classes with FindClass(..) (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/34533">#34533</a>)</li>
<li><a href="4575ef516f"><code>4575ef5</code></a> Fix codegen trying to parse <code>.d.ts</code> files (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/34439">#34439</a>)</li>
<li><a href="4f7eb6197f"><code>4f7eb61</code></a> prevent from publishing dimensions change event when app changes state (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/34014">#34014</a>)</li>
<li><a href="36153e2557"><code>36153e2</code></a> [0.68.3] Bump version numbers</li>
<li><a href="d2d244cb8f"><code>d2d244c</code></a> [LOCAL] align pods version config with the rest of the repo</li>
<li><a href="af9225ec5f"><code>af9225e</code></a> Let's not build reactnativeutilsjni shared library (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/34345">#34345</a>)</li>
<li><a href="4555fc7865"><code>4555fc7</code></a> Added additional builder method receiving arguments for using jsc or hermes t...</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/react-native/compare/v0.68.2...v0.68.4">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4206
Reviewed By: aigoncharov
Differential Revision: D40334958
Pulled By: mweststrate
fbshipit-source-id: d9f520596ea7c9868686d5f7d9c41e53abfcb4dc
Summary:
This change adds support for more inspectables and also introduces more complex types to be used as a value.
This become specially useful for more complex yet primitive types like coordinate, size, bounds, etc.
Reviewed By: LukeDefeo
Differential Revision: D40307885
fbshipit-source-id: 125e832f06d6b31f56eb5405182d1c0d61388930
Summary:
The release workflow is using a version of the github release action that is broken, due to ghr now being dynamically linked and not compatible with Alpine Linux's minimal version of libc. The fix is to use the version of the action which installs gcompat so that ghr can run on the docker image.
## Changelog
Update release workflow to use version of action compatible with latest version of ghr.
Pull Request resolved: https://github.com/facebook/flipper/pull/4220
Test Plan: N/A
Reviewed By: nikoant
Differential Revision: D40443738
Pulled By: aigoncharov
fbshipit-source-id: 7765420fbe034aa80ce07c698ff83773c81ed52f
Summary:
Bumps [sinon](https://github.com/sinonjs/sinon) from 14.0.0 to 14.0.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/sinonjs/sinon/blob/main/docs/changelog.md">sinon's changelog</a>.</em></p>
<blockquote>
<h2>14.0.1</h2>
<ul>
<li><a href="6c4753ef24"><code>6c4753ef</code></a>
Fixed CSS selectors in <code>_base.scss</code> and changed blockquote default size to 16px. (Jose Lupianez)</li>
<li>A bunch of dependency updates</li>
</ul>
<p><em>Released by <a href="https://github.com/fatso83">Carl-Erik Kopseng</a> on 2022-10-03.</em></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c4345dc1b1"><code>c4345dc</code></a> 14.0.1</li>
<li><a href="fc30a41761"><code>fc30a41</code></a> Update lock file</li>
<li><a href="6c4753ef24"><code>6c4753e</code></a> Fixed CSS selectors in _base.scss and changed blockquote default size to 16px.</li>
<li><a href="35fde18be2"><code>35fde18</code></a> Bump actions/cache from 2 to 3</li>
<li><a href="72b6c6162e"><code>72b6c61</code></a> Bump actions/setup-node from 2 to 3</li>
<li><a href="5db24d2744"><code>5db24d2</code></a> Bump actions/checkout from 2 to 3</li>
<li><a href="a9ffa0247a"><code>a9ffa02</code></a> chore: Included githubactions in the dependabot config</li>
<li><a href="df92659721"><code>df92659</code></a> chore: Set permissions for GitHub actions</li>
<li><a href="3bb7eb4016"><code>3bb7eb4</code></a> Bump nokogiri from 1.13.4 to 1.13.7</li>
<li><a href="cd503601d6"><code>cd50360</code></a> Bump tzinfo from 1.2.9 to 1.2.10</li>
<li>Additional commits viewable in <a href="https://github.com/sinonjs/sinon/compare/v14.0.0...v14.0.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4198
Reviewed By: aigoncharov
Differential Revision: D40334980
Pulled By: mweststrate
fbshipit-source-id: bfaaf4a4ae5d310bb38c0cf04b54ea8b0971abbe
