Commit Graph

160 Commits

Author SHA1 Message Date
Michel Weststrate
f2d12f1025 Fixed a bunch of prettier errors after upgrading
Summary: prettier upgrade uncovered more errors

Reviewed By: passy

Differential Revision: D18474908

fbshipit-source-id: b1553000fb3386f2bbd9defdd3332618e4b9c867
2019-11-13 08:36:54 -08:00
Pascal Hartig
05c007be16 Move plugin manager logic out of UI component
Summary: Moving some things around for the upcoming update support.

Reviewed By: jknoxville

Differential Revision: D18347572

fbshipit-source-id: b614fe3a87f8e7fdc0c11c0d3bfe4787c0914d17
2019-11-06 08:33:36 -08:00
Michel Weststrate
7040d487d8 don't keep querying iOS simulators if XCode was not installed properly
Summary: Currently the app keeps to find iOS devices if when the tooling isn't properly set up, causing an error to appear every three secs. This change makes sure that happens only once. It also takes care of some run-away promises

Reviewed By: jknoxville

Differential Revision: D18346619

fbshipit-source-id: 12b581bee0d522b37b9e0c5d5b8dad0e4d2058d9
2019-11-06 06:17:22 -08:00
Michel Weststrate
3963535610 Fix buffer warning when starting CPU / kaois plugin
Summary:
When the CPU or kaois plugins are started, they show a buffer deprecated warning, caused by the fact that they ship their own adbkit version, which is unpatched.

This diff makes sure that the adbkit as shipped with Flipper is used instead.

Reviewed By: jknoxville

Differential Revision: D18327441

fbshipit-source-id: 9cab23b9701adc070210cc4133fc8760031bd1d7
2019-11-05 11:10:16 -08:00
Pascal Hartig
d2dfb924fd Update plugin store after installation
Summary: Address the small regression introduced by D18173166. When closing the plugin manager after installing/removing, the store wasn't updated in between.

Reviewed By: jknoxville

Differential Revision: D18270821

fbshipit-source-id: 4ff54bc7607d06fa423cf8e673f216ae0a5d19da
2019-11-05 05:44:13 -08:00
Pascal Hartig
432bb1b00a Move local plugin discovery to dispatcher/redux store
Summary: In order to have update notifications, this must live outside the UI component, but it also gives some additional benefits like better testability of previously effectful UI.

Reviewed By: jknoxville

Differential Revision: D18173166

fbshipit-source-id: 1cacb6c7893423a7920a6620dfb76e631caba101
2019-11-05 05:44:12 -08:00
John Knox
42a77094f4 Clean up old flipper rating system
Summary:
Found some unused code from the rating prototype before switching to itsr.
Deleting it.

Reviewed By: cekkaewnumchai

Differential Revision: D18298155

fbshipit-source-id: 3529db17494f4f5bf7d7841460203d1c3856299a
2019-11-04 09:23:50 -08:00
Pritesh Nandgaonkar
652ffd43d6 Parse deeplink uri and update the check
Summary: Parse the deeplink url and update the checks by comparing particular components.

Reviewed By: jknoxville

Differential Revision: D18093494

fbshipit-source-id: c79c1974a7e50b61724dedd7fd3303093fac944b
2019-10-24 03:52:08 -07:00
Pascal Hartig
f53b252aff Change groups URL
Summary: Added a slug a while ago and it looks a bit better when shown in the bugnub.

Reviewed By: cekkaewnumchai

Differential Revision: D18083274

fbshipit-source-id: 5a9c8c126b5dcee92a697096ac3393a93a1690c3
2019-10-23 03:01:56 -07:00
Michel Weststrate
3b1429b8b0 Add global error bubble
Summary: Improved the display of error messages. Where previously only one error message could be displayed (quite obtrusively), with this change multiple errors can now be displayed and stack traces and further info can be hidden.

Reviewed By: passy

Differential Revision: D18036569

fbshipit-source-id: 2bc3dfa7a5196f931370a6e6dbf27c55b6cfb2bf
2019-10-22 08:48:16 -07:00
Pritesh Nandgaonkar
5614444380 Track the source of the supportform
Summary: This diff adds the telemetry to track the source of the support form being launched.

Reviewed By: passy

Differential Revision: D17908752

fbshipit-source-id: 275812992884a471844fda40d1f636815a4a2346
2019-10-15 04:13:38 -07:00
Andres Suarez
0675dd924d Tidy up Flipper license headers [1/2]
Reviewed By: passy

Differential Revision: D17863711

fbshipit-source-id: 259dc77826fb803ff1b88c88529d7f679d3b74d8
2019-10-11 13:46:45 -07:00
John Knox
ea5079ff9c Enable / Disable iOS support depending on xcode-select
Summary:
Queries xcode-select on ios dispatcher startup, to see if it's installed.
If it is, carry on with the ios device tracking, if not, don't bother.

This should stop it from emitting errors trying to track devices when things aren't installed.

I think it should also stop those install prompts from popping up.

Sets it in app state so we can tell the user about it, and maybe gate some other things too.

Reviewed By: passy

Differential Revision: D17830696

fbshipit-source-id: 960d09a9c5267afabf5e5e222379a0a7ed2cc444
2019-10-10 09:23:46 -07:00
John Knox
68881f35fc Use androidEnabled setting in dispatcher
Summary:
Takes the androidEnabled setting and uses it to gate the android dispatcher.
Enables people without android sdk to use flipper (e.g. iOS engineers).

Reviewed By: priteshrnandgaonkar

Differential Revision: D17829810

fbshipit-source-id: 7d25580e65dee93ebfda7c5cc4c4cea03744e2ca
2019-10-10 09:23:46 -07:00
Pritesh Nandgaonkar
dfc4f74ed3 Deeplink support
Summary: This diff adds the support to deeplink to the litho form.

Reviewed By: passy

Differential Revision: D17792341

fbshipit-source-id: b146993163b14df000c499236da48b7e8066f457
2019-10-08 12:01:09 -07:00
John Knox
729e74f2fc Switch to using settings for android sdk location
Summary: A settings screen has been added where android home can be set. This changes the downstream code to use this value rather than the `env.PATH` variable.

Reviewed By: passy

Differential Revision: D17713288

fbshipit-source-id: 51551652c9c2f468e1117c18785123348e4b4576
2019-10-07 08:51:06 -07:00
Alexander Putilin
dda800c4a3 Initial support for KaiOS device plugins
Summary: Introduces basic KaiOSDevice class. Since kaios phones support adb, it is inherited from AndroidDevice

Reviewed By: jknoxville

Differential Revision: D17608605

fbshipit-source-id: 6b2c5834a1f5862b864c8e76202d0d401e58cbcc
2019-09-27 06:11:18 -07:00
John Knox
1d6fc9e3ac Don't make simultaneous ios device queries
Summary:
Fixes this:
https://fb.workplace.com/groups/967178219989117/permalink/3178405185533065/

Reviewed By: passy

Differential Revision: D17421166

fbshipit-source-id: 6ee14a05d157063d7646076175b6cdaf918a7caa
2019-09-17 09:02:31 -07:00
Daniel Büchele
e33f72bb21 use adbkit instead of adbkit-fb
Summary: Finally we are able to switch back from our adbkit-fb fork to the original `adbkit`. Replacing all imports

Reviewed By: jknoxville

Differential Revision: D17343236

fbshipit-source-id: e6dd328f1a956544e8be2ab768aa270972463c6b
2019-09-13 05:28:31 -07:00
Daniel Büchele
4e7cf077b8 adbkit typing
Summary: Adding proper types for adbkit (extracted from their documentation)

Reviewed By: passy

Differential Revision: D17342184

fbshipit-source-id: da0fc0264961ca3a0fa775ab5165d20872042eb8
2019-09-13 05:28:30 -07:00
Pascal Hartig
b7ad035742 Add type annotations to iOSDevice
Summary:
Not ideal to just assert a type based on JSON output
but better than the `ts-ignore` because complete
misuse of the functions is still caught.

Reviewed By: jknoxville

Differential Revision: D17346265

fbshipit-source-id: 52d8109a11f552b912b67b1074cb906cb2cc161b
2019-09-13 02:35:47 -07:00
Pascal Hartig
cbbe32b9b9 Remove FlowFixMe's from TypeScript
Summary: This diff was a joy to draft.

Reviewed By: jknoxville

Differential Revision: D17344676

fbshipit-source-id: 0694d0393fa243edef61408ecfee92912fbbfa32
2019-09-12 10:20:08 -07:00
Pascal Hartig
6df299425e Fix dispatcher/notifications.tsx strict errors
Summary: And remove one migration warning that no longer applies.

Reviewed By: danielbuechele

Differential Revision: D17313469

fbshipit-source-id: f29a096a0da7c14735d1d5666a54a3351df54821
2019-09-11 04:40:28 -07:00
Pascal Hartig
428f6b4fc1 Make androidDevice strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17282814

fbshipit-source-id: ebf4293c973e8c866fa3c2c5cb8f0f6b42b8ae01
2019-09-10 10:33:25 -07:00
Pascal Hartig
71bb121ab8 Make dispatcher/plugins strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17258265

fbshipit-source-id: 875d434120422c782074d4c345f765684533e399
2019-09-09 10:24:44 -07:00
Pascal Hartig
c506cc57b1 Make dispatcher/application.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17258139

fbshipit-source-id: d1ab484e981b2802a22c2fc92ac52c75970ee3d2
2019-09-09 09:58:34 -07:00
Pascal Hartig
c91b778fc0 Make dispatcher/notifications.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17204312

fbshipit-source-id: 23a3b5144545db9c165fc853ece40bb5025391e6
2019-09-09 07:04:53 -07:00
Pascal Hartig
76e857041c Make dispatcher/tracking.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17204302

fbshipit-source-id: 10b6add125bb6b500122c0a7a30eb8ed223a7ad8
2019-09-09 07:04:53 -07:00
Pritesh Nandgaonkar
566f2bf96e Do not use custom serializer for all the plugins
Summary:
This diff solves the problem where the export for the graphql plugin was super super super sloooooowwww...... The reason being that the graphql plugin had chunky graphql responses which were json blob which was being serialized by our custom serializer. Instead of serializing those with custom serializer we can directly serialize them as they won't have any map's, sets, classes etc.

This diff adds the two static functions on the plugin which will provide the serialized and deserialized object for the persistedstate. As the plugin knows the structure of its state it can optimize the serialization and deserialization of its data.

This change solves the slow export issue and makes it blazing fast..... 🏎

Bug:

{F206550514}

Reviewed By: danielbuechele

Differential Revision: D17166054

fbshipit-source-id: 058b903c03c12c9194702162c46763ef5b5e7283
2019-09-09 06:13:39 -07:00
Daniel Büchele
5868946818 certificate provider
Summary: _typescript_

Reviewed By: passy

Differential Revision: D17096517

fbshipit-source-id: a6e69e8b9a82fe76bb1de51a3a93182f35f40b3f
2019-08-28 20:34:59 -07:00
Daniel Büchele
0ec48d4fc9 index
Summary:
This converts the index file to TypeScript which is used as an export for all plugins. Alongside, I had to fix a couple of errors in various files to make sure everything works correctly.

For plugins using flow, we define an interface which uses the type definition for FlipperPlugin and types all UI components as `any`.

Reviewed By: passy

Differential Revision: D16936890

fbshipit-source-id: dacd9a63a82b9f0bbb530b06072186874cba7b6f
2019-08-22 10:02:27 -07:00
Daniel Büchele
d0da0d66a5 main folder
Summary: _typescript_

Reviewed By: passy

Differential Revision: D16762117

fbshipit-source-id: b6ee32e0bb3fc686fc69cfccab703e2ef4989571
2019-08-15 03:33:06 -07:00
Pascal Hartig
573655c2f6 Migrate onRegisterDevice
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D16764866

fbshipit-source-id: bdf532dea1c3019f0cb7728b3a0a07a3602cf04b
2019-08-14 04:43:51 -07:00
Benjamin Elo
e4b071e867 Migrate PluginDebugger from js to tsx
Summary: Migrated PluginDebugger.js to PluginDebugger.tsx

Reviewed By: passy

Differential Revision: D16732025

fbshipit-source-id: c4ff5586f823e90eba14eef5a8dac114a058763b
2019-08-12 06:06:41 -07:00
Pascal Hartig
fcf99fda4b Migrate is{Headless,Production}
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16711115

fbshipit-source-id: 174e1d3057182c35a6e3493612ddcb3d6ba1ee54
2019-08-12 03:53:14 -07:00
John Knox
882d7e1a39 Convert utils/processConfig to TS
Reviewed By: danielbuechele

Differential Revision: D16710602

fbshipit-source-id: 3dbccdb0aedd3d5415487d690fb943aafdafa0f0
2019-08-12 03:11:16 -07:00
Pascal Hartig
b42abcbb59 Migrate logger
Summary:
Removed defunct log filtering functionality, but we probably want to rebuild that.
Funny that tsc caught this as non functioning but Flow happily accepted it.

Reviewed By: danielbuechele

Differential Revision: D16690959

fbshipit-source-id: b079dd6faba83ca0c443d00cbb69c8ff95c4fa69
2019-08-09 10:47:12 -07:00
John Knox
4afc417ea5 Convert iOSDevice dispatcher to TS
Summary: Convert iOSDevice dispatcher to TS

Reviewed By: passy

Differential Revision: D16690183

fbshipit-source-id: 629ac178e91b4774449503529df7e07cee6741c5
2019-08-09 09:05:10 -07:00
John Knox
6da09fa381 Convert plugins dispatcher to TS
Summary: Convert plugins dispatcher to TS

Reviewed By: passy

Differential Revision: D16689874

fbshipit-source-id: afdac7960e267ebed350fcb170795689bd327807
2019-08-09 09:05:10 -07:00
John Knox
9edfe88caa Convert notifications dispatcher to TS
Summary: Convert notifications dispatcher to TS

Reviewed By: danielbuechele

Differential Revision: D16689175

fbshipit-source-id: 7806d5452a57566ea3d6fdfd233a1679435e0103
2019-08-09 09:05:10 -07:00
Pritesh Nandgaonkar
c43beb53d1 Migrate dispatcher index to tsx
Summary: As per the title

Reviewed By: jknoxville, passy

Differential Revision: D16690303

fbshipit-source-id: fa78ea1e3f288249676d5a6423e5d0f0a6e427a4
2019-08-09 07:56:55 -07:00
Pritesh Nandgaonkar
86642816fb Migrate desktopDevice.js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16690092

fbshipit-source-id: bcb9a0e5a1e05849dd1f470fdd8d54b898f79695
2019-08-09 07:56:55 -07:00
Pritesh Nandgaonkar
c3807a6ba2 Migrate application from js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16690005

fbshipit-source-id: 8975da8aa7221b731358eacb4040f48198bf073b
2019-08-09 07:56:55 -07:00
Pritesh Nandgaonkar
03b5b133b8 Migrate androidDevice dispatcher from js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16689714

fbshipit-source-id: 1ff415a89b4ac91ffd4a23e8b50ec9fedfeea40e
2019-08-09 07:56:54 -07:00
Pritesh Nandgaonkar
0c0d595cbb Migrate WindowsDevice from js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16668705

fbshipit-source-id: 520981f2c1356a17561203f18e00f65a751ee8b8
2019-08-09 07:56:54 -07:00
Pritesh Nandgaonkar
2ed24c4a56 Migrate MacDevice from js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16668140

fbshipit-source-id: 109a7ce29a9dc3934673060e93741b96847dfa56
2019-08-09 07:56:54 -07:00
Pritesh Nandgaonkar
f408f3f949 Migrate the iOSDevice from js to tsx
Summary: As per the title.

Reviewed By: jknoxville

Differential Revision: D16668086

fbshipit-source-id: c246fcaf117802cf1d3c6b3959bf0d0c2761fdce
2019-08-09 07:56:53 -07:00
Pritesh Nandgaonkar
eb26a74327 Migrate AndroidDevice from js to tsx
Summary: As per the title

Reviewed By: jknoxville

Differential Revision: D16667269

fbshipit-source-id: d213f4ebacf8050ae55a8e3268909da8535f2d93
2019-08-09 07:56:53 -07:00
Pritesh Nandgaonkar
47a55b0f26 Migrate BaseDevice from js to tsx
Summary: As per the title

Reviewed By: passy

Differential Revision: D16687261

fbshipit-source-id: a9d85424fb0a08fada7edd0355c356907518d366
2019-08-09 06:56:54 -07:00
John Knox
18f43daa04 Convert server dispatcher to TS
Summary: Convert file to TS

Reviewed By: passy

Differential Revision: D16687921

fbshipit-source-id: 246f5ff58030463889f8f230d120477ff90f04c7
2019-08-09 04:58:27 -07:00