Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.117 to 1.0.118.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.118</h2>
<ul>
<li>Support serialization of core::num::Wrapping in no_std mode (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/1926">#1926</a>, thanks <a href="https://github.com/attente">attente</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e797431268"><code>e797431</code></a> Release 1.0.118</li>
<li><a href="4a335f8933"><code>4a335f8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/1926">#1926</a> from attente/core-num-wrapping</li>
<li><a href="84721920fd"><code>8472192</code></a> Resolve clippy items_after_statements lint</li>
<li><a href="192c7819ee"><code>192c781</code></a> Format with rustfmt 1.4.25-beta</li>
<li><a href="ede40bdfaa"><code>ede40bd</code></a> Allow serializing of Wrapping without std</li>
<li><a href="e3d871ff7b"><code>e3d871f</code></a> Opt in to experimental trybuild diffs</li>
<li><a href="0e1c4093c8"><code>0e1c409</code></a> Suppress new result_unit_err clippy lint</li>
<li><a href="0d5b6c180c"><code>0d5b6c1</code></a> Resolve ptr_eq clippy lint</li>
<li><a href="8084258a3e"><code>8084258</code></a> Update ui tests to nightly-2020-10-20</li>
<li>See full diff in <a href="https://github.com/serde-rs/serde/compare/v1.0.117...v1.0.118">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1742
Reviewed By: mweststrate
Differential Revision: D25373209
Pulled By: passy
fbshipit-source-id: 67e6ebda3c356775ffff0697bc2221b0e04f8726
Summary:
[//]: # (dependabot-start)
{emoji:26a0} **Dependabot is rebasing this PR** {emoji:26a0}
If you make any changes to it yourself then they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.6 to 14.14.10.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1749
Reviewed By: mweststrate
Differential Revision: D25373220
Pulled By: passy
fbshipit-source-id: a9f69a8c29f3c0d04939e68341f36fc26cc609a7
Summary:
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.59 to 1.0.60.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p>
<blockquote>
<h2>v1.0.60</h2>
<ul>
<li>Add <code>impl FromIterator<(impl Into<String>, impl Into<Value>)> for Value</code>, which collects a Value::Object (<a href="https://github-redirect.dependabot.com/serde-rs/json/issues/733">https://github.com/facebook/flipper/issues/733</a>, thanks <a href="https://github.com/matklad">matklad</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6a4cd8d218"><code>6a4cd8d</code></a> Release 1.0.60</li>
<li><a href="b9598ce50f"><code>b9598ce</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/json/issues/733">https://github.com/facebook/flipper/issues/733</a> from matklad/from-iter-of-pairs</li>
<li><a href="0c4b4dfc8a"><code>0c4b4df</code></a> Allow collecting an iterator of pairs into JSON object</li>
<li><a href="efc910404a"><code>efc9104</code></a> Suppress clippy unnecessary_wraps lints</li>
<li><a href="bda64205e3"><code>bda6420</code></a> Resolve clippy comparison_to_empty lint</li>
<li><a href="ec7eeb6933"><code>ec7eeb6</code></a> Suppress new manual_range_contains lint</li>
<li>See full diff in <a href="https://github.com/serde-rs/json/compare/v1.0.59...v1.0.60">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1743
Reviewed By: mweststrate
Differential Revision: D25373212
Pulled By: passy
fbshipit-source-id: 6164c172f01d0260e1e195a1317f5c18f8a92567
Summary: Metro and Mac device were always hidden in Sandy, but they should only be hidden if they don't have underlying Clients. Fixes https://fb.workplace.com/groups/748354712423318/permalink/775342569724532/
Reviewed By: nikoant
Differential Revision: D25369492
fbshipit-source-id: fdc25c3646d8339ae029425b4c45d8631bbee762
Summary:
This is the 6th most common error in our logging, and I just run into it after upgrading XCode. It happens when idb doesn't return any devices.
(because `''.split('\n')` results in `['']` not `[]`)
Reviewed By: jknoxville
Differential Revision: D25368759
fbshipit-source-id: 44b0e3a5dc4cf06ecdf2dff4a5692943e60d4b1d
Summary: Make sure that GKs can be used in pure sandy plugins.
Reviewed By: jknoxville
Differential Revision: D25368358
fbshipit-source-id: c7c6aa4ecf0443cb3b5d90e22e8aca9a73a69389
Summary:
This should fix the react-native issue with building on Xcode 12: https://github.com/facebook/react-native/issues/29984
## Changelog
Upgrade OpenSSL-Universal dependency on the one that includes arm for iPhone Simulator: https://github.com/krzyzanowskim/OpenSSL/releases
Pull Request resolved: https://github.com/facebook/flipper/pull/1735
Test Plan: This PR is not intended to be merged directly, as more version bumping and propagation through the other pods will be needed.
Reviewed By: mweststrate
Differential Revision: D25302713
Pulled By: passy
fbshipit-source-id: ac8e7e4652800ab00255398fe227e58af3ad0c5c
Summary: App match patterns are not available for all apps, there is no reason to treat this as an error, currently errors are printed for apps like "Flipper".
Reviewed By: nikoant
Differential Revision: D25369648
fbshipit-source-id: a63aadbf14745310501565b00081602e44852398
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1739
Reviewed By: mweststrate
Differential Revision: D25333594
Pulled By: passy
fbshipit-source-id: 6328aff1af963fef5116e27f8c6fe8e342f1209f
Summary:
The interesting changes don't actually come from the React type upgrade but from `csstype` which is transitive. Doesn't change any logic.
Pull Request resolved: https://github.com/facebook/flipper/pull/1727
Test Plan: yarn && yarn tsc
Reviewed By: mweststrate
Differential Revision: D25244654
Pulled By: passy
fbshipit-source-id: bddb4691aa7341c4a25de0e9b5ef0217bf151a48
Summary: After this we can inline internal/external content among pages, and safely transclude markdown files that won't be present on GitHub.
Reviewed By: mweststrate
Differential Revision: D25338530
fbshipit-source-id: 3ce4b44081766aca8b52183c2e02a98c5be09a59
Summary: Add a dogfooding tab in the Zero Rating devtools in flipper. The tab shows a list of all carriers and carrier ID (will later allow to start dogfooding after choosing one)
Reviewed By: zaxy78
Differential Revision: D24675379
fbshipit-source-id: 044b6d957976a05bfe2666ca0510531102f9d0f6
Summary: Rust default configuration path changed recently which broke transferring of settings between flipper desktop and launcher. This diff fixes it.
Reviewed By: passy
Differential Revision: D25334963
fbshipit-source-id: d6ebea9e5cfa68858a9fc2a51102815d646ab319
Summary: Delegate to launcher on restart after settings changed. This is required to update Flipper after changing release channel.
Reviewed By: passy
Differential Revision: D25331466
fbshipit-source-id: d98e272971b5782d3b9c46e6ba62d883ebbb804c
Summary: Append the hash when possible to the metadata from the flipper submissions.
Differential Revision: D25283309
fbshipit-source-id: 1e95cdc3e9f2f1a08dc53c746732c46969166d97
Summary:
See previous diff, if the plugin `id` on the class definition mismatches with the `package.json`, the navigation in Sandy will use the wrong id (from the meta data) causing the plugin not to open.
Since the `id` exposed on the class is the one that is used to setup the connect on the client, updated the ids in the `package.json` which have afaik no further meaning.
Pinging nikoant to verify that assumption. I can imagine this might impact historical data / plugin distribution?
Reviewed By: passy, nikoant
Differential Revision: D25302542
fbshipit-source-id: 43fe1667604eb7a28f6f9b7d260bc2a1e6e82dd3
Summary:
FluxStores plugin of AdsManager didn't open on Sandy. The underlying reason is that in Sandy the list was based on the plugin id's as exposed in the `package.json`, while in the old left sidebar it was based on the `id` stored on the Plugin class. And apparently they can differ (will fix that in the next diff)
We can release an update of this plugin after it landed
Reviewed By: passy
Differential Revision: D25302357
fbshipit-source-id: 874aab263fad6a83f63edc4a8f7fa7ceceaef70f
Summary: Was tired off figuring out GK's to be able to debug a plugin, so added a flag that allows me to start Flipper with all plugins enabled :)
Reviewed By: passy
Differential Revision: D25301773
fbshipit-source-id: 668b92c4ddbbeb3f4b056035de394800bbfa5377
Summary: Wired up tracking to all chrome sections and some import UI elements
Reviewed By: jknoxville
Differential Revision: D25219089
fbshipit-source-id: c75bed91894609dafc5fcc6423a5228211fb92d8
Summary:
This wires up tracking directly to the ANT component library for the following components:
1. `Button`
2. `Collapse.Panel`
3. `Tabs`
Other less commonly used elements can be connected in the future if needed.
I played a bit with different patterns, but in testing the patch-package patching give the most reliable results. Alternatives considered:
1. Expect users to explicitly wrap there components, e.g. `<Tracked><Button>Hi</Button></Tracked>`
1. Didn't implement this because it would be very common to forget, and at the moment you want to make some analysis you'll discover there is no interesting data available. I think for tracking we want to have opt-out rather than opt-in
2. The additional wrapping can cause some subtile layout issues due to static field inspection / forwarded refs (e.g. Ant often has an assumption that relevant children types are _directly_ nested under their parent element. For examle `<Tooltip><Tracked><Button>` does not work as expected
2. Expose our own `Button` / `Collapse` / `Tabs` that applies `Tracked` to an underlying Ant component.
1. also suffers from 1.b.
2. It is gonna be quite confusing for other devs that some elements would need to be imported from `flipper-plugin`, ant some from `antd`, and that this is likely to change over time. We could lint against it, but it will be still suboptimal
Reviewed By: jknoxville
Differential Revision: D25196321
fbshipit-source-id: b559356498c3191a283062a88daacb354b0f79f4
Summary: Connect usage tracking to the Flipper core, individual elements will be wrapped in a next diff
Reviewed By: passy
Differential Revision: D25196284
fbshipit-source-id: 103e1d21d2f23fbbc21975fa85082811f6f53348
Summary:
Set up basic primitives for user interaction tracking. I hope the docs and unit tests in this diff are self explanatory :)
In upcoming diffs:
* Wire up to scuba events
* Annotate all important parts of Flipper Chrome
* Investigate if we can wrap important interactions of ANT by default
Reviewed By: jknoxville
Differential Revision: D25120234
fbshipit-source-id: 9849d565d7be27e498cc2b4db33e7d6e6938ee06
Summary:
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.12.0 to 6.15.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md">eslint-config-prettier's changelog</a>.</em></p>
<blockquote>
<h3>Version 6.15.0 (2020-10-27)</h3>
<ul>
<li>Added: [typescript-eslint/space-infix-ops]. Thanks to Masafumi Koba (<a href="https://github.com/ybiquitous">ybiquitous</a>)!!</li>
</ul>
<h3>Version 6.14.0 (2020-10-21)</h3>
<ul>
<li>Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
<h3>Version 6.13.0 (2020-10-16)</h3>
<ul>
<li>Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b1ace774ac"><code>b1ace77</code></a> eslint-config-prettier v6.15.0</li>
<li><a href="c4a089a2d3"><code>c4a089a</code></a> Update npm packages</li>
<li><a href="b875b6efc7"><code>b875b6e</code></a> Turn off <code>typescript-eslint/space-infix-ops</code> (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/164">https://github.com/facebook/flipper/issues/164</a>)</li>
<li><a href="12b126d332"><code>12b126d</code></a> eslint-config-prettier v6.14.0</li>
<li><a href="2ba1a6145b"><code>2ba1a61</code></a> Update npm packages</li>
<li><a href="219757f1ab"><code>219757f</code></a> Turn off new eslint-plugin-vue rules (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/163">https://github.com/facebook/flipper/issues/163</a>)</li>
<li><a href="4edf6e6bc5"><code>4edf6e6</code></a> eslint-config-prettier v6.13.0</li>
<li><a href="ba40e0d165"><code>ba40e0d</code></a> Update npm packages</li>
<li><a href="fdc25da880"><code>fdc25da</code></a> Support eslint-plugin-vue@7 (which support Vue 3.0) (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/162">https://github.com/facebook/flipper/issues/162</a>)</li>
<li><a href="d5ae0c6e68"><code>d5ae0c6</code></a> Fix broken links in readme</li>
<li>Additional commits viewable in <a href="https://github.com/prettier/eslint-config-prettier/compare/v6.12.0...v6.15.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1725
Reviewed By: mweststrate
Differential Revision: D25244657
Pulled By: passy
fbshipit-source-id: 6fdcb6ddbb56f805086258fd91137799fb7a3041
Summary:
This diff sets all package version to "0.0.0" except of the root package and changes the bump script to only bump version in the root package. This should reduce possibility of conflicts on release diffs. Anyway we always use the same version for all of our packages, so we can only set it to the root.
Before npm publishing we will set all package versions to the same number as in the root package (we actually already do that) so there will be no differences except we won't need to bump version in more than 100 packages each release.
Reviewed By: mweststrate
Differential Revision: D25162373
fbshipit-source-id: 02fe401bee72845339c67925c130027bdaee559d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1732
Reviewed By: passy
Differential Revision: D25241631
Pulled By: nikoant
fbshipit-source-id: 788a5752208113170410271afa65a60163d2fe73
Summary: Previously, notifications can be hidden by category or plugin. This diff ports that functionality to Sandy
Reviewed By: mweststrate
Differential Revision: D25021697
fbshipit-source-id: 28bdd1c169fcef4db79c2452db8cbb5f0bce6312
Summary: This diffs add removing all action and simple search (search by matching title and/or detail)
Reviewed By: mweststrate
Differential Revision: D24992828
fbshipit-source-id: 84e59e8de5a6cfd4c6cb4097350dbb87e17271db
Summary: Adds an action for publishing packages to npm. Secret was added as part of T80403944.
Reviewed By: nikoant
Differential Revision: D25195740
fbshipit-source-id: 51d43d9f5e84a25a67b637233b2c62a9a1a15063
Summary:
To make sure we're staying in sync with the internal version. Requires some more manual updating, but even if we do this every couple of months, it should be fine.
Pull Request resolved: https://github.com/facebook/flipper/pull/1719
Test Plan: CI
Reviewed By: nikoant
Differential Revision: D25195565
Pulled By: passy
fbshipit-source-id: 763a9d877a20659e91c8b77d0900b999e5f630d3
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.64.0 to 0.66.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="ad8e8fbb24"><code>ad8e8fb</code></a> Flipper Release: v0.66.0</li>
<li><a href="008803b502"><code>008803b</code></a> Don't redefine Tabs</li>
<li><a href="32ca27f4f7"><code>32ca27f</code></a> Fix assigning unique numbers to builds</li>
<li><a href="2c9219f99a"><code>2c9219f</code></a> Add State to Notification Component</li>
<li><a href="41c7e023a9"><code>41c7e02</code></a> Enable limited use of iOS devices on non Mac devices</li>
<li><a href="07212ec8e0"><code>07212ec</code></a> Fix memory leak</li>
<li><a href="cb625d38dc"><code>cb625d3</code></a> Build tutorial app as part of sample build (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1677">https://github.com/facebook/flipper/issues/1677</a>)</li>
<li><a href="c6e51fe73c"><code>c6e51fe</code></a> Moved sections plugin into fb/</li>
<li><a href="acd2cf25ec"><code>acd2cf2</code></a> Bump algolia/client-search from 4.5.1 to 4.6.0 in /desktop (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1682">https://github.com/facebook/flipper/issues/1682</a>)</li>
<li><a href="bc7aacc229"><code>bc7aacc</code></a> Bump typescript-eslint/experimental-utils from 4.4.0 to 4.7.0 in /desktop (#...</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.64.0...v0.66.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1701
Reviewed By: mweststrate
Differential Revision: D25170894
Pulled By: passy
fbshipit-source-id: 0394fb086a3f4d39f5bea5a735cb7e4f7622c6c1
Summary:
I honestly don't know how the resolution works but it seems that we need
more than just one NDK.
Pull Request resolved: https://github.com/facebook/flipper/pull/1715
Test Plan: Let's hope this turns green.
Reviewed By: mweststrate
Differential Revision: D25170962
Pulled By: passy
fbshipit-source-id: dcdf25b5c77f08bdeceef50d924727cb0c9dcca9
Summary:
I converted the rating button to a functional component, and mistakenly moved the effect in the constructor into the render function.
This puts it into an effect with no dependencies so it should only happen once, instead of every render.
Reviewed By: mweststrate
Differential Revision: D25185514
fbshipit-source-id: 48203b01bbd85f3b9ed4dbbb416768c0d5524f70
Summary: This is suggested as a fix for the consistency issue (https://github.com/facebook/flipper/issues/1638) when interdependent packages published together and one of them cannot find another because it takes time to synchronise published packages to CDN. This fix is suggested here: https://github.com/CocoaPods/CocoaPods/issues/9497.
Reviewed By: mweststrate
Differential Revision: D25184732
fbshipit-source-id: d8d58b33f65ff7e87f935fb7cb85964dbf95dd13
Summary: I've noticed that some plugins cannot be packaged after switching to Sandy and using "antd" as peer dependency. This change should fix this issue.
Reviewed By: mweststrate
Differential Revision: D25177510
fbshipit-source-id: cfb740a757c9eb83cf0e5165abed3f9c9f5591fa
