Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.63.0 to 0.64.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/flipper/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1641
Reviewed By: passy
Differential Revision: D24702739
Pulled By: cekkaewnumchai
fbshipit-source-id: 04c42ade821899e85679b22a818e5e1c221ce507
Summary:
We've been using "booted" as a shortcut to select a device in `xcrun` but that will only refer to the *first* booted simulator. If you have multiple ones, that causes screenshots, videos and logs to always be pulled from the first.
Of course, this isn't documented anywhere, because Apple, but you can instead of `booted` pass in the "UDID" and refer to a specific device in all cases.
Reviewed By: nikoant
Differential Revision: D24627077
fbshipit-source-id: 2a52a8a17776746af4b3f6ca821dcce37bb0f7c2
Summary:
This diff makes the plugin manager and support form accessible from Sandy.
Actually converting them is TODO in T78698507 / T78698498
Reviewed By: cekkaewnumchai
Differential Revision: D24620558
fbshipit-source-id: c689d95b638b77ad504915a117e909cf0d88b841
Summary:
Make sure archived are displayed as such in the UI, and normal device functions aren't available:
* taking screenshots
* bookmarks
* metro device plugins
* disabling plugins
* disabled and unavailable plugins
* mobile builds
Also moved starting an emulator to the left rail, since it isn't a function related to the current selected thing
Reviewed By: cekkaewnumchai
Differential Revision: D24620247
fbshipit-source-id: f1f469e2fc5167fd90ccb35d583988873a9bc787
Summary:
This diffs adds support for the activeSheets mechanism in Sandy. It should be removed in the future (see T78696648) since open a dialog and keeping dialog state locally results in much more straight forward code, but supporting this for now makes sure that old flows are still supported.
With this change the plugin selection during a Flipper export for example wouldn't become visible
Reviewed By: cekkaewnumchai
Differential Revision: D24620074
fbshipit-source-id: f0558f5738e86a84a5cd0b9d574a3cfd0a3bf424
Summary: See test plan, if there is little space, 'tags' tended to overflow the search box. After this change the searchbox will grow were needed.
Reviewed By: cekkaewnumchai
Differential Revision: D24563826
fbshipit-source-id: 616173db7c080561ff51a76ab0e8938c58f87820
Summary:
Just bumping the peer dependencies to be in check with the dev deps.
React doesn't seem to be directly used, so I'm not sure why it
even needs to be listed.
Reviewed By: mweststrate
Differential Revision: D24537296
fbshipit-source-id: ac6313e7e58f79f75c7bad6ad4a6068b10ecab95
Summary:
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.1.2 to 4.2.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md">eslint-plugin-react-hooks's changelog</a>.</em></p>
<blockquote>
<h2>4.2.0</h2>
<ul>
<li>No changes, this was an automated release together with React 17.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1614
Reviewed By: cekkaewnumchai
Differential Revision: D24590115
Pulled By: passy
fbshipit-source-id: b7f4c86c6f41ad39e389b06e79f6b3e08402a230
Summary:
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.3.1 to 6.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md">eslint-plugin-jsx-a11y's changelog</a>.</em></p>
<blockquote>
<h1>6.4.0 / 2020-10-26</h1>
<ul>
<li>83e4ff2 [Deps] update <code>axe-core</code>, <code>jsx-ast-utils</code></li>
<li>eb92b07 [Dev Deps] update <code>babel/cli</code>, <code>babel/core</code>, <code>babel/plugin-transform-flow-strip-types</code>, <code>eslint-plugin-flowtype</code>, <code>eslint-plugin-import</code>, <code>estraverse</code>, <code>expect</code>, <code>object.assign</code></li>
<li>3d98d7a [Deps] update <code>babel/runtime</code>, <code>axe-core</code></li>
<li>f702f62 [readme] add Spanish translation</li>
<li>c2ae092 [Docs] <code>no-static-element-interactions</code>: Fixed rule name in comments</li>
<li>b90e20d Fix screenreader -> screen reader</li>
<li>645900a Fixed rule name in comments</li>
<li>381b9d6 [fix:634] Ignore control elements that are hidden</li>
<li>2c47f0a [Fix] <code>autocomplete-valid</code>: workaround for axe not being able to handle <code>null</code></li>
<li>00bd6d8 Add failing test for autocomplete with dynamic type</li>
<li>3c49c9a Add WCAG guidelines to rule documentation</li>
<li>4ecaf35 Add a testcase for tablist to interactive supports focus</li>
<li>dac6864 Deprecate the accessible-emoji rule</li>
<li>5191053 Update to axobject-query@2.2.0</li>
<li>b315698 Allow negative tabindex in aria-activedescendant-has-tabindex</li>
<li>8e6fcd0 docs: fix travis badge now points to correct location at travis-ci.com</li>
<li>2234df7 Account for additional control elements in label-has-associated-control</li>
<li>5cbb718 Adding test cases for label tests</li>
<li>66c425c Additional test case for no-redundant-roles</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="78080d432d"><code>78080d4</code></a> 6.4.0</li>
<li><a href="737e492959"><code>737e492</code></a> CHANGELOG update for v6.4.0</li>
<li><a href="83e4ff2870"><code>83e4ff2</code></a> [Deps] update <code>axe-core</code>, <code>jsx-ast-utils</code></li>
<li><a href="eb92b071ef"><code>eb92b07</code></a> [Dev Deps] update <code>babel/cli</code>, <code>babel/core</code>, `babel/plugin-transform-flow-...</li>
<li><a href="3d98d7a03a"><code>3d98d7a</code></a> [Deps] update <code>babel/runtime</code>, <code>axe-core</code></li>
<li><a href="f702f627a2"><code>f702f62</code></a> [readme] add Spanish translation</li>
<li><a href="5b35bb0c98"><code>5b35bb0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/725">https://github.com/facebook/flipper/issues/725</a> from piperchester/patch-1</li>
<li><a href="36523578a6"><code>3652357</code></a> Merge branch 'master' into patch-1</li>
<li><a href="c2ae0924c8"><code>c2ae092</code></a> [Docs] <code>no-static-element-interactions</code>: Fixed rule name in comments</li>
<li><a href="b90e20d6ab"><code>b90e20d</code></a> Fix screenreader -> screen reader</li>
<li>Additional commits viewable in <a href="https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.3.1...v6.4.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1630
Reviewed By: cekkaewnumchai
Differential Revision: D24590110
Pulled By: passy
fbshipit-source-id: 7a3f411025c6df142c814ed534a0da15ef9f03df
Summary:
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.12.0 to 6.14.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md">eslint-config-prettier's changelog</a>.</em></p>
<blockquote>
<h3>Version 6.14.0 (2020-10-21)</h3>
<ul>
<li>Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
<h3>Version 6.13.0 (2020-10-16)</h3>
<ul>
<li>Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="12b126d332"><code>12b126d</code></a> eslint-config-prettier v6.14.0</li>
<li><a href="2ba1a6145b"><code>2ba1a61</code></a> Update npm packages</li>
<li><a href="219757f1ab"><code>219757f</code></a> Turn off new eslint-plugin-vue rules (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/163">https://github.com/facebook/flipper/issues/163</a>)</li>
<li><a href="4edf6e6bc5"><code>4edf6e6</code></a> eslint-config-prettier v6.13.0</li>
<li><a href="ba40e0d165"><code>ba40e0d</code></a> Update npm packages</li>
<li><a href="fdc25da880"><code>fdc25da</code></a> Support eslint-plugin-vue@7 (which support Vue 3.0) (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/162">https://github.com/facebook/flipper/issues/162</a>)</li>
<li><a href="d5ae0c6e68"><code>d5ae0c6</code></a> Fix broken links in readme</li>
<li><a href="5d479e9433"><code>5d479e9</code></a> Fix tests</li>
<li><a href="e73484d8cc"><code>e73484d</code></a> Remove "Example configuration" section in readme</li>
<li>See full diff in <a href="https://github.com/prettier/eslint-config-prettier/compare/v6.12.0...v6.14.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1618
Reviewed By: cekkaewnumchai
Differential Revision: D24590112
Pulled By: passy
fbshipit-source-id: 98cf91f8bda78469348459564ea841f9b86a8705
Summary: flipper-pkg is broken because of metro package name change. This change should fix it.
Reviewed By: priteshrnandgaonkar
Differential Revision: D24591217
fbshipit-source-id: 2036c43bc0c2bb052e56740a03dc248e7daa8cfc
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.8 to 3.1.10.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1627
Reviewed By: cekkaewnumchai
Differential Revision: D24590105
Pulled By: passy
fbshipit-source-id: 490dc7bec5f231fa3c689abfb00aea33bb27fe0e
Summary:
Everything but react-native where we'd want to go through the
upgrade wizard. Used `yarn upgrade-interactive` to hit a few dependabot updates at once.
Reviewed By: mweststrate
Differential Revision: D24537224
fbshipit-source-id: c03f86310a9e5578cccc29e346c702165482a487
Summary: Added the Metro buttons to AppInspect
Reviewed By: cekkaewnumchai
Differential Revision: D24544760
fbshipit-source-id: 1eb6face14a7950d654c95b1a8fca31b8efed99b
Summary: Added Sandy styling to `CaptureButtons`, and converted to hooks while at it
Reviewed By: cekkaewnumchai
Differential Revision: D24538953
fbshipit-source-id: cfb9a9b856ada40eb96b77d2e5e6ea780971d0ce
Summary: This blesses the `Layout` and `theme` components and exposes them from `flipper-plugin`, so that they can be used in (public) Sandy plugins. Also marked old abstractions as going to be deprecated.
Reviewed By: cekkaewnumchai
Differential Revision: D24503560
fbshipit-source-id: a8f384667b8f66e3b9f00771a123fe5c9d755eb3
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1610
Reviewed By: nikoant
Differential Revision: D24505996
Pulled By: passy
fbshipit-source-id: f959e173e69d4857d3694d11590da8563d0b9cf9
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1612
* Use the QPL-managed QPLCore and PigeonClient.
**Facebook:**
js-shared/qpl and js-shared/pigeon-client are maintained by QPL in xplat/js-shared. I've updated the Metro config and tsconfig to allow the packages to be imported without breaking the open-source version.
Reviewed By: passy
Differential Revision: D24358369
fbshipit-source-id: 7f13d6c99d8ca6ebcd0e66bf0e5f25069370cce7
Summary:
Split container had a convenient property `scrollable`, that automatically applies a Scroll container to the main content.
But I noticed it leads to bad design choices because it is so convenient. So sometimes scrolling would be unnecessarily in two directions because of this.
Or, since the scroll container wraps around the whole content, toolbars would scroll out of view. By forcing scrolling to be put explicitly in the component tree, we encourage plugin developers to think about where they actually want to have that scroll, and in which direction.
Also added options to use the Container padding properties on ScrollContainer, which is great since we can keep the scrollbars outside the padding, and apply it to the content only, to prevent an accidental mistake where people would put a scroll container in a padded container, that would put the scrollbar inside the padding.
Reviewed By: cekkaewnumchai
Differential Revision: D24502546
fbshipit-source-id: 524004a1c5f33a185f9b959251b72875dd623cb3
Summary:
So far we distinguished `Layout.Container` from `Layout.Vertical`, but they did almost exactly the same, so figured to unify them, so smaller API ftw :) Normal containers put children vertical, and if you want to use horizontal, use Layout.Horzontal
Also simplified code in Layout file a little bit.
Fixed issue I split container where the main container didn't go "underneath" the fixed container
Reviewed By: cekkaewnumchai
Differential Revision: D24502547
fbshipit-source-id: 517db3692749e670cda8f0cd7cb1c807df818b4d
Summary:
per title
In addition, this diff adds `startUnactivated` option to allow setting up `onSend` mock implementation.
Reviewed By: mweststrate
Differential Revision: D24477989
fbshipit-source-id: f913574ebacdd436e8511baa43744249a014e90b
Summary:
This stack tries to migrate notification system to Sandy.
This diff contains on the view; other functionalities aren't working. Also, some of the views will be implemented as functionalities are added.
Reviewed By: mweststrate
Differential Revision: D24390370
fbshipit-source-id: 8e11a01d9462934ff1fadf411e7e8f57ca7ef078
Summary: Actually, things only start to break in 132.
Reviewed By: mweststrate
Differential Revision: D24480958
fbshipit-source-id: c7003459647d06cbcdf639505fa0779183923a3b
Summary:
This should give us some headroom. There are some incompatibilities and bugs in newer versions,
so only bumping this one which is compatible.
Reviewed By: mweststrate
Differential Revision: D24480863
fbshipit-source-id: ec21b937bf44686e49a71aeb38063d996d2cbff4
Summary: export filterRowsFact so we can reuse it. it's needed in diffs above
Reviewed By: SimoneCasagranda
Differential Revision: D24445819
fbshipit-source-id: 1c9ca363419c7e34f53e65b77764a49235e259e2
Summary: Allow using of .env file to pass env vars to be used in dev mode. Currently this allow to configure defaults for enabling fast refresh, automatic opening of dev tools and plugins to load.
Reviewed By: passy
Differential Revision: D24398938
fbshipit-source-id: 30a5d86b7906a7723a404cf84a1b8d50ae497dbc
Summary: Currently we load all the plugins even if they are not required in dev mode, e.g. when you are developing a specific plugin. This diff adds an env var and command-line option to specify exact list of plugins to load. This makes dev mode startup faster and consume less memory.
Reviewed By: passy
Differential Revision: D24394146
fbshipit-source-id: 42a78c1ffb2632e657c2411e34e9c80fff18df3a
Summary:
Some exploratory testing on all iOS and Android plugins, to see how they behave inside Sandy, and fixed some layout glitches (some were also present without Sandy)
General fixes:
* Introduced some niceties like searchbox resizing properly, and toolbars wrapping automatically in Sandy, rather than buttons becoming invisible
* Containers don't grow anymore by default, but take size of contents
* ScrollContainer child is now a Layout.Vertical. Layout.Vertical should be used as default container everywhere (e.g. Tabs, Panels) in the future
* Fixed layout issue if a split container had only 1 visible child
* DetailsSidebar now scrolls vertically by default
* Details sidebar would sometimes render content in-place rather than in the reserved area
* AppSelector dropdown and Plugin list will now properly ellipse (...) if there is not enough space
Plugin fixes:
* Long database / table names in Database plugin would break layout
Also fixes https://github.com/facebook/flipper/issues/1611
Reviewed By: passy
Differential Revision: D24454188
fbshipit-source-id: c60c867270900a1d4f28587d47067c6ec1072ede
Summary: Tests to verify the more complex selection logic resulting from the Metro device exception. Also verifies the logic that computes the available plugins
Reviewed By: nikoant
Differential Revision: D24445555
fbshipit-source-id: 70110c4470e6aa1356e814aa40744b65c21cad89
Summary:
I love useMemo, and the memoized functions are in principle easy to testable since deps are known
But in practice they aren't as they close over their deps, preventing hoisting. So I now use a small `useMemoize` utility that encourages me to write them in a testable manner.
Applied this to the PluginList, and it makes it imho cleaner to read. Also, testing is now much easier as demonstrated in the next diff.
Reviewed By: nikoant
Differential Revision: D24445556
fbshipit-source-id: e156dbd4b8623eb1b90650e174b69a0ec868d2da
Summary:
This adds the ability in AppInspect to work with Metro and plugins.
Metro remains a weird and hardcoded edge case, as we show it as part of another device. So a few things to notice:
- Metro does not have it's own entry in the device/app dropdown
- When selecting a metro plugin, the surrounding context (selected main device / app) remains, but you will notice that the device dropdown switches to 'React Native'. This is intentional to reflect that we are talking to React Native in general, and not necessarily to the device / app shown in the context.
Reviewed By: nikoant
Differential Revision: D24422267
fbshipit-source-id: 239aa71b5c01e19bdda53a930ad9fa8af13b8d4a
Summary:
This diff adds the rough navigation to open pugins, there are some rough egdes still, and tests will be added later, but wanted to keep diffs small, and land the feature early to get some initial dogfooding going on early.
Note that we now also show all disabled plugins to help people with trouble shooting.
Reviewed By: nikoant
Differential Revision: D24418411
fbshipit-source-id: 1402d69efe2e52bc2c81336cfb4f4c9928ea4d80
Summary:
This diff implement few things:
* Logs tab for plugin
* Sending new state for each action is expensive, that is why flipper side receive only diffs and uses `getStateFromLogItem` to calculate new state
* fixed `keys` in `DataInspector.tsx` which caused `DataInspector` become unresponsive
{F340648998}
Differential Revision: D23021619
fbshipit-source-id: 17490c25f7b86faf9e574a612996563aac18525e
Summary:
The bridge between Flipper and AMA has been established in previous diff. The goal of this diff - is to actually send data to flipper
{F340648834}
Differential Revision: D22999433
fbshipit-source-id: 72b6ad57bcaa9c0318879a224508397f70e3bc76
Summary: It's a lot more than just "launcher" now.
Reviewed By: nikoant
Differential Revision: D24425780
fbshipit-source-id: 74f6dd4d73a224a43608c4d3f3698dbd16c2e865
Summary: Disables the picker if the selection isn't editable
Differential Revision: D24419005
fbshipit-source-id: 433229a23db7fac947f574110326f5bf0dc51bc3
Summary:
Removes the "Set current" button if the timeline isn't editable
Note that the styling does weird stuff to colors when a field is set as not editable
Differential Revision: D24419006
fbshipit-source-id: 84dcee2e04d5ed7ebb3dc0255e99d1756f195284
Summary: Metro update already uppgraded half of babel libraries and jest update required updating some others, so here I just updated all babel-related and jest-related packages using `yarn upgrade-interactive` so their versions matched
Reviewed By: mweststrate
Differential Revision: D24421484
fbshipit-source-id: e22a1a8cbc36435253b8d92adadd2439d669e811
Summary:
Bumps [metro](https://github.com/facebook/metro) from 0.60.0 to 0.63.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro's releases</a>.</em></p>
<blockquote>
<h2>Release v0.63.0</h2>
<ul>
<li>[fix] Change initialisation logo and text from RN to Metro</li>
</ul>
<h2>Release v0.62.0</h2>
<ul>
<li>[feature] Add onBundleBuilt to ServerOptions</li>
</ul>
<h2>Release v0.61.0</h2>
<p>Contains all changes since 0.60.0:</p>
<ul>
<li>[Feature]: Add support for blockList and array of regexs</li>
<li>[Fix]: Change order of imports to be the same as in source files</li>
<li>[Feature]: Add new secureServerOptions option to runServer</li>
<li>[Feature]: Add inline-requires option</li>
<li>[PetPeeve]: Metro server => Metro</li>
</ul>
<p>See <a href="https://github.com/facebook/metro/compare/0.60.0...0.61.0">0.59.0...0.60.0</a> for a full list of changes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b9bacd51d0"><code>b9bacd5</code></a> Metro release v0.63.0</li>
<li><a href="c106b6540e"><code>c106b65</code></a> Change initialisation logo and text</li>
<li><a href="be719b29c0"><code>be719b2</code></a> remove redundant deprecated-utility setting from flow configs</li>
<li><a href="9236feba99"><code>9236feb</code></a> Turn off template literal and shorthand properties transform for hermes-canary</li>
<li><a href="6b82e8443c"><code>6b82e84</code></a> Create a <code>metro-runtime</code> module</li>
<li><a href="18883f6caa"><code>18883f6</code></a> Fix up package.json files.</li>
<li><a href="921b73e4d0"><code>921b73e</code></a> Remove autogenerated table of contents (deprecated in docusaurus v2)</li>
<li><a href="eb9b02572b"><code>eb9b025</code></a> Update configuration page with examples</li>
<li><a href="00a5a6d8d6"><code>00a5a6d</code></a> Fix troubleshooting and help pages</li>
<li><a href="c73eaf88f8"><code>c73eaf8</code></a> Update docusaurus version</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/metro/compare/v0.60.0...v0.63.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1606
Reviewed By: passy
Differential Revision: D24392103
Pulled By: nikoant
fbshipit-source-id: 6d816629f55e04852d6737f9960fa61d7e83cee8
Summary: Updates the OpenSSL dependency. Enabling bitcode as the latest version of OpenSSL has bitcode support.
Reviewed By: mweststrate
Differential Revision: D24276537
fbshipit-source-id: 6f135659d64e8849dcf68266458a8f24ef795be7
