f10f963ff1f35f3237b60ce7c26d77c8844db84c
1018 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Pascal Hartig
|
d42932c111 |
Add rule for warning against electron.remote
Summary: I don't think there's an easy way to do this based on types which would be ideal ... So instead I'm checking for - Importing `remote` from `electron`. - Accessing `electron.remote`. You can still hack this by importing `electron`, saving it to a differently named variable and accessing `remote` on it, but this should cover all reasonable cases we see in real code. Reviewed By: mweststrate Differential Revision: D26453006 fbshipit-source-id: 4b3d223bed43ca3f0d1a4f592ea8f8060a823479 |
||
Anton Nikolaev
|
b6372ad006 |
Fix appMatchPatterns error
Summary: Fixed error thrown by navigation plugin in Flipper release builds (T84083443) Reviewed By: passy Differential Revision: D26402201 fbshipit-source-id: 7433457e3074c26ad17ac5158522d287232e2ede |
||
Michel Weststrate
|
b4ec0d62a5 |
Fix device cleanup
Summary: Found some code duplication causing old devices not entirely to be cleaned up as they should Reviewed By: nikoant Differential Revision: D26422665 fbshipit-source-id: f57757f7260ac5de17edd80e9f66cc844d1a6213 |
||
|
Michel Weststrate
|
4964966b91 |
Fix Flipper crashing to an empty screen
Summary: Changelog: Fixed issue where a Flipper crash would result in an entirely blank screen, rather than a useful error message. While debugging another issue, discovered that React errors that happen outside a Plugin aren't caught at all, resulting in the infamous gray screen of deaths. This was the case because no error boundary has been set up for our Chrome, and since React 16 the default error handling has becoming rendering blank, rather than freezing. See https://reactjs.org/docs/error-boundaries.html#new-behavior-for-uncaught-errors. Thanks to ant.design styling this decently was trivial :). But sadly involved a component class since error boundaries are not yet available as hook. With these changes the errors should also end up more readably in our monitoring. Reviewed By: nikoant Differential Revision: D26422666 fbshipit-source-id: 6c0f8611c80a4a5e0d7e61d58afcf5eabe410e57 |
||
generatedunixname89002005306973
|
0633e5bfd7 |
Flipper Release: v0.75.1
Summary: Releasing version 0.75.1 Reviewed By: passy Differential Revision: D26422941 fbshipit-source-id: 655a898289c877b44a9c7bd3e359dcf045688988 |
||
|
Pascal Hartig
|
27f34be824 |
Suppress Metro error
Summary: T84629221 shows this is quite common and is not something we want to log errors for. Reviewed By: mweststrate Differential Revision: D26371400 fbshipit-source-id: 748a83d8ad484b0ceb1f3bf7e3a447602ae4c961 |
||
|
Pascal Hartig
|
eff1ce5ba7 |
Catch errors when querying physical devices
Summary: This is our #1 error and always means there's something off with the user's setup. Reviewed By: mweststrate Differential Revision: D26370974 fbshipit-source-id: 5e2644ce9de8a7d28614a22fab5ce54dab0561d3 |
||
|
Pascal Hartig
|
92f3ab8ff4 |
Improve error handling for iOSDevices
Summary: Adding context everywhere as naked messages are hard to track down and making common errors like missing Xcode license agreements a warning + error popup instead. Changelog: Reduce spamminess of iOS connection warnings Reviewed By: mweststrate Differential Revision: D26370235 fbshipit-source-id: b283d297479c2bf76a11b5a3f96a59fad70a4a67 |
||
|
Michel Weststrate
|
8d5f136a34 |
Fix active state reducer mutating existing state
Summary: This reducer was mutating existing state, which will throw since we freeze state to prevent exactly that. Fixed it by using a defensive copy. Note that `newActiveNotifications` doesn't suffer from the same as it is freshly allocated. See https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/desktop/app/src/reducers/notifications.tsx?commit=29b592866b44&lines=160 Reviewed By: passy Differential Revision: D26399200 fbshipit-source-id: 5f9f22db3de48f4f595a028faf9e9ec547641cfb |
||
|
Michel Weststrate
|
e9922746ed |
Fixed text of imported devices
Summary: Noticed in the support group that the imported device label was incorrect. Probably a copy paste error. Reviewed By: nikoant Differential Revision: D26368664 fbshipit-source-id: abc2aad4d20a9f44d6f1ac45962ab28863d78f0d |
||
|
generatedunixname89002005306973
|
48a6235d26 |
Flipper Release: v0.75.0
Summary: Releasing version 0.75.0 Reviewed By: passy Differential Revision: D26368798 fbshipit-source-id: e0d1d23023c6f0fb66ff675ccd61758722e4ebd7 |
||
dependabot[bot]
|
800759c384 |
Bump algoliasearch from 4.4.0 to 4.8.4 in /desktop (#1911)
Summary: Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 4.4.0 to 4.8.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases">algoliasearch's releases</a>.</em></p> <blockquote> <h2>4.8.4</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.3...4.8.4">v4.8.4</a></h2> <ul> <li>feat(ts): add decompoundQuery (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1240">https://github.com/facebook/flipper/issues/1240</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/446c9a0">446c9a0</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1240">https://github.com/facebook/flipper/issues/1240</a></li> <li>feat(ts): add the attributesToTransliterate setting (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1244">https://github.com/facebook/flipper/issues/1244</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/b91c035">b91c035</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1244">https://github.com/facebook/flipper/issues/1244</a></li> </ul> <h2>4.8.3</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.2...4.8.3">v4.8.3</a></h2> <ul> <li>fix(ts): correct type for listIndices response (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1236">https://github.com/facebook/flipper/issues/1236</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/0bb6bba">0bb6bba</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1236">https://github.com/facebook/flipper/issues/1236</a></li> </ul> <h2>4.8.2</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.1...4.8.2">v4.8.2</a></h2> <ul> <li>fix(findAnswers): fix typing (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1233">https://github.com/facebook/flipper/issues/1233</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a935d88">a935d88</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1233">https://github.com/facebook/flipper/issues/1233</a></li> <li>fix(ts): don't require every attribute to be highlighted (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1234">https://github.com/facebook/flipper/issues/1234</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/4591d0e">4591d0e</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1234">https://github.com/facebook/flipper/issues/1234</a></li> </ul> <h2>4.8.1</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.0...4.8.1">v4.8.1</a></h2> <ul> <li>fix(ts): correct search response for facets_stats (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1229">https://github.com/facebook/flipper/issues/1229</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/ac732d1">ac732d1</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1229">https://github.com/facebook/flipper/issues/1229</a></li> </ul> <h2>4.8.0</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.7.0...4.8.0">v4.8.0</a></h2> <ul> <li>feat(saveSynonyms): replaceExistingSynonyms -> clearExistingSynonyms (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1226">https://github.com/facebook/flipper/issues/1226</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/2fcf485">2fcf485</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1226">https://github.com/facebook/flipper/issues/1226</a> <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1224">https://github.com/facebook/flipper/issues/1224</a></li> <li>fix(findAnswers): expose in lite version (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1227">https://github.com/facebook/flipper/issues/1227</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/6cb1d0a">6cb1d0a</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1227">https://github.com/facebook/flipper/issues/1227</a></li> </ul> <h2>4.7.0</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.6.0...4.7.0">v4.7.0</a></h2> <ul> <li>feat(findAnswers): implement the new method (experimental) (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1219">https://github.com/facebook/flipper/issues/1219</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/8d962ea">8d962ea</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1219">https://github.com/facebook/flipper/issues/1219</a></li> <li>feat(analytics & recommendation): allow creation of clients (initAnalytics, initRecommendation) with their own credentials (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1223">https://github.com/facebook/flipper/issues/1223</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a7938b0">a7938b0</a>)</li> </ul> <h2>4.6.0</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.5.1...4.6.0">v4.6.0</a></h2> <ul> <li>fix(node): allow passing requesterOptions (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1215">https://github.com/facebook/flipper/issues/1215</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/4348b38">4348b38</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1215">https://github.com/facebook/flipper/issues/1215</a></li> <li>fix(node): reuse http agent across client (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1216">https://github.com/facebook/flipper/issues/1216</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/f6e9e56">f6e9e56</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1216">https://github.com/facebook/flipper/issues/1216</a></li> <li>feat(client-search): add personalization field to RankingInfo (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1213">https://github.com/facebook/flipper/issues/1213</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/50b78a3">50b78a3</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1213">https://github.com/facebook/flipper/issues/1213</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md">algoliasearch's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.3...4.8.4">v4.8.4</a></h2> <ul> <li>feat(ts): add decompoundQuery (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1240">https://github.com/facebook/flipper/issues/1240</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/446c9a0">446c9a0</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1240">https://github.com/facebook/flipper/issues/1240</a></li> <li>feat(ts): add the attributesToTransliterate setting (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1244">https://github.com/facebook/flipper/issues/1244</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/b91c035">b91c035</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1244">https://github.com/facebook/flipper/issues/1244</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.2...4.8.3">v4.8.3</a></h2> <ul> <li>fix(ts): correct type for listIndices response (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1236">https://github.com/facebook/flipper/issues/1236</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/0bb6bba">0bb6bba</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1236">https://github.com/facebook/flipper/issues/1236</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.1...4.8.2">v4.8.2</a></h2> <ul> <li>fix(findAnswers): fix typing (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1233">https://github.com/facebook/flipper/issues/1233</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a935d88">a935d88</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1233">https://github.com/facebook/flipper/issues/1233</a></li> <li>fix(ts): don't require every attribute to be highlighted (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1234">https://github.com/facebook/flipper/issues/1234</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/4591d0e">4591d0e</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1234">https://github.com/facebook/flipper/issues/1234</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.0...4.8.1">v4.8.1</a></h2> <ul> <li>fix(ts): correct search response for facets_stats (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1229">https://github.com/facebook/flipper/issues/1229</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/ac732d1">ac732d1</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1229">https://github.com/facebook/flipper/issues/1229</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.7.0...4.8.0">v4.8.0</a></h2> <ul> <li>feat(saveSynonyms): replaceExistingSynonyms -> clearExistingSynonyms (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1226">https://github.com/facebook/flipper/issues/1226</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/2fcf485">2fcf485</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1226">https://github.com/facebook/flipper/issues/1226</a> <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1224">https://github.com/facebook/flipper/issues/1224</a></li> <li>fix(findAnswers): expose in lite version (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1227">https://github.com/facebook/flipper/issues/1227</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/6cb1d0a">6cb1d0a</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1227">https://github.com/facebook/flipper/issues/1227</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.6.0...4.7.0">v4.7.0</a></h2> <ul> <li>feat(findAnswers): implement the new method (experimental) (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1219">https://github.com/facebook/flipper/issues/1219</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/8d962ea">8d962ea</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1219">https://github.com/facebook/flipper/issues/1219</a></li> <li>feat(analytics & recommendation): allow creation of clients (initAnalytics, initRecommendation) with their own credentials (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1223">https://github.com/facebook/flipper/issues/1223</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a7938b0">a7938b0</a>)</li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.5.1...4.6.0">v4.6.0</a></h2> <ul> <li>fix(node): allow passing requesterOptions (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1215">https://github.com/facebook/flipper/issues/1215</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/4348b38">4348b38</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1215">https://github.com/facebook/flipper/issues/1215</a></li> <li>fix(node): reuse http agent across client (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1216">https://github.com/facebook/flipper/issues/1216</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/f6e9e56">f6e9e56</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1216">https://github.com/facebook/flipper/issues/1216</a></li> <li>feat(client-search): add personalization field to RankingInfo (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1213">https://github.com/facebook/flipper/issues/1213</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/50b78a3">50b78a3</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1213">https://github.com/facebook/flipper/issues/1213</a></li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.5.0...4.5.1">v4.5.1</a></h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
054bfdb047 |
Bump antd from 4.11.2 to 4.12.2 in /desktop (#1909)
Summary: Bumps [antd](https://github.com/ant-design/ant-design) from 4.11.2 to 4.12.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.12.2</h2> <ul> <li>{emoji:1f484} Make Table expand icon and checkbox same size and aligned. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li> <li>{emoji:1f41e} Fix List with <code>gutter</code> makes column break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li> </ul> <hr /> <ul> <li>{emoji:1f484} 调整 Table 展开图标和选择框的大小一致并对齐。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li> <li>{emoji:1f41e} 修复 List 配置 <code>gutter</code> 时列会折行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li> </ul> <h2>4.12.1</h2> <ul> <li>{emoji:1f41e} Fix antd crash when load before page ready. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li> <li>{emoji:1f41e} Fix Table pagination <code>current</code> change logic when <code>pageSize</code> changes. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li> </ul> <hr /> <ul> <li>{emoji:1f41e} 修复 antd 在页面加载之前载入导致的页面崩溃问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li> <li>{emoji:1f41e} 修正 Table 改变 <code>pageSize</code> 重置 <code>current</code> 的逻辑，现在若超出会重置到最大页数。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li> </ul> <h2>4.12.0</h2> <ul> <li>{emoji:1f195} Image.PreviewGroup add <code>current</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li> <li>InputNumber <ul> <li>{emoji:1f195} InputNumber support <code>bordered</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li> <li>{emoji:1f195} InputNumber add <code>keyboard</code> prop which could disable keyboard behavior. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li> </ul> </li> <li>{emoji:1f484} Darken Tag text color to enhance readability. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li> <li>{emoji:1f484} Fix Row with vertical <code>gutter</code> provides additional <code>margin-bottom</code> style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li> <li>{emoji:1f41e} Fix Collapse header disappers with delay. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li> <li>{emoji:1f41e} Fix the problem that <code>showCount</code> display data is incorrect when TextArea input emoji. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li> <li>{emoji:1f4e6} Optimize ConfigProvider to avoid import all icons when tree shaking is not enabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li> <li>{emoji:1f310} Add en-GB missing translations for table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li> <li>Table <ul> <li>{emoji:1f195} Table <code>showSorterTooltip</code> now could be a object for more configuration. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29002">#29002</a> <a href="https://github.com/harrisoff"><code>harrisoff</code></a></li> <li>{emoji:26a1} Optimize calling sequence of <code>onChange</code> and <code>onSelectAll</code> in <code>rowSelection</code> of Table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29079">#29079</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li> </ul> </li> <li>Badge <ul> <li>{emoji:1f484} Fix Badge change <code>count</code> content to hide miss style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li> <li>{emoji:1f41e} Fix Badge digital animation problem. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li> </ul> </li> <li>TypeScript <ul> <li>� Table TS definition update <code>dataSource</code> to <code>readonly</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29084">#29084</a></li> </ul> </li> <li>Less <ul> <li>{emoji:1f484} Add less variable <code>progress-info-text-color</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28981">#28981</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>{emoji:1f195} Image.PreviewGroup 添加 <code>current</code> 属性支持受控模式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li> <li>InputNumber <ul> <li>{emoji:1f195} InputNumber 支持 <code>bordered</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li> <li>{emoji:1f195} InputNumber 添加 <code>keyboard</code> 属性以支持禁用键盘行为。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li> </ul> </li> <li>{emoji:1f484} 加深 Tag 文字颜色以提升可读性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li> <li>{emoji:1f484} 修复 Row 配置垂直 <code>gutter</code> 时会额外添加 <code>margin-bottom</code> 样式的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li> <li>{emoji:1f41e} 修复 Collapse 标题区域隐藏延迟的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li> <li>{emoji:1f41e} 修复 TextArea 输入 emoji 时 <code>showCount</code> 展示数据不正确的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li> <li>{emoji:1f4e6} 优化 ConfigProvider 在未开启 tree shaking 的项目中引入所有图标的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li> <li>{emoji:1f1ec_1f1e7} 为表格添加 <code>en-GB</code> 翻译。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li> <li>Badge <ul> <li>{emoji:1f41e} 修复 Badge 的数字动画方向问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li> <li>{emoji:1f484} 修复 Badge 修改 <code>count</code> 内容以隐藏时的样式问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li> </ul> </li> <li>Table</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.12.2</h2> <p><code>2021-02-04</code></p> <ul> <li>{emoji:1f484} Make Table expand icon and checkbox same size and aligned. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li> <li>{emoji:1f41e} Fix List with <code>gutter</code> makes column break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li> </ul> <h2>4.12.1</h2> <p><code>2021-02-03</code></p> <ul> <li>{emoji:1f41e} Fix antd crash when load before page ready. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li> <li>{emoji:1f41e} Fix Table pagination <code>current</code> change logic when <code>pageSize</code> changes. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li> </ul> <h2>4.12.0</h2> <p><code>2021-02-03</code></p> <ul> <li>{emoji:1f195} Image.PreviewGroup add <code>current</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li> <li>InputNumber <ul> <li>{emoji:1f195} InputNumber support <code>bordered</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li> <li>{emoji:1f195} InputNumber add <code>keyboard</code> prop which could disable keyboard behavior. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li> </ul> </li> <li>{emoji:1f484} Darken Tag text color to enhance readability. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li> <li>{emoji:1f484} Fix Row with vertical <code>gutter</code> provides additional <code>margin-bottom</code> style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li> <li>{emoji:1f41e} Fix Collapse header disappers with delay. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li> <li>{emoji:1f41e} Fix the problem that <code>showCount</code> display data is incorrect when TextArea input emoji. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li> <li>{emoji:1f4e6} Optimize ConfigProvider to avoid import all icons when tree shaking is not enabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li> <li>{emoji:1f310} Add en-GB missing translations for table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li> <li>Table <ul> <li>{emoji:1f195} Table <code>showSorterTooltip</code> now could be a object for more configuration. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29002">#29002</a> <a href="https://github.com/harrisoff"><code>harrisoff</code></a></li> <li>{emoji:26a1} Optimize calling sequence of <code>onChange</code> and <code>onSelectAll</code> in <code>rowSelection</code> of Table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29079">#29079</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li> </ul> </li> <li>Badge <ul> <li>{emoji:1f484} Fix Badge change <code>count</code> content to hide miss style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li> <li>{emoji:1f41e} Fix Badge digital animation problem. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li> </ul> </li> <li>TypeScript <ul> <li>� Table TS definition update <code>dataSource</code> to <code>readonly</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29084">#29084</a></li> </ul> </li> <li>Less <ul> <li>{emoji:1f484} Add less variable <code>progress-info-text-color</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28981">#28981</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> </ul> <h2>4.11.3</h2> <p><code>2021-02-03</code></p> <p>Wrong release is the same as <code>4.12.0</code>, if you need to lock the version, you need to lock it to <code>4.11.2</code>.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
79d937772f |
Bump @types/socket.io from 2.1.11 to 2.1.13 in /desktop (#1910)
Summary: Bumps [types/socket.io](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/socket.io) from 2.1.11 to 2.1.13. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/socket.io">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1910 Reviewed By: mweststrate Differential Revision: D26341340 Pulled By: passy fbshipit-source-id: aaa780ca9a3e5c7ca082818e7462b02abca373fa |
||
|
dependabot[bot]
|
3654c79006 |
Bump @types/react-test-renderer from 16.9.3 to 17.0.0 in /desktop (#1906)
Summary: Bumps [types/react-test-renderer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-test-renderer) from 16.9.3 to 17.0.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-test-renderer">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1906 Reviewed By: mweststrate Differential Revision: D26341261 Pulled By: passy fbshipit-source-id: 09baa342878dcf31874635371fd63b8298a1581e |
||
bizzguy
|
1b76c3d8e7 |
Changes to local storage for mocks and body format (#1871)
Summary: Network calls are normally unique to an application as are the associated mocks. Currently, the mocks for different applications are combined together and saved to the local store. It would be better if mocks were saved (and retrieved by application). This PR adds "appId" to the local store name to save mocks separately for each app. This is not really the ideal technique since different apps could have the same name. Android apps use packageId rather than app name (which is what appid is) to uniquely identify an app. However, package id does not seem to be available to the Flipper client so appid is used instead. This requirement is described in this issue: https://github.com/facebook/flipper/issues/1487 Also, individual developers often have a preference for how they like to view response data (parsed or formatted). This PR saved the selected format so that the developer does not have to keep selecting it. Since this preference is not specific to an app, it is not necessary to save the preference for each app. ## Changelog Network plugin - save mocks by app Network plugin - save response body format preference to local storage Pull Request resolved: https://github.com/facebook/flipper/pull/1871 Test Plan: Install two apps (with different names) Create mocks in each app Restart Flipper View the mocks for each app and verify that they are unique to the app Reviewed By: mweststrate Differential Revision: D26341333 Pulled By: passy fbshipit-source-id: cc0286a9dc4e37e008672bfad7c6180f0d5675e4 |
||
|
Michel Weststrate
|
bf7599e574 |
Bumped some deps to fix parsing of template literal types
Summary:
I want to use TypesScipt type literals in a next diff (e.g.
```
type Percentage = `${number}%`
```
But to be able to use that typescript, prettier and eslint needed bumps :)
Reviewed By: nikoant
Differential Revision: D26321133
fbshipit-source-id: a4891246ef8c654f324c6daf303c5c4b2f54496e
|
||
|
Michel Weststrate
|
3b6be6b7b6 |
Minor improvements in handling offline applications
Summary: Some minor loose ends from exploratory testing: - disconnect device logs event listeners if the device disconnects - show metro if that is still up, even if the app is no longer connected - hide the options in the support form to record videos / screenshots if the device isn't connected Reviewed By: nikoant Differential Revision: D26277100 fbshipit-source-id: 49d0c934d587b226bc25524224efce60b53939e9 |
||
|
Michel Weststrate
|
54f9ff260b |
Show quick notification if plugin interaction fails
Summary: Per title, if a plugin makes a client call, show a quick notif so that the user knows why his plugin interactions aren't responding in case the plugin doesn't use `isConnected` guards. This might turn out to be too spammy, but I think it should be ok. Reviewed By: nikoant Differential Revision: D26277099 fbshipit-source-id: bd555ea84acae6189ec7f8fff0fc0a088dbc5337 |
||
|
Michel Weststrate
|
60cfcb54a1 |
Wrap plugin calls into isConnected guards
Summary: Previously, plugins could relatively safely use `client.call` at any moment in time to fetch some information from / to the client. Except for some raise conditions there was generally speaking a connection available. With this stack it becomes possible to interact with plugins even after an app (unexpectedly) disconnected, which makes Flipper a lot more versatile, especially when it comes to inspect crashes post mortem. (For more explanation see the second diff in this stack) However, this means that it is no longer safe to assume there is always a connection available. For that reason `client.isConnected` has been introduced to safeguard against that. This diff introduces guards on all user interactions that are not super explicitly triggered by the user to avoid a lot of errors being generated. This is mostly in `init()` blocks and implicit user events like selecting or hovering rows. Explicit user interactions like pressing buttons are not guarded by this diff, as ideally failure to communicate with the client should be communicated back to the user more explicitly rather than failing silently. The next diff will introduce a fallback mechanism where a popup is shown in case those calls aren't guarded. Fixed a few key warnings while at it. Reviewed By: nikoant Differential Revision: D26275604 fbshipit-source-id: 5630066cdd9541e448a6dd1f8a21861b5d751ced |
||
|
Michel Weststrate
|
43c68c0e7c |
Separate the concepts of archived and disconnected devices
Summary: Minor code cleanup to avoid future confusion: - archived: a device that was imported from a Flipper trace, and only has persisted state - (dis)connected: a real stateful device that might or might not have an active connection Reviewed By: nikoant Differential Revision: D26275459 fbshipit-source-id: eba554b37c39711e367c3795ff4456329a303c22 |
||
|
Michel Weststrate
|
1bb1cae167 |
Don't send messages to disconnected clients. Make exportPersistedState compatible with disconnected devices.
Summary:
This diff addresses two problems:
1. Since clients plugins can be active beyond having a connection, we have to make it possible for plugin authors to check if they are connected before they make a call.
2. if there is a custom `exportPersistedState`, plugins should be able to skip making calls if the device has disconnected.
Introducing this change makes it possible to interact with a reasonable level with disconnected clients, and makes it possible to create Flipper traces for disconnected clients.
Note that both items were already problems before supporting offline clients; as there can be a noticeable delay between disconnecting and Flipper detecting that (i've seen up to 30 secs). What happend previously in those cases is that the export would simply hang, as would other user interactions, as loosing the connection in the middle of a process would cause the promise chains to be neither rejected or resolved, which is pretty iffy.
Before this diff, trying to export a disconnected device would hang forever like:
{F369600601}
Reviewed By: nikoant
Differential Revision: D26250895
fbshipit-source-id: 177624a116883c3cba14390cd0fe164e243bb97c
|
||
|
Michel Weststrate
|
7650ab620d |
Fixed bug causing pending events of non-sandy plugins not to be part of the export
Summary: During testing I noticed that even though plugin queues were flushed, the processed messages didn't end up in the export snapshots. This was caused by holding a ref of an older snapshot of the state Changelog: Fixed an issue where data that arrived in the background was not part of the generated Flipper export. Reviewed By: nikoant Differential Revision: D26250897 fbshipit-source-id: ddd3f5bb19e38a1b13498d03f235bf63858eb8f8 |
||
|
Michel Weststrate
|
2df117923c |
Select new client after connecting, if possible
Summary: Small UX improvement, try to select a newly arriving client if possible, this is nice as it means that disconnecting and connecting will typically end you up in the same app. Changelog: If a new client connects, Flipper will try to focus on it Reviewed By: nikoant Differential Revision: D26250896 fbshipit-source-id: 83d9777a8608cd887d663a6bbe1444d2aa614e95 |
||
|
Michel Weststrate
|
ff7997b3fa |
Make sure disconnected devices / apps can be imported and exported
Summary: It should be possible to exported disconnected devices, so that flipper traces / support form reports can be created from them. This diff introduces this functionality. Support for plugins with custom export logic is introduced in a later diff. Issues fixed in this diff: - don't try to take a screenshot for a disconnected device (this would hang forever) - device plugins were always exported, regardless whether the user did select them or not - sandy plugins were never part of exported disconnected clients - increased the amount of data exported for device logs to ~10 MB. This makes more sense now as the logs will no longer be included in all cases - fixed issue where are plugins would appear to be enabled after the client disconnected (this bug is the result of some unfortunate naming of `isArchived` vs `isConnected` semantics. Will clean up those names in a later diff. Changelog: It is now possible to create a Flipper trace for disconnected devices and apps Reviewed By: nikoant Differential Revision: D26250894 fbshipit-source-id: 4dd0ec0cb152b1a8f649c31913e80efc25bcc5dd |
||
|
Michel Weststrate
|
8bc1b953c2 |
Show current device/app connection status in AppInspect selector
Summary: UX love for imported and disconnected devices, so that stuff looks better :) Reviewed By: nikoant Differential Revision: D26249348 fbshipit-source-id: 70db682ccf0cb73161e136994f5135717f3c6be6 |
||
|
Michel Weststrate
|
bb529411b5 |
Expose current connection status to Sandy plugins
Summary: Introduced `isConnected` flag on device and plugin client to reflect whether a connection is still available for the plugins, or that they have been disconnected. Potentially we could expose the (readonly) `connected` state atom for this as well, or an `onDisconnect` event for device pugins, to create a responsive UI, but there might be no need for that, in which case this suffices. Reviewed By: nikoant Differential Revision: D26249346 fbshipit-source-id: b8486713fdf2fcd520488ce54f771bd038fd13f8 |
||
|
Michel Weststrate
|
7e1bf0f58b |
Preserve client state after disconnect
Summary: This diff introduces support for keeping clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example. With this diff, the current client is just kept around until it connects again, instead of throwing clients immediately away if they disconnect. After this change, ArchivedClients will only be created by imports / exports, and no longer by disconnects. Initially I played with improving the creation of archived devices, by migrating all plugin state over from the original client to the archive, but I discovered that is very prone, as it would be a lot of pointer redistribution (plugins would point to a different client / device etc). While in contrast, disconnected clients is already an existing concept in Flipper, so reusing that keeps all the changes relatively simple. Note that we could potentially still reuse old clients around after reconnected, but it would become much harder to reason about how plugins would behave if they missed updates for a while, so throwing away the device / clients and starting with a fresh slate sounds safer. So I figured that chance to be too risky for now, but would probably be good follow up work. Issues with import / export, UX, and making calls to to a disconnected client will be addressed in follow up diffs Changelog: Clients will retain their state after being disconnected, until they reconnect again Reviewed By: nikoant Differential Revision: D26224677 fbshipit-source-id: feb9d241df2304341c2847fe7fd751ac54c045f6 |
||
|
Michel Weststrate
|
c43049d881 |
Preserve device state after disconnect
Summary: This diff stack introduces support for keeping devices and clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example. This feature existed partially before, but only supported Android, and only support plugins with persisted state; as it replace the current device with an archived version of the same device. In practice this didn't work really well, as most plugins would not be available, and all non-persisted state would be lost. This diff makes sure we can keep devices around after disconnecting, the next one will keep the clients around as well. And explain some code choices in more detail. Note that `Device.isArchived` was an overloaded term before, and even more now (both representing imported and disconnected devices), will address that in a later diff. https://github.com/facebook/flipper/issues/1460 https://github.com/facebook/flipper/issues/812 https://github.com/facebook/flipper/issues/1487 Changelog: iOS and Android devices will preserve their state after being disconnected Reviewed By: nikoant Differential Revision: D26224310 fbshipit-source-id: 7dfc93c2a109a51c2880ec212a00463bc8d32041 |
||
|
Michel Weststrate
|
7361ecc080 |
Disable CPU plugin on archived devices
Summary: Changelog: CPU plugin will no longer show up for archived devices CPU plugin did show up on imported devices, but would always result in exceptions as no `adb` connection is available for them. Reviewed By: jknoxville Differential Revision: D26249575 fbshipit-source-id: c4fa7b3fec895f9c4ab9e31dce2f61fb23e9195b |
||
|
Michel Weststrate
|
9987c8ee89 |
Make sure antd is used from Flipper
Summary: Fix build job that didn't include require rewrites for antd Reviewed By: timur-valiev Differential Revision: D26311554 fbshipit-source-id: 473a9c7d343e4534a33e5938ea27667f7795d8ac |
||
|
Pascal Hartig
|
949b57b473 |
Improve types
Summary: The any type was masking how the log object is actually initialised. Sorry for the deluge of drive-by diffs. Something more substantial is coming. Reviewed By: mweststrate Differential Revision: D26250580 fbshipit-source-id: 5ba3f450ac1a646616868a8fd8b3cb42fb14dcc8 |
||
|
Pascal Hartig
|
e788bb09be |
Add logs support for physical devices
Summary: There's a bit of an oddity with `idb` that the `stream` parameter is implied even though the docs say otherwise and if you try to use it, it'll give you a strange Python error. That's likely why we never implemented it. Now, it works just as it does using local tooling. Reviewed By: mweststrate Differential Revision: D26228036 fbshipit-source-id: e20cb31167170ba0501e2929ed129305cb9aaf2c |
||
|
generatedunixname89002005306973
|
0429c1892f |
Flipper Release: v0.74.0
Summary: Releasing version 0.74.0 Reviewed By: jknoxville Differential Revision: D26253173 fbshipit-source-id: 80f4e3917cf130bbf546af6d48e43a62265660d0 |
||
|
Pascal Hartig
|
87caca9e77 |
Demote iOS connection errors
Summary: The "attaching failed" error provides no context and is a handled error, so we don't need to elevate this to a warning. We also see a socket warning on stderr every time we start up logging through simctl, so we don't need to treat that as an error. Reviewed By: nikoant Differential Revision: D26228037 fbshipit-source-id: 1938dadd54499462e1fd614c9477f738661c387b |
||
|
Pascal Hartig
|
661af25ff9 |
getAppVersion for UpdateIndicator
Summary:
VSCode got a new thing where it doesn't save my file because it waits for a formatter or some stuff indefinitely, which is really cool, because it means my diffs end up being incomplete.
So this should have been in D26223274 (
|
||
|
Anton Nikolaev
|
2f03aca5eb |
Revert D26222885: Upgrade metro to 0.65.0
Differential Revision:
D26222885 (
|
||
|
Pascal Hartig
|
642d89213d |
Extract getAppVersion() util
Summary: Just some simple memoisation so we limit this particular `remote` call to one per session. Reviewed By: mweststrate Differential Revision: D26223274 fbshipit-source-id: 7a12764758823c52f68fb7075f46caf58affb22f |
||
|
Michel Weststrate
|
40abef860f |
Fix key warning
Summary: Crash reporter generated React errors because the different lines in a stack trace are not per definition unique Reviewed By: jknoxville Differential Revision: D26201941 fbshipit-source-id: 084e0157b1fa3b8216d35f62f0dc17b0d6414b8e |
||
|
Anton Nikolaev
|
9fe82dd6c7 |
Upgrade metro to 0.65.0
Summary: Upgrade metro to 0.65.0 Reviewed By: passy Differential Revision: D26222885 fbshipit-source-id: bb386ae4bc913d47d9f3431368e45c6319f0d65d |
||
|
dependabot[bot]
|
e09e3c82ee |
Bump antd from 4.9.1 to 4.11.2 in /desktop (#1886)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.9.1 to 4.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.11.2</h2> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <hr /> <ul> <li>{emoji:1f41e} 修复 rc-trigger BuildInPlacements TypeScript 编译错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>{emoji:1f484} Layout 内联子表单添加背景颜色以更好的区分层级。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader 支持 <code>breadcrumbRender</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> 属性添加 <code>tooltip</code> 支持以自定义收缩时的提示信息。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image 支持配置 <code>preview.maskClassName</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} 修复预览图片会跟随鼠标移动的问题。<a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} 修复 Image <code>placeholder</code> 不显示的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} 修复多个 Image.PreviewGroup 之间图片互串的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider</li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider 支持 <code>iconPrefixCls</code> 修改图标样式前缀。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} 优化 ConfigProvider 切换属性的性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} 调整 TreeSelect 搜索高亮条目的颜色。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} 修复 Select 自定义 <code>tagRender</code> 时不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} 修复 Form.Item 无法正确清理嵌套的 <code>noStyle</code> 错误信息问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item 配置 <code>preserve=false</code> 时，移除该字段将自动重置对应值为 <code>initialValues</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.11.2</h2> <p><code>2021-01-26</code></p> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <p><code>2021-01-24</code></p> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <h2>4.11.0</h2> <p><code>2021-01-24</code></p> <p>It is a wrong release which same as <code>4.10.3</code>, don't use it.</p> <h2>4.10.3</h2> <p><code>2021-01-18</code></p> <ul> <li>{emoji:1f41e} Fix Button not adapting to the <code>btn-border-width</code> when loading. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28886">#28886</a> <a href="https://github.com/jjanssen"><code>jjanssen</code></a></li> <li>Table <ul> <li>{emoji:1f484} Add <code>table-border-color</code> less variable. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28903">#28903</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Pritesh Nandgaonkar
|
6a0854557e |
Add gk checks in plugin
Summary: This diff adds gk checks, VPN check and User login check to our plugin. I added gk checks for Insta and FB apps. There are three kind of GK's. One with FB universe, one with Distillery universe and one with Insta WWW universe. We have API's to check gk with FB and Distillery universe. API to check with Insta WWW universe doesn't exists. There are some technical challenges to build this API. So right now for gks with Insta WWW universe, we just show an notification with info icon. For gks in other universe we aggressively check it when user closes the notif to verify if user assigned himself/herself to it. In long term we are moving away from gks altogether, we need this UX improvement as it will help users to onboard easily. See the following flow. Reviewed By: mweststrate Differential Revision: D26176996 fbshipit-source-id: 92a931610f9b244c14c6888bb12df936b62edd75 |
||
|
Pascal Hartig
|
9469ad33af |
Make addErrorNotification raise a warning
Summary: These are recoverable, handled errors. We shouldn't treat these as events that require actions from us. They also have a tendency of firing a lot. Reviewed By: nikoant Differential Revision: D26202358 fbshipit-source-id: 445f3c2bcd0041d5cd773ec04172fdeed9b32222 |
||
|
Pascal Hartig
|
6dffc5695e |
Bump ts linters
Summary: It had this scary warning at the top that the TS version was too new for the linters. Reviewed By: nikoant Differential Revision: D26202273 fbshipit-source-id: df03d6bf176da00ee37b027679b9f258ab123395 |
||
|
dependabot[bot]
|
5850bb6b52 |
Bump open from 7.0.3 to 7.3.1 in /desktop (#1867)
Summary: Bumps [open](https://github.com/sindresorhus/open) from 7.0.3 to 7.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p> <blockquote> <h2>v7.3.1</h2> <ul> <li>Fix support for WSL when Windows isn&<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/39">https://github.com/facebook/flipper/issues/39</a>;t mounted in <code>/mnt/</code> (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/210">https://github.com/facebook/flipper/issues/210</a>) a3bbadc</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1">https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1</a></p> <h2>v7.3.0</h2> <ul> <li>Support WSL configuration where Windows paths are not in PATH (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/195">https://github.com/facebook/flipper/issues/195</a>) be0f794</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0">https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0</a></p> <h2>v7.2.1</h2> <ul> <li>Fix <code>app</code> option on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/191">https://github.com/facebook/flipper/issues/191</a>) 9bcd285</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1">https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1</a></p> <h2>v7.2.0</h2> <ul> <li>Use PowerShell on Windows for improved reliability (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/188">https://github.com/facebook/flipper/issues/188</a>) f7ca0d3</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0">https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0</a></p> <h2>v7.1.0</h2> <ul> <li>Add <a href="https://github.com/sindresorhus/open#allownonzeroexitcode"><code>allowNonzeroExitCode</code></a> option (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/176">https://github.com/facebook/flipper/issues/176</a>) e009765</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0">https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0</a></p> <h2>v7.0.4</h2> <ul> <li>Fix double-encoding of URLs (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/182">https://github.com/facebook/flipper/issues/182</a>) 48b6d0e</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4">https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
9bd3d6fd7c |
Fix serialization performance
Summary:
Using our serialization utilities in the previous diff absolute destroyed the performance of serializing the device logs. Investigated a bit, and the root cause is that *every* object serialization would notify the UI.
This is not only pointless, since the UI won't be updated until the next tick anyway, it also is terribly expensive since React has to process and queue all these updates.
Exporting the device logs went down from **2 minutes to a few seconds** with this change. (Still a lot slower than JSON.stringify, but I think the flexibility for plugin devs is worth it).
This change does not only benefit devicelogs plugin, but all existing plugins as well, plugins like GraphQL should now export their data much quicker.
Before (practically all time of serialization is spend in React's setState):
{F366147730}
After (only a spike at the end of the idler tick):
{F366147779}
Reviewed By: priteshrnandgaonkar
Differential Revision: D26146420
fbshipit-source-id: 9bbeccf04701fd044e041956b7bb00f1e0622b63
|
||
|
Michel Weststrate
|
594fa4d2bc |
serialize Sandy plugins with serialization utils to support Date/Set/Map
Summary: Unlike non-sandy plugins, non-sandy plugins weren't serialized using our serialization utility yet. This diff addresses that, meaning that users don't have to bother about how to serialize maps, sets and dates. Unlike the old fashioned plugins, the `makeObjectSerialize` utility is used, rather than `serialize`. This normalizes the objects, but doesn't serialize them, which is done at the end of the export data process anyway for the whole tree. This avoids creating a double JSON serialization which is fully of ugly escape characters. This makes the onImport / onExport definition of the logs plugin nicer. Also improved the docs. Reviewed By: nikoant Differential Revision: D26146421 fbshipit-source-id: 6abfb6ee2e3312e2a13a11832ff103dc62fd844c |
||
|
Michel Weststrate
|
e614993558 |
Fix incorrect date serialization
Summary:
While creating some other tests, discovered that our current date serialization uses `toString()` serialization, causing the amount of milliseconds to be lost. The serialization (see below) uses less bytes as well since the human readable timezone isn't included. This change only affects serialization and is backward compatible.
```
✓ test serialize and deserializeObject function for non Object input (1 ms)
✕ test makeObjectSerializable and deserializeObject function for Date input (2 ms)
✓ test makeObjectSerializable and deserializeObject function for Map of Sets
✓ test makeObjectSerializable and deserializeObject function for Map, Dates and Set with complex nesting (1 ms)
● test makeObjectSerializable and deserializeObject function for Date input
expect(received).toEqual(expected) // deep equality
Expected: 2021-03-01T10:31:07.205Z
Received: 2021-03-01T10:31:07.000Z
```
Reviewed By: priteshrnandgaonkar
Differential Revision: D26145941
fbshipit-source-id: dfd6607a4199ca46e2075027856138efb88a07f9
|
||
|
Michel Weststrate
|
7cc55daf34 |
Stop storing device logs on the device object and in the plugin
Summary: Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state. This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction. Reviewed By: nikoant Differential Revision: D26127243 fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2 |
||
|
Michel Weststrate
|
f2ade40239 |
Support custom data processing during import
Summary: Per title, this allows for pre-processing data after it is deserialized and before it is stored in the plugin Reviewed By: nikoant Differential Revision: D26126423 fbshipit-source-id: bc08a6ab205d2a0d551515563cd85a197595ddb2 |