Summary:
Added "id" field to Flipper plugin manifest which is used to match native and desktop plugin parts. Before that, "name" field was used both as npm package name and as plugin id.
The problem is that currently there are a lot of plugins which has invalid values in "name", e.g. not starting with "flipper-package-", or containing upper cased letters.
Simple renaming of "name" field can be very problematic, so we need a new field to avoid any breaking changes and keep historical analytics data which is also bound to plugin id.
Reviewed By: mweststrate
Differential Revision: D21129689
fbshipit-source-id: efd143c82a6a802cc0b5438fd3f509bd99aded0e
Summary:
Added versioning for plugin format.
The first version is where "main" points to source code entry and plugins are bundled by Flipper in run-time on loading them.
The second version is where "main" points to the already existing bundle and Flipper just loads it without bundling. The plugins of version 2 must be bundled using "flipper-pkg" tool before publishing.
Changelog: Support new packaging format for plugins.
Reviewed By: mweststrate
Differential Revision: D21074173
fbshipit-source-id: 7b70250e48e5bd5d359c96149fb5b14e67783c4d
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/969
Added all public plugins as workspaces to the root package.json. This means all these plugins will use the single root yarn.lock and installation of their dependencies will be faster. This also means that plugins can declare dependencies to other local packages included into workspaces and they will be symlinked automatically.
Changelog: Internals: plugins added as "yarn workspaces" into the root package.json to simplify dependency management between them
Reviewed By: mweststrate
Differential Revision: D20805231
fbshipit-source-id: e85c62d3195d1ea3c5c60def6ca12318a2b53466
Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
Summary:
The network plugin warns about network requests that cannot be properly deflated if they are big and binary. Not sure yet why that is the case and if that is something that should be addressed (planned T63909985 for that), but if the body is big and binary it causes problems for our logging.
While testing I had some requests that where 45m large, and Electron literally hang for a few minutes before recovering. Failed to capture that, but the test plan shows smaller cases of the problem
Reviewed By: jknoxville
Differential Revision: D20560083
fbshipit-source-id: 324eb180b203dd585814dba5c94373d8daee5dde
Summary:
1) moved "sonar/desktop/src" to "sonar/desktop/app/src", so "app" is now a separate package containing the core Flipper app code
2) Configured yarn workspaces with the root in "sonar/desktop": app, static, pkg, doctor, headless-tests. Plugins are not included for now, I plan to do this later.
Reviewed By: jknoxville
Differential Revision: D20535782
fbshipit-source-id: 600b2301960f37c7d72166e0d04eba462bec9fc1
Summary:
Before this diff, the input bar is unresponsive to the user input; when one typed fast enough the input doesn't reflect that as shown in the before video (the console printed the log directly when `onChange` was fired).
This diff tried to store value locally and use that to render. When the component is closed, the state update will take place. This tried to solve too many state update.
Reviewed By: mweststrate
Differential Revision: D20489142
fbshipit-source-id: c118adc61d9234daec17782e4bbf8e4ea3dd369f
Summary:
- Add a close button when hovering over the component
- Remove the route corresponding to it when clicking on closing
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20444419
fbshipit-source-id: 5ebe112c542b033a3e10ed10f23d6a04a730c657
Summary:
- Add mock button if a client supports the function
- Open the dialog when clicking the button
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440145
fbshipit-source-id: 750099020e0b2d6ed10bb20e883f6b3be664ae79
Summary:
per title
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440146
fbshipit-source-id: 0a3ade1e78e62d3bc0d98ef9fb6c3f258b34af23
Summary:
- Add ManageMockResponsePanel to add, modify and remove mocked route
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440147
fbshipit-source-id: 3af127c4b091f288c13b41b74d78c07b4eb0e52f
Summary:
- Add MockResponseDetail component to show and edit mocked route
- Add `immer` package which will be used for internal state handler
Change from PR
- Change to functional component
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440149
fbshipit-source-id: d7c35600b9a22cb62c2bdae7e19abe5c767e3670
Summary:
This diff added dummy state handler for route, which appeared in the next diffs. Routes will be used to render components for mocking handler and determine data on the client side.
State and other variables will appear on the next diffs.
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440150
fbshipit-source-id: d441ae1d53caf7280bef78d937aaa71617e2da9f
Summary:
per title
Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488
Reviewed By: mweststrate
Differential Revision: D20440148
fbshipit-source-id: 9365f0b83449f295e819cccc2fa622d866dca129