Commit Graph

159 Commits

Author SHA1 Message Date
Pascal Hartig
344e6e7a04 Rename test classes
Summary: Take care of the test class names.

Reviewed By: danielbuechele

Differential Revision: D10113028

fbshipit-source-id: c8f0967fe2ae8c0f416e0f2f1eab30785fad01e8
2018-10-02 05:11:56 -07:00
Pascal Hartig
8c4e5ec647 Rename diagnostics AndroidManifest.xml
Summary:
The manifest is invalid without a package name and causes CI
to fail in some weird ways.

Reviewed By: jknoxville

Differential Revision: D10123737

fbshipit-source-id: d4adc84e6c1a4297fc1b30720f131fd06c22c4d3
2018-10-01 14:04:08 -07:00
Pascal Hartig
e39b08cdbf Move test sonar package to flipper
Summary: This confused Android Studio real bad.

Reviewed By: danielbuechele

Differential Revision: D10103210

fbshipit-source-id: 20b28575942998fa0c646090e46a2f55983a26a6
2018-09-30 04:13:54 -07:00
Pascal Hartig
b756b5490f Set up unit test support in Gradle
Summary:
This works now:

```
./gradlew :android:testDebugUnitTest
BUILD SUCCESSFUL in 1s
39 actionable tasks: 39 up-to-date
```

Reviewed By: danielbuechele

Differential Revision: D10101985

fbshipit-source-id: e3d1f17b29652061498d50a9218a94aaebee67e2
2018-09-30 04:13:53 -07:00
Pascal Hartig
2a4df330b2 Fix robolectric test runner import
Summary: Can't use our internal test runner for this, d'uh.

Reviewed By: danielbuechele

Differential Revision: D10101984

fbshipit-source-id: 23f0af1c0b9e5d761de260643ef8d5546d9478eb
2018-09-30 04:13:53 -07:00
Pascal Hartig
cf1c0748e1 Remove unnecessary plugin sourceSet
Summary: This is from before we adopted the gradle standard layout.

Reviewed By: danielbuechele

Differential Revision: D10101917

fbshipit-source-id: f45ab06cbf4d56a70df1cac6cb1fd234148d2634
2018-09-28 10:14:46 -07:00
Pascal Hartig
59f762cac9 Fix failing tests
Summary: Previous diffs fixed all compilation issues, this one makes them actually pass again.

Reviewed By: danielbuechele

Differential Revision: D10050632

fbshipit-source-id: 7e9f30c51d192b9f7e43abec8a19b2f1eef997df
2018-09-26 10:32:14 -07:00
Pascal Hartig
86d32758e3 Fix InspectorSonarPluginTest
Summary: Fix compilation issues in InspectorSonarPluginTest.

Reviewed By: danielbuechele

Differential Revision: D10050477

fbshipit-source-id: 556f48ca80f8091c34319b5ada26874eb5ac1e40
2018-09-26 10:32:13 -07:00
Pascal Hartig
038a2dbe82 Fix DescriptorMappingTest
Summary: Fixing broken tests one-by-one. This was an interface addition that wasn't implemented here.

Reviewed By: danielbuechele

Differential Revision: D10050418

fbshipit-source-id: 5e157ccbe414c6cacca1feba3e6460bbf1593abf
2018-09-26 10:32:13 -07:00
Pascal Hartig
f18802e373 Rename internal android references
Summary: sonar -> Flipper

Reviewed By: jknoxville

Differential Revision: D10028004

fbshipit-source-id: 33a32b4aaca9c97ce8db7da3bccb7ee6515a6104
2018-09-25 06:57:31 -07:00
Pascal Hartig
c7b0d419cb Rename libsonar* to libflipper*
Summary: Rename the native libraries.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10009245

fbshipit-source-id: 987c4fdb1acc21abbbecfb3db8a672f4aa4e499d
2018-09-25 04:02:29 -07:00
Pascal Hartig
b78c703bdb Rename error message
Summary: Per title.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10009219

fbshipit-source-id: 9647c8b0e317b789e154949aad221cbc3c50801e
2018-09-25 04:02:28 -07:00
Pascal Hartig
777e9323de Rename remaining exported Sonar Android references
Summary: Excludes internal plugins, but should cover everything else.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10009134

fbshipit-source-id: f601014e984bccf78fadbe59ee50dffdb4f6cb12
2018-09-24 11:15:05 -07:00
Pascal Hartig
079057727c Rename core references
Summary:
Only public reference touched is `toSonarObject()`.

The controller you requested could not be found.

Reviewed By: jknoxville

Differential Revision: D10009071

fbshipit-source-id: 985b472403d9ddd8e390620fb7896df93366dbef
2018-09-24 07:50:40 -07:00
Pascal Hartig
41adb3bdaa Rename android internals
Summary: Rename public method and internal references inside the android package to Flipper.

Reviewed By: jknoxville, priteshrnandgaonkar

Differential Revision: D10008330

fbshipit-source-id: fd9b8a54bc9766e2d10b10c9b428f62e0bc3224a
2018-09-24 07:50:40 -07:00
John Knox
3838decf1d Rename SONAR_OSS compiler flag
Summary: Part of sonar to flipper rename

Reviewed By: passy

Differential Revision: D9920332

fbshipit-source-id: 99b5cf33c07ca5d9cd59af21490fea18272e67d9
2018-09-24 07:00:44 -07:00
John Knox
c1295b1bc9 Rename SonarState* to FlipperState*
Summary: Part of sonar to flipper rename

Reviewed By: passy

Differential Revision: D9919821

fbshipit-source-id: a44a2a04d5463750f884f8bf1328e02d56593e82
2018-09-24 06:03:51 -07:00
John Knox
1d2793f701 Rename SonarWebSocket
Summary:
Part of Sonar -> Flipper rename.
It's about time this is renamed from *Websocket as well, since it doesn't use websockets anymore.

Reviewed By: passy

Differential Revision: D9919695

fbshipit-source-id: 78a63bfb7d5de19c093b7fb775d1426b4fc58f77
2018-09-24 06:03:51 -07:00
John Knox
5350d3ce7a Rename C++ SonarPlugin class
Summary: Part of sonar -> flipper rename

Reviewed By: passy

Differential Revision: D9917615

fbshipit-source-id: e59f43bf003d30ae6be4d95bc4a21c92ab39f732
2018-09-24 06:03:50 -07:00
Pascal Hartig
90cf003035 Rename shared preferences plugin
Summary: Sonar -> Flipper

Reviewed By: priteshrnandgaonkar

Differential Revision: D9991095

fbshipit-source-id: 685775e373ae22abbb06b979fea8461c35de74b5
2018-09-23 04:13:55 -07:00
Pascal Hartig
448e2e720c Rename sandbox plugin
Summary: Sonar -> Flipper

Reviewed By: priteshrnandgaonkar

Differential Revision: D9991058

fbshipit-source-id: ce5deb979ddd1ba4190a82a668dd57789731b688
2018-09-23 04:13:55 -07:00
Pascal Hartig
c7f6893cb4 Rename network plugin
Summary: Sonar -> Flipper. Class names only for now.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9991029

fbshipit-source-id: b96dbab7acc89586c1ee67b64bef1c9490b560b5
2018-09-22 16:43:26 -07:00
Pascal Hartig
52fb0fc1b8 Rename LithoFlipperDescriptors
Summary:
As titled.
The controller you requested could not be found.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9990862

fbshipit-source-id: 459420adf400fd4504035fc36b14c5595f431f6a
2018-09-22 09:38:43 -07:00
Pascal Hartig
bd27a624cd Rename LeakCanarySonarPlugin to LeakCanaryFlipperPlugin
Summary: As before.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9990841

fbshipit-source-id: 4517d6949c3eb408b86b2b520d369134b006cf4f
2018-09-22 09:38:43 -07:00
Pascal Hartig
235916666b Rename InspectorSonarPlugin to InspectorFlipperPlugin
Summary: Per title.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9990824

fbshipit-source-id: f40a769a2f46e5051e09523939ba1034b21e88cb
2018-09-22 09:38:42 -07:00
Pascal Hartig
4a146eba8b Rename ConsoleSonarPlugin to ConsoleFlipperPlugin
Summary: Per title

Reviewed By: priteshrnandgaonkar

Differential Revision: D9990572

fbshipit-source-id: 4127063aa4600b34be80285d689edb2babd76f2b
2018-09-22 09:38:42 -07:00
Pascal Hartig
f9d869b5af Rename Sonar{Connection,Responder}Mock
Summary: Per title.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9967253

fbshipit-source-id: f1472f760f8094ee20b2810ba64d0f2271f3160b
2018-09-22 09:38:42 -07:00
Pascal Hartig
855d647a0a Rename flipper.plugins.common
Summary: Per title.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9967192

fbshipit-source-id: 6abee777335bc36d8714d208ee8e2ae47093a50e
2018-09-22 07:13:18 -07:00
Pascal Hartig
9a841d369b Rename android package classes to Flipper
Summary: Rename SonarClientImpl, SonarConnectionImpl, SonarResponderImpl, SonarThread.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9966853

fbshipit-source-id: e9f0faa32aff6efa2287aa94f6da6b6b395b7a1f
2018-09-22 05:13:24 -07:00
Pascal Hartig
470ac6f6f7 AndroidSonarClient -> AndroidFlipperClient
Summary:
Per title.

The controller you requested could not be found.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9966768

fbshipit-source-id: 224ff9d02d6a01a6f7ee28788ddd9167d15aafee
2018-09-21 17:37:12 -07:00
Pascal Hartig
8780cff8ca Rename SonarDiagnosticActivity to FlipperDiagnosticActivity
Summary: Per title.

Reviewed By: danielbuechele

Differential Revision: D9966619

fbshipit-source-id: 52934813903f1d48c1ee35938848320b54a50a0f
2018-09-21 11:45:28 -07:00
Pascal Hartig
3f128bcd50 Rename SonarUtils to FlipperUtils
Summary:
Per title.

The controller you requested could not be found.

Reviewed By: danielbuechele

Differential Revision: D9966597

fbshipit-source-id: eab1a670c7e956aa1dc7f816fb03875cd0b5c965
2018-09-21 05:29:58 -07:00
Pascal Hartig
5d9e9aa402 Remove CMakeList.txt copy
Summary: The file doesn't actually exist anymore as we found our earlier today.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9972135

fbshipit-source-id: aac5f5afd301169aaa552554b11fd4132285d951
2018-09-21 03:27:53 -07:00
John Knox
9889df3f3c Rename SonarConnection to FlipperConnection
Summary: Part of Sonar -> Flipper rename

Reviewed By: passy

Differential Revision: D9907353

fbshipit-source-id: 01f7bb84da1c27fd68d608151f437a18b6eaaa4e
2018-09-20 17:06:54 -07:00
John Knox
3c656de7fa Rename SonarClient to FlipperClient
Summary: Part of the Sonar -> Flipper rename

Reviewed By: passy

Differential Revision: D9871902

fbshipit-source-id: 4b64953cb1a64235d47caaf0fabfb560bb85f7a2
2018-09-20 17:06:53 -07:00
John Knox
df8763e697 Move xplat/sonar/xplat/Sonar* to Flipper*
Summary:
Part of the Sonar -> Flipper rename
Intentionally left externally visible buck target as Sonar for now to minimize diff size.

Reviewed By: passy

Differential Revision: D9871684

fbshipit-source-id: 6926eb62c578a05cd895745c75ed7da3cfe965b5
2018-09-20 15:39:57 -07:00
Pascal Hartig
0a20d95195 Rename java core classes
Summary:
Rename everything `Sonar*.java` in `core/`.

Biggest chunk of the rename happened with

```fish
for name in (cat names.txt)
    ambr --no-interactive --regex '\b'"$name"'\b' (echo $name | sed 's/Sonar/Flipper/') fbandroid/java/com/facebook
end
```

names.txt:
```
SonarArray
SonarClient
SonarConnection
SonarDynamic
SonarObject
SonarPlugin
SonarReceiver
SonarResponder
SonarStateUpdateListener
SonarValue

```

The controller you requested could not be found.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9940900

fbshipit-source-id: 4a1342fac02513025d80dcb0af62c26ea38b5086
2018-09-20 10:33:43 -07:00
Pascal Hartig
cc6f28f7c4 Link static libraries statically (#277)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/277

Link all dynamically loaded libraries statically with the exception of libevent.

Reviewed By: jknoxville

Differential Revision: D9967422

fbshipit-source-id: b33cec5da0c2b34f47217353f205b9d77f1acae2
2018-09-20 09:35:19 -07:00
Pascal Hartig
0e753e684f Rename skip_view_traversal setting
Summary: Sonar -> Flipper. 'nuff said.

Reviewed By: danielbuechele

Differential Revision: D9940670

fbshipit-source-id: ed9c8267c0c32952ac2069dc25bdb5359a438ce5
2018-09-19 13:09:57 -07:00
Pascal Hartig
22742fd563 Move sonar directory to flipper
Summary:
This leaves a BUCK skeleton in place that re-exports everything. Phew, that
was fun to create ... NOT. Are not-jokes still a thing? I'm on a plane,
and I claim that up here they still are.

Reviewed By: jknoxville

Differential Revision: D9922310

fbshipit-source-id: f48dcd98a7ad651a538c1c697bba24037e13db63
2018-09-19 13:09:56 -07:00
Pascal Hartig
88ca69a13f Rename Java packages from sonar to flipper
Summary:
This soft-breaks Android Studio support because folder names no longer map to package names, but this will be mitigated by future diffs.

Steps taken for rename:

```
cd xplat/sonar/android/;
ambr 'com.facebook.sonar' 'com.facebook.flipper'
```

Reviewed By: danielbuechele

Differential Revision: D9850009

fbshipit-source-id: d26d8ab783e7050e4e2fbdd0c35eae3f97879464
2018-09-19 09:12:06 -07:00
John Knox
9d9fa17134 Rename all The c++ JNI classes
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/272

Reviewed By: passy

Differential Revision: D9861432

Pulled By: jknoxville

fbshipit-source-id: 523b8fc28541b922bbcc0939514f4ddd0a3fc1b0
2018-09-18 07:27:28 -07:00
John Knox
a480be90a2 Rename facebook::sonar namespace
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/271

Reviewed By: passy

Differential Revision: D9861393

Pulled By: jknoxville

fbshipit-source-id: d65f751c35028748915023f33f273d6ec45863c8
2018-09-18 07:27:28 -07:00
Pascal Hartig
a34bddae0b Update BuildConfig to flipper namespace
Summary: That's a pretty good stand-alone piece.

Reviewed By: danielbuechele

Differential Revision: D9851019

fbshipit-source-id: 98dfe8e553a37cd84da8675f5e4a110f954f4354
2018-09-17 09:58:01 -07:00
Pritesh Nandgaonkar
9a16d9cbad Update rsocket version
Summary: Updates rsocket version

Reviewed By: passy

Differential Revision: D9769468

fbshipit-source-id: b822e697446b1464b63206869726e0e086438134
2018-09-13 03:12:35 -07:00
Pascal Hartig
c495c53cd4 Fix sample app build
Summary:
Two fixes included in this one. The debug flag is obvious, the annotations
less so. I'll try and find the right place to document this, but the reason
we need this here is because we reflect on `Prop.class`, so these need to be
available at runtime.

Reviewed By: jknoxville

Differential Revision: D9766713

fbshipit-source-id: 269b5a60c0df644f4fda0ea289ef9dc392ee352b
2018-09-11 07:57:16 -07:00
Pritesh Nandgaonkar
ea840e230e Update Folly version
Summary: Updated Folly version for android

Reviewed By: passy

Differential Revision: D9754662

fbshipit-source-id: 487a2cab4114e42672a431edfdfbe79bdb412076
2018-09-11 04:43:24 -07:00
Sara Valderrama
73759e71db add litho accessibility rendering to Flipper accessibility mode [1/2]
Summary:
Litho renders differently based on whether applicable accessibility services are enabled. In Flipper's accessibility mode this will be forced (with the option to turn it off) so that you don't have to be running an accessibility service to actually see what someone running an accessibility service would.

Here's an example video of what the re-rendering does (this also happens on toggle of accessibility mode, this is just the settings option to force it):

{F137856647}

Reviewed By: jknoxville

Differential Revision: D9667222

fbshipit-source-id: 292353d89f07734f1e525f795b1d7daf4130e203
2018-09-07 14:58:00 -07:00
Sara Valderrama
7bd264bd10 Remove accessibility panel from Layout Inspector in non-accessibility mode
Summary: Removes the Accessibility panel from the layout inspector since all of these properties are shown (and logged) in the Accessibility Inspector along with other properties that may be useful. This will make it easier to track accessibility use and also will help more people discover the accessibility feature when they need it.

Reviewed By: blavalla

Differential Revision: D9523532

fbshipit-source-id: f6d3a745980ec631ec8bf2e59017382f4c2edd5a
2018-08-28 09:58:16 -07:00
Sara Valderrama
364883f661 Live update sidebar with click and focus accessibility events
Summary: Lets AX inspector live update the sidebar when a view is clicked (state may change) or accessibility focus changes (previously only updated the sidebar live if it became the focused element).

Differential Revision: D9489376

fbshipit-source-id: 8959f722370ce1d3a622b24c7b049b03f0d662e6
2018-08-24 09:42:02 -07:00