Summary:
Flipper's network plugin may cause crash on a frequency of about one time per 1~2 days(I think it depends on how many network request we send).
I assume the crash is caused by part of the code of HTTPParser is not thread-safe, and invoke it asynchronously may cause double-free crash. So I manually ask for HTTPBody synchronously, make the HTTPParser parse the request and cache them in advance, before any possible asynchronous invoking.
## Changelog
Fix potential crash cause by network plugin.
Pull Request resolved: https://github.com/facebook/flipper/pull/563
Test Plan:
1. Run our App with Flipper integrated
2. Make sure FlipperNetworkPlugin is active
3. It may take days to reproduce the crash
Reviewed By: passy
Differential Revision: D17739327
Pulled By: priteshrnandgaonkar
fbshipit-source-id: e814145c346bd2da1d2f5f87b6a2f7e200f0bf2d
Summary:
- Introduce new base protocol `CKMountable`
- Contains Layout & Mount methods that have been extracted from `CKComponent`
- This will allows us to introduce a new lighter version of `CKComponent`, which doesn't rely on Scope/State/Controllers/etc
- Refactor `CKComponentLayout` to work with `CKMountable` instead of `CKComponent`, which will allows us to interop between `CKComponent` and a new type of components.
- Refactor the codebase to support this change
Reviewed By: kevin0571
Differential Revision: D17668253
fbshipit-source-id: 13db5ff4acb37b338e291ca2dd7d67cd25dbc6d2
Summary:
**Highlights**
- Android: Leakcanary is no longer part of the core distribution but a separate artifact: `com.facebook.flipper:flipper-leakcanary-plugin`.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17601074
fbshipit-source-id: 862fc44d45b4ddc95059deb3959476af162b1cb0
Summary: Fix for p-map error at startup and `fbjni` dependency on Android.
Reviewed By: danielbuechele
Differential Revision: D17528600
fbshipit-source-id: db0fd2e99bd35645ceef63500312b3ad16c04d57
Summary:
# Highlights
- Android: Separate artifacts for the Litho, Fresco and Network plugins.
This does not yet include updates to the docs as the publishing process requires manual approval by Bintray first.
Reviewed By: danielbuechele
Differential Revision: D17480406
fbshipit-source-id: 92cd54e708bc1718e40e9ea95ca62f8c73b11fdc
Summary:
**Highlights**
- Changed to the upstream `adbkit` instead of the Facebook-specific fork of it.
- Migrate the rest of Flipper core from Flow to (strict) TypeScript.
- UI docs use the TypeScript code as basis.
Reviewed By: danielbuechele
Differential Revision: D17368399
fbshipit-source-id: 5ba92c4f0d4ca627ffac58052ef6e4d9fd07bd95
Summary: Moving FlipperKitLayoutPlugin/FlipperKitPluginUtils/SKHighlightOverlay to shared folder, so Layout and WorkingRange plugins can depend on it
Reviewed By: kevin0571
Differential Revision: D17156396
fbshipit-source-id: 3f17371f2ab4818924d61e6cfb243f60ad1f2892
Summary:
**Highlights**
1. Windows builds should publish on the release page now.
2. We have x86_64 support on Android.
3. React DevTools are now publicly available.
Reviewed By: danielbuechele
Differential Revision: D17204023
fbshipit-source-id: 41aaa1c884e1f251216423a8b08cec6e8802fd80
Summary:
Publishing React Dev tools plugin:
- migrate to TS
- move iOS and JS part to public folder (Android was already)
Reviewed By: passy
Differential Revision: D17164782
fbshipit-source-id: 20ccba71d807df2d33fe5348a62c6ee7f78ae8ba
Summary:
This PR updates the installation instruction for Cocoapods 1.7+ as the previous installation instruction was broken for the latest Cocoapods version
Solves https://github.com/facebook/flipper/issues/478 and https://github.com/facebook/flipper/issues/495
## Changelog
- Updated the Documentation
- Updated the sample app
Pull Request resolved: https://github.com/facebook/flipper/pull/522
Test Plan:
- Travis CI
- Also tested locally by building sample app.
Reviewed By: jknoxville
Differential Revision: D16902023
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 19cc01c842f93ab3565c302f8258ca88dbdecfb2
Summary: Removes the symlink files and copies the actual files. The OSS build is broken as its not able to access those files.It used to work before as the ship it config used to sync thos files from fbobjc. But that approach is fragile as it broke our OSS build recently, because of this diff D16829348
Reviewed By: jknoxville
Differential Revision: D16891051
fbshipit-source-id: b5146129adc8628d336fbca5936539d2e1131ba2
Summary: This target was bloating. Split it in two. Migrate to autotests.
Reviewed By: joshleibsly
Differential Revision: D16829348
fbshipit-source-id: 17f2a10371293ddb850c4556abeecee99a9d7bef
Summary: T46426056: Add utility to convert nlohmann::json to NSDictionary. Use same in instagram logging module.
Differential Revision: D16798341
fbshipit-source-id: 88923fcbcd1ffbed5a468cee4ba2f9482ba81a97
Summary: Size is passed as a prop to every `CKComponent` and `CKFlexboxChild`. It is useful to see where it was set exactly
Reviewed By: kevin0571
Differential Revision: D16688496
fbshipit-source-id: 5f8dc39a967ab2d7d89d6a37a8152aa6b59db220
Summary:
Live editing is now working faster.
We had an issue that it took about 5 seconds to see the view changed and 10 seconds to see tha value in the flipper, now it's done immidiately
Reviewed By: priteshrnandgaonkar
Differential Revision: D16500961
fbshipit-source-id: 742ce628a887bab06c1b883d9710c477af2508e7
Summary: objc_msgSend_stret isn't available when building for 64 bit devices so this line breaks. objc_msgSend is the correct function to call in 64 bit, but Flipper doesn't run for devices so its fine either way.
Reviewed By: jasonhotsauce
Differential Revision: D16502377
fbshipit-source-id: cfc20880bcccd086dc34fad74a6eef2c9a17cb17
Summary:
CKCenterLayoutComponent's options are now live editable
P.S. Now it takes some time to see the view changed and the new value of everything on flipper side
Reviewed By: kevin0571
Differential Revision: D16458390
fbshipit-source-id: a5344253641633dd8c985549c2d9bc6f64da1f74
Summary:
CKRatioLayoutComponent's ratio is now live editable
P.S. Now it takes some time to see the view changed and the new value of everything on flipper side
Reviewed By: kevin0571
Differential Revision: D16458380
fbshipit-source-id: 0f06426477b6747f6ad71716dc66e69316b23208
Summary:
CKFlexboxComponent's insets are now live editable
P.S. Now it takes some time to see the view changed and the new value of everything on flipper side
Reviewed By: kevin0571
Differential Revision: D16379743
fbshipit-source-id: 69bc9b7cb6b2103ff34b5c4489b240ac7562a85d
Summary:
CKInsetComponent's insets are now live editable
P.S. Now it takes some time to see the view changed and the new value of insets on flipper side
Reviewed By: kevin0571
Differential Revision: D16338109
fbshipit-source-id: 9c6648e72d55a09df9d715637e82901d1b5dcec8
Summary: Preparation for making components live editable
Reviewed By: kevin0571
Differential Revision: D16379961
fbshipit-source-id: d0ea3d753eb588fe7b55f2345124427b4a5a58b5
Summary: Theadsafe Data Storage for new insets in CKInsetComponent
Reviewed By: kevin0571
Differential Revision: D16338091
fbshipit-source-id: 3b77652a4d08cfebce115a606af3fc3440a1aca0
Summary: Updated the OpenSSL dependency and released the new versions of Folly and RSocket.
Reviewed By: jknoxville
Differential Revision: D16222388
fbshipit-source-id: e894650a8c3ac764bc489e843e9a3ccf33688659
Summary:
Fixed bug with live editing
Previously if the meaining of the value was changed in flipper you receive back same value as it was
Now you see correct changed value
Reviewed By: priteshrnandgaonkar
Differential Revision: D16162141
fbshipit-source-id: 1a68ea64603171e952382c5093470d2cc12f7bbe
Summary: Added a possibility to search for the text not only in name and id of components but also in text for all components, that conforms to a protocol <SKTextSearchable>
Reviewed By: priteshrnandgaonkar
Differential Revision: D16108297
fbshipit-source-id: 31da4ac6762c487ef644d62c9576d9eff43e8cd4
Summary:
Bugfix
Add protect when save task
If local cache resource are valid, we don't create a Task .So here are crash.
Pull Request resolved: https://github.com/facebook/flipper/pull/466
Reviewed By: passy
Differential Revision: D15851816
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 753b3c5c9a6ed4c703c934a89e45fa30df99068c
Summary:
`/*` is the standard throughout open source code. For example, Firefox uses single /*: https://hg.mozilla.org/mozilla-central/file/21d22b2f541258d3d1cf96c7ba5ad73e96e616b5/gfx/ipc/CompositorWidgetVsyncObserver.cpp#l3
In addition, Rust considers `/**` to be a doc comment (similar to Javadoc) and having such a comment at the beginning of the file causes `rustc` to barf.
Note that some JavaScript tooling requires `/**`. This is OK since JavaScript files were not covered by the linter in the first place, but it would be good to have that tooling fixed too.
Reviewed By: zertosh
Differential Revision: D15640366
fbshipit-source-id: b4ed4599071516364d6109720750d6a43304c089
Summary: Importing the extensions fixes the fact that responds to selector was returned false for `sonar_additionalDataOverride` selector
Reviewed By: priteshrnandgaonkar
Differential Revision: D15535414
fbshipit-source-id: ab465a1aab36cccd2129c5b0c29a7872dfd65015
Summary:
This solves the watch tab crash discussed here D15266478, which got reverted.
Bug: [Here](diffusion/FBS/browse/master/xplat/sonar/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.mm;57c596a566bec49e343af51b93df65ed1377a2b9$338), when the node is `CKComponentRootView` the `[descriptor childForNode: node atIndex: i]` returns `SKComponentLayoutWrapper`. In the next iteration of the loop, node is `SKComponentLayoutWrapper`, the `[descriptor childForNode: node atIndex: i]` returns `CKComponentRootView`, and hence the infinite recursion
I also tested T44431259, it is not regressed.
Reviewed By: passy
Differential Revision: D15451821
fbshipit-source-id: 25f10112f5f52bb1fa964316a4c7e91a3b29156d
Summary: This resolves a crash related to the contents of certain CKComponents, which was apparently introduced by D15266478
Differential Revision: D15406260
fbshipit-source-id: efd1ad1a1bcb41451c56b74c240ad2dca069deb0
Summary:
This PR sets up Circle CI to publish pods when github release is made. This PR also updates the Flipper-Folly pod as it didn't build on 32 bit architecture, because `thread_local` was not supported.
Automated publish of cocoapods through Circle CI.
Pull Request resolved: https://github.com/facebook/flipper/pull/445
Reviewed By: danielbuechele
Differential Revision: D15333975
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 7db68efeeebbe344213917f10f9f3ce4132e8cbc
Summary:
BUG:
{F158264042}
Context: The code entered an infinite loop till it crashed. In the implementation of `- (SKSearchResultNode *)searchForQuery:(NSString *)query fromNode:(id)node withElementsAlreadyAdded:(NSMutableSet<NSString *> *)alreadyAdded`, we recurse through the child. In the case when the view was `CKRootComponent` it created a `SKComponentLayoutWrapper` in the call to `[descriptor childForNode: node atIndex: i];`. This wrapper's descriptor used to return the very same view from which it was created when it's children were asked. So this led to an infinite loop.
Reviewed By: kfirapps
Differential Revision: D15266478
fbshipit-source-id: 8035209746b7cb4b8773e2fcbdd4c0a148191304
Summary: Our very own SeaMammal plugin for iOS written in swift
Reviewed By: passy
Differential Revision: D15199381
fbshipit-source-id: 10b085c314328ff52ae3f5feef51f70d0ce12f1b
Summary: Tutorial app for iOS. It follows the same theme as its android counterpart.
Reviewed By: passy
Differential Revision: D15184515
fbshipit-source-id: bb473c0fa863bb325bb33f8e42c8d6b3d9c640ff
Summary: Add the affiliates bit that the linter is checking for.
Reviewed By: jknoxville
Differential Revision: D15164826
fbshipit-source-id: 500ffe89ec0c2fd3acfbc374408d16a337cecfa4
Summary:
Removed the symlink and moved `Flipper.podspec` and `FlipperKit.podspec` to the root directory. Also published `Flipper.podspec` and `FlipperKit.podspec`on cocoapods
http://cocoapods.org/pods/Flipperhttp://cocoapods.org/pods/FlipperKit
Also removed the stub podspec files.
Released Flipper and FlipperKit on Cocoapods
Pull Request resolved: https://github.com/facebook/flipper/pull/423
Reviewed By: passy
Differential Revision: D15146621
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 86ee16773a81b0896548169cba49810250122ec1
