flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Rain ⁣	aa649ff48f	standardize C-like MIT copyright headers throughout fbsource Summary: `/` is the standard throughout open source code. For example, Firefox uses single /: https://hg.mozilla.org/mozilla-central/file/21d22b2f541258d3d1cf96c7ba5ad73e96e616b5/gfx/ipc/CompositorWidgetVsyncObserver.cpp#l3 In addition, Rust considers `/` to be a doc comment (similar to Javadoc) and having such a comment at the beginning of the file causes `rustc` to barf. Note that some JavaScript tooling requires `/`. This is OK since JavaScript files were not covered by the linter in the first place, but it would be good to have that tooling fixed too. Reviewed By: zertosh Differential Revision: D15640366 fbshipit-source-id: b4ed4599071516364d6109720750d6a43304c089	2019-06-06 19:40:28 -07:00
Pascal Hartig	2885f87189	Update copyright headers (#433 ) Summary: Style is modified, so I think it's okay to add our header there too. Pull Request resolved: https://github.com/facebook/flipper/pull/433 Differential Revision: D15213091 Pulled By: passy fbshipit-source-id: c02b67b022f12fdb3e0da39a308d33b073dcb9d3	2019-05-04 11:16:23 -07:00
Marc Terns	c7ad49a9eb	Integrating NSUserDefaults plugin to iOS (#291 ) Summary: I have a few details left, but its almost done. This PR addresses #145 - The NSUserDefaults plugin uses the SharedPreferences Desktop Part since we can reuse all of it. - The NSUserDefaults plugin uses swizzling in order to be notified of what specific event changed at runtime. - Added Test harness in both Sample Swift and Sample apps for iOS in order to test the plugin. - Updated the documentation in `docs/shared-preferences-plugin.md` and` README.md` I am open to suggestions since the desktop sharedPreferences version doesn't support deletion of preferences. Most likely I would have to modify the UI, and for that matter, I might as well build a user defaults desktop version I wanted to add xiphirx in this MR since he developed the shared preferences plugin for Android and Desktop. I don't see a way to remove preferences from the flipper desktop app so I was wondering if you would be OK with me adding that. Pull Request resolved: https://github.com/facebook/flipper/pull/291 Reviewed By: passy Differential Revision: D10334685 Pulled By: priteshrnandgaonkar fbshipit-source-id: d798c01a46df7ddecf713924799f046b560ea922	2018-10-12 04:09:29 -07:00

Author

SHA1

Message

Date

Rain ⁣

aa649ff48f

standardize C-like MIT copyright headers throughout fbsource

Summary:
`/*` is the standard throughout open source code. For example, Firefox uses single /*: https://hg.mozilla.org/mozilla-central/file/21d22b2f541258d3d1cf96c7ba5ad73e96e616b5/gfx/ipc/CompositorWidgetVsyncObserver.cpp#l3

In addition, Rust considers `/**` to be a doc comment (similar to Javadoc) and having such a comment at the beginning of the file causes `rustc` to barf.

Note that some JavaScript tooling requires `/**`. This is OK since JavaScript files were not covered by the linter in the first place, but it would be good to have that tooling fixed too.

Reviewed By: zertosh

Differential Revision: D15640366

fbshipit-source-id: b4ed4599071516364d6109720750d6a43304c089

2019-06-06 19:40:28 -07:00

Pascal Hartig

2885f87189

Update copyright headers (#433 )

Summary:
Style is modified, so I think it's okay to add
our header there too.
Pull Request resolved: https://github.com/facebook/flipper/pull/433

Differential Revision: D15213091

Pulled By: passy

fbshipit-source-id: c02b67b022f12fdb3e0da39a308d33b073dcb9d3

2019-05-04 11:16:23 -07:00

Marc Terns

c7ad49a9eb

Integrating NSUserDefaults plugin to iOS (#291 )

Summary:
I have a few details left, but its almost done. This PR addresses #145

- The NSUserDefaults plugin uses the SharedPreferences Desktop Part since we can reuse all of it.
- The NSUserDefaults plugin uses swizzling in order to be notified of what specific event changed at runtime.
- Added Test harness in both Sample Swift and Sample apps for iOS in order to test the plugin.
- Updated the documentation in `docs/shared-preferences-plugin.md` and` README.md`

I am open to suggestions since the desktop sharedPreferences version doesn't support deletion of preferences. Most likely I would have to modify the UI, and for that matter, I might as well build a user defaults desktop version

I wanted to add xiphirx in this MR since he developed the shared preferences plugin for Android and Desktop. I don't see a way to remove preferences from the flipper desktop app so I was wondering if you would be OK with me adding that.
Pull Request resolved: https://github.com/facebook/flipper/pull/291

Reviewed By: passy

Differential Revision: D10334685

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d798c01a46df7ddecf713924799f046b560ea922

2018-10-12 04:09:29 -07:00

3 Commits