Summary: display thermal information of connected device in the CPU plugin on a sidebar
Reviewed By: charles011
Differential Revision: D15715680
fbshipit-source-id: 1216da7bf8e0e6277d06aa02f40e6278f8e7fa07
Summary:
The logs plugin had an inconsistency where you'd be tailing the logs, and then hit "Clear Logs", which would empty the screen, but as the page fills up again, it would stay in the current position and not scroll with the new ones coming in.
This makes it consistent by making the behaviour:
```
If not props.stickyBottom
never autoscroll, e.g. for static tables of data
else
if scrolled to the bottom
autoscroll
if all the rows fit into the screen at once
autoscroll
```
Reviewed By: passy
Differential Revision: D15856813
fbshipit-source-id: 1357b0e39b576dbe69d260545b21fdab808d2bd2
Summary:
We're if-ing over an enum, so this should be a switch.
Also removed the edge case for the share sheet and
made the error handling part of the component so the
user actually sees it.
Reviewed By: jknoxville
Differential Revision: D15853056
fbshipit-source-id: 241ed0f2e042b08c4c157db9616175297b683ac3
Summary:
Debouncing search to prevent triggering multiple searches, while typing.
Now, a search is only triggered, when the input hasn't changed for more than 200ms.
This affects all SearchableTables.
Reviewed By: passy
Differential Revision: D15855343
fbshipit-source-id: 261cf601249ac604c865ae10deb25d5c836f964a
Summary:
Makes the timestamp column visible by default in the logs plugin.
Can still be hidden by right clicking the column name.
Reviewed By: passy
Differential Revision: D15855890
fbshipit-source-id: 349a224c6a0ddfe607e7d92ce11df07c42b5db36
Summary:
The test used to exit before the promise was fulfilled, so essentially all tests passed. For more details, read [here](https://jestjs.io/docs/en/asynchronous.html)
> Be sure to return the assertion—if you omit this return statement, your test will complete before the promise returned from fetchData is resolved and then() has a chance to execute the callback.
Reviewed By: jknoxville
Differential Revision: D15804017
fbshipit-source-id: 769caa8957737b4864c5888d28854920e6a1447a
Summary:
Adds an argument to the headless Flipper to print the list of available plugins. Added `--list-plugins`.
Currently the startFlipper function is not scalable enough to add new arguments and its implementation. I am planning to tackle this with the list of Actions which will be closure. So adding a new argument with its implementation will be just appending a closure at the correct location in an array. Will work on that in the later diff stacked on the current one.
Reviewed By: jknoxville
Differential Revision: D15789778
fbshipit-source-id: 91ba472617d593c3490bb932590a06d83597cba7
Summary:
In React VR we doing automatic retries in cases when request takes too much time. It helps in cases when network quality is poor. As long as this implicit for developer, we would like to highlight this information in insights. It helps to explain why request were so long.
This diff adds one more field to insights which displays amount of time spent on retries, count and limit of them.
https://pxl.cl/CntV
Reviewed By: passy
Differential Revision: D15845598
fbshipit-source-id: 3e0d1baf93b6be5c4d1c6c1d2b64c05852b843b7
Summary:
https://pxl.cl/Cd84
In React VR we got a case to explain developers why their requests took so long. To do this we export timings from Curl and send them in Flipper. This diff added visualization for this data. Any other platforms can use this feature by extending json which they send to Flipper.
Reviewed By: jknoxville
Differential Revision: D15804247
fbshipit-source-id: 9deea5c9f5f7c5416b42c476f7f0ed431c8dea04
Summary: Enable highlight of multiple rows so they can be copied
Reviewed By: passy
Differential Revision: D15822749
fbshipit-source-id: 2302ddd27a57574c1eaf1f1395939c9f006ba301
Summary:
Select multiple rows, and then right click, or use Ctrl-click.
This was broken, it was resetting the selection when this happened.
This fixes it.
Now after selecting multiple, what happens depends where you right-click.
If you right-click within the current selection, it stays selected and you can copy it.
But if you right-click outside the current selection, that row becomes the new selected set, and you will just be able to copy that one. This feels right to me.
Reviewed By: passy
Differential Revision: D15822668
fbshipit-source-id: 6a6cda8a8f16fec55cffa52c1c2ff958c86b3f43
Summary: Transfer it from the device, reformat the notification to make use of it.
Reviewed By: danielbuechele
Differential Revision: D15779267
fbshipit-source-id: 747dc7f895528618ff6a07c15b7f72bf6a1adde9
Summary:
Trying to detect version mismatches between the running Simulator and the version of Xcode's CLI tools.
What is done in this check:
- The running path of the running simulator is queries from `ps`
- The path of Xcode CLI tools is queried using `xcode-select -p`.
- The two paths are compared if they differ
Reviewed By: jknoxville, passy
Differential Revision: D15803238
fbshipit-source-id: 6638312505fc950ff7869fd55494984bfffb677b
Summary:
We in React VR were need newer Chrome DevTools version to make our plugin work properly. Chromium version with required fixes were shipped in electron 5.0.0.
This diff bumps electron version and explicitly allows node integration (accessing require, process and other node related functions from window object in index.html), because it was disabled by default in 5.0.0.
Reviewed By: jknoxville
Differential Revision: D15693539
fbshipit-source-id: 4f71a07b2afaa489aec46940c924f4ad30ad0413
Summary: Adds the capability to customize rows in the elements inspector via a callback.
Reviewed By: danielbuechele
Differential Revision: D15738355
fbshipit-source-id: 27b91a74535736318b7fdb9d2eb44dfa20b4d77b
Summary: The "Conflict in temp dir" message was misleading when there were 0, rather than >1 file. This fixes that error message.
Reviewed By: passy
Differential Revision: D15716247
fbshipit-source-id: 572addf99f623cdcffd7602dd3935bb69a50d047
Summary: Add sidebar to the flipper CPU plugin. Sidebar displays detailed information about the selected CPU core
Differential Revision: D15696198
fbshipit-source-id: 47e687b4354653e6bef626cd3f27adcb219dbd28
Summary:
`StatusIndicator` works well as a flex child, but didn’t support usage in inline / text contexts.
Adding `display: inline-block` fixes that.
Reviewed By: danielbuechele
Differential Revision: D15695673
fbshipit-source-id: 30378d2292390b8d86c0a26c11571e5953b841f2
Summary:
Pulls out the local `Lamp` component from `PluginDebugge` into `StatusIndicator`.
This will allow to reuse the component in different context, to guarantee a consistent appearance of Flipper throughout.
For good measure, we make diameter and title configurable. Vertical alignment is changed from `margin-top` to `align-self`.
Reviewed By: danielbuechele
Differential Revision: D15692275
fbshipit-source-id: 438b2f5300175565dbf07d07a5d757936b4f7cfe
Summary:
Using `process.exit()` stops the node process without waiting for the event loop to finish, so when using async i/o, which is what happens when piped, if the output is buffered, the process can terminate before it finishes flushing the buffer.
This means you only get some of the output and the JSON is malformed.
This fixes it by calling `process.exit()` inside the flushed callback.
Reviewed By: passy
Differential Revision: D15624806
fbshipit-source-id: ea540ed5a40fb1811e5b705b190da96c8e54730d
Summary: Catch the exception thrown in xcrun, which will occur for linux machines and in the cases when Xcode command line toolchain is not installed.
Reviewed By: passy
Differential Revision: D15621368
fbshipit-source-id: f3044cee6f7a4b5ba927a33003f9690c1fe31586
Summary:
Adds a "Track Leaks" option that will show notifications (even retroactively)
for `CloseableReferences` that were tracked.
Reviewed By: danielbuechele
Differential Revision: D15622596
fbshipit-source-id: ef610379aa96f9a5e541f741af608db30bee74e1
Summary: Added unit tests for the "WASTED_BYTES" for the fresco plugin
Reviewed By: passy
Differential Revision: D15610871
fbshipit-source-id: dc9bd84363e1ba22fc96890b74e217372188a9d0
Summary:
Notification from plugins (especially network) could be very spammy. This diff introduces a throttle, so a plugin can only send a notification every 5 seconds. If a notification is sent earlier, it is not displayed and the counter is reset to 5 seconds from now.
In the notifications panel still all notifications are dispalyed.
Reviewed By: passy
Differential Revision: D15621427
fbshipit-source-id: ea5e3b39fdd5cdedff3fd5234e752800520a423b
Summary: Unrelated to what I was going to work on, so separate diff.
Reviewed By: jknoxville
Differential Revision: D15620643
fbshipit-source-id: a555bbd54adfe44fa7d566cb9cb6d31bd75be28e
Summary: Add a metric for the raw number of leaked closeable references.
Reviewed By: priteshrnandgaonkar
Differential Revision: D15603348
fbshipit-source-id: 03379e180b5822620e8e8347bef354edb3527d19
Summary:
The FlipperArray creation from JSONArray used to create an array of `null`'s instead of the FlipperObject, which used to crash the Flipper. Thus added a check in the flipper to not crash in the case when it receives array of nulls. Also fixed the Fresco plugin in mobile to send the proper FlipperArray.
Bug:
{F160049909}
Reviewed By: passy
Differential Revision: D15608297
fbshipit-source-id: 625e017d3bce4135ac699ee5aee8d871db378749
Summary:
This diff fetches the additional data by calling the hook added in each plugins when the headless tries to export metrics directly out of the store rather than from the trace.
I added `fetchMetadata` function which will be called while exporting the state as well as exporting the metrics. We do not need to fetch metadata in the case when the metrics are exported from the given trace.
Reviewed By: passy
Differential Revision: D15560129
fbshipit-source-id: 9b14340e565ce17d1825bc2d32520d7b0c2b2219
Summary: Actually reduce in the reducer step instead of using mutable state.
Reviewed By: jknoxville
Differential Revision: D15603095
fbshipit-source-id: f603ca548bb760db5423a4c1871d94284ece9521
Summary:
We've got some exit troubles, meaning we have to use process.exit() to stop the headless process. This isn't good because the output isn't necessarily flushed when the process forcefully exits this way.
The tests can check for this, so I've removed the forceExit flag, and fixed the case stopping them from cleanly exiting - the android adb client.
Reviewed By: passy
Differential Revision: D15602919
fbshipit-source-id: b4a9dbabf5d3c874bda6bf938e4acb7b5b7e901b
Summary:
There's a mismatch as we don't use the same existential qualification
in the constructor as we do for the class definition. This this
enforced more strictly in newer Flow versions.
Reviewed By: danielbuechele
Differential Revision: D15601548
fbshipit-source-id: 807ef9ba74933fbc653514a617d1008f4f65c631
Summary: Not sure why Flow was okay with this before.
Reviewed By: danielbuechele
Differential Revision: D15601506
fbshipit-source-id: a211bb373061d1481dbc6748d4e061a980cd0278
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/455
Only logging to the console for now, but it's a good start.
Reviewed By: oprisnik
Differential Revision: D15535820
fbshipit-source-id: 8531ec5ef681d01b2428a1f016b2a1d9f1589a34
Summary: requestIdleCallback does not exist in node.js. In this case, we immediately invoke the callback.
Reviewed By: priteshrnandgaonkar
Differential Revision: D15556037
fbshipit-source-id: 62cee8544fabd4528d9df17109e882fa9db6585f
Summary: This is a big dep, and wasn't even used. Removing.
Reviewed By: danielbuechele
Differential Revision: D15555949
fbshipit-source-id: 31a5430819592478b01548469fdbf58637c4de22
Summary: Red error bar at bottom when something goes wrong.
Reviewed By: danielbuechele
Differential Revision: D15536042
fbshipit-source-id: 6a20e22489f9346864b78f9102a0917f94c1c74f
Summary: I've found myself having to extract strings from things that *might* be Errors more than once. Centralising this so it's consistent and correct everywhere.
Reviewed By: danielbuechele
Differential Revision: D15536034
fbshipit-source-id: 8e054dd6122aff10f0aacdfaed65125df0aea99f
Summary: This hadn't been tested on any tables with indexes. It was using the wrong set of columns to index the rows. Fixed by using the right list.
Reviewed By: danielbuechele
Differential Revision: D15535864
fbshipit-source-id: 1842a0695715e947b7e28b59e65dcc1eb5b32695
Summary:
React outputs the following error:
Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.
This fixes it by using value instead of selected.
Reviewed By: danielbuechele
Differential Revision: D15535717
fbshipit-source-id: eb784ba2cdefe1c6744cc15592cd3e0191d237d0
Summary: React is printing errors saying not to use "Span", and booleans in html properties
Reviewed By: danielbuechele
Differential Revision: D15535593
fbshipit-source-id: e074137c89abfa69625b370087c9c18b579ff279
Summary:
As seen [here](https://fb.workplace.com/groups/230455004101832/permalink/623364598144202/?comment_id=623436418137020&comment_tracking=%7B%22tn%22%3A%22R%22%7D) using the primary key + CTRL to open the context menu, triggers the drag-select mode. This should not be the case. This diff changes the behaviour to:
- Not trigger the drag-select-mode, when openting the context menu using CTRL
- Select the current row, when performing a context click on it.
Reviewed By: jknoxville
Differential Revision: D15538057
fbshipit-source-id: d3d086c3d44618b2801e3a9b0646689c04fa32ff
