Summary:
- Docs for UI components are now automatically published: https://fbflipper.com/docs/ui-components.html
- Stop caching source files in dev mode: ad98ba3235
- `createTablePlugin` now uses persisted State: db42e8e970
- HTML in network responses now gets formatted: a56d7d5d72
- Notification filters are persisted between sessions: 9fb3a56303
- Prevent Flipper SDK crashes from bringing down Android apps: ddbb3c7f89
- Fix Android devices from not showing up: a6765deec6
Full commit log since the last release available here: https://github.com/facebook/flipper/compare/v0.11.1...v0.12.0
Reviewed By: jknoxville
Differential Revision: D13153344
fbshipit-source-id: e67e2ac9469b2a5ef58d1963a38b1c8f448bd4fb
Summary:
Last one that's available through the DSL. The Android
plugin still isn't.
Reviewed By: jknoxville
Differential Revision: D13176791
fbshipit-source-id: 6684812bb4fee1dcd9db1503e660fb019160224e
Summary:
We've seen this happen sometimes, e.g. when adb fails and we aren't showing any android devices, but the sdk still manages to connect.
When we detect this, log an error so we can track how often it occurs.
Reviewed By: passy
Differential Revision: D13175639
fbshipit-source-id: b0f79b77ac04ad804e56448b3696a3ffeb30631e
Summary:
Doesn't change how it works, but using the new recommended mechanism for loading plugins.
Pull Request resolved: https://github.com/facebook/flipper/pull/331
Reviewed By: jknoxville
Differential Revision: D13167476
Pulled By: passy
fbshipit-source-id: ac0ae925f5780136ce5c1fcb666faa79c19e049c
Summary: This diff fixes the improper plugin id getting assigned to the variable which lead to notifications not getting shown. The client id has `#` so pluginId is no longer the second argument when one splits the string by `#`. This diff fixes this problem.
Reviewed By: passy
Differential Revision: D13176776
fbshipit-source-id: cd5bdc33c61485e3cdc2f2dbcc615980c39c8b8c
Summary: Added tests for flipper client which makes sure that didconnect is called in the case of background plugin. It also checks the case of a non background plugin.
Reviewed By: jknoxville
Differential Revision: D13152686
fbshipit-source-id: 7850f66a42d669243f656a1e1c26584869ee919f
Summary: Retry up to 5 times with exponential backoff.
Reviewed By: passy
Differential Revision: D13138244
fbshipit-source-id: 94c68b87aa281cfc3239b0bb8bdd75a2e0d7edc7
Summary:
Eslint / prettier are unhappy with the formatting of the FlowFixMe
comment, but the suggested solution is really ugly. Let's disable
the lint for now and remove this once it's addressed.
Pull Request resolved: https://github.com/facebook/flipper/pull/332
Reviewed By: jknoxville
Differential Revision: D13156552
Pulled By: passy
fbshipit-source-id: 680d151ea1022912e0e4a83fa42dc51005631c30
Summary:
Some network requests are yielding error: e.getMessage() is not a function.
It shouldn't be .getMessage(), it should be .message
Reviewed By: priteshrnandgaonkar
Differential Revision: D13137334
fbshipit-source-id: 72c782376c8e62a05c5e9ce1b956566ce1fc5bf0
Summary: This was misusing promise.resolve by calling it before the result is produced, meaning there was a race condition. It would also resolve as success even if listDevices failed.
Reviewed By: passy
Differential Revision: D13121173
fbshipit-source-id: f120a1b199d1e3168059c537461f65a8dc125a94
Summary:
Finally tracked down this bug that's been annoying me.
If you start flipper while the adb daemon is not running, then flipper will start the daemon, but it won't wait for it to have finished starting before telling the client to watch for devices. This is a race condition, and in practice never seems to work.
To avoid this, I'm calling `adb devices` on the client and waiting for it to complete before doing anything else. This forces it to wait for the daemon to start up if it hasn't already, and if it has then it instantly returns.
Reviewed By: passy
Differential Revision: D13101963
fbshipit-source-id: b85bed24751ce5c8efdfc6e841400e4db2580ab0
Summary: This diff wraps all the important places where the java code is called in a try-catch block in order to avoid flipper bringing down an app.
Reviewed By: jknoxville
Differential Revision: D12839504
fbshipit-source-id: 4711bccbe6d50094d76ed7ecd1eb652cefc2a090
Summary: This diff just adds the changes done here D12829542 for the OSS
Reviewed By: jknoxville
Differential Revision: D12839582
fbshipit-source-id: 0bdfa9e8e661309454709819af703499cd540ab4
Summary:
This PR adds a stub podspec files which will be pushed to cocoapods master repo to reserve our project name on cocoapods master repo. This PR follows the suggestion given by KrauseFx in #132 132. I have reserved the name of [Flipper](https://cocoapods.org/pods/Flipper) and [FlipperKit](https://cocoapods.org/pods/FlipperKit) on cocoapods with these stub podspecs.
Pull Request resolved: https://github.com/facebook/flipper/pull/330
Reviewed By: passy
Differential Revision: D13118301
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 754a69ee9577c1357cf3284b5c89143d46f69c87
Summary:
This PR adds the example flipper plugin in swift sample app. Example flipper plugin acts as an example for the plugin authors. The example flipper plugin was already added in an objective c example but the swift sample app didn't have it.
Pull Request resolved: https://github.com/facebook/flipper/pull/329
Reviewed By: jknoxville
Differential Revision: D13085611
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d86cca43e95592ecca8d9991d170e62170b8217b
Summary:
Bug report here: https://fb.facebook.com/groups/230455004101832/permalink/519062535241076/
This has broken layout plugin when NT components are used.
Removing the subdescriptors as a quick fix. At the moment, this means removing the new NT features.
Reviewed By: priteshrnandgaonkar
Differential Revision: D13103790
fbshipit-source-id: 57c10a0a07507aaba0cd7a20d1b548470203f2f6
Summary: Stops them from jumping around if they try to connect more than once.
Reviewed By: passy
Differential Revision: D13084056
fbshipit-source-id: 803538298c45b9c28e5116f072518e8632b0f1cf
Summary:
Adds an optional interface that, when implemented, adds
a "Report Bug" button to the top of the screen.
This is a weird Android-ism that's sadly still the
recommended way of providing hooks into Fragments:
https://developer.android.com/guide/components/fragments#EventCallbacks
In order to keep things vanilla here, let's follow that pattern.
Reviewed By: jknoxville
Differential Revision: D13045578
fbshipit-source-id: 1506fcfc630c2d1183d7d1eaf470d23954e0c097
Summary:
This allows passing in some options in an easy way, like a callback
that contains all debug information for a bug report.
Reviewed By: jknoxville
Differential Revision: D13045282
fbshipit-source-id: 5698228ee9aef31d406313047b6836dc928448cf
Summary: Adds test for the plugin reducer and dispatcher
Reviewed By: jknoxville, passy
Differential Revision: D13082652
fbshipit-source-id: 4af2c7721c4d88abbd332d610ff71d5db78e721c
Summary: Adding two GKs (one failing, one passing) to allow the testing of gatekeeper functionality. This is used in the next diff.
Reviewed By: jknoxville
Differential Revision: D13082651
fbshipit-source-id: c6d8ef484564c8ae8b4c107de5643c700f696ad5
Summary:
Plugins were loaded in `/plugins/index.js` which was loaded once at launch of the app. This moves the list of available plugins to redux. This way, plugins can be dynamically added. The redux store keeps to Maps of plugins (devicePlugins and clientPlugins) with their ID as key:
```
devicePlugins: Map<string, Class<FlipperDevicePlugin<>>>,
clientPlugins: Map<string, Class<FlipperPlugin<>>>,
```
On launch of the app, all plugins bundled with the app and the one found in `pluginsPath` are dynamically added.
This changes now allows to add new plugins at any time. All components that need to know which plugins are available (e.g. the sidebar) are connected to the redux store. This way, they will automatically update, whenever a new plugin is added.
- add `plugins` to the redux store to keep the list of available plugins
- add a plugins dispatcher, responsible for loading the plugins on launch
- connecting all React components that imported `plugins/index.js` before to the redux store to get the plugins from there.
- moved the updating of the MenuBar to the plugins dispatcher as it needs to update whenever a new plugin is added.
Reviewed By: jknoxville, passy
Differential Revision: D12449236
fbshipit-source-id: 6ef3e243e2c80443614b901ccbfde485fcb4301c
Summary:
2 spaces, and space before and after the `+`
Pull Request resolved: https://github.com/facebook/flipper/pull/324
Reviewed By: jknoxville
Differential Revision: D13082547
Pulled By: priteshrnandgaonkar
fbshipit-source-id: b6053ebde16a1f7f953704e0791622d3d59cc962
Summary:
First step in visualising the connection setup process.
Just a spinner while cert exchange is happening, so it doesn't look like nothing is happening.
Reviewed By: passy
Differential Revision: D13062514
fbshipit-source-id: a0692821025f42f4fe4af86faf059d4719008f25
Summary: Puts the connection state into redux so we have more visibility on what's happening in bug reports and in general allowing us to display it on screen.
Reviewed By: passy
Differential Revision: D13060455
fbshipit-source-id: c79b4b7d6a1155d86128a5d8d1174ead9e4514ae
Summary:
This improves bug reports.
Adding serial into device.toJson() means you can now easily see which clients (apps) are from which device because they both contain the serial.
Changing client id to use # instead of - because the subcomponents of it already use -.
Reviewed By: passy
Differential Revision: D13058430
fbshipit-source-id: 02697ec623829423e667fd2acbd1abc369a6919b
Summary:
Now the BugReporter has access to the logs and the redux store, to submit more useful bug reports.
This isn't currently used in open source, unless you override / replace this file.
Reviewed By: danielbuechele
Differential Revision: D13058210
fbshipit-source-id: e52a3cb528693ab171843080685e5342e0b6a393
Summary:
We use this class to show an invisible overlay when using a sandbox. This shouldn't intercept hit tests.
Would be good to remove these FB-specific references from the OSS code, but since there's one already, will leave that for a separate diff.
Reviewed By: danielbuechele
Differential Revision: D13028248
fbshipit-source-id: df2eb83fd9c4b7547ede5dcb088e10a7d3d4f36b
Summary: Just keeping it up-to-date. Includes a fix for source maps which could be interesting.
Reviewed By: jknoxville
Differential Revision: D13023339
fbshipit-source-id: 4c68029bb3cef408e2a7b28a1cde39f246dc046d
Summary:
The appId field gets embedded into the certificate request, so flipper knows which app to provide the cert to.
In iOS this field is never used, so far, because the destination path uniquely identifies the app so this is redundant.
For physical iPhones however, knowing the bundle id lets you deploy files into the container, so we can use this value.
Reviewed By: passy
Differential Revision: D13000296
fbshipit-source-id: 9f21850b908a03f1be87dc204e59d616150cc7ec
Summary: Searchbar didn't update the filters when new default filters were added. This adds the new filters when they are added to the searchbar. Existing filters are not touched.
Reviewed By: passy
Differential Revision: D12999885
fbshipit-source-id: 51d9a1579724be2098b54161b39a0769180fb343
Summary:
* adds a button to hide notifications by category
* adds a quick action to report notifications as not helpful
* fixes type of network plugin's notifications to be string instead of number
Reviewed By: jknoxville
Differential Revision: D12999883
fbshipit-source-id: 32be5bde5931cca4a27ab1ad34418300196452cc
Summary:
Allows filtering notification by category. Category filters are also persisted in redux.
Adds a test suite for notification reducer
Reviewed By: passy
Differential Revision: D12999884
fbshipit-source-id: 5f8d2357e52f091c17b726e1f89ed68f3b7294fb
Summary: This diff adds action buttons to the notifications. Notifications with actions can only be sent from the main process. This is why we need to send a message to the main process which then shows the notification. The action callbacks are sent back to the renderer process to handle the action and log the event.
Reviewed By: passy
Differential Revision: D12999886
fbshipit-source-id: b415fded3172582fad11d88cabf0cfc5b3b8d4f9
Summary: This is a re-do of D9720987. Now that the Litho version has been bumped to 20 in D12838684, this diff can land safely.
Reviewed By: danielbuechele
Differential Revision: D12969979
fbshipit-source-id: b12d14e3b292d8cd110967f84f770f3725a800de
Summary: Is it too early for spring cleaning? We don't use websockets anymore, do we? Couldn't find any imports or `require()`s.
Reviewed By: jknoxville
Differential Revision: D12997868
fbshipit-source-id: c87c67ec98b925c4209b97bf00e91fce67215465
Summary: Let's stay up to date and get the latest improvements.
Reviewed By: jknoxville
Differential Revision: D12997456
fbshipit-source-id: 1d543aec032052d1115d627f0103e7b8f721d74c
Summary: In the accessibility inspector plugin, the "Enabled" view property was marked at mutable, but would not actually change the clicked. This is because no case for changing this property was implemented. This fixes the issue and allows the property to be mutable.
Reviewed By: jknoxville
Differential Revision: D12944810
fbshipit-source-id: 846547ba1baa481eca3fe1cd949cf252904677bc
Summary: took out dictionary implementation and passing string through NTSubDescriptor
Reviewed By: rohan-mehta
Differential Revision: D12961340
fbshipit-source-id: 73493b83b3b670eb3455148c0223972b0d25815a
