Summary:
Some improvements on the previous diff that were too much for just comments.
- Remove an unnecessary `touch` that I commented on in the previous diff.
- Ensure that the recording button is not set to "recording" if there's an error during the setup.
- More reliable way of checking the file size on the device before pulling.
Still not done: Show the error more prominently in the UI. Out of scope for this but if we could come up with a design for showing this (perhaps in place of the recording button) when something went wrong, that would be more obvious than having the error caret show up at the top of the screen.
Reviewed By: jknoxville
Differential Revision: D19723627
fbshipit-source-id: 20babcc1482e5a9ac829ff6d6ae7a731a3454fa0
Summary:
Original commit changeset: 5caf9df02c95
It backs out the diff as it broke the video recording button in support form.
Bug:
{F227855063}
Reviewed By: passy
Differential Revision: D19742486
fbshipit-source-id: 4a275e6ead919b4f4ed94889545a650c101f89b7
Summary:
Getting the error
```
$ /mnt/btrfs/trunk-hg-fb4a-fbsource-86184178-1580774714/xplat/sonar/node_modules/.bin/tsc --noemit
src/plugins/network/index.tsx(180,59): error TS2349: This expression is not callable.
Type 'Number' has no call signatures.
error Command failed with exit code 1.
```
EDIT: This error was a red herring from another commit I was based on. Either way, `Number` is discouraged by the Typescript standard (https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html), so let's move these to `number` instead.
Reviewed By: mweststrate
Differential Revision: D19712113
fbshipit-source-id: b754780063a1c429724abcd343da06514671bc83
Summary:
Currently `exportStore` function returns the serialized string along with errorArray. errorArray contains an error when there is some issue with fetching metadata. Essentially, it keeps the error in the errorArray and continues with fetching the data for the next plugin. Previously we used to exit our submit form execution when the errorArray had any value. So this diff removes that check and instead logs it on the console and in our logging system.
It will handle the case mentioned [here](https://fb.workplace.com/groups/1430200360634661/permalink/2566831316971554/)
This diff also adds a log when there is failure to upload flipper data.
Reviewed By: mweststrate
Differential Revision: D19723674
fbshipit-source-id: 18bf90461156f67ecc2b4ce4b1eac4aa3485188d
Summary: Shows warning when requiredplugin has empty data. It also makes the validation box as an error one, to distinguish between the two boxes.
Reviewed By: passy
Differential Revision: D19704910
fbshipit-source-id: ffd9413c3cd65c09f8b6019889191decefa6b6f6
Summary:
Backgrouds
- For screen recording Flipper use 'adb shell scrrenrecord' and 'adb pull'.
- 'screenrecord' make error and doens't works for some android devices and AOS versions.
- For example, "--bugreport" option doesn't work old version of AOS.
- We can not control 'screenrecord' command yet.
- It is better let user know the situation early.
<AS-IS>
When 'screenrecord' emit error:
- Noting happened for users.
- Result of screen record file is just empty. (pull command create the file)
<TO-BE>
When 'screenrecord' emit error:
- Let users know 'screenrecord' is not working properly.
Reviewed By: passy
Differential Revision: D19643060
fbshipit-source-id: 5caf9df02c956283f371c50c1735060be2158fb2
Summary: Adds analytics for the selected group, failure cases and distinguishing between user clicks for the support form vs deeplink.
Reviewed By: passy
Differential Revision: D19697856
fbshipit-source-id: 62d5afa998d2096252570387c9a3df1c7c134e67
Summary:
## The dependency [algoliasearch]() was updated from `3.35.1` to `4.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [nunomaduro](https://www.npmjs.com/~nunomaduro)
**License:** MIT
[Find out more about this release]().
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/772
Test Plan: Manually tested searching and installing still works.
Reviewed By: jknoxville
Differential Revision: D19690706
Pulled By: passy
fbshipit-source-id: 46cb05fb2c0429c4a1f7fb31a833cd000805825d
Summary:
## The devDependency [types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped) was updated from `24.9.1` to `25.1.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [types](https://www.npmjs.com/~types)
**License:** MIT
[Find out more about this release](https://github.com/DefinitelyTyped/DefinitelyTyped).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/764
Reviewed By: jknoxville, mweststrate
Differential Revision: D19602722
Pulled By: passy
fbshipit-source-id: 8f20b325389c68e4422842eea164c2f6fc84162a
Summary:
## The devDependency [ts-jest](https://github.com/kulshekhar/ts-jest) was updated from `24.3.0` to `25.1.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [kul](https://www.npmjs.com/~kul)
**License:** MIT
[Find out more about this release](https://github.com/kulshekhar/ts-jest).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/768
Reviewed By: mweststrate
Differential Revision: D19639975
Pulled By: passy
fbshipit-source-id: d3e344d54d76127476c42146e2cc6c4c578d89c8
Summary: This diff refactors the scattered logic of required plugins and default selection of the plugins into Group class. Also the same class handles the deeplink logic.
Reviewed By: mweststrate
Differential Revision: D19666745
fbshipit-source-id: c9427f0ddba643f0b32aac7b6f2496e2e3248b12
Summary:
Write now the logic to append (Imported) and (Offline) text for archived devices is scattered at multiple places. Due to which we had the following bug
{F227484749}
Reviewed By: mweststrate
Differential Revision: D19663506
fbshipit-source-id: 1f5c0060825d8b246c94da85ac4a18cc4ff040d2
Summary: Updated the source a while ago to also include the images plugin.
Reviewed By: nikoant
Differential Revision: D19691720
fbshipit-source-id: 70bf1929e4c571f02db2d8ef787f1130a480d05f
Summary: Changed the plugin display logic in SupportForm to show plugins which are enabled(includes device plugins) and plugins which has `exportPersistedState` defined.
Reviewed By: mweststrate
Differential Revision: D19643857
fbshipit-source-id: 7a4a5882507c06c6b6f9c481ee2c5c36ecc32ac6
Summary:
getTargetDeviceId is now being called directly from within server.tsx.
Since it's exported anyway, it should always sanitize its input.
Changed the ios method to sanitize the CSR in the same way that the android one does.
Reviewed By: cekkaewnumchai
Differential Revision: D19663992
fbshipit-source-id: 77662542b3a8767ecdd4e984a8e2d990761a9815
Summary:
This diff makes sure that important errors are always shown to the user, such as an xcode version mismatch.
Also made some small styling improvements
Reviewed By: jknoxville
Differential Revision: D19660337
fbshipit-source-id: 24dfb4d98bfdd1666164403f87b6a4e1dc915ddb
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.115.0` to `0.117.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [mvitousek](https://www.npmjs.com/~mvitousek)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/763
Reviewed By: passy
Differential Revision: D19621269
Pulled By: mweststrate
fbshipit-source-id: d213eeda19ba3715471f3843b38a8ae5d7a53713
Summary: Remove the old sidebar, since the new one has been rolled out fully
Reviewed By: jknoxville
Differential Revision: D19659945
fbshipit-source-id: d1592df98fe69ef07d88d3a40790768dee3ab11c
Summary: Fixes issue where the user would loose context if having a lot of apps open, and then opening a bug report
Reviewed By: priteshrnandgaonkar
Differential Revision: D19640759
fbshipit-source-id: cc3aa617d99aae1904999da98d12b8a3595f6fbe
Summary:
mityal implemented a new check for nullsafe to warn about potentially
incorrect overrides of `equals` method (not yet released).
While testing some other things I stumbled upon incorrect `equal`
overrides in Flipper, particularly not properly handling `null` param.
Reviewed By: passy
Differential Revision: D19639882
fbshipit-source-id: 7f9aec7270e89a906810807f6849628967047b2a
Summary: Added radio buttons when the listview enforces single selection
Reviewed By: mweststrate
Differential Revision: D19626710
fbshipit-source-id: 9220fad7b0825cac5ba39def4d5e85d671c61da7
Summary: Adds a status message when the one deeplinks to support form and the selectedClient doesn't support GraphQL plugin.
Reviewed By: jknoxville
Differential Revision: D19602900
fbshipit-source-id: 98a45ead2659bb229f4a1301e918e02dca05fc66
Summary: Update the deps as proposed by greenkeeper, to check if they indeed break the build
Reviewed By: passy
Differential Revision: D19620346
fbshipit-source-id: 9e273012373f7091180d90c368a8193572b7155a
Summary: Fixes the broken Layout plugin in wilde. Before this fix it will just show an empty screen in the layout plugin.
Reviewed By: jknoxville
Differential Revision: D19621517
fbshipit-source-id: e10078248b95b93c6b9c87ccf4508628b6ad86bb
Summary: A small clarification after the question 7964772f82 (comments)
Reviewed By: jknoxville
Differential Revision: D19619402
fbshipit-source-id: c392c492fe5e9cd46d46c93f617288ac0a4d02a5
Summary: When JavaScript fiction meets native interop reality, things get weird. Apparently some coordinates must be integer values.
Reviewed By: mweststrate
Differential Revision: D19606677
fbshipit-source-id: 88a6e8c465e59078b070b56b37eee571274c494a
Summary:
It looks like this timeout was firing every time, causing a misleading error.
Fixing by clearing it when the match is found.
Reviewed By: passy
Differential Revision: D19602640
fbshipit-source-id: b5d97e71a02a014b9498dd56371c1a48f8ae08eb
Summary: This diff adds support for the deeplink of support form for graphql groups.
Reviewed By: mweststrate
Differential Revision: D19583680
fbshipit-source-id: fc4505dc5f46c701f1e43fc47ee094fb0aa15d42
Summary: This diff updates default plugin selected when group selection gets updated. This diff also makes sure that group selection is persisted when swtiching between different tabs.
Reviewed By: mweststrate
Differential Revision: D19578748
fbshipit-source-id: 6f401248fe32441e30cb5acbb9251e206866984a
Summary:
Added a group selection view in the support form to select the group to post the support form in. Added two groups for GraphQL's android and iOS.
Also added a check to avoid selecting graphQL group unless GraphQL plugin is enabled.
Reviewed By: mweststrate
Differential Revision: D19538023
fbshipit-source-id: 022d592ae2aa17ed1e1b10a37b011ddc68df560a
Summary: Using just the scope identifier for the root component is not sufficient when it doesn't have a scope. Solve this by prepending the scope root identifier to the parent identifier.
Reviewed By: fabiomassimo
Differential Revision: D19600721
fbshipit-source-id: d90f9ffd7ae369c76316cebc4ef792626a4584b7
Summary: Added information that "Debugger for Chrome" extension is required to be able to debug in VSCode.
Reviewed By: passy
Differential Revision: D19599117
fbshipit-source-id: 7323fb59daae24fe6b914e9ddb450326b135ad2b
Summary:
## Summary
Resolves https://github.com/facebook/flipper/issues/607
This removes stetho dependencies directly in favor of just copying in the used classes. This removes the last non-androidx dependency from the project, and is useful as stetho appears to be unmaintained. The fresco stetho dependency appeared to be completely unused.
## Changelog
Remove stetho dependencies. It was unused other than a few utility methods, but came at the cost of preventing Flipper consumers from completely removing dependencies that hadn't updated to Androidx yet.
Pull Request resolved: https://github.com/facebook/flipper/pull/762
Test Plan: Existing tests still pass with no regressions. Functionally this should be no difference.
Reviewed By: jknoxville
Differential Revision: D19577969
Pulled By: passy
fbshipit-source-id: b277ddf97a9d2c846dd0b9227c02bb46c1ecd930
Summary: Added stats, so that we know how much people have to wait when opening plugin after we open the queue GK
Reviewed By: jknoxville
Differential Revision: D19598730
fbshipit-source-id: f955123f2bae5b870eada8f787385d6c0450453e
Summary:
## The dependency [mkdirp](https://github.com/isaacs/node-mkdirp) was updated from `0.5.1` to `1.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [isaacs](https://www.npmjs.com/~isaacs)
**License:** MIT
[Find out more about this release](https://github.com/isaacs/node-mkdirp).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/757
Reviewed By: mweststrate
Differential Revision: D19578531
Pulled By: passy
fbshipit-source-id: b31ca29fabf263978242af464882cc530ff6564d
Summary: Currently we dont describe a `Window` object at all. Now we how the relevant theme data associated with the window.
Reviewed By: passy
Differential Revision: D19550049
fbshipit-source-id: 29903fb487b0be91d305f3b8d8fa7e4c3b3213e9
Summary:
## The dependency [mkdirp](https://github.com/isaacs/node-mkdirp) was updated from `0.5.1` to `1.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [isaacs](https://www.npmjs.com/~isaacs)
**License:** MIT
[Find out more about this release](https://github.com/isaacs/node-mkdirp).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/758
Reviewed By: mweststrate
Differential Revision: D19578530
Pulled By: passy
fbshipit-source-id: 3f7970875458904dc9bd74828328e5f436abacde
Summary: Updated "Debugging" page in Flipper docs: added instructions about debugging from Visual Studio Code and Google Chrome.
Reviewed By: mweststrate
Differential Revision: D19578864
fbshipit-source-id: c88c8278feb7c90fe77bde1d883c73079f2147f9
Summary:
This diff creates a small FPS graph to be able to see where we slow down the app. This visualizes two things
1. The amount of FPS we render at (from tracking.fps).
2. If we were not able to render at all (due to the main thread being blocked fully), we interpolate the graph and draw it in red.
Reviewed By: nikoant
Differential Revision: D19579115
fbshipit-source-id: 2421d724c6d514986759bc9d68b92a5e4f51e401
Summary: The welcome screen links were a bit out of date.
Reviewed By: nikoant
Differential Revision: D19578769
fbshipit-source-id: 69fc7977bd75ca4256043698350381a5f9d7fdb8
Summary: When doing a Flipper trace export through the app menu (not the support form), the export still contained a support request details section, with the default data of a bug report. That doesn't make any sense and is confusing, so this change makes sure the report is only included if it is supported through the supportRequestForm
Reviewed By: passy
Differential Revision: D19499408
fbshipit-source-id: ff7a5333f2045f2465966dffa0c5fb03aaeaceb8
