Commit Graph

22 Commits

Author SHA1 Message Date
Andrey Goncharov
3176c2f81d Update js-flipper in the pre-release phase and publish it
Summary:
1. Update js-flipper's version in pre-release
2. Update current version of js-flipper to match react-native-flipper
3. Publish js-flipper automatically

Reviewed By: mweststrate

Differential Revision: D31858522

fbshipit-source-id: e5a9816980d89d3ca6745bc16942f7b75f8d2a88
2021-10-25 04:35:12 -07:00
Pascal Hartig
c63cb6e42b Improve test plan for snapshot diff
Summary: Make it a bit clearer what this is and how to land it.

Reviewed By: mweststrate, fabiomassimo

Differential Revision: D29032029

fbshipit-source-id: c48e9119b465100befc5d25c7b19ced2ee917201
2021-06-11 06:42:41 -07:00
Pascal Hartig
cf8a023126 Simplify release diff test plan
Summary:
Taking fabiomassimo's feedback. We include a lot of internals in the instructions which
made sense when it broke basically at every single step all the time. Now that it's
way more stable, it's probably okay to describe the happy path and leave the debugging
instructions in the wiki.

Reviewed By: fabiomassimo

Differential Revision: D29027849

fbshipit-source-id: 5c7a314cfab1d7e1534376783c9291417b6bf4bc
2021-06-10 09:25:38 -07:00
Michel Weststrate
39ae6bf6b0 Back out "Fix RN GH example jobs failing after release bump"
Summary:
As discussed, the npm packages haven't been released yet during this step of the process, so we can't update the `yarn.lock` yet.

Bumping itself is reverted in the next diff.

Original commit changeset: 84fa2d35b5f4 / D27591155 (ebcb535fd3)

Reviewed By: nikoant

Differential Revision: D27764974

fbshipit-source-id: 36d4e5b329e8d045f2d789e883c54a47eddf524a
2021-04-14 08:19:25 -07:00
Michel Weststrate
ebcb535fd3 Fix RN GH example jobs failing after release bump
Summary: After running a flipper release, public builds start to failing as the yarn.lock file of ReactNativeFlipperExample is out of sync with the package.json. This diff fixes that

Reviewed By: passy

Differential Revision: D27591155

fbshipit-source-id: 84fa2d35b5f41ba9a28cfecabbaf6a2a082791db
2021-04-07 03:08:37 -07:00
Anton Nikolaev
4b58d4438a Release test plan updated to match the new release process
Summary: Release test plan updated to match the new release process and include some details which might be required in case something failed.

Reviewed By: passy

Differential Revision: D25618132

fbshipit-source-id: c39ceebe4569475554866097970a2410a992b6ae
2020-12-18 08:53:13 -08:00
Anton Nikolaev
dbc888613b Do not bump every package version for every release
Summary:
This diff sets all package version to "0.0.0" except of the root package and changes the bump script to only bump version in the root package. This should reduce possibility of conflicts on release diffs. Anyway we always use the same version for all of our packages, so we can only set it to the root.

Before npm publishing we will set all package versions to the same number as in the root package (we actually already do that) so there will be no differences except we won't need to bump version in  more than 100 packages each release.

Reviewed By: mweststrate

Differential Revision: D25162373

fbshipit-source-id: 02fe401bee72845339c67925c130027bdaee559d
2020-12-02 02:38:47 -08:00
Anton Nikolaev
d8b3ac3e54 Pass already bumped version to prepare-release.sh
Summary: The script now receives new version via command line.

Reviewed By: jknoxville

Differential Revision: D24771302

fbshipit-source-id: 243ad2cc8cb62af86eadb44fbf4bd7c71e97af6f
2020-11-09 11:24:23 -08:00
Pascal Hartig
c282184d9f Run generate-changelog with xplat node
Summary: This way we don't need to depend on Sandcastle configurations. amurawska pointed out that the header in `generate-changelog.js` indicates it must be run with Node 6, but trying to do so actually raises a Syntax error.

Reviewed By: mweststrate

Differential Revision: D23904875

fbshipit-source-id: 264f3b16d64ebfbae6afb0028715f67624166499
2020-09-25 03:54:04 -07:00
Pritesh Nandgaonkar
a4422a7687 Update pod version after release (#1338)
Summary:
This diff updates the Github workflow to update pod versions after the release is published on Cocoapods.
## Changelog

- Update Github workflow to update the pod versions till the release is published in Cocoapods.

Pull Request resolved: https://github.com/facebook/flipper/pull/1338

Test Plan:
A PR got created with the updated pod versions after the release was pushed.
https://github.com/facebook/flipper/pull/1365

Reviewed By: passy

Differential Revision: D22456857

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 335996bc1ebb6da309d3f60a8f3401559e0a83c7
2020-07-10 02:20:14 -07:00
Pascal Hartig
d6701e2f96 Allow customisation of release version
Summary: Allows passing the version part to be bumped as part of the release process.

Reviewed By: nikoant

Differential Revision: D21722939

fbshipit-source-id: 94d3ddeb78722dae5dfbc5822f9e70873f565a81
2020-05-27 09:52:12 -07:00
Anton Nikolaev
cdc851f281 Fix release version bumping in docs
Summary: Fix release version bumping in docs after switching from ".md" to ".mdx".

Reviewed By: mweststrate

Differential Revision: D21282492

fbshipit-source-id: 60ecfd9a058b71d1895945c9c3d05b9df8f6493c
2020-04-28 11:43:58 -07:00
Anton Nikolaev
0a79118ee7 Fix bumping podspecs in "Getting Started" docs in prepare-release.sh
Summary: Fixed bumping podspecs in "Getting Started" docs in prepare-release.sh

Reviewed By: mweststrate

Differential Revision: D20869684

fbshipit-source-id: 78a3b7064de51dbd8ca505db863595726d038326
2020-04-06 11:10:56 -07:00
Anton Nikolaev
3bdfea387b Install yarn modules required for prepare-release script
Summary: Install yarn modules required for release script

Reviewed By: mweststrate

Differential Revision: D20773606

fbshipit-source-id: 97ceda05e2d75229335bb77c7cef6dd328167283
2020-03-31 13:38:54 -07:00
Anton Nikolaev
2a27b47752 Fixed version bumping
Summary: Fixed version bumping in prepare-release script

Reviewed By: priteshrnandgaonkar

Differential Revision: D20771162

fbshipit-source-id: 8b8efa7111269e3f2b39b09c3dff1afe1fd0cf41
2020-03-31 11:20:27 -07:00
Anton Nikolaev
bf32297ad9 Publish all packages to npm on release
Summary: Publish all the public packages (excluding those with "private=true") included as workspaces to "desktop" project.

Reviewed By: jknoxville

Differential Revision: D20765097

fbshipit-source-id: 444541e9a682a90eba02cb3da85ada9bd00d93d0
2020-03-31 06:34:39 -07:00
Anton Nikolaev
eb9a2cb5e7 Bump versions for all npm packages on release
Summary:
Automatically bump versions for all local npm packages included as workspaces and fix local dependencies correspondingly.

As a part of this I have also aligned versioning for all the packages by using the same version for all of them.

Reviewed By: jknoxville

Differential Revision: D20745632

fbshipit-source-id: 2d438c4b23ee72f7d7c068c5ce161063c7ceb9e5
2020-03-31 06:34:39 -07:00
Anton Nikolaev
5ed3e8b1eb Set attributes to Flipper release builds
Summary: Changelog: fixed applying of product attributes (title, publisher etc) to Flipper builds.

Reviewed By: passy

Differential Revision: D20724437

fbshipit-source-id: 70e31484ddd59f1802573e2f963ee37857ab8405
2020-03-30 01:58:30 -07:00
Anton Nikolaev
e091c21fba Fix prepare-release.sh script
Summary: Fixed paths after moving js code to "desktop" subfolder

Reviewed By: jknoxville, mweststrate

Differential Revision: D20469775

fbshipit-source-id: 4df963550012905dff4c1ddf6e8b6cd2693b8fbe
2020-03-16 09:59:51 -07:00
Michel Weststrate
724fb79fe7 Don't submit release automatically when running on SC
Summary:
Our SC release job failed when submitting directly from the prepare-release script, as the jf context wasn't properly setup. So instead we reuse the code we already have for that in SandcastleFlipperAutoReleaseCommand.

However, for manual releases we still do submit automatically and in name of the current user.

Reviewed By: passy

Differential Revision: D20384247

fbshipit-source-id: ed5eca180f009611f2890f8cb665bf203789d189
2020-03-11 04:50:45 -07:00
Michel Weststrate
9dc187cc25 Make sure prepare-release scripts works when running from another dir
Summary: Yesterday's script failed if prepare-release was invoked from another dir

Reviewed By: jknoxville

Differential Revision: D20362093

fbshipit-source-id: a0ce877a2f145f320cf346dc86e3d2568279b8b9
2020-03-10 07:10:29 -07:00
Michel Weststrate
8f2dd977b7 unify internal and external release into one flow
Summary:
This diff makes updating the internal and external release part of the same flow. The will be changed to:

1. The chronos job is kicked to start a new release
2. That job kicks of `./prepare-release.sh` (see D20304039) which
   1. bumps the version of all packages
   2. generates the changelog
   3. generates a release diff + test instructions for that
   4. generates a diff with snapshot version updates
   5. submit those commits
3. when this is job is completed, the relevant release commits can be checked out and tested.
4. If these job is landed, this will kick off the OSS builds through `release.sh` (as-is). But, this will also generate a diff that updates the flipper pin to the verify same commit (new).

Next steps:
* [ ] update wiki

Code pointers (irrelevant for review):
- Chronos Job entry https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/commands/SandcastleFlipperAutoReleaseCommand.php?lines=85
- Sonar build step: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/sonar/SandcastleSonarBuildStep.php?lines=84
- Release commit observer: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/entity/opensource/github/observers/EntOpensourceGitHubCommitBuilderObserver.php?lines=17-48

Reviewed By: passy

Differential Revision: D20283664

fbshipit-source-id: 129ea862bda4721d707f1b6fdd862a937c0ed6d5
2020-03-10 02:48:14 -07:00