Luke De Feo
237faddb40
Fix crash for bloks sidebar
...
Summary: Bloks ios is serializing some ns dictionary without registering the metadata, this means the look up fails. That said regsitering metadata for dictionarys where the keyspace is unbounded doesnt make any sense so for this case we can just fall back to the key as the name. Since we can rely on the id lookup passing we iterarates the enties of the object
Reviewed By: passy, ivanmisuno
Differential Revision: D49314398
fbshipit-source-id: 65f7beb0d8402b08a68b9f00b7605e0b6c44766f
2023-09-15 04:05:43 -07:00
Luke De Feo
21b4423231
Refactor stream inteceptor
...
Summary:
There was a frustrating issue previously where the UI would jump everytime a new frame came in with bloks data. This would occur constantly as the client was generating new frames every 10 seconds. The issue was because the previous appraoch to speed up the augmentation was to display the raw client raw and then asynchronously process a new frame with the added derived components.
The issue was the raw client frame has less nodes so we would breifly display this, and because the reduciton trace was cache on the next tick we would show this causing a jump.
Now we have a new solution:
1. We use an event emitter to push frames / metadata into the interceptor
2. The interceptor should always produce 1 frame, this can be the same or augmented, for open source its just the same
3. We use react query to check if we already have the reduction trace cached, if so then we are able to quickly process the whole thing, if not its split into 2 parts.
React query is also nice since we can add a cache time for the reduciton traces which are very large and not useful one your screen is gone. This should help keep memory usage under control a bit.
one other benefit to this approach is i can remove the error handling stuff from the main plugin code, since the blok augmentation is not on the critical path and it can retry internally and push out a new frame whenever.
Reviewed By: antonk52
Differential Revision: D49272152
fbshipit-source-id: e5539d36231a32754e8612014195449b9faafdb1
2023-09-15 04:05:43 -07:00
Anton Kastritskiy
bc5ad749f7
fix console stack traces for errors from plugins
...
Summary:
We had our stack traces broken for a long time. They always pointed at the bundle.js file. With this change the stack traces **in the console** will be pointing at the actual source files. This will save a lot of time for engineers instead of manually looking for the source of errors.
Why this didn't work before?
When we were calling `console.error(error.toString())` the browser was not applying sourcemaps to the stacktrace as it interpreted as a random string. However, when you pass an actual instance of Error constructor, the sourcemaps will be applied and we get correct stack traces to the source files.
I looked at the code of the Logger and it is already handles the Error instances, so I think this should be fine also for the logs that go to scuba. CC passy
Reviewed By: LukeDefeo, passy
Differential Revision: D49275025
fbshipit-source-id: 2addc601f45622e35890d7d0e1992f4bca41a338
2023-09-14 09:40:09 -07:00
generatedunixname89002005306973
e9e7141999
Flipper Snapshot Bump: v0.218.1-SNAPSHOT
...
Summary: Releasing snapshot version 0.218.1-SNAPSHOT
Reviewed By: lblasa
Differential Revision: D49274240
fbshipit-source-id: fc21a87bdd05251b5ffa4070a4acc1e0bd8439c1
2023-09-14 09:25:32 -07:00
generatedunixname89002005306973
e369fac36b
Flipper Release: v0.218.0
...
Summary: Releasing version 0.218.0
Reviewed By: lblasa
Differential Revision: D49274241
fbshipit-source-id: 9f658704183200175a105327e42bd4ef5567e37a
2023-09-14 09:25:32 -07:00
Aditya Sharat
00c203efc3
Renames debug event attributes to be more consistent
...
Summary: Renames debug event attributes to be more consistent
Reviewed By: pentiumao
Differential Revision: D49269291
fbshipit-source-id: 88fe3607bdfc58b941897a5dcc00f20bdb98fea3
2023-09-14 07:45:23 -07:00
Aditya Sharat
134e1f6bfa
Renames debug event attributes and deduplicate them
...
Summary: Renames debug event attributes and deduplicate them
Reviewed By: pentiumao
Differential Revision: D49268777
fbshipit-source-id: 62f707424bb62e95a0d372307e7bf71ff770e554
2023-09-14 07:45:23 -07:00
Aditya Sharat
ba94a2416c
Renames global key to key
...
Summary: Renames global key to key
Reviewed By: pentiumao
Differential Revision: D49268637
fbshipit-source-id: 9c3e11ce78380048eed75d554170319e81892efd
2023-09-14 07:45:23 -07:00
Lorenzo Blasa
8062e2c9e5
Generate auth token
...
Summary: Generate auth token on whenever we load the secure server config, and add more logs.
Reviewed By: antonk52
Differential Revision: D49272857
fbshipit-source-id: 1e549a8bfd7926e9a44b9480432e92ee3c0162b2
2023-09-14 07:04:59 -07:00
Andrey Goncharov
1cf7160b2c
Add same_as_absolute_date_no_time operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49232775
fbshipit-source-id: 0ad6fafdd998f79a8b96bf9cd9d6e012e6e3a492
2023-09-14 04:48:12 -07:00
Andrey Goncharov
7d90493148
Add older_than_absolute_date_no_time operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49232776
fbshipit-source-id: 1083c277c78cd6eb2bae069966a9de290aa71930
2023-09-14 04:48:12 -07:00
Andrey Goncharov
ea1d2e9813
Add older_than_absolute_date operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49232777
fbshipit-source-id: ec82faca4690d099c6c9d0427c569bfe2a9dd233
2023-09-14 04:48:12 -07:00
Andrey Goncharov
7a6d895aa8
Add newer_than_absolute_date_no_time operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49232773
fbshipit-source-id: 96ab2d0d5cc804c1fcf1e64475fd68de60fa797a
2023-09-14 04:48:12 -07:00
Andrey Goncharov
ad6b3ed4f9
Add newer_than_absolute_date operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49232772
fbshipit-source-id: 578378faffd83da10df103715734603c67bebb83
2023-09-14 04:48:12 -07:00
Andrey Goncharov
51073bc665
Add float_equals operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230150
fbshipit-source-id: 976055a555d02ea61e29b4f2e939c9c89e44fd49
2023-09-14 04:48:12 -07:00
Andrey Goncharov
a0f02c57e4
Add int_equals operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230145
fbshipit-source-id: 3fa4332ca3129a2a652cf2c33a4383f100d50e33
2023-09-14 04:48:12 -07:00
Andrey Goncharov
3a4dada2fc
Add is_nullish operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230135
fbshipit-source-id: 1f7d88512eb3ed592eb406f0950ffa0c6985772c
2023-09-14 04:48:12 -07:00
Andrey Goncharov
75884674e0
Add enum_is_not operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230146
fbshipit-source-id: 66ab340b52a1de1935b4d2f1ef4bc81dc16310f0
2023-09-14 04:48:12 -07:00
Andrey Goncharov
6857e1fb26
Add enum_set_is_none_of operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230148
fbshipit-source-id: b0aa4e702b27359e513b2557c80b6bab529618d5
2023-09-14 04:48:12 -07:00
Andrey Goncharov
12179a35da
Add enum_set_is_any_of operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230147
fbshipit-source-id: a020d182a36affe65ed9ab3eb6a1197ddd12270b
2023-09-14 04:48:12 -07:00
Andrey Goncharov
61160a2d4b
Add enum_is operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49230138
fbshipit-source-id: f20a1a053cc6370acec57e63df80691c64bffc90
2023-09-14 04:48:12 -07:00
Andrey Goncharov
1618404d25
Add float_less_or_equal operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230133
fbshipit-source-id: ff55224698c71273b4b9f78afe3df58caa9561dc
2023-09-14 04:48:12 -07:00
Andrey Goncharov
db60ec0fa1
Add float_less_than operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230142
fbshipit-source-id: b49af428d75f749142f2aa87c8b863c379f53c27
2023-09-14 04:48:12 -07:00
Andrey Goncharov
70a46ddcc6
Add float_greater_or_equal operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230137
fbshipit-source-id: 19c97bd850b065f4c203c257ce9f0a3f33bb1eb2
2023-09-14 04:48:12 -07:00
Andrey Goncharov
467a4591b0
Add float_greater_than operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: antonk52
Differential Revision: D49230130
fbshipit-source-id: 31755bc19d4bb7a397c361f5d0e236e08c945cd1
2023-09-14 04:48:12 -07:00
Andrey Goncharov
092e9e7a72
Add int_less_or_equal operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49230140
fbshipit-source-id: 0fd825eb38f64e67ebdd4bca4846aae440b95981
2023-09-14 04:48:12 -07:00
Andrey Goncharov
8d4c8486e5
Add int_less_than operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49230143
fbshipit-source-id: d1551a9a472bdb9dafe61259e88bb50fa8b79153
2023-09-14 04:48:12 -07:00
Andrey Goncharov
18ae536dc3
Add int_greater_or_equal operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa, antonk52
Differential Revision: D49230132
fbshipit-source-id: ac0e32e4d83d45d18a03dc2b95c4d0d546f86372
2023-09-14 04:48:12 -07:00
Andrey Goncharov
df37187b6b
Add int_greater_than operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230136
fbshipit-source-id: e3ebcc1d501a31a3d7076ad2d013b66ec69ea935
2023-09-14 04:48:12 -07:00
Andrey Goncharov
43b2effdda
Add string_set_contains_none_of operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230131
fbshipit-source-id: 9c4375e181b2ac20b5ab346c2e5f24c6d90c28ac
2023-09-14 04:48:12 -07:00
Andrey Goncharov
a27f4580a3
Add string_set_contains_any_of operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230134
fbshipit-source-id: aa8c4494e707dfbf70568517a50c1f5803fce32a
2023-09-14 04:48:12 -07:00
Andrey Goncharov
17903c22f4
Add string_not_matches_exactly operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230141
fbshipit-source-id: 7dc7bfa06ab413642385c63b1eb25ef2ef69ef43
2023-09-14 04:48:12 -07:00
Andrey Goncharov
113e2a90ad
Add string_matches_exactly operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230149
fbshipit-source-id: 7d66733d0ff311a82f9bc5673a2fb204d3ae6a9a
2023-09-14 04:48:12 -07:00
Andrey Goncharov
3206649a29
Add string_not_contains operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230139
fbshipit-source-id: 23d0f9f8f50906c940764e3e9e5382ead9be9d35
2023-09-14 04:48:12 -07:00
Andrey Goncharov
ceac388eed
Add string_contains operator
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49226934
fbshipit-source-id: 12d43334e87b0fb502173143d5a19a48cd2fc9ee
2023-09-14 04:48:12 -07:00
Andrey Goncharov
589937bc8f
Add boilerplate for data table power search config and processors
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49230144
fbshipit-source-id: d6e6dfb340fd23c8655e331869600cb474c8e8bc
2023-09-14 04:48:12 -07:00
Andrey Goncharov
f897ab9487
Add DataTable wirh PowerSearch integrated
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D49225985
fbshipit-source-id: ea121c88f4f2275bb15b116858951a8bd2f43cc3
2023-09-14 04:48:12 -07:00
Andrey Goncharov
af73cbb669
Add power search config to data table column config
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D48866308
fbshipit-source-id: 72ed7eb1401e44722d9bb9e680d6fa5d558b8eed
2023-09-14 04:48:12 -07:00
Andrey Goncharov
cb5b3d9f28
Create a separate DataTableWithPowerSearch component
...
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7
Reviewed By: lblasa
Differential Revision: D48866151
fbshipit-source-id: c35fa7adb878b7d85782edd37591e2983a96b66a
2023-09-14 04:48:12 -07:00
Lorenzo Blasa
2b4c631652
Certificate and token generation fixes
...
Summary:
A few things need to be done which are on this change:
- Certificate generation should execute as an atomic operation, hence, it needs to be synchronised.
- Do not generate client token as part of certificate generation. This causes a deadlock now.
- Add more logs for troubleshooting
Reviewed By: aigoncharov
Differential Revision: D49269624
fbshipit-source-id: 071a8e5b895198730b7d914cc4622837e9094e2f
2023-09-14 04:15:18 -07:00
Lorenzo Blasa
cf599f9c3c
Move launch further down, temporarily
...
Summary: Attempt to fix an ongoing issue whereas there's a race condition generating certificates
Reviewed By: passy
Differential Revision: D49237915
fbshipit-source-id: 2383b20cb6ba786166d5e70206b5fff846ed1211
2023-09-13 11:52:46 -07:00
generatedunixname89002005306973
58c891b1d2
Flipper Snapshot Bump: v0.217.1-SNAPSHOT
...
Summary: Releasing snapshot version 0.217.1-SNAPSHOT
Reviewed By: lblasa
Differential Revision: D49227619
fbshipit-source-id: 7e0bdb048f825905f310a88de77892e0b5ae254c
2023-09-13 06:56:59 -07:00
generatedunixname89002005306973
879c57fb34
Flipper Release: v0.217.0
...
Summary: Releasing version 0.217.0
Reviewed By: lblasa
Differential Revision: D49227620
fbshipit-source-id: ac587ecb7f4821d55d123f99c16336e74e276fd4
2023-09-13 06:56:59 -07:00
Lorenzo Blasa
e80843d433
Modal visible -> open
...
Summary: The `visible` prop is marked as deprecated in favour of `open`
Reviewed By: passy
Differential Revision: D49226821
fbshipit-source-id: 4a4a7d03a1c8ff860c4e4cd02e19071185a8554e
2023-09-13 05:19:13 -07:00
Pascal Hartig
860af1eff7
Fix duplicate key for emulator launcher
...
Summary: Shows up in the console as a warning. Easy to fix.
Reviewed By: lblasa
Differential Revision: D49189263
fbshipit-source-id: 40428434803db708789811352b76004549d8c086
2023-09-13 04:07:14 -07:00
Lorenzo Blasa
4cdbfff7fb
Remove useless tag
...
Summary: ^
Reviewed By: antonk52
Differential Revision: D49193961
fbshipit-source-id: a51bd8b274a7f6f3bf3cdd7d3ff665430bf7bc3a
2023-09-13 04:06:58 -07:00
Lorenzo Blasa
3292945887
Launch should be blocking and at a later stage
...
Summary: This should be a blocking call and done later as it depends on the FlipperServerConfig to be set.
Reviewed By: antonk52
Differential Revision: D49193650
fbshipit-source-id: 4f74ca5de30b7f992880bbb9032792fd713203b7
2023-09-13 04:06:58 -07:00
Lorenzo Blasa
dd6cef66f6
Do not log token
...
Summary: Don't log it, otherwise it may end up in Scuba, we don't want that.
Reviewed By: antonk52
Differential Revision: D49187133
fbshipit-source-id: 38d4ea0801a9abbc463c23340e23f8b55e0d22f3
2023-09-13 04:06:58 -07:00
Lorenzo Blasa
93d94c9fc3
More logs around certificates and token generation
...
Summary: Useful for triaging defects
Reviewed By: passy
Differential Revision: D49186779
fbshipit-source-id: 743746444ce6e28753434a63d1bee2989cf4f66a
2023-09-13 04:06:58 -07:00
Anton Kastritskiy
a52757aadf
include validating @types/* packages' major version in flipper lint ci
...
Summary: `lint` is already called by CI. No further work is needed.
Reviewed By: LukeDefeo, passy
Differential Revision: D49188675
fbshipit-source-id: 731c21567af329fab4125869bcbea8cc9561a5d3
2023-09-12 08:26:22 -07:00