e104a1fa6bded176d1eb8d756fdea51a9c8e533d
10 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
91b501d0ed |
Bump antd from 4.6.6 to 4.9.1 in /desktop (#1734)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.6.6 to 4.9.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.9.1</h2> <ul> <li>TypeScript <ul> <li>� Fix Collapse.Panel <code>collapsible</code> property to optional. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092">#28092</a> <a href="https://github.com/sammarks">sammarks</a></li> </ul> </li> </ul> <hr /> <ul> <li>TypeScript <ul> <li>� 修复 Collapse.Panel 可折叠属性 <code>collapsible</code> 为可选。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092">#28092</a> <a href="https://github.com/sammarks">sammarks</a></li> </ul> </li> </ul> <h2>4.9.0</h2> <ul> <li>Modal <ul> <li>{emoji:1f195} Modal support <code>focusTriggerAfterClose</code> to disable auto focus back. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985">#27985</a> <a href="https://github.com/molokovev">molokovev</a></li> <li>{emoji:1f41e} Fix Modal hooks not trigger <code>onCancel</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063">#28063</a> <a href="https://github.com/JuniorTour">JuniorTour</a></li> <li>{emoji:1f41e} Fix Modal sometime not popup from the click position. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037">#28037</a></li> <li>{emoji:1f195} Support <code>closable</code> and <code>closeIcon</code> api for Modal.method. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909">#27909</a> <a href="https://github.com/MrHeer">MrHeer</a></li> </ul> </li> <li>{emoji:1f484} Reduce Table selection column width to <code>32px</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073">#28073</a></li> <li>Image <ul> <li>{emoji:1f525} Image add PreviewGroup component to support multiple images preview. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069">#28069</a></li> <li>{emoji:1f41e} Fix Image style prop not acting on img element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446">#27446</a></li> </ul> </li> <li>Collapse <ul> <li>{emoji:1f525} Collapse support <code>collapsible</code> to customize trigger region and deprecated Panel <code>disabled</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790">#27790</a></li> <li>{emoji:1f41e} Fix Collapse cannot contains <code><Table sticky /></code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039">#28039</a></li> </ul> </li> <li>{emoji:1f41e} Fix Cascader bug that empty data can be selected. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28062">#28062</a> <a href="https://github.com/n0ruSh">n0ruSh</a></li> <li>{emoji:1f195} Alert support <code>action</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/25892">#25892</a> <a href="https://github.com/jesse3mh9a">jesse3mh9a</a></li> <li>{emoji:1f525} Tree refactor drag behavior. Add <code>dropIndicatorRender</code> and <code>allowDrop</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/26462">#26462</a> <a href="https://github.com/07akioni">07akioni</a></li> <li>{emoji:1f195} Space support <code>wrap</code> for auto break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27910">#27910</a></li> <li>{emoji:1f195} Descriptions.Item support <code>labelStyle</code> & <code>contentStyle</code> props. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27897">#27897</a></li> <li>{emoji:1f195} Form.List support <code>initialValue</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27872">#27872</a></li> <li>{emoji:1f195} Menu supports <code>expandIcon</code>, and optimize default expand icon style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27565">#27565</a></li> <li>{emoji:1f195} Input and TextArea add <code>setSelectionRange</code> of <code>ref</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27584">#27584</a> <a href="https://github.com/appleshell">appleshell</a></li> <li>{emoji:1f195} Select support <code>filterSort</code> to order the filtered options. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27523">#27523</a> <a href="https://github.com/n0ruSh">n0ruSh</a></li> <li>{emoji:1f1f0_1f1ff} Add Kazakh locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27589">#27589</a> <a href="https://github.com/nodkz">nodkz</a></li> </ul> <hr /> <ul> <li>Modal <ul> <li>{emoji:1f195} Modal 支持 <code>focusTriggerAfterClose</code> 以关闭自动恢复焦点的功能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985">#27985</a> <a href="https://github.com/molokovev">molokovev</a></li> <li>{emoji:1f41e} 修复 Modal hooks 没有触发 <code>onCancel</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063">#28063</a> <a href="https://github.com/JuniorTour">JuniorTour</a></li> <li>{emoji:1f41e} 修复 Modal 有时不在点击位置弹出的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037">#28037</a></li> <li>{emoji:1f195} Modal.method 支持 <code>closable</code> 和 <code>closeIcon</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909">#27909</a> <a href="https://github.com/MrHeer">MrHeer</a></li> </ul> </li> <li>{emoji:1f484} 减少 Table 选中列宽度至 <code>32px</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073">#28073</a></li> <li>Image <ul> <li>{emoji:1f525} Image 增加 PreviewGroup 组件支持多张图片预览。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069">#28069</a></li> <li>{emoji:1f41e} 修复 Image style 属性未作用于 img 元素的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446">#27446</a></li> </ul> </li> <li>Collapse <ul> <li>{emoji:1f525} Collapse 添加 <code>collapsible</code> 以支持指定可折叠触发区域并废弃 Panel 的 <code>disabled</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790">#27790</a></li> <li>{emoji:1f41e} 修复 Collapse 内使用 <code><Table sticky /></code> 时不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039">#28039</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.9.1</h2> <p><code>2020-12-01</code></p> <ul> <li>TypeScript <ul> <li>� Fix Collapse.Panel <code>collapsible</code> property to optional. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092">#28092</a> <a href="https://github.com/sammarks">sammarks</a></li> </ul> </li> </ul> <h2>4.9.0</h2> <p><code>2020-11-30</code></p> <ul> <li>Modal <ul> <li>{emoji:1f195} Modal support <code>focusTriggerAfterClose</code> to disable auto focus back. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985">#27985</a> <a href="https://github.com/molokovev">molokovev</a></li> <li>{emoji:1f41e} Fix Modal hooks not trigger <code>onCancel</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063">#28063</a> <a href="https://github.com/JuniorTour">JuniorTour</a></li> <li>{emoji:1f41e} Fix Modal sometime not popup from the click position. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037">#28037</a></li> <li>{emoji:1f195} Support <code>closable</code> and <code>closeIcon</code> api for Modal.method. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909">#27909</a> <a href="https://github.com/MrHeer">MrHeer</a></li> </ul> </li> <li>{emoji:1f484} Reduce Table selection column width to <code>32px</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073">#28073</a></li> <li>Image <ul> <li>{emoji:1f525} Image add PreviewGroup component to support multiple images preview. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069">#28069</a></li> <li>{emoji:1f41e} Fix Image style prop not acting on img element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446">#27446</a></li> </ul> </li> <li>Collapse <ul> <li>{emoji:1f525} Collapse support <code>collapsible</code> to customize trigger region and deprecated Panel <code>disabled</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790">#27790</a></li> <li>{emoji:1f41e} Fix Collapse cannot contains <code><Table sticky /></code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039">#28039</a></li> </ul> </li> <li>{emoji:1f41e} Fix Cascader bug that empty data can be selected. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28062">#28062</a> <a href="https://github.com/n0ruSh">n0ruSh</a></li> <li>{emoji:1f195} Alert support <code>action</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/25892">#25892</a> <a href="https://github.com/jesse3mh9a">jesse3mh9a</a></li> <li>{emoji:1f525} Tree refactor drag behavior. Add <code>dropIndicatorRender</code> and <code>allowDrop</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/26462">#26462</a> <a href="https://github.com/07akioni">07akioni</a></li> <li>{emoji:1f195} Space support <code>wrap</code> for auto break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27910">#27910</a></li> <li>{emoji:1f195} Descriptions.Item support <code>labelStyle</code> & <code>contentStyle</code> props. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27897">#27897</a></li> <li>{emoji:1f195} Form.List support <code>initialValue</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27872">#27872</a></li> <li>{emoji:1f195} Menu supports <code>expandIcon</code>, and optimize default expand icon style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27565">#27565</a></li> <li>{emoji:1f195} Input and TextArea add <code>setSelectionRange</code> of <code>ref</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27584">#27584</a> <a href="https://github.com/appleshell">appleshell</a></li> <li>{emoji:1f195} Select support <code>filterSort</code> to order the filtered options. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27523">#27523</a> <a href="https://github.com/n0ruSh">n0ruSh</a></li> <li>{emoji:1f1f0_1f1ff} Add Kazakh locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27589">#27589</a> <a href="https://github.com/nodkz">nodkz</a></li> </ul> <h2>4.8.6</h2> <p><code>2020-11-27</code></p> <ul> <li>{emoji:1f41e} Fix Badge style blink when mounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28003">#28003</a></li> <li>{emoji:1f484} Reduce Modal style size. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27998">#27998</a></li> <li>{emoji:1f41e} Fix Layout.Sider can not collapse when <code>width='0'</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28000">#28000</a></li> <li>{emoji:1f41e} Fix Menu style when using none Ant Design icons. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27983">#27983</a></li> <li>Input <ul> <li>{emoji:1f41e} Fix Input.Search button height when customize less variables. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27986">#27986</a></li> <li>{emoji:1f41e} Fix Input.Search <code>addonBefore</code> abnormal style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27960">#27960</a></li> </ul> </li> <li>{emoji:1f41e} Fix Typography.Link clicking copy button will redirect. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27982">#27982</a></li> <li>{emoji:1f41e} Fix Carousel throws error <code>Unable to preventDefault inside passive event listener</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27957">#27957</a></li> <li>{emoji:1f310} Improve data picker locale for <code>en_GB</code> and <code>zh_TW</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28016">#28016</a> <a href="https://github.com/abz53378">abz53378</a></li> <li>RTL <ul> <li>{emoji:1f484} Optimize the border style of Descriptions in RTL model. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28010">#28010</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Michel Weststrate
|
dd6f39c2b3 |
Wire up Tracking to different ant.design elements
Summary:
This wires up tracking directly to the ANT component library for the following components:
1. `Button`
2. `Collapse.Panel`
3. `Tabs`
Other less commonly used elements can be connected in the future if needed.
I played a bit with different patterns, but in testing the patch-package patching give the most reliable results. Alternatives considered:
1. Expect users to explicitly wrap there components, e.g. `<Tracked><Button>Hi</Button></Tracked>`
1. Didn't implement this because it would be very common to forget, and at the moment you want to make some analysis you'll discover there is no interesting data available. I think for tracking we want to have opt-out rather than opt-in
2. The additional wrapping can cause some subtile layout issues due to static field inspection / forwarded refs (e.g. Ant often has an assumption that relevant children types are _directly_ nested under their parent element. For examle `<Tooltip><Tracked><Button>` does not work as expected
2. Expose our own `Button` / `Collapse` / `Tabs` that applies `Tracked` to an underlying Ant component.
1. also suffers from 1.b.
2. It is gonna be quite confusing for other devs that some elements would need to be imported from `flipper-plugin`, ant some from `antd`, and that this is likely to change over time. We could lint against it, but it will be still suboptimal
Reviewed By: jknoxville
Differential Revision: D25196321
fbshipit-source-id: b559356498c3191a283062a88daacb354b0f79f4
|
||
|
dependabot[bot]
|
35a433d1a3 |
Bump metro from 0.60.0 to 0.63.0 in /desktop (#1606)
Summary: Bumps [metro](https://github.com/facebook/metro) from 0.60.0 to 0.63.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro's releases</a>.</em></p> <blockquote> <h2>Release v0.63.0</h2> <ul> <li>[fix] Change initialisation logo and text from RN to Metro</li> </ul> <h2>Release v0.62.0</h2> <ul> <li>[feature] Add onBundleBuilt to ServerOptions</li> </ul> <h2>Release v0.61.0</h2> <p>Contains all changes since 0.60.0:</p> <ul> <li>[Feature]: Add support for blockList and array of regexs</li> <li>[Fix]: Change order of imports to be the same as in source files</li> <li>[Feature]: Add new secureServerOptions option to runServer</li> <li>[Feature]: Add inline-requires option</li> <li>[PetPeeve]: Metro server => Metro</li> </ul> <p>See <a href="https://github.com/facebook/metro/compare/0.60.0...0.61.0">0.59.0...0.60.0</a> for a full list of changes.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Anton Nikolaev
|
30213e118f |
Update Metro to 0.60.0 (#1380)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/1380 Updated Metro to 0.60.0 Reviewed By: mweststrate Differential Revision: D22453798 fbshipit-source-id: 14c5bacf88bc31bd3dd06ad42edf271769a4a669 |
||
|
Anton Nikolaev
|
a2e77f5da0 |
Patch metro to avoid erasing "process" global var
Summary: Patch for "metro" to avoid erasing of "process" global var during bundling. Also removed "process" babel transform for main Electron process which was also made to workaround the same issue with "process" being erased. Reviewed By: mweststrate Differential Revision: D22389153 fbshipit-source-id: 569882e20534eedfca45509b8efe0186d335c681 |
||
|
Michel Weststrate
|
89de3d4ae2 |
Disable require cycle warnings
Summary: The holier-than-thou warnings of metro about require cycles are annoying. Require cycles are generally speaking well handles by ESM, and cause only harm if modules themselves are stateful, which is a bad smell. But warning for every cycle is just a flooding of false positives and removes the insentive to drop actual warnings. Reviewed By: jknoxville Differential Revision: D21859908 fbshipit-source-id: 66ec9a619a3737ccab5b16d11be5623d1d97c9f6 |
||
|
Anton Nikolaev
|
ec7cbd7f14 |
Fixed the patch disabling warnings for cyclic dependencies inside node_modules
Summary: Fixed the patch disabling warnings for cyclic dependencies inside node_modules. It broke after I changed the way of bundling plugins. Reviewed By: passy Differential Revision: D21065488 fbshipit-source-id: f8891f007d14d2475df517b28452dc0b8346f113 |
||
|
Anton Nikolaev
|
627cc8fe7f |
Update Metro
Summary: Updated Metro to the latest version 0.59.0 Reviewed By: passy Differential Revision: D21027614 fbshipit-source-id: 0b2c1c422dfed7e8426bb9a36c5626f3a96eb8f6 |
||
|
Anton Nikolaev
|
527d417ab4 |
Suppress Metro warning about cyclic dependencies in node_modules
Summary: Metro shows cyclic dependencies warnings in dev mode even if they are caused by 3rd party packages installed into node_modules. This produces a lot of noise, but totally unactionable. In this diff I have implemented patch for "metro" package wich disables these unactionable warnings. Reviewed By: passy Differential Revision: D20835057 fbshipit-source-id: 2aebc59a0f8c0adfc768ed4c170e5d0b9ced7e0e |
||
|
Anton Nikolaev
|
85c13bb1f3 |
Move desktop-related code to "desktop" subfolder (#872)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/872 Move all the JS code related to desktop app to "desktop" subfolder. The structure of "desktop" folder: - `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins". - `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process - `pkg` - Flipper packaging lib and CLI tool - `doctor` - Flipper diagnostics lib and CLI tool - `scripts` - Build scripts for Flipper desktop app - `headless` - Headless version of Flipper app - `headless-tests` - Integration tests running agains Flipper headless version Reviewed By: passy Differential Revision: D20249304 fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9 |