Commit Graph

8 Commits

Author SHA1 Message Date
John Knox
0a0aec17ca Don't allow rejecting with non-error objects
Summary: This will make it easier to handle errors, because you know you can get the message out, along with stack trace, without having to deal with potentially any object that could be passed in.

Reviewed By: passy

Differential Revision: D16006180

fbshipit-source-id: f200965d7663c5f8a471603fceb6b4cdbea73381
2019-06-26 09:59:26 -07:00
Pascal Hartig
703f43a903 Declare prettier the winner
Summary:
There's been an ongoing fight between eslint and prettier.
You win, prettier.

Reviewed By: danielbuechele

Differential Revision: D14799153

fbshipit-source-id: a4f0546a3a468bb21fed47d61bc14bd7e6f0b185
2019-04-05 09:41:37 -07:00
Pascal Hartig
aa365b990b Restore "fb" preset (#363)
Summary:
I must have run this locally on an outdated version of eslint or the
plugin, because I did not see all the formatting errors. This is because
`eslint-plugin-prettier` dropped support for the `fb` preset (see https://github.com/prettier/eslint-plugin-prettier/pull/113/files). This restores the equivalent ruleset explicitly.
Pull Request resolved: https://github.com/facebook/flipper/pull/363

Reviewed By: danielbuechele

Differential Revision: D13839021

Pulled By: passy

fbshipit-source-id: 59e27a241e8aada8648b175ab8abbdfbd391556e
2019-01-28 07:07:28 -08:00
Pascal Hartig
1b9c32b103 Upgrade to ESLint 5
Summary:
Wanted to do that for a while, but the previous eslint error
blocked me. Continues running with the same level or warnings.

Reviewed By: jknoxville

Differential Revision: D13818478

fbshipit-source-id: ac12888dd4177316020c947925d4ff9d64784140
2019-01-28 04:51:06 -08:00
Daniel Büchele
7825d9247c optional chaining
Summary: Adds support for optional chaining to the codebase, enables flow and eslint support for it.

Reviewed By: passy

Differential Revision: D9940732

fbshipit-source-id: 730aa76653bd22a8fa17a73e72b3a7329de0226c
2018-09-20 04:27:48 -07:00
Daniel Buchele
6fda334a00 fbshipit-source-id: 5d9ecf33fca19e4a6b8c979b879ec9dd82af1ef9 2018-06-25 04:33:04 -07:00
Michael Evans
86d266e75c Fix yarn lint failures
Summary: Closes https://github.com/facebook/Sonar/pull/20

Reviewed By: jknoxville

Differential Revision: D8378657

Pulled By: danielbuechele

fbshipit-source-id: 51dcc4621d657dee089949caf3ebf1961eb3dd6d
2018-06-12 05:10:35 -07:00
Daniel Büchele
fbbf8cf16b Initial commit 🎉
fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2
Co-authored-by: Sebastian McKenzie <sebmck@fb.com>
Co-authored-by: John Knox <jknox@fb.com>
Co-authored-by: Emil Sjölander <emilsj@fb.com>
Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>
2018-06-01 11:03:58 +01:00