Pascal Hartig
dc6dd47a23
Make openssl check async
...
Summary:
This was the last eslint warning for `flipper-server-core` and the only call-site
was async already.
Reviewed By: mweststrate
Differential Revision: D32026626
fbshipit-source-id: 0d6f06086c33707b26f58f668ad533daca9de7dd
2021-11-03 05:40:04 -07:00
Michel Weststrate
72ce759e61
Remove some unhandled rejections in tests
...
Summary: Fixed several tests that caused uncaught promise rejects to fire after the tests finished. This caused jest to fail if there are too many of them.
Reviewed By: aigoncharov
Differential Revision: D32118124
fbshipit-source-id: 50734dab6dee2efec7f056940af72858b27b1707
2021-11-03 03:14:08 -07:00
Michel Weststrate
8f3e729b7b
Bump electron-builder
...
Summary: `yarn build --mac` started failing with errors. This fixes it. Probable root cause: https://github.com/electron-userland/electron-builder/issues/5668
Reviewed By: aigoncharov
Differential Revision: D32101006
fbshipit-source-id: 50011f8be8079bd96c8f602002ccb500c3ad4794
2021-11-02 09:19:41 -07:00
Juan Tejada
763a29d799
Update React Devtools v4.21.0
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flippe, etc.
`js1 upgrade react-devtools -v 4.21.0`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.21.0
Reviewed By: bvaughn
Differential Revision: D32065685
fbshipit-source-id: 30d0cca2bec6e9abe384da2afefab1d241e0523f
2021-11-01 10:46:02 -07:00
Anton Kastritskiy
4a4cc21d89
Refine DataSource id to use actual key type instead of a wide string type
...
Summary: Current implementation uses type `string` as a key for indexing items stored in datasource. However, users can provide any key as an index which means that the type of index item can be anything, not only string. This diff introduces a more refined types for the key. It adds another requirement to provide a key property to a generic which is used to infer the index type.
Reviewed By: mweststrate, aigoncharov
Differential Revision: D31895751
fbshipit-source-id: 19ba907bd6f35df87e3fa442db5fc5cec6af174d
2021-10-28 10:44:01 -07:00
Michel Weststrate
64e791e253
Remove usage of Electron context menus
...
Summary: Removed the usage of electron's native context menus, and replaces it with Antd based context menu's.
Reviewed By: passy
Differential Revision: D31990756
fbshipit-source-id: 0312cbac5fd20a1a30603ce1058c03f4291b23b1
2021-10-28 07:41:00 -07:00
Michel Weststrate
25590e14b9
Move Electron stuff to separate folder, decapitate restart
...
Summary: Per title
Reviewed By: passy
Differential Revision: D31991715
fbshipit-source-id: 9ca58cdd26c1f540fbe09dcfc7b7f5e7a319ea7d
2021-10-28 07:41:00 -07:00
dependabot[bot]
7a19b1c8d4
Bump ws from 7.5.5 to 8.2.3 in /desktop ( #3004 )
...
Summary:
Bumps [ws](https://github.com/websockets/ws ) from 7.5.5 to 8.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/websockets/ws/releases ">ws's releases</a>.</em></p>
<blockquote>
<h2>8.2.3</h2>
<h1>Bug fixes</h1>
<ul>
<li>When context takeover is enabled, messages are now compressed even if their size
is below the value of the <code>perMessageDeflate.threshold</code> option (41ae5631).</li>
</ul>
<h2>8.2.2</h2>
<h1>Bug fixes</h1>
<ul>
<li>Some closing operations are now run only if needed (ec9377ca).</li>
</ul>
<h2>8.2.1</h2>
<h1>Bug fixes</h1>
<ul>
<li>Fixed an issue where the socket was not resumed, preventing the connection
from being closed cleanly (869c9892).</li>
</ul>
<h2>8.2.0</h2>
<h1>Features</h1>
<ul>
<li>Added <code>WebSocket.WebSocket</code> as an alias for <code>WebSocket</code> and
<code>WebSocket.WebSocketServer</code> as an alias for <code>WebSocket.Server</code> to fix name
consistency and improve interoperability with the ES module wrapper (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1935 ">https://github.com/facebook/flipper/issues/1935 </a>).</li>
</ul>
<h2>8.1.0</h2>
<h1>Features</h1>
<ul>
<li>Added ability to skip UTF-8 validation (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1928 ">https://github.com/facebook/flipper/issues/1928 </a>).</li>
</ul>
<h1>Bug fixes</h1>
<ul>
<li>Fixed an issue with a breaking change in Node.js master (6a72da3e).</li>
<li>Fixed a misleading error message (c95e695d).</li>
</ul>
<h2>8.0.0</h2>
<h1>Breaking changes</h1>
<ul>
<li>The <code>WebSocket</code> constructor now throws a <code>SyntaxError</code> if any of the
subprotocol names are invalid or duplicated (0aecf0c9).</li>
<li>The server now aborts the opening handshake if an invalid
<code>Sec-WebSocket-Protocol</code> header field value is received (1877ddeb).</li>
<li>The <code>protocols</code> argument of <code>handleProtocols</code> hook is no longer an <code>Array</code> but
a <code>Set</code> (1877ddeb).</li>
<li>The opening handshake is now aborted if the <code>Sec-WebSocket-Extensions</code> header
field value is empty or it begins or ends with a white space (e814110e).</li>
<li>Dropped support for Node.js < 10.0.0 (552b5067).</li>
<li>The <code>WebSocket</code> constructor now throws a <code>SyntaxError</code> if the connection URL
contains a fragment identifier or if the URL's protocol is not one of <code>'ws:'</code>,
<code>'wss:'</code>, or <code>'ws+unix:'</code> (ebea038f).</li>
<li>Text messages and close reasons are no longer decoded to strings. They are</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cfd99b6309fef7942a1841ae56313b474aa3616f055949fd235b85322f54f871195c5572296e54ca3039b6b9d204c032c51bhttps://github.com/websockets/ws/compare/7.5.5...8.2.3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3004
Reviewed By: passy
Differential Revision: D31991546
Pulled By: cekkaewnumchai
fbshipit-source-id: 029092fa88e0c4a0816574c6c18e5565b9650615
2021-10-28 06:18:12 -07:00
dependabot[bot]
66661ca4fa
Bump socket.io from 4.1.3 to 4.3.1 in /desktop ( #3003 )
...
Summary:
Bumps [socket.io](https://github.com/socketio/socket.io ) from 4.1.3 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases ">socket.io's releases</a>.</em></p>
<blockquote>
<h2>4.3.1</h2>
<h3>Bug Fixes</h3>
<ul>
<li>fix server attachment (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4127 ">#4127</a>) (<a href="0ef2a4d02chttps://github.com/socketio/socket.io/compare/4.3.0...4.3.1 ">https://github.com/socketio/socket.io/compare/4.3.0...4.3.1 </a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.1 ">4.3.1</a></li>
<li>engine.io version: <code>~6.0.0</code></li>
<li>ws version: <code>~8.2.3</code></li>
</ul>
<h2>4.3.0</h2>
<p>For this release, most of the work was done on the client side, see <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.0 ">here</a>.</p>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> add name field to cookie option (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4099 ">#4099</a>) (<a href="033c5d399adc81fcf46160edecb3bdhttps://github.com/socketio/socket.io/compare/4.2.0...4.3.0 ">https://github.com/socketio/socket.io/compare/4.2.0...4.3.0 </a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.0 ">4.3.0</a></li>
<li>engine.io version: <code>~6.0.0</code> (<a href="https://github.com/socketio/engine.io/compare/5.2.0...6.0.0 ">diff</a>)</li>
<li>ws version: <code>~8.2.3</code> (<a href="https://github.com/websockets/ws/compare/7.4.2...8.2.3 ">diff</a>)</li>
</ul>
<h2>4.2.0</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> allow async listener in typed events (<a href="ccfd8caba6https://github-redirect.dependabot.com/socketio/socket.io/issues/4024 ">#4024</a>) (<a href="24fee27ba3https://github.com/socketio/socket.io/compare/4.1.3...4.2.0 ">https://github.com/socketio/socket.io/compare/4.1.3...4.2.0 </a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.2.0 ">4.2.0</a></li>
<li>engine.io version: <code>~5.2.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md ">socket.io's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io/compare/4.3.0...4.3.1 ">4.3.1</a> (2021-10-16)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>fix server attachment (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4127 ">#4127</a>) (<a href="0ef2a4d02chttps://github.com/socketio/socket.io/compare/4.2.0...4.3.0 ">4.3.0</a> (2021-10-14)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> add name field to cookie option (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4099 ">#4099</a>) (<a href="033c5d399adc81fcf46160edecb3bdhttps://github.com/socketio/socket.io/compare/4.1.3...4.2.0 ">4.2.0</a> (2021-08-30)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> allow async listener in typed events (<a href="ccfd8caba6https://github-redirect.dependabot.com/socketio/socket.io/issues/4024 ">#4024</a>) (<a href="24fee27ba3ccc5ec39a80ef2a4d02chttps://github-redirect.dependabot.com/socketio/socket.io/issues/4127 ">#4127</a>)</li>
<li><a href="95810aa62d60edecb3bdeb5fdbd03e4974e9077chttps://github-redirect.dependabot.com/socketio/socket.io/issues/4115 ">#4115</a>)</li>
<li><a href="033c5d399ahttps://github-redirect.dependabot.com/socketio/socket.io/issues/4099 ">#4099</a>)</li>
<li><a href="7a74b66872dc81fcf461c100b7b61chttps://github.com/socketio/socket.io/compare/4.1.3...4.3.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3003
Reviewed By: passy
Differential Revision: D31991555
Pulled By: cekkaewnumchai
fbshipit-source-id: de5c8726d8ff0efd5bed7945697f58b8684f7048
2021-10-28 06:18:12 -07:00
dependabot[bot]
197614fd3e
Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.33.0 in /desktop ( #3000 )
...
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 4.31.0 to 4.33.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases "><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.33.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0 ">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [lines-between-class-members] fix <code>exceptAfterOverload</code> for abstract methods (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3943 ">#3943</a>) (<a href="240fc65c30https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3937 ">#3937</a>) (<a href="c40dd13df7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3947 ">#3947</a>) (<a href="edaa3c10ebhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3940 ">#3940</a>) (<a href="40760f98dahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3944 ">#3944</a>) (<a href="f8f534e42bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3946 ">#3946</a>) (<a href="0868725713https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3934 ">#3934</a>) (<a href="ee5dfd4989https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3949 ">#3949</a>) (<a href="f022fb14c7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3837 ">#3837</a>) (<a href="214f898178https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0 ">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [consistent-type-definitions] correct fix for <code>export default</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3899 ">#3899</a>) (<a href="ebb33ed8bchttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3871 ">#3871</a>) (<a href="8aa87a136ehttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3868 ">#3868</a>) (<a href="dda9cee68ahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3884 ">#3884</a>) (<a href="ed5e45983fhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3869 ">#3869</a>) (<a href="186135698bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3855 ">#3855</a>) (<a href="ffdb5ff990https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3852 ">#3852</a>) (<a href="9e98b8f43chttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3805 ">#3805</a>) (<a href="bdb8f0be14https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3887 ">#3887</a>) (<a href="806eaac6afhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3865 ">#3865</a>) (<a href="4195919973https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3349 ">#3349</a>) (<a href="4e999614e9https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3775 ">#3775</a>) (<a href="ec5d50696bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3916 ">#3916</a>) (<a href="13b7de508ehttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3873 ">#3873</a>) (<a href="25a42c0bbehttps://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2 ">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md "><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0 ">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [lines-between-class-members] fix <code>exceptAfterOverload</code> for abstract methods (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3943 ">#3943</a>) (<a href="240fc65c30https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3937 ">#3937</a>) (<a href="c40dd13df7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3947 ">#3947</a>) (<a href="edaa3c10ebhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3940 ">#3940</a>) (<a href="40760f98dahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3944 ">#3944</a>) (<a href="f8f534e42bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3946 ">#3946</a>) (<a href="0868725713https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0 ">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [consistent-type-definitions] correct fix for <code>export default</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3899 ">#3899</a>) (<a href="ebb33ed8bchttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3871 ">#3871</a>) (<a href="8aa87a136ehttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3868 ">#3868</a>) (<a href="dda9cee68ahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3884 ">#3884</a>) (<a href="ed5e45983fhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3869 ">#3869</a>) (<a href="186135698bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3855 ">#3855</a>) (<a href="ffdb5ff990https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3852 ">#3852</a>) (<a href="9e98b8f43chttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3805 ">#3805</a>) (<a href="bdb8f0be14https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3865 ">#3865</a>) (<a href="4195919973https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3349 ">#3349</a>) (<a href="4e999614e9https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3775 ">#3775</a>) (<a href="ec5d50696bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3916 ">#3916</a>) (<a href="13b7de508ehttps://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2 ">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="7bf8c9cb02edaa3c10eb0868725713https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3946 ">#3946</a>)</li>
<li><a href="f8f534e42b240fc65c3040760f98dac40dd13df735a8acfc52https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3921 ">#3921</a>)</li>
<li><a href="3c773e475bhttps://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3889 ">#3889</a>)</li>
<li><a href="02c6ff3c5ahttps://github.com/typescript-eslint/typescript-eslint/commits/v4.33.0/packages/eslint-plugin ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3000
Reviewed By: passy
Differential Revision: D31991585
Pulled By: cekkaewnumchai
fbshipit-source-id: 15ea4adeb250934dcc142915b1f4196e6e776abd
2021-10-28 06:18:12 -07:00
dependabot[bot]
cd2804c553
Bump eslint-plugin-promise from 5.1.0 to 5.1.1 in /desktop ( #3001 )
...
Summary:
Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise ) from 5.1.0 to 5.1.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/xjamundx/eslint-plugin-promise/commits ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3001
Reviewed By: passy
Differential Revision: D31991583
Pulled By: cekkaewnumchai
fbshipit-source-id: af1be4f0e2d70885d2d6622363a7433a786c7778
2021-10-28 06:18:12 -07:00
dependabot[bot]
7094475431
Bump split2 from 3.2.2 to 4.1.0 in /desktop ( #3002 )
...
Summary:
Bumps [split2](https://github.com/mcollina/split2 ) from 3.2.2 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mcollina/split2/releases ">split2's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What’s Changed</h2>
<ul>
<li>Add engines field. Add node 10.x to CI (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/52 ">https://github.com/facebook/flipper/issues/52 </a>) <a href="https://github.com/mcollina "><code>@mcollina</code></a></li>
</ul>
<h2>v4.0.0</h2>
<h2>What’s Changed</h2>
<ul>
<li>Update to node 12 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/50 ">https://github.com/facebook/flipper/issues/50 </a>) <a href="https://github.com/mcollina "><code>@mcollina</code></a></li>
<li>Upgrade to GitHub-native Dependabot (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/48 ">https://github.com/facebook/flipper/issues/48 </a>) <a href="https://github.com/dependabot-preview "><code>@dependabot-preview</code></a></li>
<li>Bump standard from 15.0.1 to 16.0.1 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/43 ">https://github.com/facebook/flipper/issues/43 </a>) <a href="https://github.com/dependabot-preview "><code>@dependabot-preview</code></a></li>
<li>Bump standard from 14.3.4 to 15.0.0 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/41 ">https://github.com/facebook/flipper/issues/41 </a>) <a href="https://github.com/dependabot-preview "><code>@dependabot-preview</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="06818424cbbeff8a031chttps://github-redirect.dependabot.com/mcollina/split2/issues/52 ">https://github.com/facebook/flipper/issues/52 </a>)</li>
<li><a href="b66af507caf662904a41https://github-redirect.dependabot.com/mcollina/split2/issues/50 ">https://github.com/facebook/flipper/issues/50 </a>)</li>
<li><a href="4a776ffa20https://github-redirect.dependabot.com/mcollina/split2/issues/48 ">https://github.com/facebook/flipper/issues/48 </a>)</li>
<li><a href="c3124e3d9bhttps://github-redirect.dependabot.com/mcollina/split2/issues/43 ">https://github.com/facebook/flipper/issues/43 </a> from mcollina/dependabot/npm_and_yarn/standard-16.0.1</li>
<li><a href="efe0ddd808bc6e5fc7fbhttps://github-redirect.dependabot.com/mcollina/split2/issues/41 ">https://github.com/facebook/flipper/issues/41 </a> from mcollina/dependabot/npm_and_yarn/standard-15.0.0</li>
<li><a href="03c7cecc3chttps://github.com/mcollina/split2/compare/v3.2.2...v4.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3002
Reviewed By: passy
Differential Revision: D31991563
Pulled By: cekkaewnumchai
fbshipit-source-id: 3a133ca1d60a0ec471147ac7af4c9772060c6e35
2021-10-28 06:18:11 -07:00
dependabot[bot]
3297c4f44b
Bump algoliasearch from 4.10.5 to 4.11.0 in /desktop ( #2998 )
...
Summary:
Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript ) from 4.10.5 to 4.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases ">algoliasearch's releases</a>.</em></p>
<blockquote>
<h2>4.11.0</h2>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0 ">v4.11.0</a></h2>
<ul>
<li>fix(insideBoundingBox): allow strings (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310 ">https://github.com/facebook/flipper/issues/1310 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/87d5b0d ">87d5b0d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310 ">https://github.com/facebook/flipper/issues/1310 </a></li>
<li>feat: add custom request function (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312 ">https://github.com/facebook/flipper/issues/1312 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3cea192 ">3cea192</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312 ">https://github.com/facebook/flipper/issues/1312 </a></li>
<li>feat(ts): document enableReRanking (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306 ">https://github.com/facebook/flipper/issues/1306 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/00ad924 ">00ad924</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306 ">https://github.com/facebook/flipper/issues/1306 </a></li>
<li>docs(recommend): add TSDoc (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305 ">https://github.com/facebook/flipper/issues/1305 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a5df2fb ">a5df2fb</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305 ">https://github.com/facebook/flipper/issues/1305 </a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md ">algoliasearch's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0 ">v4.11.0</a></h2>
<ul>
<li>fix(insideBoundingBox): allow strings (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310 ">https://github.com/facebook/flipper/issues/1310 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/87d5b0d ">87d5b0d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310 ">https://github.com/facebook/flipper/issues/1310 </a></li>
<li>feat: add custom request function (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312 ">https://github.com/facebook/flipper/issues/1312 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3cea192 ">3cea192</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312 ">https://github.com/facebook/flipper/issues/1312 </a></li>
<li>feat(ts): document enableReRanking (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306 ">https://github.com/facebook/flipper/issues/1306 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/00ad924 ">00ad924</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306 ">https://github.com/facebook/flipper/issues/1306 </a></li>
<li>docs(recommend): add TSDoc (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305 ">https://github.com/facebook/flipper/issues/1305 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a5df2fb ">a5df2fb</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305 ">https://github.com/facebook/flipper/issues/1305 </a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="9392aa43abhttps://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1313 ">https://github.com/facebook/flipper/issues/1313 </a>)</li>
<li><a href="dfe3eac629https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1314 ">https://github.com/facebook/flipper/issues/1314 </a>)</li>
<li><a href="8011c0ecb787d5b0d842https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310 ">https://github.com/facebook/flipper/issues/1310 </a>)</li>
<li><a href="3cea192c5chttps://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312 ">https://github.com/facebook/flipper/issues/1312 </a>)</li>
<li><a href="7c38e642b2https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1308 ">https://github.com/facebook/flipper/issues/1308 </a>)</li>
<li><a href="6223bf63f5https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1309 ">https://github.com/facebook/flipper/issues/1309 </a>)</li>
<li><a href="00ad9246a9https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306 ">https://github.com/facebook/flipper/issues/1306 </a>)</li>
<li><a href="a5df2fb905https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305 ">https://github.com/facebook/flipper/issues/1305 </a>)</li>
<li>See full diff in <a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2998
Reviewed By: mweststrate
Differential Revision: D31991634
Pulled By: cekkaewnumchai
fbshipit-source-id: 3e6f04390b542f2e51d42446f8758e2ed591bb9b
2021-10-28 06:18:11 -07:00
Pascal Hartig
2525a5efd4
Fix Flipper lints #9
...
Summary:
This introduces a few more lints in fact because I renamed the icon functions
to make clear that they use sync methods under the hood.
Reviewed By: timur-valiev
Differential Revision: D31964701
fbshipit-source-id: d0beb58b5b301f5428fdbfe8c65784df0d86eaad
2021-10-28 05:47:40 -07:00
Pascal Hartig
f8117240af
Fix async filtering ( #3008 )
...
Summary:
I relied too much on the types which in this case don't help at all.
Filtering on a promise will just automatically get all values to pass.
Pull Request resolved: https://github.com/facebook/flipper/pull/3008
Test Plan: `yarn build --mac` works again on the GH checkout.
Reviewed By: mweststrate
Differential Revision: D31991576
Pulled By: passy
fbshipit-source-id: f632d29ddfc09b7130b68b4b17264fd30e1969ce
2021-10-28 05:36:52 -07:00
Pascal Hartig
366c8f2681
Fix Flipper lints #9 1/n
...
Summary: Mostly ignoring things in this one because it's tests.
Reviewed By: timur-valiev
Differential Revision: D31955716
fbshipit-source-id: f799bf2b3eaae6753f41121264c777fdeda03165
2021-10-27 11:10:52 -07:00
Pascal Hartig
1b5cd3d2d5
Fix Flipper lints #12
...
Reviewed By: timur-valiev
Differential Revision: D31932981
fbshipit-source-id: 4cf905495494466462c0494116f56cd16773e549
2021-10-27 11:10:52 -07:00
Flipper Bot
360ecb4b24
Flipper Release: v0.117.0
...
Summary: Releasing version 0.117.0
Reviewed By: aigoncharov
Differential Revision: D31955241
fbshipit-source-id: 0a4c848c96bc63ebd1f4d642965693a1e3502f6c
2021-10-27 09:44:32 -07:00
Pascal Hartig
0f9698312a
Fix capitalization of method reference
...
Summary: Docs only.
Reviewed By: jknoxville
Differential Revision: D31928323
fbshipit-source-id: 14be8bf89215054e6561fc38f73040ccfae229c4
2021-10-27 02:48:07 -07:00
Michel Weststrate
9763af4c96
Decouple open/save dialogs, reload, shouldUseDarkColors from Electron
...
Summary: Per title. Less imports from Electron.
Reviewed By: timur-valiev, aigoncharov
Differential Revision: D31923504
fbshipit-source-id: dc7557cf7c88c0c8168ba22f7dca7b3e2d339a09
2021-10-26 12:07:22 -07:00
Daniel Parreira
9ef4303a1a
Add platform wizard when opening Flipper for first time
...
Summary: T103651722 - Added a first time wizard to pick the user platforms when the user opens it for the first time. The fact that the wizard was shown is stored in localstorage.
Reviewed By: mweststrate
Differential Revision: D31861286
fbshipit-source-id: a46c532520cd88a0c4c608d3ee314289f0407475
2021-10-25 15:05:04 -07:00
Daniel Kohli
fa7e8a6b37
Add max-width Style Prop to Tabs.tsx
...
Summary:
- We're using the `Tabs` component from `flipper-plugin` and upon adding them, we noticed that our view being displayed within the tabs no longer scrolled and the tab internally was being stretched far off the screen. (D31538124)
- After egp did some digging, he discovered that by adding the `maxWidth` style property to the inner `Layout.Container`, the tab no longer stretched and the scrolling was restored.
- We played around by adding wrapper elements around the contents of our Tab and adding the same style prop, but this did not yield the same result.
***Would Love some input from the Flipper team as to the best way to ensure that this won't break other's plugins. Thank you!***
Reviewed By: mweststrate
Differential Revision: D31672790
fbshipit-source-id: 99cab1873f359f4c1827e4c94f2527636884c237
2021-10-25 14:13:35 -07:00
Juan Tejada
2423423183
Update React DevTools v4.20.2
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.20.2`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.20.2
Reviewed By: lunaruan
Differential Revision: D31809278
fbshipit-source-id: 0360fe173cfc7ce09595e6db4e8e41c6f64becd7
2021-10-25 14:00:42 -07:00
Lorenzo Blasa
ef8557b5a1
Improve error message for unresponsive clients
...
Summary:
This change adds 'adb' to the error message checks. If the device is Android, is confusing to suggest the problem may be with 'idb'.
This could be further improved by looking at the client OS and device type to suggest formulate the correct message.
Reviewed By: passy
Differential Revision: D31894695
fbshipit-source-id: 8eb2ca152807afd9706af1523c917803611246d7
2021-10-25 06:50:49 -07:00
Michel Weststrate
945f133593
Remove some Electron imports
...
Summary: Remove some Electron imports that weren't needed
Reviewed By: passy
Differential Revision: D31893756
fbshipit-source-id: 92edeb2e00a7c37e32365bb059d00d7c730a7a92
2021-10-25 06:12:20 -07:00
Michel Weststrate
ae726e7cac
Don't export Electron from index
...
Summary: Removed 'electron' based exports from 'flipper' package
Reviewed By: passy
Differential Revision: D31893039
fbshipit-source-id: 9dba50978d19c86bf6d89e3f967e19fc368f1f62
2021-10-25 06:12:20 -07:00
Pascal Hartig
695ba14289
More granular logging
...
Summary: The `'PLUGIN_DEVICE_BAIL'` event encompasses too many individual steps. This is now broken down into the various parts like closing the emulator launch dialogue, selecting multiple apps/devices or quitting the wait period.
Differential Revision: D31861520
fbshipit-source-id: ff724b461f3af8021950f4aebe87eba0b20dea79
2021-10-25 03:18:47 -07:00
Pascal Hartig
0b44931e2b
Refresh on new plugins
...
Summary:
afcoplan found a bug in the deeplink opening flow: If a device is open but not the app that supports a supported plugin, the dialogue won't disappear once the app is connected.
That is because apps are initialised with an empty plugin list and we're doing a reference equality check to get notified of changes which won't get triggered when the deep `plugin` property is changed.
Instead, we additionally wait for the `plugin-change` event that's emitted by the client to refresh.
Differential Revision: D31861521
fbshipit-source-id: 88fc456553e218f9c8ea68435ff84bdae0d1b586
2021-10-25 03:18:47 -07:00
Pascal Hartig
ec9e3aeb6e
Filter out OS devices when finding valid clients
...
Summary: When running debug builds, and not specifying a `device=...` qualifier as part of the deeplink, you'd get stuck on the "waiting for plugin to be launched" dialogue as Flipper would accept the local MacOS (or Windows, ...) connection as a valid client which can be quite confusing.
Reviewed By: mweststrate
Differential Revision: D31857737
fbshipit-source-id: ff568544f660c51e17b40c2aaadf058588746ef9
2021-10-22 11:29:00 -07:00
Pascal Hartig
ece8b8e1a1
Add debug logging
...
Summary:
Open to feedback that this is making it harder to follow the code.
I was trying to make sense of some odd opening behaviour and it helped
in that case but we can also just keep this diff around to re-apply if needed.
Reviewed By: mweststrate
Differential Revision: D31857738
fbshipit-source-id: 4ebc8685e65e1cc854586518d4f790b3ad102633
2021-10-22 11:29:00 -07:00
Michel Weststrate
75df79a248
Factored out ipcRender.send
...
Summary: Delegate sending events over IPC from the render process to the main process over the RenderHost interface. This basically removes all our direct usages of `ipcRenderer`.
Reviewed By: timur-valiev, aigoncharov
Differential Revision: D31828580
fbshipit-source-id: 9c1333ae55620d36c2af70aa7abc5403c2f4907c
2021-10-22 09:21:18 -07:00
Michel Weststrate
ecf2e32722
Factored out ipcRenderer.on
...
Summary:
Delegate receiving events from the Electron host process to the RenderHost interface.
Typed them as well while at it.
Reviewed By: timur-valiev
Differential Revision: D31828130
fbshipit-source-id: 920055de6f48512b91a433b229dbacd611c6f139
2021-10-22 09:21:18 -07:00
Michel Weststrate
cc946d12ec
Disable Redux devTools
...
Summary:
I can't recall seeing anybody use Redux DevTools in the last 2 years. I don't think it adds much (most data in it is not serializable anyway), and disabling hopefully makes memory leaks / OOMs less likely on long debug sessions :)
If someone misses it, feel free to bring it back.
Reviewed By: passy
Differential Revision: D31827421
fbshipit-source-id: 3c3836d4620a1ae431116df2de19a606672a6cd7
2021-10-22 09:21:18 -07:00
Michel Weststrate
27549ac5eb
Move first pieces of functionality of Electron
...
Summary: Started abstraction some Electron specific APIs away, like process id, select directory dialogs etc.
Reviewed By: timur-valiev, aigoncharov
Differential Revision: D31827016
fbshipit-source-id: e835ac9095e63d7ea79dd0eaf7f2918ac8d09994
2021-10-22 09:21:18 -07:00
Andrey Goncharov
02115722b3
Implement React example of WS integration with Flipper
...
Summary: Create an example of how one can use `js-flipper` in a browser to connect to Flipper over WS.
Reviewed By: mweststrate
Differential Revision: D31688114
fbshipit-source-id: 135f826daeddeda8dca5b3df6504cc2bdc04dd1b
2021-10-21 09:13:18 -07:00
Pascal Hartig
25a6fc1ab1
Re-enable flipper:// support
...
Summary: We used to support invoking `flipper://` to launch Flipper. This broke with the recent changes to our deeplink handling.
Reviewed By: mweststrate
Differential Revision: D31826699
fbshipit-source-id: 09d0d16de4779bb550da884d268ca9fd60f1a9e2
2021-10-21 07:51:05 -07:00
Roman Karpenko
2be631ea4d
Fix Flipper lints #18
...
Summary: Fixed several lint errors mainly related to Warning/node/no-sync.
Reviewed By: passy
Differential Revision: D31795894
fbshipit-source-id: 020597d93232a8e84b25ea11a87d9481a6d2616f
2021-10-21 03:44:31 -07:00
Andrey Goncharov
37498ad5a9
Refactor server implementation for WebSockets
...
Summary:
Standardize WS implementation for JS environments.
Why do we need a separate server implementation for browsers?
Browser targets cannot authenticate via the default certificate exchange flow. For browser targets we verify the origin instead.
Moreover, for already forgotten reasons the initial implementation of the WS server for browsers used a different kind of message structure and added extra `connect`/`disconnect` messages. After examination, it seems the `connect`/`disconnect` flow is redundant.
Major changes:
1. Updated class hierarchy for WS server implementations.
2. Updated browser WS server to support the modern and the legacy protocols.
3. Now a websocket connection with the device is closed on error. The idea is it is highly unlikely to handle any subsequent messages properly once we observe an error. It is better to bail and reconnect. What do you think?
Reviewed By: mweststrate
Differential Revision: D31532172
fbshipit-source-id: f86aa63a40efe4d5263353cc124fac8c63b80e45
2021-10-21 03:34:15 -07:00
Flipper Bot
3a233129b3
Flipper Release: v0.116.0
...
Summary: Releasing version 0.116.0
Reviewed By: cekkaewnumchai
Differential Revision: D31789901
fbshipit-source-id: f714fa7195f5e07be72d8039074e8b745b657e72
2021-10-20 03:54:57 -07:00
Juan Tejada
0e91f8562a
Update React DevTools v4.20.1
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.20.1`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.20.1
Reviewed By: lunaruan
Differential Revision: D31762360
fbshipit-source-id: 9269a49afb263c78916852f51ebbd48ceaf531b0
2021-10-19 10:00:41 -07:00
Anton Kastritskiy
6facf5ed0f
Fix eslint warning for communist-spelling/communist-spelling rule
...
Summary: Fixes eslint warnings
Reviewed By: passy
Differential Revision: D31760180
fbshipit-source-id: 635e842d626c58a2a8d2ea2543bf171237e93dc4
2021-10-19 09:40:49 -07:00
Pascal Hartig
bd66928464
Fix Flipper lints #11
...
Summary: Turning off irrelevant lints for pkg/.
Reviewed By: nikoant
Differential Revision: D31734972
fbshipit-source-id: 845c4c0b0dea22973bc875ad0f86b5344a30280a
2021-10-19 09:21:36 -07:00
Pascal Hartig
b3fa8dd6c1
Dep bump
...
Summary:
Took a few iterations to make offline mirror happy, but everything is green now.
allow-large-files
Reviewed By: nikoant
Differential Revision: D31690614
fbshipit-source-id: 38d0d6cb5e3f63b3707d917a1ed6fc6144762731
2021-10-19 09:21:36 -07:00
Zack Brody
9d34c90b9a
Fix Date Label In Crashes Plugin
...
Summary: The date type for crash reports was updated in D29327501 (aff02b2ca1
2021-10-18 12:21:52 -07:00
Juan Tejada
b4647eaa13
Update React DevTools v4.20.0
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.20.0`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.20.0
Reviewed By: bvaughn
Differential Revision: D31694359
fbshipit-source-id: d05d75e9473878828617c5cd0db8d6008b6abd4d
2021-10-15 12:56:43 -07:00
Ananya Arun
df7bb59e9a
Add screenshots for in app debugging with preview
...
Summary:
Added ss for in app diagnostics using FB app as an example.
Image can be previewed as well if user wants more clarity.
Reviewed By: mweststrate
Differential Revision: D31679937
fbshipit-source-id: 550de8099c8912d2d6caa58c6c9c4c90ba78fabe
2021-10-15 02:48:59 -07:00
dependabot[bot]
5a795ad52a
Bump eslint-plugin-react from 7.25.1 to 7.26.1 in /desktop ( #2942 )
...
Summary:
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react ) from 7.25.1 to 7.26.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/yannickcr/eslint-plugin-react/releases ">eslint-plugin-react's releases</a>.</em></p>
<blockquote>
<h2>v7.26.0</h2>
<h3>Added</h3>
<ul>
<li>add [<code>no-namespace</code>] rule (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a> <a href="https://github.com/yacinehmito "><code>@yacinehmito</code></a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li><a href="docs/rules/jsx-max-props-per-line.md"><code>jsx-max-props-per-line</code></a>: add <code>single</code> and <code>multi</code> options (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a> <a href="https://github.com/SIL0RAK "><code>@SIL0RAK</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li><a href="docs/rules/display-name.md"><code>display-name</code></a>: Get rid of false position on component detection (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a> <a href="https://github.com/iiison "><code>@iiison</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[<code>no-access-state-in-setstate</code>]: passing test for “don't error if it's not a React Component” (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a> <a href="https://github.com/kentcdodds "><code>@kentcdodds</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3078 ">yannickcr/eslint-plugin-react#3078</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2640 ">yannickcr/eslint-plugin-react#2640</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2759 ">yannickcr/eslint-plugin-react#2759</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/1873 ">yannickcr/eslint-plugin-react#1873</a>
[<code>react/jsx-runtime</code>]: <a href="https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L163-L176 ">https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L163-L176 </a></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md ">eslint-plugin-react's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.26.0...v7.26.1 ">7.26.1</a> - 2021.09.29</h2>
<h3>Fixed</h3>
<ul>
<li>[<code>no-namespace</code>]: fix crash on non-string React.createElement name (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3082 ">#3082</a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>no-namespace</code>]: avoid crash on non-string createElement values (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3085 ">#3085</a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>jsx-no-target-blank</code>]: improve error messages (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3088 ">#3088</a> <a href="https://github.com/cutiful "><code>@cutiful</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[Docs] [<code>jsx-max-props-per-line</code>]: fix options example (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3083 ">#3083</a> <a href="https://github.com/MrRaiter "><code>@MrRaiter</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3088 ">#3088</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3088 ">yannickcr/eslint-plugin-react#3088</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3085 ">#3085</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issue/3085 ">yannickcr/eslint-plugin-react#3085</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3083 ">#3083</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3083 ">yannickcr/eslint-plugin-react#3083</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3082 ">#3082</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3082 ">yannickcr/eslint-plugin-react#3082</a></p>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.3...v7.26.0 ">7.26.0</a> - 2021.09.20</h2>
<h3>Added</h3>
<ul>
<li>add [<code>no-namespace</code>] rule (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a> <a href="https://github.com/yacinehmito "><code>@yacinehmito</code></a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>jsx-max-props-per-line</code>]: add <code>single</code> and <code>multi</code> options (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a> <a href="https://github.com/SIL0RAK "><code>@SIL0RAK</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>[<code>display-name</code>]: Get rid of false position on component detection (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a> <a href="https://github.com/iiison "><code>@iiison</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[<code>no-access-state-in-setstate</code>]: passing test for “don't error if it's not a React Component” (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a> <a href="https://github.com/kentcdodds "><code>@kentcdodds</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3078 ">yannickcr/eslint-plugin-react#3078</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2640 ">yannickcr/eslint-plugin-react#2640</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2759 ">yannickcr/eslint-plugin-react#2759</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/1873 ">yannickcr/eslint-plugin-react#1873</a></p>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.2...v7.25.3 ">7.25.3</a> - 2021.09.19</h2>
<h3>Fixed</h3>
<ul>
<li>[<code>prop-types</code>], <code>propTypes</code>: bail out unknown generic types inside func params (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3076 ">#3076</a> <a href="https://github.com/vedadeepta "><code>@vedadeepta</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[readme] Update broken link for configuration files (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3071 ">#3071</a> <a href="https://github.com/prateek3255 "><code>@prateek3255</code></a>)</li>
<li>[Refactor] create/extract <code>isCreateElement</code> and <code>isDestructuredFromPragmaImport</code> utils (<a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3076 ">#3076</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3076 ">yannickcr/eslint-plugin-react#3076</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3071 ">#3071</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3071 ">yannickcr/eslint-plugin-react#3071</a></p>
<h2>[7.25.2] - 2021.09.16</h2>
<h3>Fixed</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="119a7f3c737844d8ecbb8785c169c2a8ecd54b74a4bf7dad85eeb0144f148cf47a8ac2e4acd07cd483eb22651c95a8a4eb53https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.1...v7.26.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2942
Reviewed By: passy
Differential Revision: D31390485
Pulled By: jknoxville
fbshipit-source-id: 92909bb967d0b0a62e3e5a927257d2d1e2cc53d4
2021-10-14 06:27:59 -07:00
dependabot[bot]
16e3a9cb3d
Bump axios from 0.21.4 to 0.22.0 in /desktop ( #2940 )
...
Summary:
Bumps [axios](https://github.com/axios/axios ) from 0.21.4 to 0.22.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/releases ">axios's releases</a>.</em></p>
<blockquote>
<h2>v0.22.0</h2>
<h3>0.22.0 (October 01, 2021)</h3>
<p>Fixes and Functionality:</p>
<ul>
<li>Caseless header comparing in HTTP adapter (<a href="https://github-redirect.dependabot.com/axios/axios/pull/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li>Avoid package.json import fixing issues and warnings related to this (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4041 ">#4041</a>), (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4065 ">#4065</a>)</li>
<li>Fixed cancelToken leakage and added AbortController support (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3305 ">#3305</a>)</li>
<li>Updating CI to run on release branches</li>
<li>Bump follow redirects version</li>
<li>Fixed default transitional config for custom Axios instance; (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4052 ">#4052</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/HEAD/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/mastermatt ">Matt R. Wilson</a></li>
<li><a href="https://github.com/chinesedfan ">Xianming Zhong</a></li>
<li><a href="https://github.com/DigitalBrainJS ">Dmitriy Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/blob/master/CHANGELOG.md ">axios's changelog</a>.</em></p>
<blockquote>
<h3>0.22.0 (October 01, 2021)</h3>
<p>Fixes and Functionality:</p>
<ul>
<li>Caseless header comparing in HTTP adapter (<a href="https://github-redirect.dependabot.com/axios/axios/pull/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li>Avoid package.json import fixing issues and warnings related to this (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4041 ">#4041</a>), (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4065 ">#4065</a>)</li>
<li>Fixed cancelToken leakage and added AbortController support (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3305 ">#3305</a>)</li>
<li>Updating CI to run on release branches</li>
<li>Bump follow redirects version</li>
<li>Fixed default transitional config for custom Axios instance; (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4052 ">#4052</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/master/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/mastermatt ">Matt R. Wilson</a></li>
<li><a href="https://github.com/chinesedfan ">Xianming Zhong</a></li>
<li><a href="https://github.com/DigitalBrainJS ">Dmitriy Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="72f14ceef73e016002086100f694b3https://github-redirect.dependabot.com/axios/axios/issues/4052 ">#4052</a>)</li>
<li><a href="ac10a254ef9bcff10dfahttps://github-redirect.dependabot.com/axios/axios/issues/3305 ">#3305</a>)</li>
<li><a href="fffa02cd2chttps://github-redirect.dependabot.com/axios/axios/issues/4065 ">#4065</a>)</li>
<li><a href="66d188d590https://github-redirect.dependabot.com/axios/axios/issues/4041 ">#4041</a>)</li>
<li><a href="f3ca6371cahttps://github-redirect.dependabot.com/axios/axios/issues/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li><a href="4091b075f6https://github-redirect.dependabot.com/axios/axios/issues/4025 ">#4025</a>)</li>
<li>See full diff in <a href="https://github.com/axios/axios/compare/v0.21.4...v0.22.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2940
Reviewed By: passy
Differential Revision: D31390489
Pulled By: jknoxville
fbshipit-source-id: 3abea61aaa89e2320b81af78a3d6d02018c5f158
2021-10-14 06:27:59 -07:00
Lucas Bento
8b270ed204
Fix Settings window hotkeys alignment and colors ( #2961 )
...
Summary:
This PR fixes a few color issues (mainly on dark mode) and the alignment of the `React Native keyboard shortcuts` hotkeys.
I also took the liberty of changing the color of a few other icons.
### Light mode
|Before|After|
|---|---|
|||
### Dark mode
|Before|After|
|---|---|
|||
## Changelog
Fix `Settings` window hotkeys alignment and colors.
Pull Request resolved: https://github.com/facebook/flipper/pull/2961
Test Plan:
1. Run the app;
1. Press `⌘` + `,`;
2. Profit.
Reviewed By: mweststrate
Differential Revision: D31546032
Pulled By: passy
fbshipit-source-id: 5f7c73826cf6a367afb1ad758d1fd0451aaeb6cf
2021-10-14 06:07:46 -07:00
Pascal Hartig
91cc0ef3c0
Dep bump
...
Summary: Lots of open security warnings so I'm trying to catch a few that are behind patch releases at once.
Reviewed By: mweststrate
Differential Revision: D31574708
fbshipit-source-id: 5a4f2b18b50a3752b4986c4196a4bcda1e8a298c
2021-10-14 03:56:43 -07:00
