Commit Graph

4 Commits

Author SHA1 Message Date
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
2021-12-27 14:31:45 -08:00
CodemodService FBSourceGoogleJavaFormatLinterBot
90fe42f629 Daily arc lint --take GOOGLEJAVAFORMAT
Reviewed By: zertosh

Differential Revision: D32269835

fbshipit-source-id: 71104597fab6b10321abf45278e070b10bdf8a66
2021-11-08 19:58:43 -08:00
Archit Raj
d33041cd9e fix: NativeEventEmitter warnings for android (#2975)
Summary:
With React Native v0.65+, `NativeEventEmitter` shows non-null argument warnings. Issue https://github.com/facebook/flipper/issues/2707
```
`new NativeEventEmitter()` was called with a non-null argument without the required `addListener` method.
`new NativeEventEmitter()` was called with a non-null argument without the required `removeListeners` method.
```

## Changelog
https://github.com/facebook/flipper/issues/2707 - Fix NativeEventEmitter warnings for android

Pull Request resolved: https://github.com/facebook/flipper/pull/2975

Test Plan:
- Add `redux-flipper` plugin to `ReactNativeFlipperExample` project

## Screenshots

#### Before
![Screenshot_1634241069](https://user-images.githubusercontent.com/20144332/137386556-79bbad7e-74b9-4343-ad45-26119557142a.png)

#### After
![Screenshot_1634241159](https://user-images.githubusercontent.com/20144332/137386572-54c74ca5-a70a-4fd4-9644-d5e15f817128.png)

Reviewed By: passy

Differential Revision: D32243694

Pulled By: mweststrate

fbshipit-source-id: 21e490a275875268fea982ac1e855ca4bed02bc8
2021-11-08 04:23:12 -08:00
Joao Alves
51e37311d0 Fix: Release builds on android (#1325)
Summary:
After `react-native-flipper` 0.48.0 I cannot build releases on android (I think that passed on CI tests because the example was running an older version of this package, 0.47.0).
So I moved all the `android/src/main` content to `android/src/debug` because we will not use Flipper in another Build Variant

## Changelog

I moved all content from `react-native-flipper/android/src/main` to `react-native-flipper/android/src/debug`.

Probably solves https://github.com/facebook/flipper/issues/1303
Pull Request resolved: https://github.com/facebook/flipper/pull/1325

Test Plan: Maybe create a custom CI script to verify if Flipper deps are present on Release Builds, [something like this](https://github.com/facebook/flipper/issues/1274#issue-641197153)

Reviewed By: cekkaewnumchai

Differential Revision: D22333432

Pulled By: passy

fbshipit-source-id: 4abbab5ecbe08d44752b2138569ff60d25724087
2020-07-02 04:07:59 -07:00