Summary: Previously I had created a RN build, locally, with a few minor differences. That had to be reverted. Instead of reverting and re-applying changes, I'm introducing a flag that can be used in the interim to produce the RN-only builds.
Reviewed By: LukeDefeo
Differential Revision: D50555055
fbshipit-source-id: edface9a1587fb51e54eebe73724032baf985c83
Summary:
Every time the token is returned, export it to the manifest.
This covers the case in which the token found in the manifest has already expired.
Reviewed By: antonk52
Differential Revision: D50419458
fbshipit-source-id: 8eefa0e97e234985b34f824190b208bf74e2d8ec
Summary: If the token has already expired, generate another one.
Reviewed By: aigoncharov
Differential Revision: D50410431
fbshipit-source-id: 108a3b344a1bcafd93a8d9bc94cba5c133d099d7
Summary: Do not use mutex for device listing.
Reviewed By: antonk52
Differential Revision: D50265112
fbshipit-source-id: 9b3bf4f9351e28dfb6366b6b787ec8b466b9bc47
Summary:
This change will allow us to display correct stack traces in flipper UI as well as send them to scuba.
Currently correct stack traces are only displayed in the console and we do not have access to them.
Reviewed By: ivanmisuno
Differential Revision: D50015827
fbshipit-source-id: 2a60315dd5c06b2635ce0414f612ff1fdca0e489
Summary: Set a timeout period to become ready. It is better to kill the server if not ready, than keeping it alive.
Reviewed By: antonk52
Differential Revision: D50004605
fbshipit-source-id: be1d2c022c634ece059fc03eb6faea695431ba95
Summary: Track whenever the server is unable to bind to the specified port.
Reviewed By: antonk52
Differential Revision: D49951304
fbshipit-source-id: 971d7c324f27c287036707d21bb51d26acbd6615
Summary:
^
Also, if an error happens, do not swallow it, rethrow.
Reviewed By: passy
Differential Revision: D49912780
fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2
Summary: If we are unable to bind to the specified port, exit process.
Reviewed By: passy
Differential Revision: D49908107
fbshipit-source-id: 6d76f3d661ec61867be5307c756e372a7b20a9f6
Summary: Currently, we are not interested in these errors. Let's add some logging as a way of knowing if they take place and why.
Reviewed By: antonk52
Differential Revision: D49828378
fbshipit-source-id: f741a45e1ba9892aa54dca85f97bcc419e0b5e25
Summary:
There has been multiple requests to incorporate an export to plain text functionality for a while.
This diff adds it.
It will export a node and optionally its chidren as JSON.
Reviewed By: antonk52
Differential Revision: D49596476
fbshipit-source-id: 3681bc0c2d02e1ea64ff589e0e272f6d54ad0524
Summary:
Expose an endpoint to retrieve server environment information.
We can use version information and process number to aid engineers with troubleshooting Flipper.
Reviewed By: antonk52
Differential Revision: D49537325
fbshipit-source-id: 511fe4441638f91cd35f13706ceeeb515051416b
Summary: This is the default from Node 17 onwards and should unblock problems we're seeing on some people's machines.
Reviewed By: lblasa
Differential Revision: D49415859
fbshipit-source-id: c15ab82e69db4916838228324a9739c95f3562f3
Summary: Use the newly exposed HTTP shutdown API. It is simpler.
Reviewed By: antonk52
Differential Revision: D49499264
fbshipit-source-id: 2d81db1d1a66c0b7550ee1245e51d8f1a8671aa6
Summary: Expose the shutdown API via the HTTP server.
Reviewed By: ivanmisuno
Differential Revision: D49496840
fbshipit-source-id: df2045edc89e9feabe74b4b513f973d137323d0f
Summary: Used last year to GK server usage. This is obsolete so is safe to remove.
Reviewed By: ivanmisuno
Differential Revision: D49414625
fbshipit-source-id: 9eeff932c59c90dff829e4c6c83bad43a0fd74e3
Summary:
The existing loading page was not behaving the way it was intended. The previous implementation triggered a page reload which made the whole retry mechanism useless.
Instead, a new endpoint was defined to expose whether the server is ready or not. Use this instead as a way of knowing whether we are good to reload the page.
Reviewed By: passy
Differential Revision: D49314749
fbshipit-source-id: eb67765d7deab8610fa5d31e710070da43a18c1c
Summary: Generate auth token on whenever we load the secure server config, and add more logs.
Reviewed By: antonk52
Differential Revision: D49272857
fbshipit-source-id: 1e549a8bfd7926e9a44b9480432e92ee3c0162b2
Summary:
A few things need to be done which are on this change:
- Certificate generation should execute as an atomic operation, hence, it needs to be synchronised.
- Do not generate client token as part of certificate generation. This causes a deadlock now.
- Add more logs for troubleshooting
Reviewed By: aigoncharov
Differential Revision: D49269624
fbshipit-source-id: 071a8e5b895198730b7d914cc4622837e9094e2f
Summary: This should be a blocking call and done later as it depends on the FlipperServerConfig to be set.
Reviewed By: antonk52
Differential Revision: D49193650
fbshipit-source-id: 4f74ca5de30b7f992880bbb9032792fd713203b7
Summary: Changelog: FLIPPER_DISABLE_KEYTAR env var can be used to force in-memory implementation
Reviewed By: lblasa
Differential Revision: D49183501
fbshipit-source-id: 4ce886303678485673750417b09f272dd3f66623
Summary:
If a requests fails due to lack of allow-listing or other incompatibilities, we will now fall back to VPN mode while logging an error that will hopefully end up at the plugin owner.
For this, there's a new `vpnMode` option on every request that can also be used to enforce a particular type.
There's a lot of verbose logging that's turned off by default but very handy when debugging. Also potentially useful for plugin authors that are looking into request issues.
Reviewed By: lblasa
Differential Revision: D49023365
fbshipit-source-id: 755393063e379587feda9ae13973877780a1d987
Summary:
We recently raised a concern that for some packages types/* version is different than the package we are using. This can cause runtime errors as typescript can suggest usage that no longer reflects current API of a library. To combat this issue we decided to add a CI check to verify that major versions of types and a libriary match.
This script will be refined if in the next few diffs
Reviewed By: LukeDefeo
Differential Revision: D48779652
fbshipit-source-id: 2a826ba9d00565563553f04cd809ae0638db6282
Summary:
If the server certificates have expired, then the returned token will no longer be valid as soon as the certificates are renewed.
So, validate this before returning any existing token.
This was not an issue before, as launching used to be the last step during bootstrapping.
Reviewed By: antonk52
Differential Revision: D48902334
fbshipit-source-id: 2458aa0df806db245994ee742f42bff47a533e23
Summary:
The socket will close as the endpoint is terminating the connection.
Status code 1000 and 1001 are used for normal closures. Either the connection is no longer needed or the endpoint is going away i.e. browser navigating away from the current page.
WS RFC: https://www.rfc-editor.org/rfc/rfc6455
Reviewed By: LukeDefeo
Differential Revision: D48896696
fbshipit-source-id: 22070ae34b7f35d35589db06108feb718e73e866
Summary:
A previous diff introduced the isReady state as to make it possible to serve HTML content sooner than we are ready.
This worked great on debugging. As I was testing a release, it was discovered that there was a race condition and the server was not ready when it was already handling upgrade events.
To solve this, I've added another state flag in the form of a promise.
This one, can be waited on. This is used then during upgrade events as we can safely wait until the server is ready to accept incoming connections before proceeding with the upgrade.
Problem is shown below:
{F1080003241}
{F1080003356}
Reviewed By: passy
Differential Revision: D48829453
fbshipit-source-id: e148a392bbe66dd91710e32871e270c8950e25c2
Summary:
Flipper Launcher downloads, unpacks, launches Flipper, and closes itself.
This is fine except for the fact that Flipper may be initiating and thus there's a gap of a few seconds until engineers see the main Flipper UI.
This change improves this by launching earlier, even if just showing a loading page until Flipper is actually ready.
Reviewed By: passy, aigoncharov
Differential Revision: D48824479
fbshipit-source-id: aa6147a09f313d80592c9b08d089660ba73773a4
