Commit Graph

26 Commits

Author SHA1 Message Date
Pritesh Nandgaonkar
2dacea8541 Published Flipper-PeerTalk dependency on Cocoapods (#395)
Summary:
I have published the new tag of Peertalk on my [fork](https://github.com/priteshrnandgaonkar/peertalk) and published a [Flipper-PeerTalk](80e4cd9a05/Specs/d/6/6/Flipper-PeerTalk/0.0.4/Flipper-PeerTalk.podspec.json) pod on cocoapods. There was no reply on the [request](https://github.com/rsms/peertalk/issues/48) to publish the new version of the peertalk on their repository and it was blocking us to publish Flipper and FlipperKit pods to Cocoapods. For more context follow the issue #132. With this PR we would have all our dependencies on cocoapods and thus we can now publish Flipper and FlipperKit pods on the cocoapods master repository.

I have also added the Flipper-PeerTalk podspec file for future updates.
Pull Request resolved: https://github.com/facebook/flipper/pull/395

Reviewed By: passy

Differential Revision: D14642440

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 7847c19cddea358ffb62d2c6f16fc06d1afa1ea1
2019-04-01 08:49:16 -07:00
Pritesh Nandgaonkar
8a19a859f2 Update Componentkit, Yoga, YogaKit
Summary: Fixed the broken master for flipper iOS  oss

Reviewed By: jknoxville

Differential Revision: D14686908

fbshipit-source-id: abdcacf279449f83c98d1635c65ff8759ee17926
2019-04-01 06:59:59 -07:00
Pritesh Nandgaonkar
f8bd473828 Use Folly and RSocket from cocoapods (#379)
Summary:
I have released pods for Folly and RSocket on cocoapods. Thus we won't need to host different versions of these pods on our repository. I haven't removed those pods from `Specs` folder, as the current users of `0.16.2` would still be referring the Specs folder on the master branch. I will remove the specs folder once, all our pods are on cocoapods and we no longer need to host any pods.
Pull Request resolved: https://github.com/facebook/flipper/pull/379

Reviewed By: jknoxville

Differential Revision: D14185931

Pulled By: priteshrnandgaonkar

fbshipit-source-id: ea285024123e41c2d110827e26f79a72ef22c008
2019-02-26 04:18:00 -08:00
Pritesh Nandgaonkar
da37ab78bd Docs with an updated install instruction (#343)
Summary:
This PR updates the installation instruction. It missed few crucial information and thus the projects installing flipper as a dependency were facing issues. It addresses the issue #341. It also brings the sample application at par with the documentation.
Pull Request resolved: https://github.com/facebook/flipper/pull/343

Reviewed By: danielbuechele

Differential Revision: D13507298

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 5a4b23d79930cb7eeb491e359b616d3558e260fb
2018-12-21 07:40:57 -08:00
Pritesh Nandgaonkar
2c9feb40e9 Remove crashreporter plugin iOS implementation
Summary: Removes the iOS implementation of crash reporter plugin as its implemented as desktop plugin

Reviewed By: adamjernst

Differential Revision: D13451980

fbshipit-source-id: 19cca52a00bb4a6d350eff91ac405f6dd3b07818
2018-12-18 13:42:40 -08:00
Pritesh Nandgaonkar
940ab5843f Add crash reporter plugin in swift sample app
Summary: Adds crash reporter plugin to swift sample app

Reviewed By: jknoxville

Differential Revision: D13359298

fbshipit-source-id: 2025725a7405d79407fbc15448d4f222f33c00fc
2018-12-07 07:37:55 -08:00
mtfum
67dd1fc596 Remove unnecessary semicolon (#327)
Summary:
I updated to remove unnecessary semicolon in AppDelegate.swift, SampleSwift
Pull Request resolved: https://github.com/facebook/flipper/pull/327

Reviewed By: priteshrnandgaonkar

Differential Revision: D13121242

Pulled By: jknoxville

fbshipit-source-id: 9e848b2def84c5b969c9167abc556fe18ccecdbc
2018-11-20 02:12:18 -08:00
Pritesh Nandgaonkar
6e1c1d57f9 Adds example flipper plugin in swift sample app (#329)
Summary:
This PR adds the example flipper plugin in swift sample app. Example flipper plugin acts as an example for the plugin authors. The example flipper plugin was already added in an objective c example but the swift sample app didn't have it.
Pull Request resolved: https://github.com/facebook/flipper/pull/329

Reviewed By: jknoxville

Differential Revision: D13085611

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d86cca43e95592ecca8d9991d170e62170b8217b
2018-11-19 01:53:00 -08:00
Pritesh Nandgaonkar
c98a463464 Ignore Podfile.lock (#297)
Summary:
This PR puts Podfile.lock in gitignore
Pull Request resolved: https://github.com/facebook/flipper/pull/297

Reviewed By: passy

Differential Revision: D10447350

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 8de6e92f6e53972e8dc5af3b09d18259020c89c5
2018-10-21 16:09:48 -07:00
Pritesh Nandgaonkar
603c4c5fbc Layout Plugin support for swift (#295)
Summary:
Changed the podspec file to expose only those header files in public which are necessary. The exposed public header files have no c++ in it, thus due to this layout plugin now works for swift too.

Fixes #174

![ezgif com-video-to-gif](https://user-images.githubusercontent.com/3865908/46979109-9c5a4b80-d0c8-11e8-8f86-639dfba51efe.gif)
Pull Request resolved: https://github.com/facebook/flipper/pull/295

Reviewed By: passy

Differential Revision: D10389202

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0ecc428f8008dd3aac48a675a8b97bb610f8e9eb
2018-10-16 08:37:57 -07:00
Marc Terns
c7ad49a9eb Integrating NSUserDefaults plugin to iOS (#291)
Summary:
I have a few details left, but its almost done. This PR addresses #145

- The NSUserDefaults plugin uses the SharedPreferences Desktop Part since we can reuse all of it.
- The NSUserDefaults plugin uses swizzling in order to be notified of what specific event changed at runtime.
- Added Test harness in both Sample Swift and Sample apps for iOS in order to test the plugin.
- Updated the documentation in `docs/shared-preferences-plugin.md` and` README.md`

I am open to suggestions since the desktop sharedPreferences version doesn't support deletion of preferences. Most likely I would have to modify the UI, and for that matter, I might as well build a user defaults desktop version

I wanted to add xiphirx in this MR since he developed the shared preferences plugin for Android and Desktop. I don't see a way to remove preferences from the flipper desktop app so I was wondering if you would be OK with me adding that.
Pull Request resolved: https://github.com/facebook/flipper/pull/291

Reviewed By: passy

Differential Revision: D10334685

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d798c01a46df7ddecf713924799f046b560ea922
2018-10-12 04:09:29 -07:00
Pritesh Nandgaonkar
588d61efc6 Rename SonarKitLayoutComponentkitsupport
Summary: Rename SonarKitLayoutComponentkitsupport

Reviewed By: passy

Differential Revision: D10029301

fbshipit-source-id: c87717d431ce2603e31bf3c25add40f90eb76609
2018-09-25 13:47:38 -07:00
Pritesh Nandgaonkar
ccf47e75fd Rename podspec file
Summary: Rename podspec file

Reviewed By: passy

Differential Revision: D10027676

fbshipit-source-id: b5936f0e514f06d1ff3d68657d7fe5912cac233d
2018-09-25 13:47:35 -07:00
Pritesh Nandgaonkar
22f37368ce Change the file name of SonarKitNetworkPlugin to FlipperKitNetworkPlugin
Summary: Renames the file name of SonarKitNetworkPlugin to FlipperKitNetworkPlugin

Reviewed By: passy

Differential Revision: D9972211

fbshipit-source-id: c092c75f0e1bab54cd247e3ae69449577453ec07
2018-09-21 03:45:54 -07:00
Pritesh Nandgaonkar
02ac3ff9cd Rename SonarKitNetworkPlugin
Summary: Renames SonarKitNetworkPlugin

Reviewed By: passy

Differential Revision: D9968092

fbshipit-source-id: 6d5b7761405be9b47e679510ce6fc7f2a84c308b
2018-09-21 03:45:54 -07:00
John Knox
df8763e697 Move xplat/sonar/xplat/Sonar* to Flipper*
Summary:
Part of the Sonar -> Flipper rename
Intentionally left externally visible buck target as Sonar for now to minimize diff size.

Reviewed By: passy

Differential Revision: D9871684

fbshipit-source-id: 6926eb62c578a05cd895745c75ed7da3cfe965b5
2018-09-20 15:39:57 -07:00
Pritesh Nandgaonkar
ba7b43a547 Rename SonarKitLayoutPlugin to FlipperKitLayoutPlugin
Summary: Renames SonarKitLayoutPlugin to FlipperKitLayoutPlugin

Reviewed By: passy

Differential Revision: D9949785

fbshipit-source-id: 8cfde4dfad3e34038d2f66f0ce4393db9d83ef60
2018-09-20 04:45:35 -07:00
Pritesh Nandgaonkar
da851bd7e6 Change modulename to FlipperKit
Summary: Change modulename to FlipperKit

Reviewed By: passy

Differential Revision: D9940793

fbshipit-source-id: ea3c6633c481e29fc192cea7465fe3a93cf28f87
2018-09-19 08:29:43 -07:00
Pritesh Nandgaonkar
f970e60edd Rename iOS SonarPlugin to FlipperPlugin
Summary: Rename iOS SonarPlugin to FlipperPlugin

Reviewed By: jknoxville

Differential Revision: D9915094

fbshipit-source-id: ea2ca60ab578aca8c8f028e3deea4a3b9a48a63b
2018-09-18 09:58:08 -07:00
Pritesh Nandgaonkar
a488e34514 Rename iOS SonarClient to FlipperClient
Summary: Renamed `SonarClient` to `FlipperClient`

Reviewed By: passy

Differential Revision: D9861749

fbshipit-source-id: 3374e4297e49ac198a235babc92deb9d2dddc268
2018-09-18 08:58:10 -07:00
Pritesh Nandgaonkar
a0bb9e6fe5 Fix broken sample app
Summary:
This diff adds FlipperStateUpdateListener in public headers, as SonarClient.h depends on it and the sample app depends on SonarClient.h.

This diff fixes the compilation error for Sample and SwiftSample

Ideally travis should have caught it. Fix for travis is coming.

Reviewed By: jknoxville

Differential Revision: D9462177

fbshipit-source-id: e3e0ec90f9083294d4a131989ec0eaee02b52791
2018-08-22 12:57:33 -07:00
Pritesh Nandgaonkar
be4b45c703 Update Sample apps to refer local podspecs (#244)
Summary:
Before this PR, travis used to build sample app which used a tagged release of SonarKit and Sonar. So travis used to never check the source code in master branch. This PR, instead uses local podspecs, which refers to the local source code, and thus travis would be testing the local source code.
Solves #237
Pull Request resolved: https://github.com/facebook/flipper/pull/244

Reviewed By: passy

Differential Revision: D9394955

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 7109a8baaeb8ff7e14d19ebe1d7c3bcb7e4bebd2
2018-08-20 04:11:38 -07:00
Pritesh Nandgaonkar
0c60347593 Swift support for NetworkPlugin (#201)
Summary:
Solves #173

- [x] Add plugins in the sonarkit xcodeproj so that its easy to debug
- [x] Get rid off the c++ in the headers
- [x] Add example to hit network requests and validate

Have a look at the screen shot below ️

<img width="1677" alt="screen shot 2018-08-02 at 12 46 07 pm" src="https://user-images.githubusercontent.com/3865908/43581809-22efe4fe-9652-11e8-9424-f279d07c5c81.png">
Pull Request resolved: https://github.com/facebook/flipper/pull/201

Reviewed By: danielbuechele

Differential Revision: D9132157

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 2b425506961f02eb2bf629c2bcab0da6e7ce5bb0
2018-08-06 12:43:13 -07:00
Pritesh Nandgaonkar
3d66b1c9d0 Fix for iOS Cocoapods default config (#205)
Summary:
Solves #203

- [x] Sample Objc and Swift apps now have default configs(i.e non-recursive header search paths)
- [x] Fix for the cocoapods default config by adding FBMacros.h file in `Core` subspec
- [x] Updated the Spec(0.6.15) so that 0.6.15 works for default configs
- [x] Updated the doc
Pull Request resolved: https://github.com/facebook/flipper/pull/205

Reviewed By: passy

Differential Revision: D9148358

Pulled By: priteshrnandgaonkar

fbshipit-source-id: e6d32d9cde7b100573bd9a9996f0ec850b269d28
2018-08-03 07:12:47 -07:00
Pritesh Nandgaonkar
10dc4d0ca9 Change the mention of Sonar in iOS sample app
Summary: Update the iOS sample app with flipper

Reviewed By: passy

Differential Revision: D9056882

fbshipit-source-id: f5b49fc60905c6d5ebca3da977cf966e76feffb8
2018-07-31 14:02:58 -07:00
Pritesh Nandgaonkar
6c78895b2a Move SampleSwift project to xplat
Summary: Move SampleSwift project to xplat

Reviewed By: passy

Differential Revision: D8989867

fbshipit-source-id: cfda775ec3919d5c689aaf6846a870a2653c47a6
2018-07-26 05:21:43 -07:00