Summary: Dismissing the popover will stiop the user from being prompted for a while, so we only want to send this event when the user was proactively prompted in the first place - which is when we're using the eligibility check.
Reviewed By: passy
Differential Revision: D17343227
fbshipit-source-id: 95a071e34ce318fe49640c6ee9f68127957f390c
Summary:
Behind a gk.
This uses a hidden webview to check if a user is eligible for star ratings. This means you can practively ask the user, and makes sure you'll get an unbiased distribution.
Reviewed By: danielbuechele
Differential Revision: D17343118
fbshipit-source-id: fe7471416aef947ec10f4734e4136868ab5ab3e5
Summary:
Unnecessary and very broad - effectively disabling
all of tsc for the class.
Reviewed By: jknoxville
Differential Revision: D17342993
fbshipit-source-id: 609ce2cbd69bd83749111f64b1784fd4965c9704
Summary:
This is a pretty broad ignore which doesn't seem required
but could hide real bugs.
Reviewed By: jknoxville
Differential Revision: D17342033
fbshipit-source-id: c7941e383936e44e39eff3fb7eced1d85a0d6417
Summary: Hmm, how did this land despite the formatting error?
Reviewed By: jknoxville
Differential Revision: D17342057
fbshipit-source-id: 514be1548feb024cc107139ac962b0d69ff42198
Summary:
Previously url's were displayed only for the Android app even if the user was using the iOS app.
This commit displays the url's for the iOS app if the user is using the iOS app.
Reviewed By: danielbuechele
Differential Revision: D17318175
fbshipit-source-id: 3bd8be4de55ea5b3ce634c2c6b713cba14ffcccd
Summary:
I didn't update the render logic accordingly after figuring
out how the internal update endpoint works. This closes
that gap.
Reviewed By: danielbuechele
Differential Revision: D17316892
fbshipit-source-id: 1e6c4dd17b342b2a062cea90d763be01ed6fc1ec
Summary: Mostly exclaming here, but it's a test so ... �
Reviewed By: danielbuechele
Differential Revision: D17314463
fbshipit-source-id: 84a4cb9d5b91865b7f723c883dc4840479db9aa3
Summary:
Icon names including the -outline suffix get stripped out so the local path becomes the filled variant by default.
But it's only observable in release builds, because they are the only ones that use local icons.
This should fix that by keeping the variant in the local icon path as well.
Reviewed By: danielbuechele
Differential Revision: D17314646
fbshipit-source-id: b8402d85b1cc690caef7870194e60f22d17dca05
Summary:
This is an interesting invariant that TS caught here. We
expect `getDevice()` to always return a device but it
cannot because it's set lazily. John Knox suggested we instead
set up a promise in the constructor and resolve it instead of
overriding the stateful promise later.
Reviewed By: jknoxville
Differential Revision: D17313468
fbshipit-source-id: 8fd75f2720546abf67beead23db56216f1a5e0df
Summary: And remove one migration warning that no longer applies.
Reviewed By: danielbuechele
Differential Revision: D17313469
fbshipit-source-id: f29a096a0da7c14735d1d5666a54a3351df54821
Summary: Plugin is moved up as soon as it gets clicked because of the same array reference
Reviewed By: jknoxville
Differential Revision: D17285335
fbshipit-source-id: c4413844fe07a9aed77e4b0e9fb5f5e025d722ca
Summary:
Relies heavily on types (not) defined in other modules,
so right now it's mostly sprinkling more `any`s in.
My type declaration is based on `dts-gen` output and some
manual fixes. This is the same level as the old flow-typed
definition we had.
Reviewed By: jknoxville
Differential Revision: D17282739
fbshipit-source-id: 0e5015d3b61044615a03c50fefade908041310a8
Summary:
Could use a closer look. *Shouldn't* change semantics,
but there are some assumptions baked into the code
which I don't fully grasp.
Reviewed By: jknoxville
Differential Revision: D17282310
fbshipit-source-id: af8e6bcd188bd12180a7b2eeafee7ced4f44d1aa
Summary: Per title. Somehow both typecheck, but importing the module like this doesn't work.
Reviewed By: jknoxville
Differential Revision: D17285507
fbshipit-source-id: 40a38db5dfb52213e0407f8bda83f2ebad5c50c7
Summary: These strings be provided by the api.
Reviewed By: passy
Differential Revision: D17282133
fbshipit-source-id: a818f915c0a21f84894a6073d2cc08669647caaa
Summary: The persistedState of the Layout (and potentially other plugins) wasn't updated. It turned out that the updated state value never got passed to `setPluginState`, but accidentally when adding a type declaration, the `Object` constructor was passed as value to the state.
Reviewed By: jknoxville, passy
Differential Revision: D17282822
fbshipit-source-id: 6fc64960ee2405ea5a705504969c36a27ac62f2c
Summary: And also increase the time-to-disappear from 1s to 1.5s.
Reviewed By: passy
Differential Revision: D17281904
fbshipit-source-id: df0f3e1a40949f5a518bf05d89b6ac0ecf92c5bb
Summary:
This one is in TS, so we get types for free.
`promisify` makes it rather awkward to work with overloaded
functions like `spawn`, so there's still value in having
a proper library for this.
Reviewed By: jknoxville
Differential Revision: D17204471
fbshipit-source-id: 3d07edfe2bb8c1e4c4f3134b53a0c4a0d9be383b
Summary: OS must always be defined.
Reviewed By: jknoxville
Differential Revision: D17204398
fbshipit-source-id: 0d84111c382af623843a41360bcb472394daf3f1
