Commit Graph

16 Commits

Author SHA1 Message Date
Luke De Feo
6f6b953c62 Fix warning
Summary: This was complaining about mixing shorthand  and separete css attributes. Just use separate since its clearer

Reviewed By: passy

Differential Revision: D48315864

fbshipit-source-id: e73e76d7fb94b3d7bba36a34d408202bc91933be
2023-08-21 04:24:16 -07:00
Luke De Feo
4912b3f47e Fix bottom panel and make it resizable
Summary: The bottom panel got broken during the virtualisation+ panel refactor, we need to tell the tree how much height is taken by the panel so it can size itself accordingly.

Reviewed By: lblasa

Differential Revision: D48313766

fbshipit-source-id: 849886101eb0869cc068fd0ad6dc1d053233043e
2023-08-21 04:24:16 -07:00
Luke De Feo
94114eb821 Add tree id
Summary:
Added new tree id to the framework event. Its currently optional.

The tree id is the parent component tree / tree manager this tree belongs to, this is so we can view all tree events at once in the table.

We ony show the context menu item when we have the tree root tag which is set for component tree only at this point. We can add for blok and ios later

Reviewed By: lblasa

Differential Revision: D48268120

fbshipit-source-id: 3dee06309b146a0392ca32fbb5e8231883b8439a
2023-08-21 04:24:16 -07:00
Luke De Feo
4e7ca39168 Tweaks to tree UI
Summary:
Made rows smaller so you get to see more content
Monospace font

Reviewed By: antonk52

Differential Revision: D47949839

fbshipit-source-id: f8935e233838ff35acf8c1ab14bcf9b8f2153ab4
2023-08-01 10:32:29 -07:00
Luke De Feo
09042ec5d6 Make non visible views non opaque
Summary: On certain apps there are a lot of views that have zero size and this isnt clear from the tree view. This will help

Reviewed By: lblasa

Differential Revision: D47917167

fbshipit-source-id: 180ef1cf34c3735acfd54d3498db9d29f759d959
2023-08-01 10:32:29 -07:00
Luke De Feo
1cf0527a51 Double click to expand or collapse in tree
Reviewed By: aigoncharov

Differential Revision: D47949838

fbshipit-source-id: be7208633cee13579eaa20d3b0bfaa4380a4e399
2023-08-01 10:32:29 -07:00
Luke De Feo
ce1fdfdf19 Added context menu items for collapsing and expanding nodes
Summary:
Added 3 context menu items:
- expand recursive
- collapse recursive

These are self explanatory.

I also collapse non ancestors. This collapses everything except your direct ancestor path to the root. Quite useful to refocus the tree on a node

Changelog: UIDebugger - added  context menu items for exanding and collapsing the tree.

Reviewed By: aigoncharov

Differential Revision: D47949840

fbshipit-source-id: 6eebba182fe2092fbf5f0db0ec5ff728c3900424
2023-08-01 10:32:29 -07:00
Luke De Feo
1394a41599 Fix subtile bug with keyboard controls
Summary:
The code used the hovered node and selected node somewhere inconsistently for keyboard controls, this led to subitle bugs where if you moused over the next keybaord jump point would be the hovered node sometimes. This straightens it all out

Changelog: [UIDebugger] Fixed bug with keyboard tree controls

Reviewed By: aigoncharov

Differential Revision: D47832249

fbshipit-source-id: 7697c97a817ed5b70250c0c4f12fc1c59bdb96b9
2023-08-01 06:41:14 -07:00
Luke De Feo
21483986c3 Fix bug in tree when search term is set
Summary: Previously we would run the effect even if search term hadnt changed causing us to scorll to a search term rather than the selected node when selecting in the visualiser

Reviewed By: antonk52

Differential Revision: D47831188

fbshipit-source-id: 5700d49aea219a1229bcc8df462e55d8508c6c1a
2023-08-01 06:41:14 -07:00
Luke De Feo
c1a99a8a52 ONly show framework event monitoring where there are events
Reviewed By: antonk52

Differential Revision: D47757004

fbshipit-source-id: 44e0e6aff0213d3bf684652906abae28777cfe9e
2023-07-26 04:24:54 -07:00
Luke De Feo
f854e9f3f3 rename controls to tree controls and consistent button style
Reviewed By: mweststrate

Differential Revision: D47672437

fbshipit-source-id: 5ce237cfd300a481450411a0242410e01bcc5411
2023-07-26 03:22:38 -07:00
Luke De Feo
272d2d2106 Redesign Split Tree and visualiser into panels
Summary: This looks a lot neater and allows us to have separate dedicated visualiser header

Reviewed By: mweststrate

Differential Revision: D47626867

fbshipit-source-id: 843721853e0ff88837afbb9bf3f510a908160d12
2023-07-26 03:22:38 -07:00
Luke De Feo
0e15dce033 New Tree design
Summary:
1. Add indent guidess to all tree depths
2. Monospaced font
3. cleaned up alignment of icons
4. Gave everything a bit more space to breathe

Changelog: UI Debugger Tree UI refresh, added indent guides and fixed alignment

Reviewed By: mweststrate

Differential Revision: D47626869

fbshipit-source-id: e4509621cda6c254f7dd5a7ec9b99c13efb577f4
2023-07-26 03:22:38 -07:00
Luke De Feo
6faccc4889 UIDRefactor 8/n rename tree types
Summary: The previous names made no sense after they drifted over time

Reviewed By: lblasa

Differential Revision: D47550916

fbshipit-source-id: fa7df17b090c52b68ab4af9388d87365da6e8ff3
2023-07-21 07:17:31 -07:00
Luke De Feo
d8fda847b8 UIDREfactor 7/n Split tree.tsx
Reviewed By: lblasa

Differential Revision: D47548809

fbshipit-source-id: bdcbc96129a289c64a4a0b17fab29ac91d73d48e
2023-07-21 07:17:31 -07:00
Luke De Feo
2655ea8523 UIDRefactor 6/n Move tree into folder
Summary: preparing to split this up a bit

Reviewed By: lblasa

Differential Revision: D47548840

fbshipit-source-id: 907b9cd6a7a044e4aad97f9755fd9b43b81768f1
2023-07-21 07:17:31 -07:00