Summary:
The previous one was a bit outdated. It's only used in low-res
environments otherwise where that's fine, but let's a more recent
one for the README header.
Pull Request resolved: https://github.com/facebook/flipper/pull/585
Test Plan: eyes
Reviewed By: jknoxville
Differential Revision: D17908742
Pulled By: passy
fbshipit-source-id: 81e3ccf9e1b94bd57d162dd59b0a4dfb8e4366ea
Summary:
Close https://github.com/facebook/flipper/pull/580
This enables Greenkeeper with some caveats:
- I disabled a bunch of upgrades we know currently break:
- React
- Emotion
- Electron/Electron-Builder
- The bot isn't CLA-whitelisted yet, so we won't be able to directly import yet.
- It might actually be better to have automatic tasks created for the dependencies above breaking.
- Something changed in the prop types and required `StatusBar` to have its signature changed.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D17906693
fbshipit-source-id: f73fe231518f56a6f6114f761d5e5e5528d0d487
Summary:
Quite useful if you want to know what the most recent version is.
Pull Request resolved: https://github.com/facebook/flipper/pull/428
Reviewed By: jknoxville
Differential Revision: D15164635
Pulled By: passy
fbshipit-source-id: 4a78b928625d6d71381b0e3e8272372f5f1b654d
Summary:
This will make sure your local pods repo is up to date, so you won't be building against old dependencies.
Pull Request resolved: https://github.com/facebook/flipper/pull/296
Reviewed By: passy
Differential Revision: D10446899
Pulled By: jknoxville
fbshipit-source-id: 61c8832e8d5f7c54a43fc3e419347687756f4883
Summary:
I have a few details left, but its almost done. This PR addresses #145
- The NSUserDefaults plugin uses the SharedPreferences Desktop Part since we can reuse all of it.
- The NSUserDefaults plugin uses swizzling in order to be notified of what specific event changed at runtime.
- Added Test harness in both Sample Swift and Sample apps for iOS in order to test the plugin.
- Updated the documentation in `docs/shared-preferences-plugin.md` and` README.md`
I am open to suggestions since the desktop sharedPreferences version doesn't support deletion of preferences. Most likely I would have to modify the UI, and for that matter, I might as well build a user defaults desktop version
I wanted to add xiphirx in this MR since he developed the shared preferences plugin for Android and Desktop. I don't see a way to remove preferences from the flipper desktop app so I was wondering if you would be OK with me adding that.
Pull Request resolved: https://github.com/facebook/flipper/pull/291
Reviewed By: passy
Differential Revision: D10334685
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d798c01a46df7ddecf713924799f046b560ea922
Summary:
We're in a pretty good state now. Let's get rid of the big warning.
Pull Request resolved: https://github.com/facebook/flipper/pull/285
Reviewed By: jknoxville
Differential Revision: D10161261
Pulled By: passy
fbshipit-source-id: ef1fc03c289a0472916c67bf34c2f9e394c3fef2
Summary:
Took me a moment to figure out how to build it,
so let's add it to the docs.
Reviewed By: jknoxville
Differential Revision: D9654631
fbshipit-source-id: 32ee6e647d9fa85b921d19919c1bbd060615bb8e
Summary:
Without the newline, this gets interpreted as a headline, which looks a bit weird.
Pull Request resolved: https://github.com/facebook/flipper/pull/208
Reviewed By: danielbuechele
Differential Revision: D9194566
Pulled By: passy
fbshipit-source-id: 67d63e072f4f8d0e86f3a2a0a48886e7e5716b40
Summary:
For those not familiar with android and iOS development practices, adding basic build instructions.
Pull Request resolved: https://github.com/facebook/Sonar/pull/185
Reviewed By: passy
Differential Revision: D8991468
Pulled By: jknoxville
fbshipit-source-id: 990dc1217c7b5275d143b915c1b4872b271f4c94
Summary:
This lets `yarn` work properly on Windows. Tested in a Cygwin environment. I also added a note about yarn compatibility to the readme.
Closes https://github.com/facebook/Sonar/pull/138
Reviewed By: danielbuechele
Differential Revision: D8734197
Pulled By: xiphirx
fbshipit-source-id: 19be8bb0653a2b0381224b065df0cac579d72c3b
Summary:
To make it more appealing for people landing on the GitHub page - seeing a nice screenshot is always a plus!
Closes https://github.com/facebook/Sonar/pull/46
Differential Revision: D8476809
Pulled By: danielbuechele
fbshipit-source-id: d26b10069ab5745342156669ff627dd4fdad2fdb
Summary:
Adds windows and linux builds to Sandcastle
allow-large-files
Reviewed By: jknoxville
Differential Revision: D8379581
fbshipit-source-id: 94c80fc91c69f43b7dc0c7eb8b2ee5ace4daf888