Summary:
You know the drill.
Pull Request resolved: https://github.com/facebook/flipper/pull/1530
Test Plan: Checked that `yarn.lock` references the respective new versions.
Reviewed By: nikoant
Differential Revision: D23733338
Pulled By: passy
fbshipit-source-id: abf9812b977542a8b297b88ea16c7c01a062898b
Summary:
Changelog: Fixed react-native-flipper causing Android release builds to fail
https://github.com/facebook/flipper/issues/1325 made progress but did not quite fix https://github.com/facebook/flipper/issues/1303. Android Release builds would still fail because `PackageList` depended on `FlipperPackage` and couldn't find it in release builds. There doesn't appear to be a clear way to set up a debug-only package with React Native's Android autolinking (see https://github.com/react-native-community/cli/issues/1211), so this change creates an empty `FlipperPackage` to satisfy that dependency, while still avoiding bundling the Flipper library into the release build.
(manual linking also works, but seems less-desirable for consumers of the library)
## Changelog
Add an empty `FlipperPackage` to the `release` folder to satisfy the reference put in `PackageList` by the autolinker for release builds.
Pull Request resolved: https://github.com/facebook/flipper/pull/1329
Test Plan:
Verified that release builds did fail without this change (using ReactNativeFlipperExample app)
Successfully built a React Native Android Release app from Android Studio using this library and verified that the APK still did not contain Flipper. Built debug and verified that Flipper still worked as before.
Reviewed By: passy
Differential Revision: D23292543
Pulled By: mweststrate
fbshipit-source-id: cb897a0e6dcdc04e29d676596447ca9dd68182c8
Summary:
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p>
<blockquote>
<h2>4.17.16</h2>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d7fbc52ee0"><code>d7fbc52</code></a> Bump to v4.17.19</li>
<li><a href="2e1c0f22f4"><code>2e1c0f2</code></a> Add npm-package</li>
<li><a href="1b6c282299"><code>1b6c282</code></a> Bump to v4.17.18</li>
<li><a href="a370ac8140"><code>a370ac8</code></a> Bump to v4.17.17</li>
<li><a href="1144918f35"><code>1144918</code></a> Rebuild lodash and docs</li>
<li><a href="3a3b0fd339"><code>3a3b0fd</code></a> Bump to v4.17.16</li>
<li><a href="c84fe82760"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li>
<li><a href="e7b28ea6cb"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li>
<li><a href="0cec225778"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li>
<li><a href="94c3a8133c"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1386
Reviewed By: mweststrate
Differential Revision: D22643186
Pulled By: passy
fbshipit-source-id: 25283f284dd673ca48455b1ff05c8a6b518c8038
Summary:
After `react-native-flipper` 0.48.0 I cannot build releases on android (I think that passed on CI tests because the example was running an older version of this package, 0.47.0).
So I moved all the `android/src/main` content to `android/src/debug` because we will not use Flipper in another Build Variant
## Changelog
I moved all content from `react-native-flipper/android/src/main` to `react-native-flipper/android/src/debug`.
Probably solves https://github.com/facebook/flipper/issues/1303
Pull Request resolved: https://github.com/facebook/flipper/pull/1325
Test Plan: Maybe create a custom CI script to verify if Flipper deps are present on Release Builds, [something like this](https://github.com/facebook/flipper/issues/1274#issue-641197153)
Reviewed By: cekkaewnumchai
Differential Revision: D22333432
Pulled By: passy
fbshipit-source-id: 4abbab5ecbe08d44752b2138569ff60d25724087
Summary: Still got four warnings up for this on GitHub. Let's do the same we do in the rest of the repo.
Reviewed By: mweststrate
Differential Revision: D22233188
fbshipit-source-id: eb76409b1e5ff5735e354bdbd93f875d22f2add2
Summary:
This should fix https://github.com/facebook/flipper/issues/1274
I had some cleaning up to do to get to this point.
Changelog:
Fix `react-native-flipper` dependency pulling in debug-only artifacts into release builds.
Reviewed By: mweststrate
Differential Revision: D22160304
fbshipit-source-id: 0ebc0ed942427f2966bccd721bf01aafa38ba400
Summary:
Remove warning `'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'.`
## Changelog
- swithed from `variant.getJavaCompile()` to `variant.getJavaCompileProvider()`
Pull Request resolved: https://github.com/facebook/flipper/pull/1168
Test Plan: n/a
Reviewed By: passy
Differential Revision: D21618883
Pulled By: cekkaewnumchai
fbshipit-source-id: 522fe5847b074836cc36a9e1b9a0487b044cf555
Summary:
Searched for broken link patterns inside the app itself. I think I found them all but it's not certain.
Patterns searched for and replaced:
```
.html
getting-started/)
getting-started)
getting-started"
```
and also searched the repo for regex `\]\(.*)` and checked them by eye.
Reviewed By: passy
Differential Revision: D21306944
fbshipit-source-id: a2e09b0fd8677f5f26e5cc4a06805b474247f7e6
Summary:
There's `TODO` in the description for `react-native-flipper` so this should be updated
## Changelog
Internal change.
Pull Request resolved: https://github.com/facebook/flipper/pull/1055
Test Plan: No test plan required.
Reviewed By: mweststrate
Differential Revision: D21256140
Pulled By: passy
fbshipit-source-id: 6b07e38b80ac395481270b05fca6823ec6559da5
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.
The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version
Reviewed By: passy
Differential Revision: D20249304
fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
Summary:
In line with, https://github.com/facebook/flipper/pull/874/files, the package should promote itself as iOS 9.0 compatibe, to prevent errors and warnings like:
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] CocoaPods could not find compatible versions for pod "react-native-flipper":
In Podfile:
react-native-flipper (from `../node_modules/react-native-flipper`)
Specs satisfying the `react-native-flipper (from `../node_modules/react-native-flipper`)` dependency were found, but they required a higher minimum deployment target.
```
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Downloading dependencies
Installing react-native-flipper 0.33.1
Generating Pods project
Integrating client project
Pod installation complete! There are 34 dependencies from the Podfile and 38 total pods installed.
[!] The platform of the target `ReactNativeFlipperExample` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
[!] The platform of the target `ReactNativeFlipperExampleTests` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
mweststrate-mbp:ios mweststrate$ cd ..
mweststrate-mbp:ReactNativeFlipperExample
```
Reviewed By: passy
Differential Revision: D20362156
fbshipit-source-id: 766d033f2ea2e5559a72a3473115bc4a470a284f
