jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,884 Commits 1 Branch 0 Tags
d02bfabfbf94bba03580b9c7065d3dfee52c6064
Commit Graph

43 Commits

Author SHA1 Message Date
Pascal Hartig
7d58037ad6 Improve errors around screen capture 
Summary:
Tasks like T143443148 pop up frequently and are inactionable. This is usually due to device flakiness, storage being full, incompatibility or configuration problems.

Start and stop were also copy-pasted to make matters worse.

Reviewed By: ivanmisuno

Differential Revision: D42800489

fbshipit-source-id: 11caaa4133e4fa1d773364a6ba4e5f5bb0d2f2ce
 2023-01-30 03:18:19 -08:00
Andrey Goncharov
10e415655c Fix table flickering without hiding content 
Summary:
Followup of D39772453 (2437aeb3e9)
Fixes https://fb.workplace.com/groups/flippersupport/permalink/1518236858656967/

1. Stop using clientWidth and offsetWidth because they have rounding errors
2. Since step 1 did not resolve the issue entirely (for some weird reason I do not really have the capacity now to investigate - my bet it is a rounding error when you sum up doubles) set offset of the table to "scroll" instead of "auto". As a result, it starts rendering space for the scrollbars all the time, but since Flipper is a dev tool it should be fine

Reviewed By: antonk52

Differential Revision: D41839402

fbshipit-source-id: cf50eb1600b692d3970003fd1b45b953ee45e3df
 2022-12-09 04:06:58 -08:00
Ranesh Saha
7a28ed1fe5 Pipe through --updater/--no-updater flag for flipper.exe (#4277) 
Summary:
In our organization, Flipper is distributed in a version controlled way. As a result, we do not want users to manually update or receive prompts to update when a new version is available. There is already a `--updater` flag in the command line arguments for flipper.exe, but it isn't piped through. This change pipes it through and disables all update related UI when `--no-updater` is passed in.
## Changelog

Support --updater and --no-updater options for flipper.exe

Pull Request resolved: https://github.com/facebook/flipper/pull/4277

Test Plan: Ran `yarn build --win` in flipper/desktop, and launched flipper.exe from flipper/dist/win-unpacked with the `--updater`, `--no-updater` and no flags and ensured the proper behavior was observed (update UI shows by default or when `--updater` is specified, and doesn't show when `--no-updater` is specified).

Reviewed By: passy

Differential Revision: D41298321

Pulled By: mweststrate

fbshipit-source-id: 5ddfede2700954f0fdd6a111b20d0836fab25565
 2022-11-15 03:23:55 -08:00
Andrey Goncharov
0e5af8095f Stash and export debug logs 
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#

Stash all logs including debug ones for the export

Reviewed By: lblasa

Differential Revision: D40467905

fbshipit-source-id: 963ce8e92d2131220640a63f5e9c38f4317af061
 2022-10-25 05:31:48 -07:00
Andrey Goncharov
2437aeb3e9 Fix AutoResizer flickering 
Summary: https://github.com/bvaughn/react-virtualized/issues/773

Differential Revision: D39772453

fbshipit-source-id: 613b809201d7dca34a0322c0cc65468f2fba2b08
 2022-09-23 12:08:09 -07:00
Ken Yee
fa9ba6f2d0 Adds a notifyAvailableUpdate flag to config.json to disable update (#3992) 
Summary:
We would like to version control Flipper and some of our custom plugins that are installed on developers' systems.
Flipper by default prompts users to upgrade so they sometimes do the update and then all our custom plugins break because they were compiled for an older version.
See https://github.com/facebook/flipper/issues/3947 for feature request info.

## Changelog

Adds notifyAvailable flag to config.json to disable prompting for users that "an update is available"

Pull Request resolved: https://github.com/facebook/flipper/pull/3992

Test Plan:
Tested by running locally.
Had to comment out the isProduction() check to confirm this it worked properly because this flag is false on dev versions.
Couldn't figure out how to manually test the handleOpenPluginDeeplink.tsx change but made a similar change there; happy to test that if you can tell me how to exercise that path.

Reviewed By: antonk52

Differential Revision: D39654481

Pulled By: antonk52

fbshipit-source-id: cef6b48d870915c48f620269c42d24b8ef1f4c29
 2022-09-21 09:47:44 -07:00
Andrey Goncharov
650ff4bcfb Remove plugin bundling 
Summary: Remove the notion of bundled plugins

Reviewed By: lblasa

Differential Revision: D39308888

fbshipit-source-id: aa88ddbf2801ad1da95f89e4c761259b697b0d66
 2022-09-15 10:02:19 -07:00
Feiyu Wong
3ffb25e672 Update UI for enabling persisted logs feature 
Summary:
This is the first diff to implement the feature for the Flipper logs plugin to have an option to persist logs in the table between crashes, disconnections, etc.

Since this is not a local change, the UI option for persistence will be located in the settings for the Flipper UI(as seen in the test plan). The setting is associated with the Redux Store `Settings` and is stored globally to be used across all plugins. So the plan is making the persistence pertain to all plugins.

Reviewed By: mweststrate

Differential Revision: D37786988

fbshipit-source-id: 7ffc6077cbca559b3401b16770eda657a6c45620
 2022-07-28 13:56:34 -07:00
Feiyu Wong
f46cf2b0ce Added color options for highlighting search terms 
Summary:
This diff builds on the previous ones by enabling other colors to be used as highlights for the search terms. Current color options are: yellow(default), red, blue, green. Possible extensions to this feature could include allow the user to enter a custom hex-color string and use that as the highlight color.

Changelog: DataTable will now have option to have its search terms highlighted in the search results by toggling and customizing the highlight colors in the menu bar

Reviewed By: mweststrate

Differential Revision: D37383163

fbshipit-source-id: c81e383c0570ef5efbf3171b92b81a8fb2e55ea7
 2022-06-29 10:36:52 -07:00
Feiyu Wong
2f39ede6f7 Highlight search terms in logs with yellow when highlight search setting is enabled 
Summary: Building on the previous diff which added a setting to enable/disable highlighting search terms in the logs. This diff adds the actual highlighting and connects with the setting. The highlighting currently only supports one color, while the next diff will seek to support a preset of a "custom" colors for the highlighting

Reviewed By: mweststrate

Differential Revision: D37348441

fbshipit-source-id: 7a2b74b16f239d5e36c213e06ccb86f74eaa8df5
 2022-06-29 10:36:52 -07:00
Lorenzo Blasa
335dec1a08 Adds some settings to check flipper-server state 
Summary:
There's one setting: to enable or disable flipper-server.

However, I've added some current running state to it. If there's a better way of doing this, please do let me know.

Reviewed By: aigoncharov

Differential Revision: D37276670

fbshipit-source-id: f6c941cf0cfe55c267b9bcb9f799934fba1e28ef
 2022-06-22 05:26:11 -07:00
Andrey Goncharov
17ab7a86ef Use getRenderHost from flipper-frontned-core in flipper-ui-core 
Summary: See D37139129

Reviewed By: lblasa

Differential Revision: D37236435

fbshipit-source-id: 927e9f741bfedb65165f5d24f0acfb775925cdc7
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
fd380a4c1e Use BaseDevice from flipper-frontend-core in flipper-ui-core 
Summary: Use BasDevice definition from flipper-frontend-core in flipper-ui-core and remove the redundant definition from flipper-ui-core

Reviewed By: lblasa

Differential Revision: D37234785

fbshipit-source-id: 6e768090a197c1d2c49cb1cd573acea12fb65d24
 2022-06-20 12:18:40 -07:00
Pascal Hartig
b25a212890 Remove SupportRequestFormV2 
Summary: This is now replaced by the support entry point and we need to delete the calling sites before we can clean up the everstore type.

Reviewed By: lawrencelomax

Differential Revision: D37090901

fbshipit-source-id: 597684bb149783d75e46ba61113e73878bf271a8
 2022-06-13 07:16:47 -07:00
Andrey Goncharov
59761ecd50 Mark deprecated plugins in the UI 
Summary:
Changelog: Add a deprecation warning for deprecated plugins.

Closes https://github.com/facebook/flipper/issues/2074

Reviewed By: lblasa, antonk52

Differential Revision: D36760209

fbshipit-source-id: 64cf799644f28aeedf88824c949738a6a766b094
 2022-05-30 07:32:12 -07:00
dependabot[bot]
7f68a4d673 Bump antd from 4.18.5 to 4.19.2 in /desktop (#3551) 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3551

Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.5 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<ul>
<li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>🐞 修复 Dropdown 在边界情况下不会自动调整展示位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 缩小 PageHeader <code>extra</code> 内元素间距为 <code>8px</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 导出 antd/es/config-provider 目录下的 css variable 函数以支持 ssr 的需求。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 使用 React hooks 重构 Menu。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 修复大尺寸 Input 的字号问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 修复 Input.Group 多余的错误边框样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 修复 Form.Item 在 <code>form.validateFields</code> 中移除时抛出 <code>Can't perform a React state update on an unmounted component</code> 警告的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 修复 Form 组件当 <code>preserve</code> 为 <code>false</code> 时 <code>initialValues</code> 会被更改的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 修复 Tooltip 在 Safari 下的内容宽度问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 修复 Tooltip/Popover/Popconfirm 等组件箭头大小问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 优化 Collapse 简洁模式的底边框。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� 修复 Input 不支持 <code>data-*</code> TS 定义的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� 修复 Transfer 的 <code>footer</code> 类型定义。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<h2>4.19.1</h2>
<ul>
<li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li>
<li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li>
</ul>
</li>
<li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>
<hr />
<ul>
<li>🐞 修复自定义状态相关的 less 编译错误 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 修复使用定制主题时 less 编译提示 <code>ReferenceError: colorPalette is not defined</code> 错误。</li>
<li>🐞 修复引入 <code>antd/dist/antd.css</code> 时提示 <code>Error: Invalid class or id selector syntax</code> 错误。</li>
</ul>
</li>
<li>🐞 修复 Input.Passowrd 图标颜色错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 修复 ConfigProvider <code>csp</code> 有时在 Icon 上不会生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<p><code>2022-03-13</code></p>
<ul>
<li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<h2>4.19.1</h2>
<p><code>2022-03-08</code></p>
<ul>
<li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li>
<li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li>
</ul>
</li>
<li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>
<h2>4.19.0</h2>
<p><code>2022-03-08</code></p>
<ul>
<li>
<p>💄 Optimize arrow style for some components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33710">#33710</a></p>

</li>
<li>
<p>Input</p>
<ul>
<li>🛠 Refactor Input with rc-input. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34206">#34206</a>
<ul>
<li>Attention: The type and value of <code>ref</code> is modified because of refactoring from class component to function component. You can still get DOM node from <code>input</code>, and other methods such as <code>focus</code> and <code>blur</code> mentioned in document are also supported.</li>
</ul>
</li>
<li>🆕 Support <code>clearIcon</code> prop for customizing clear icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34325">#34325</a></li>
</ul>
</li>
<li>
<p>Table</p>
<ul>
<li>🆕 <code>filterSearch</code> now support passing function to customize search. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34085">#34085</a> <a href="https://github.com/heiyu4585"><code>@​heiyu4585</code></a></li>
<li>🆕 <code>column.filterDropdown({ clearFilters })</code> support <code>clearFilters({ confirm: false, closeDropdown: false })</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34120">#34120</a> <a href="https://github.com/heiyu4585"><code>@​heiyu4585</code></a></li>
<li>⌨️ Table adds <code>aria-sort</code> attribute for screen readers. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33603">#33603</a> <a href="https://github.com/dgreene1"><code>@​dgreene1</code></a></li>
<li>🐞 Fix Table filters select-all Checkbox not changed when select item. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34295">#34295</a></li>
</ul>
</li>
<li>
<p>🆕 Data entry components add <code>status</code> prop to support custom status.</p>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="085a9e9235"><code>085a9e9</code></a> chore: upgrade rc-menu to 9.3.x (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34473">#34473</a>)</li>
<li><a href="01dceec0c7"><code>01dceec</code></a> docs(✨ ): changelog for 4.19.2 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34472">#34472</a>)</li>
<li><a href="ed47a8e1ea"><code>ed47a8e</code></a> docs(module:timeline): fix typo (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34389">#34389</a>)</li>
<li><a href="2e27c00293"><code>2e27c00</code></a> chore: export css variable func (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34436">#34436</a>)</li>
<li><a href="c50bbe64bb"><code>c50bbe6</code></a> chore: refactor internal menu with hooks (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34433">#34433</a>)</li>
<li><a href="f987bd0479"><code>f987bd0</code></a> fix: PageHeader extra gutter (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34428">#34428</a>)</li>
<li><a href="86415ef8a2"><code>86415ef</code></a> docs(Table): replace the link of <code>TableComponents</code> prop with <code>rc-table</code> type ...</li>
<li><a href="fca7210309"><code>fca7210</code></a> fix: Tooltip width in safari (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34415">#34415</a>)</li>
<li><a href="362a99e9d4"><code>362a99e</code></a> feat: hide the last border in borderless mode (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34366">#34366</a>)</li>
<li><a href="fbb98f2b4f"><code>fbb98f2</code></a> Fix InputProps supports data attributes (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34410">#34410</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.5...4.19.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.5&new-version=4.19.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3531

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

   yarn start --no-launcher

{F711751713}

Reviewed By: mweststrate

Differential Revision: D34867418

Pulled By: lblasa

fbshipit-source-id: 6af37b791f4e232dc3ae7b7350d2091f4e2f246f
 2022-03-17 10:02:20 -07:00
Anton Nikolaev
37ff34390a Enable Marketplace for Flipper (#3491) 
Summary:
This is PR on top of: https://github.com/facebook/flipper/pull/3473

It adds an option to Settings to allow distribution of marketplace plugins.

Also includes a simple fetch function to retrieve data from external API/server.

## Changelog

Allow marketplace plugins

Pull Request resolved: https://github.com/facebook/flipper/pull/3491

Test Plan:
1. Enable marketplace
2. Provide custom marketplace server (it will serve the list of internal plugins with downloadURL)
3. Test if can see Available plugins and can download/remove the plugin
4. If new update for the plugin, it should also allow auto update

Reviewed By: antonk52

Differential Revision: D34586339

Pulled By: nikoant

fbshipit-source-id: c887982aa0f0f9abd3b5360f22e8692a2445d345
 2022-03-07 02:49:49 -08:00
Andrey Goncharov
6c74f2dd18 Set device features on device initialization 
Summary:
1. Identify if device supports screenshots/screen recording when it is created.
2. Disable screen recording/screenshot buttons when they are not supported

Reviewed By: passy

Differential Revision: D34611133

fbshipit-source-id: 82ad2d67e4af482d9becf7995187667b5d99bc36
 2022-03-04 02:00:23 -08:00
dependabot[bot]
e9da574720 Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code>&lt;Icon component={HomeOutlined} /&gt;</code> 和 <code>&lt;HomeOutlined /&gt;</code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li>
<li>🐞 修复 <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@​dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@​hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@​developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@​wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da"><code>8217c54</code></a> docs(✨): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822">#33822</a>)</li>
<li><a href="578aaad7f2"><code>578aaad</code></a> test: fix lint</li>
<li><a href="ab8fc12fa7"><code>ab8fc12</code></a> docs: add Plasmic for Ant (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758">#33758</a>)</li>
<li><a href="a65ba8aa8a"><code>a65ba8a</code></a> docs: update sentence structure in the FAQ section (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33816">#33816</a>)</li>
<li><a href="e55a68670f"><code>e55a686</code></a> chore(deps): update dependency simple-git to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33817">#33817</a>)</li>
<li><a href="fe23374871"><code>fe23374</code></a> fix: Invalid hook dependency array in Sider and Row (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804">#33804</a>)</li>
<li><a href="75adc23fe3"><code>75adc23</code></a> chore: i18n contributing docs improve (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760">#33760</a>)</li>
<li><a href="9cf0dca8fc"><code>9cf0dca</code></a> test: fix cascader test coverage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33802">#33802</a>)</li>
<li><a href="5d2994ec12"><code>5d2994e</code></a> style: Cascader loading icon (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799">#33799</a>)</li>
<li><a href="6dd39c1f89"><code>6dd39c1</code></a> fix(checkbox): disabled checkbox should works well with tooltip (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.2&new-version=4.18.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3346

Reviewed By: aigoncharov

Differential Revision: D33741775

Pulled By: lblasa

fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
 2022-01-28 03:09:50 -08:00
Simek
903476bdad use centered prop for variable height modals (#3334) 
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.

Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.

## Changelog

* use `centered` prop for variable height modals to improve UI in small app window

Pull Request resolved: https://github.com/facebook/flipper/pull/3334

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png">

<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png">

#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png">

Reviewed By: mweststrate

Differential Revision: D33741484

Pulled By: lblasa

fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
 2022-01-26 04:23:05 -08:00
Simek
1c91d28390 improve dev perf canvas readability (#3333) 
Summary:
This PR updates the performance Canvas widgets readability in Dev mode.

Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text.

Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text.

## Changelog

* improve the performance canvas widgets readability in Development mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3333

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Dark Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png">

#### Light Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png">

Reviewed By: aigoncharov

Differential Revision: D33738722

Pulled By: lblasa

fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775
 2022-01-24 08:52:22 -08:00
Simek
f1b83a96fd do not add GrayedOutOverlay if there is no children (#3329) 
Summary:
Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children.

Current approach was causing UI issue in the Settings Modal in dark mode.

## Changelog

* do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children

Pull Request resolved: https://github.com/facebook/flipper/pull/3329

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png">

Reviewed By: aigoncharov

Differential Revision: D33738627

Pulled By: lblasa

fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d
 2022-01-24 05:42:22 -08:00
Simek
4b0091df0f fix Plugins table UI glitch in dark mode, add column name (#3332) 
Summary:
Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table.

I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns).

## Changelog

* fix Plugins table UI glitch in dark mode, add column name

Pull Request resolved: https://github.com/facebook/flipper/pull/3332

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)
<img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png">
<img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png">

Reviewed By: aigoncharov

Differential Revision: D33738705

Pulled By: lblasa

fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8
 2022-01-24 03:56:59 -08:00
Simek
d897cfd765 fix Settings modal UI glitch with overlow in dark mode (#3330) 
Summary:
This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting.

## Changelog

* fix Settings modal UI glitch with content overflow setting in dark mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3330

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### No scrollbar

<img width="390" alt="Screenshot 2022-01-23 at 15 45 47" align="left" src="https://user-images.githubusercontent.com/719641/150684278-b09031bd-9b8c-4c9c-9ac2-2dba3c1af63d.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 45 39" src="https://user-images.githubusercontent.com/719641/150684279-151b83d6-c819-45e0-a662-3d294f4f6a77.png">

#### With scrollbar
<img width="390" alt="Screenshot 2022-01-23 at 15 51 40" align="left" src="https://user-images.githubusercontent.com/719641/150684331-a8f27623-9a2b-4ffe-b4c1-3fb06a6362a2.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 51 47" src="https://user-images.githubusercontent.com/719641/150684330-57434f21-0d4d-4ef6-be41-fdd88d082d1b.png">

Reviewed By: aigoncharov

Differential Revision: D33738647

Pulled By: lblasa

fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec
 2022-01-24 02:33:42 -08:00
Michel Weststrate
9267a19c89 Fix settings not being saved before restart 
Summary:
2022 New years intention: don't fix problems with arbitrarily timeouts

In production builds, settings weren't saved if apply + restart was used (apply and manual restart did work). I suspect a bug in redux-persist, since we do await a flush, but anyway a little delay seems to fix it consistently.

Changelog: Fixed an issue where changing settings wasn't persisted when using "Apply + Restart

P.S. I won't accept any insinuations that this was my new years intention of 2015, 2017, 2018, 2020 and 2021 as well.

Reviewed By: cekkaewnumchai

Differential Revision: D33377718

fbshipit-source-id: 3a9ec58b4f8208603d786342ddaf6bf02b3887c7
 2022-01-04 04:18:16 -08:00
Michel Weststrate
b77b234e98 fix table header column widths deviating from rows 
Summary:
changelog: Improved column widths in data tables

This diff fixes two issues:
1) dynamic width columns became invisible if there is too much else, and therefor it was hard to make them bigger or even notice them
2) column headers could be out of sync with the actually rendered rows, due to minor styling differences

Reviewed By: cekkaewnumchai

Differential Revision: D33364781

fbshipit-source-id: c3d47bb8db4af521859a5cbdf525d8ce39c71d00
 2022-01-04 04:08:23 -08:00
dependabot[bot]
4e11458655 Bump antd from 4.16.8 to 4.18.0 in /desktop (#3222) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.16.8 to 4.18.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>🐞 修复 Skeleton 不支持 <code>style</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 修复 Descriptions 内使用其他组件会被切割的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 统一类 Select 组件泛型定义为 OptionType 以支持自定义 FieldNames 匹配。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 修复 Slider 禁用时 <code>hover</code> 色彩的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> 与 <code>rowSpan</code> 迁移至 <code>onCell</code> 方法中，以优化渲染性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table 支持 Table.EXPAND_COLUMN 和 Table.SELECTION_COLUMN 以实现自定义列排序。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List 嵌套使用 Form.Item 时不再需要手工指定 <code>fieldKey</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form 现在支持通过 <code>labelWrap</code> 开启标签可换行。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider 支持 Form 的 colon 配置。<a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 <code>InputNumber</code> 增加 <code>prefix</code> 属性支持。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal 静态方法支持 <code>wrapClassName</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm 新增是否显示取消按钮。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button 新增 <code>loading</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input 新增 <code>showCount</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert 支持 <code>closeIcon</code> 自定义关闭图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 对于可编辑段落，可以通过配置 <code>triggerType</code> 配置触发编辑状态。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography 支持 <code>enterIcon</code> 以设置编辑确认图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<p><code>2021-12-27</code></p>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<h2>4.17.4</h2>
<p><code>2021-12-19</code></p>
<ul>
<li>🐞 Fix a bug that Form.Item name is &quot;parentNode&quot; casue endless loop and memory leak. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31846">#31846</a> <a href="https://github.com/DaoxingHuang"><code>@​DaoxingHuang</code></a></li>
<li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32448">#32448</a> to fix emoji input at Input.TextArea. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33312">#33312</a></li>
</ul>
<h2>4.17.3</h2>
<p><code>2021-12-08</code></p>
<ul>
<li>🐞 Fix Drawer broken style caused by title width. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33205">#33205</a></li>
<li>🐞 Fix Badge flash style when switch from <code>display:none</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33083">#33083</a> <a href="https://github.com/songlinn"><code>@​songlinn</code></a></li>
<li>💄 Change Anchor className form <code>.fixed</code> to <code>.ant-anchor-fixed</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33085">#33085</a> <a href="https://github.com/tangjinzhou"><code>@​tangjinzhou</code></a></li>
<li>💄 Fix Button loading style missing in Firefox. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33199">#33199</a></li>
<li>Select
<ul>
<li>🐞 Fix Select width became small when searching. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32988">#32988</a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="41ac1f0c1a"><code>41ac1f0</code></a> chore: 4.18.0 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33424">#33424</a>)</li>
<li><a href="24458eb54e"><code>24458eb</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33423">#33423</a>)</li>
<li><a href="b3cc1e5276"><code>b3cc1e5</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33422">#33422</a>)</li>
<li><a href="7ae451729f"><code>7ae4517</code></a> test: update snapshot</li>
<li><a href="6ed4d855b1"><code>6ed4d85</code></a> Merge remote-tracking branch 'origin/master' into feature-merge-master</li>
<li><a href="73ac1b1aaa"><code>73ac1b1</code></a> docs: Update practical-projects.zh-CN.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33419">#33419</a>)</li>
<li><a href="7f09f0a604"><code>7f09f0a</code></a> chore(deps): update dependency scrollama to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33418">#33418</a>)</li>
<li><a href="9c086c5328"><code>9c086c5</code></a> fix: Skeleton missing style (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33405">#33405</a>)</li>
<li><a href="f1e0c9c1d2"><code>f1e0c9c</code></a> chore: Internal Menu interface for ProLayout usage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33399">#33399</a>)</li>
<li><a href="0edf04253e"><code>0edf042</code></a> fix: Descriptions default overflow value (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33392">#33392</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.16.8...4.18.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.16.8&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3222

Reviewed By: timur-valiev

Differential Revision: D33348265

Pulled By: nikoant

fbshipit-source-id: e219049791c8341b4795fc8b742edaa61ee7559d
 2022-01-01 20:28:45 -08:00
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta 
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
 2021-12-27 14:31:45 -08:00
Michel Weststrate
5df34a337c Unshare global types 
Summary:
This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package.

This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup.

As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same.

Reviewed By: lawrencelomax

Differential Revision: D33124441

fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7
 2021-12-17 07:36:07 -08:00
Michel Weststrate
78413c1ecf Register shortcuts on window instead of globally 
Summary:
Changelog: Register shortcuts only for Flipper application instead of globally. Fixes https://github.com/facebook/flipper/issues/3090

As reported, during decapitation we accidentally started registering shortcuts globally, rather per app as it used to be in the menu's. This diff fixes that and also makes sure shortcuts are supported in the browser version of flipper

Reviewed By: lawrencelomax

Differential Revision: D33158445

fbshipit-source-id: 8371e5b96e772152eeb93ba990e1f5edb9e67085
 2021-12-16 14:51:08 -08:00
Michel Weststrate
accef856fc Remove remaining Node imports from core 
Summary:
Removed remaining path / fs imports from Flipper core.

`expand-tide` needed replacement too, but noticed that it never actually rewrites paths since all use cases were already using absolute paths, so removed it instead.

Reviewed By: aigoncharov

Differential Revision: D33017654

fbshipit-source-id: e12f66ef68b5f9e4279411c94445a2fb87249e9a
 2021-12-13 05:48:17 -08:00
Michel Weststrate
bb23b36051 Fixed flipper settings not being loaded / saved on fresh install 
Summary:
I was running flipper-server on a fresh machine without Flipper installed and discovered that reading / writing settings failed since `~/.flipper` wasn't existing, due to using `access` instead of `pathExists`.

Added a warning about needing to restart the server after making changes, since that is tricky to do from the UI.

Fixed an issue in the settings screen, which would fs.stat as part of rendering, causing the Settings UI not to load.

Reviewed By: timur-valiev, aigoncharov

Differential Revision: D32984538

fbshipit-source-id: 2b2011ad9d84c72ac824d92a8c96f636237b8771
 2021-12-10 17:59:33 -08:00
Michel Weststrate
943d535e86 Move sending intern requests from client to server 
Summary: This diff moves send intern request from the browser to the server. The reason to make this change is that making such requests from a browser environment causes CORS restrictions to kick in.

Reviewed By: nikoant

Differential Revision: D32835449

fbshipit-source-id: e8e92e51ca963aa50b3c859bb61c2381171e85ae
 2021-12-08 04:30:57 -08:00
Michel Weststrate
129cbd6f7b Move changelog loading to server 
Summary: per title

Reviewed By: aigoncharov

Differential Revision: D32723706

fbshipit-source-id: ce5108da9f5da6fdfa7d1a66a31a4f8f430eb78d
 2021-12-08 04:30:56 -08:00
Michel Weststrate
eab4f0d3d3 Bits & pieces 
Summary: Added a command to let a file be opened by the OS, and some other small bits and pieces to make Flipper browser compatible.

Reviewed By: lblasa

Differential Revision: D32721748

fbshipit-source-id: a4ad1c2f662f4651ddf6c20c57e5af1e123914a8
 2021-12-08 04:30:56 -08:00
Michel Weststrate
2b4981c7cb Remove remaing from 'os' imports 
Summary: Per title.

Reviewed By: passy

Differential Revision: D32721206

fbshipit-source-id: 9e465d0ed60c0c6da33c462aa76468faac620626
 2021-12-08 04:30:56 -08:00
Michel Weststrate
2480ed30c5 Move flipper-doctor check running to flipper-server-core 
Summary: Per title. Two new server API's: get-healthchecks, and run-healtcheck. Types have all been moved to flipper-common, so that they can be used by doctor, server-core and ui-core packages. Since it were quite some, moved them into a FlipperDoctor namespace.

Reviewed By: nikoant

Differential Revision: D32720510

fbshipit-source-id: 37aa35cde6ebd58479cf0dffec5b7b2da6d22198
 2021-12-08 04:30:56 -08:00
Michel Weststrate
64747dc417 move plugin management from ui-core to server-core 
Summary:
Follow up of D32665064, this diff moves all plugin management logic from flipper-ui to flipper-server. Things like downloading, installing, querying new plugins.

Loading plugins is handled separately in the next diff.

Reviewed By: nikoant

Differential Revision: D32666537

fbshipit-source-id: 9786b82987f00180bb26200e38735b334dc4d5c3
 2021-12-08 04:30:56 -08:00
Michel Weststrate
e7f841b6d2 Move flipper plugin from flipper-lib types to flipper-common 
Summary: Moved all types related to plugin descriptions from plugin-lib (which handles downloads and such) to flipper-common. The goal of that is to remove all plugin-lib usage from ui-core to server-core, so that the UI itself doesn't do any file operations anymore related to plugins. That will be done in next diffs, this just moves types but no code.

Reviewed By: nikoant, aigoncharov

Differential Revision: D32665064

fbshipit-source-id: 86d908e7264569b0229b09290a891171876c8e00
 2021-12-08 04:30:55 -08:00
Michel Weststrate
2bf8ae2364 Get rid of perf_hooks package in Flipper UI 
Summary:
perf_hooks is no longer needed as these APIs are widely available in both browser and electron.

Still needed in unit tests, as they run from Node

Reviewed By: lblasa, aigoncharov

Differential Revision: D32648253

fbshipit-source-id: 5718ea99b57f96f6858311fd0815ad18c476c99e
 2021-12-08 04:30:55 -08:00
Michel Weststrate
bca169df73 Move settings, launcherSettings, GKs to app / flipper-server-core 
Summary:
This diff moves a lot of stuff from the client to the server. This diff is fairly large, as a lot of concept closely relate, although some things have split off to the earlier diffs in the stack, or are still to follow (like making intern requests).

This diff primarily moves reading and storing settings and GKs from client to server (both flipper and launcher settings). This means that settings are no longer persisted by Redux (which only exists on client). Most other changes are fallout from that. For now settings are just one big object, although we might need to separate settings that are only make sense in an Electron context. For example launcher settings.

Reviewed By: passy, aigoncharov

Differential Revision: D32498649

fbshipit-source-id: d842faf7a7f03774b621c7656e53a9127afc6192
 2021-12-08 04:30:54 -08:00
Andrey Goncharov
225a2a7e34 Refactor Stella plugin 
Summary:
1. Replace old FileSelector with the new FileSelector
2. Remove showOpenDialog from FlipperLib

Reviewed By: mweststrate

Differential Revision: D32667103

fbshipit-source-id: be8da034c2695f83b397b6c7d35bc6aee78d66e5
 2021-11-26 08:30:13 -08:00
Michel Weststrate
7e50c0466a Move app/src (mostly) to flipper-ui-core/src 
Summary:
This diff moves all UI code from app/src to app/flipper-ui-core. That is now slightly too much (e.g. node deps are not removed yet), but from here it should be easier to move things out again, as I don't want this diff to be open for too long to avoid too much merge conflicts.

* But at least flipper-ui-core is Electron free :)
* Killed all cross module imports as well, as they where now even more in the way
* Some unit test needed some changes, most not too big (but emotion hashes got renumbered in the snapshots, feel free to ignore that)
* Found some files that were actually meaningless (tsconfig in plugins, WatchTools files, that start generating compile errors, removed those

Follow up work:
* make flipper-ui-core configurable, and wire up flipper-server-core in Electron instead of here
* remove node deps (aigoncharov)
* figure out correct place to load GKs, plugins, make intern requests etc., and move to the correct module
* clean up deps

Reviewed By: aigoncharov

Differential Revision: D32427722

fbshipit-source-id: 14fe92e1ceb15b9dcf7bece367c8ab92df927a70
 2021-11-16 05:29:21 -08:00