Summary: Set a timeout period to become ready. It is better to kill the server if not ready, than keeping it alive.
Reviewed By: antonk52
Differential Revision: D50004605
fbshipit-source-id: be1d2c022c634ece059fc03eb6faea695431ba95
Summary: Change the button title when clicked.
Reviewed By: mweststrate
Differential Revision: D49954493
fbshipit-source-id: 3d689effc0cc5587ab8a07901b66139577b21837
Summary: Track whenever the server is unable to bind to the specified port.
Reviewed By: antonk52
Differential Revision: D49951304
fbshipit-source-id: 971d7c324f27c287036707d21bb51d26acbd6615
Summary:
Simplify how messages (state updates) are shown in Flipper UI.
This main change was introduced as a way to show the 'Start' server button whenever we were in a disconnected state. This is not as simple as the server may be restarting or the client may be even have reset the WS connection. Hence you the experience where this UI is shown and immediately dismissed.
This UI is only ever shown if at one point the server was alive, period. So, in this case, either the server becomes available again OR the user quits the PWA/tab/browser and launches again.
IMHO, this is a better experience that totally assuming the server is dead.
In a next iteration, we can be more clever and have a timeout such that if after a set period of time the server doesn't become online, then we show a button to start (or force kill) the server.
Reviewed By: aigoncharov
Differential Revision: D49915698
fbshipit-source-id: 03fcc150ed1f1303d1d727c82a71eb32616208e8
Summary:
^
Also, if an error happens, do not swallow it, rethrow.
Reviewed By: passy
Differential Revision: D49912780
fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2
Summary: Also remove the suppress error usage as is it was never used.
Reviewed By: aigoncharov
Differential Revision: D49910876
fbshipit-source-id: 7267eaddadb73ab2b6e2aab0045157271ceed427
Summary: When a user pastes anything, it is treated as an input for a search through the entire row
Reviewed By: lblasa
Differential Revision: D49948975
fbshipit-source-id: 2dd23d4ee0819623549d88eb077c7b2d2fdf604f
Summary:
When a user enters any arbitrary text, we will treat as an input for the search through the entire row.
Based on feedback from https://fb.workplace.com/groups/flippersupport/permalink/1703929480087703/
Reviewed By: lblasa
Differential Revision: D49911868
fbshipit-source-id: 4c569e4b01e468f0ca112ea4b00fe143b30bed2a
Summary: If we are unable to bind to the specified port, exit process.
Reviewed By: passy
Differential Revision: D49908107
fbshipit-source-id: 6d76f3d661ec61867be5307c756e372a7b20a9f6
Summary:
The icon was not shown in the past as it was indefinitely bouncing on the dock.
This is fixed now by asynchronously initiating the Node server process and then waiting until it becomes ready.
Reviewed By: passy
Differential Revision: D49907976
fbshipit-source-id: cdeaa578be42d9f5308e2e0df50872858b8248c3
Summary: One log was misplaced, also added another one.
Reviewed By: passy
Differential Revision: D49873310
fbshipit-source-id: b391e2be600070eb96e6cd53846f5665f8400edc
Summary:
Metamate says:
This diff adds documentation for VPN-less Interngraph requests in Flipper. The changes include adding a new file to the Flipper documentation with information on how to use VPN-less Interngraph requests and updating the sidebar to include the new documentation.
Reviewed By: lblasa
Differential Revision: D49907281
fbshipit-source-id: 9e541e0c6e64215db1c3b899df45d5f9fbdaa0da
Summary: Old MasterDetail and DataTable (pre-power search) are using `extraActions` prop which no longer exists in teh new components. This diff adds a fallback.
Reviewed By: ivanmisuno
Differential Revision: D49869730
fbshipit-source-id: 4c1a658aa94acc770836f9bf296a3df7d6cdcb3e
Summary:
Original commit changeset: 9d09d9660dfa
This breaks the build on GitHub.
Original Phabricator Diff: D49772851
Reviewed By: antonk52
Differential Revision: D49829328
fbshipit-source-id: 88f4a29abe148b1427ed9af5bd8b6d0c14066343
Summary:
If no version information is obtained, check if port is in use.
This is for the cases in which an older server which may not have implemented this endpoint fails to return version information.
In this case, send the shutdown command.
Reviewed By: antonk52
Differential Revision: D49830759
fbshipit-source-id: 6c9763d01f335ecc8a28df3b90d319f98016c2da
Summary: Currently, we are not interested in these errors. Let's add some logging as a way of knowing if they take place and why.
Reviewed By: antonk52
Differential Revision: D49828378
fbshipit-source-id: f741a45e1ba9892aa54dca85f97bcc419e0b5e25
Summary: Some columns set title to an empty string
Reviewed By: lblasa
Differential Revision: D49826852
fbshipit-source-id: 3661394323dade813295420a1186d9297a8be153
Summary: We treat every column without the power search config as if it contains strings. Sometimes that might bite us, for instance, when the column contains an object.
Reviewed By: lblasa
Differential Revision: D49822511
fbshipit-source-id: 18dadb5abe624fae510663fc26668b2b594899c3
Summary: Not in use in this diff, but it will be for next diffs.
Reviewed By: antonk52
Differential Revision: D49823258
fbshipit-source-id: 364414d7c37a14c6a166b33b9229e6f874f7f146
Summary: Show an unsupported modal for Electron builds (FB employees only)
Reviewed By: antonk52
Differential Revision: D49770083
fbshipit-source-id: 3616dce3206e976f2fdccd834b2c57748f19fcb0
Summary: No need to check for updates on Electron builds.
Reviewed By: antonk52
Differential Revision: D49821903
fbshipit-source-id: d836e4254bbe793921bb4a627220fee961c1c402
Summary: For the last stable Electron version, do not delegate to Launcher.
Reviewed By: antonk52
Differential Revision: D49821835
fbshipit-source-id: 0a80627cd1da312447b7d98d0351aa8faf2bae89
Summary:
Bumps [clap](https://github.com/clap-rs/clap) from 3.2.25 to 4.4.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p>
<blockquote>
<h2>v4.4.5</h2>
<h2>[4.4.5] - 2023-09-25</h2>
<h3>Fixes</h3>
<ul>
<li><em>(parser)</em> When inferring subcommand <code>name</code> or <code>long_flag</code>, allow ambiguous-looking matches that unambiguously map back to the same command</li>
<li><em>(parser)</em> When inferring subcommand <code>long_flag</code>, don't panic</li>
<li><em>(assert)</em> Clarify what action is causing a positional that doesn't set values which is especially useful for derive users</li>
</ul>
<h2>v4.4.4</h2>
<h2>[4.4.4] - 2023-09-18</h2>
<h3>Internal</h3>
<ul>
<li>Update <code>terminal_size</code> to 0.3</li>
</ul>
<h2>v4.4.3</h2>
<h2>[4.4.3] - 2023-09-12</h2>
<h3>Documentation</h3>
<ul>
<li><em>(derive)</em> Clarify use of attributes within the tutorial</li>
<li>Split sections in the builder and derive tutorials into separate modules</li>
</ul>
<h2>v4.4.2</h2>
<h2>[4.4.2] - 2023-08-31</h2>
<h3>Performance</h3>
<ul>
<li>Improve build times by removing <code>once_cell</code> dependency</li>
</ul>
<h2>v4.4.1</h2>
<h2>[4.4.1] - 2023-08-28</h2>
<h3>Features</h3>
<ul>
<li>Stabilize <code>Command::styles</code></li>
</ul>
<h2>v4.3.24</h2>
<h2>[4.3.24] - 2023-08-23</h2>
<h3>Fixes</h3>
<ul>
<li>Ensure column padding is preserved in <code>--help</code> with custom templates</li>
</ul>
<h2>v4.3.23</h2>
<h2>[4.3.23] - 2023-08-18</h2>
<h3>Fixes</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p>
<blockquote>
<h2>[4.4.5] - 2023-09-25</h2>
<h3>Fixes</h3>
<ul>
<li><em>(parser)</em> When inferring subcommand <code>name</code> or <code>long_flag</code>, allow ambiguous-looking matches that unambiguously map back to the same command</li>
<li><em>(parser)</em> When inferring subcommand <code>long_flag</code>, don't panic</li>
<li><em>(assert)</em> Clarify what action is causing a positional that doesn't set values which is especially useful for derive users</li>
</ul>
<h2>[4.4.4] - 2023-09-18</h2>
<h3>Internal</h3>
<ul>
<li>Update <code>terminal_size</code> to 0.3</li>
</ul>
<h2>[4.4.3] - 2023-09-12</h2>
<h3>Documentation</h3>
<ul>
<li><em>(derive)</em> Clarify use of attributes within the tutorial</li>
<li>Split sections in the builder and derive tutorials into separate modules</li>
</ul>
<h2>[4.4.2] - 2023-08-31</h2>
<h3>Performance</h3>
<ul>
<li>Improve build times by removing <code>once_cell</code> dependency</li>
</ul>
<h2>[4.4.1] - 2023-08-28</h2>
<h3>Features</h3>
<ul>
<li>Stabilize <code>Command::styles</code></li>
</ul>
<h2>[4.4.0] - 2023-08-24</h2>
<h3>Compatibility</h3>
<ul>
<li>Update MSRV to 1.70.0</li>
</ul>
<h2>[4.3.24] - 2023-08-23</h2>
<h3>Fixes</h3>
<ul>
<li>Ensure column padding is preserved in <code>--help</code> with custom templates</li>
</ul>
<h2>[4.3.23] - 2023-08-18</h2>
<h3>Fixes</h3>
<ul>
<li>Fixed <code>UnknownArgumentValueParser</code> to not error on flag's absence</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c298f6a52c"><code>c298f6a</code></a> chore: Release</li>
<li><a href="463d6c52af"><code>463d6c5</code></a> docs: Update changelog</li>
<li><a href="3ac44040ef"><code>3ac4404</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5025">https://github.com/facebook/flipper/issues/5025</a> from SUPERCILEX/resolve-alias-conflicts</li>
<li><a href="a76789eb8b"><code>a76789e</code></a> fix: Make long subcommand flag inference consistent</li>
<li><a href="c2b8ec3bd3"><code>c2b8ec3</code></a> fix: Resolve conflicting name inference if from aliases</li>
<li><a href="e5c6993cca"><code>e5c6993</code></a> test: Long flags inference</li>
<li><a href="0d9b14fa6e"><code>0d9b14f</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5136">https://github.com/facebook/flipper/issues/5136</a> from epage/panic</li>
<li><a href="221177b9cb"><code>221177b</code></a> fix(assert): Call out the action in positional assert</li>
<li><a href="cb2d2bcf07"><code>cb2d2bc</code></a> chore: Update from '_rust/main'</li>
<li><a href="4173c8f476"><code>4173c8f</code></a> chore(ci): Don't set patch for MSRV</li>
<li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/v3.2.25...v4.4.5">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5180
Reviewed By: lawrencelomax
Differential Revision: D49772851
Pulled By: passy
fbshipit-source-id: 9d09d9660dfac85a5246817e412eba164c34f81d
Summary:
the glyph isnt working and need to get it fixed asap
changelog: UIDebugger fix icon for litho event timeline tab
Reviewed By: ivanmisuno
Differential Revision: D49780805
fbshipit-source-id: 832746237a43552171cd8e0bd3063318159279dd
