Summary: This diff adds support for the deeplink of support form for graphql groups.
Reviewed By: mweststrate
Differential Revision: D19583680
fbshipit-source-id: fc4505dc5f46c701f1e43fc47ee094fb0aa15d42
Summary: The welcome screen links were a bit out of date.
Reviewed By: nikoant
Differential Revision: D19578769
fbshipit-source-id: 69fc7977bd75ca4256043698350381a5f9d7fdb8
Summary: Previously it was not possible to run unit tests to test logic that requires GK's to be enabled. This fixes that
Reviewed By: passy
Differential Revision: D19158368
fbshipit-source-id: b89691bdd2f975a3b4be343bd966ed77b2ad3763
Summary: Added a setting "Match local fbsource chekout", which inverserly corresponds to the `ignore_local_pin` setting in `flipper-launcher.toml`.
Reviewed By: passy
Differential Revision: D19030456
fbshipit-source-id: deaaf4e873a00bbc4e8bd3034353cf580df95a36
Summary:
* Make sure uploadIDs are converted into CDN urls and displayed
* Changed type of uploadID's to strings, as numbers are
Reviewed By: priteshrnandgaonkar
Differential Revision: D18762974
fbshipit-source-id: d94af61b0bc114b5f0cc2bfcde98fd491058e971
Summary: Initial setup for a support detail form. Will only show up if meta data is present in the flipper file, so use the attached one to see it.
Reviewed By: jknoxville
Differential Revision: D18479193
fbshipit-source-id: 61da089f1e883fea20b2422a6bea99b2f8a4434b
Summary: This diff sets up the create form for the new support request project. The current screen is very basic. I will be iterating through it in the upcoming diffs.
Reviewed By: passy
Differential Revision: D18327464
fbshipit-source-id: af01fc10f68a135f32f0ae98551986852019e8aa
Summary: This will allow rating data to be joined with version number so we can get the rating of each release.
Reviewed By: mweststrate
Differential Revision: D18297808
fbshipit-source-id: 00f151c64aad40632389f728ad25a565f44a2a90
Summary: This got broken during TS migration. Plugin failures were being logged as platform failures, and showing up in the wrong graphs.
Reviewed By: passy
Differential Revision: D18059046
fbshipit-source-id: 8209a0e852f62e221bf64cb5091115e3cac09fd9
Summary: This makes use of the previously set up new settings. The logic is a tiny bit difficult to follow so I wanted to make sure it's not lost in the noise of the previous diff.
Reviewed By: jknoxville
Differential Revision: D18036538
fbshipit-source-id: db3bbce4361862cee479aed70578a4bcbde2c46d
Summary: Allows users to override the GK status of prefetching. It is implemented as a Tri-State. "Unset" means that the local Flipper config won't take precedent over the GK setting and will leave it unchanged. If a user interacts with the setting, it gets persisted into the config and will from then-on override the GK, meaning that the user has an opt-in mechanism and if we open the GK to more people, they effectively have an opt-out.
Reviewed By: jknoxville
Differential Revision: D18008259
fbshipit-source-id: bdfde9a8b9acf43aa60c84800a7979a29a4e9364
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/592
Finally we can join the 21st century and use `jest.mock` in tests!
I'm enabling the ts-jest transform to `*/__tests__/*.tsx` files. This takes care of transforming the typescript, and preserves jest mock capabilities.
I have left the existing custom transform on all other files, so they will continue to work as usual.
Caveats:
* Our existing custom transforms will no longer be applied in tests.
* With our current suite this makes no difference. But bear in mind things like importing directly from 'flipper' instead of the actual files, won't work. However, I don't see this being a problem, as I think they'll only be needed inside the actual product code.
Reviewed By: passy
Differential Revision: D17978753
fbshipit-source-id: df7b312b5dd5592e4aa4f8df605f5952ea3158e9
Summary:
This diff shows the error screen when one of the following condition is met:
- Selected device is not android
- No clients are active for selected device
- At least there is one client which supports inspector plugin.
For this I have added a SupportRequestManager class which loads the error screen or the litho form based on the above condition.
The UI is super basic. Will improve the design based on your feedback in the coming diffs.
Reviewed By: jknoxville
Differential Revision: D17790596
fbshipit-source-id: 2afc917c93c6e7321399633c5bf9d27a703742ee
Summary:
A bit ugly to have test-only code in prod logic,
but we don't need any of the logger logic in tests
and by pulling out the `StubLogger`, we can avoid
loading Electron during tests.
Reviewed By: jknoxville
Differential Revision: D17808479
fbshipit-source-id: d2295d7bbca2f09c3f23389ad9443648757d8d03
Summary: Change flipper from using the dodgy webview check that requires auth, to using the interngraph api for eligibility checking.
Reviewed By: passy
Differential Revision: D17498724
fbshipit-source-id: b81fd8b7b0bd36a7fcf73ba05d9885b61e420c61
Summary: This diff adds an initial support to prefill the app information and the revision information. This diff also copies the workplace url in the clipboard.
Reviewed By: passy
Differential Revision: D16990925
fbshipit-source-id: 4f354e52de5fea07c2ea36336761d6963c27ef66
Summary: Dismissing the popover will stiop the user from being prompted for a while, so we only want to send this event when the user was proactively prompted in the first place - which is when we're using the eligibility check.
Reviewed By: passy
Differential Revision: D17343227
fbshipit-source-id: 95a071e34ce318fe49640c6ee9f68127957f390c
Summary:
Behind a gk.
This uses a hidden webview to check if a user is eligible for star ratings. This means you can practively ask the user, and makes sure you'll get an unbiased distribution.
Reviewed By: danielbuechele
Differential Revision: D17343118
fbshipit-source-id: fe7471416aef947ec10f4734e4136868ab5ab3e5
Summary: Per title. Somehow both typecheck, but importing the module like this doesn't work.
Reviewed By: jknoxville
Differential Revision: D17285507
fbshipit-source-id: 40a38db5dfb52213e0407f8bda83f2ebad5c50c7
Summary: To keep it in sync with the JS implementation.
Reviewed By: danielbuechele
Differential Revision: D17208786
fbshipit-source-id: 8d89f33bfef22317266a0ad1e0c5689540d54f9e
Summary:
This isn't ready to release yet, it's still behind a GK so noone will see it.
There has been no styling applied to the popover so it looks bad but is fully functional.
What it also doesn't have yet:
* Get the prompt text from the API (including the predefined selectable comments)
* Check with the server whether it should pop up proactively, it's completely passive at the moment.
Reviewed By: passy
Differential Revision: D17206158
fbshipit-source-id: f1734f3d6bc555c860ebbaad7515d4675e1700cb
Summary:
- Show all or show 5 LRU plugins
- Update when close/reopen app, collapse sidebar, or expand sidebar
Reviewed By: danielbuechele
Differential Revision: D16917950
fbshipit-source-id: 1e7edc86945162ea14e1cdaa89aa47d3defa4c7d
Summary:
- Add `show more` and `show less` button to expand and collapse
- The element to show depends on its usage rank from Flipper dashboard (manually copied)
Reviewed By: danielbuechele
Differential Revision: D16917952
fbshipit-source-id: fc37d5c640be33794694e302341fa08849b8f97f
Summary:
Had to mess with the tagged union we had, to distinguish based on
a string rather a bool which is a bit rubbish.
Reviewed By: danielbuechele
Differential Revision: D16764797
fbshipit-source-id: c33536f17b0705ca40abef8448802f9961c4c114
Summary:
Removed defunct log filtering functionality, but we probably want to rebuild that.
Funny that tsc caught this as non functioning but Flow happily accepted it.
Reviewed By: danielbuechele
Differential Revision: D16690959
fbshipit-source-id: b079dd6faba83ca0c443d00cbb69c8ff95c4fa69
Summary: Migrate user and introduce a global declarations file.
Reviewed By: danielbuechele
Differential Revision: D16690480
fbshipit-source-id: be4e5218715dcae4b403b24cdbc2f3e89728dd59
Summary: TSC actually found a type error here in `safeExec` which is nice.
Reviewed By: danielbuechele
Differential Revision: D16666740
fbshipit-source-id: 28a1ad12190d2351a48323f23c3a69947503625d
Summary: We can't `*`-export as the symbols are invisible but being explicit about this seems like a good improvement anyway.
Reviewed By: danielbuechele
Differential Revision: D16666637
fbshipit-source-id: 8f9a14ed41f4d8ad93b4bab8dd54f3b6c9e24824
Summary:
Very mechanical migration. No syntactic changes, only moves and
file name changes.
Reviewed By: danielbuechele
Differential Revision: D16665891
fbshipit-source-id: afb1f2418f55bf6c5370b8a2b1d2c35ac5986dc3
Summary:
Adds a star rating to flipper internal.
Based on the nuclide behaviour:
We get an event emitted when a user changes their rating.
And we also get the rating with every ping event, which is fired every minute, if flipper is the primary window.
The only thing I don't like that much is that this doesn't actually say anywhere what the stars are for.
Reviewed By: passy
Differential Revision: D16420281
fbshipit-source-id: 69a52f64058955d7cd068215478e95c554cb9ed4
Summary:
Logic for installing an uninstalling a custom `post-update` mercurial hook, invoking the script introduced in the previous diff.
This is to gather some early data before rolling this integration out more broadly, i.e. through the mercurial distribution.
Reviewed By: jknoxville
Differential Revision: D16283081
fbshipit-source-id: e8610509e5f105a9b717a881aa327bb04f9a2f4f
