Commit Graph

14 Commits

Author SHA1 Message Date
Michel Weststrate
bdd4516dc4 Track how much time people spend waiting for queues to be flushed
Summary: Added stats, so that we know how much people have to wait when opening plugin after we open the queue GK

Reviewed By: jknoxville

Differential Revision: D19598730

fbshipit-source-id: f955123f2bae5b870eada8f787385d6c0450453e
2020-01-28 05:07:22 -08:00
Michel Weststrate
23625f7a89 Change star concept to enabled
Summary:
The 'starring' concept of plugins no longer covers the meaning of 'starring', as unstarred plugins will no longer receive data from background plugins, not be available in support request forms due to a lack of data etc. So this diff renames the feature to 'enabled'.

Also fixed an issue where selecting a non-enabled plugin wouldn't show it in the sidebar if the additional plugins are collapsed.

To make disabled plugins more clear, they are . now always rendered in gray.

The toggle button now delays its effect for better visual feedback

- [x] update side bar styling
- [x] remove bottom bar warning
- [x] details screen
- [ ] only open connection for active plugins (will be done in a next diff)
- [x] check archived / imported devices
- [x] make sure device plugins work correctly
- [x] check without GK's

Reviewed By: jknoxville

Differential Revision: D19470326

fbshipit-source-id: 9160a3434287561f56b1b741d5ba282ab6063ea8
2020-01-27 04:04:19 -08:00
Anton Nikolaev
b117a36f8a Flipper fails to load on Windows because of ifinite PluginContainer component update loop
Summary: Flipper fails to load on Windows because of inifinite update loop in PluginContainer component.

Reviewed By: mweststrate

Differential Revision: D19374611

fbshipit-source-id: f2039c055ffefe508c8cf5bcfcd16fffc97a10b8
2020-01-14 04:28:35 -08:00
Ankur Sadhoo
e7173e060c Make sure right sidebar shows for Watch plugin in client-less mode
Differential Revision: D19261373

fbshipit-source-id: 194480622074bc7672eae67105e0ac8efeafe623
2020-01-02 12:43:07 -08:00
Michel Weststrate
9acf23596e Show a message if a background plugin is not starred
Summary:
Since background plugins don't receive data anymore when not starred, we should hint the user about this.

For this diff, I reused the existing statusbar. Although this solution is quite ugly, I think it is better than introducing yet another notification / warning mechanism. Probably we should revisit the layout of this status bar in the future.

Reviewed By: jknoxville

Differential Revision: D19251588

fbshipit-source-id: 1dfd07be383d4ba318f344ebff4b08ed36194c58
2020-01-02 07:14:15 -08:00
Michel Weststrate
8c8f360572 Process and render messages when a plugin is opened
Summary: This introduces the necessary UI changes, to kick off and render event progressing process where needed

Reviewed By: jknoxville

Differential Revision: D19175450

fbshipit-source-id: 61e3e8f59eeebf97eedbe715fa7db320286543e2
2020-01-02 07:14:13 -08:00
Chaiwat Ekkaewnumchai
d4acdf8504 Delete Notification Plugin Code
Summary: Delete dead code as we change to static view

Reviewed By: passy

Differential Revision: D18810148

fbshipit-source-id: 17b5a2355abb39a711a95b4ffcd0bcd387259787
2019-12-05 03:26:28 -08:00
Michel Weststrate
9f7be13e39 Rework sidebar selection
Summary:
- Make sure newly connecting apps are automatically selected
- Improved the sidebar UI by using more consistent, spacious styling, and giving some more attention to error states

Reviewed By: passy

Differential Revision: D18505636

fbshipit-source-id: 18b2c8e78be13aabb3a54c60553f6b0d1e613b27
2019-11-18 02:21:14 -08:00
Pritesh Nandgaonkar
ef43878286 Add Marketing Bar for Flipper Support Form
Summary: This diff shows marketing bar for support feature when someone inspects the litho view. Once it is inspected it will shown for the rest of the time till the plugin is unmounted.

Reviewed By: jknoxville

Differential Revision: D18086347

fbshipit-source-id: cb906614f571e8ece2293b028f809d1aa5c211e5
2019-10-23 10:40:03 -07:00
Andres Suarez
0675dd924d Tidy up Flipper license headers [1/2]
Reviewed By: passy

Differential Revision: D17863711

fbshipit-source-id: 259dc77826fb803ff1b88c88529d7f679d3b74d8
2019-10-11 13:46:45 -07:00
Daniel Büchele
e9aaf5d445 fix persistedPluginState
Summary: The persistedState of the Layout (and potentially other plugins) wasn't updated. It turned out that the updated state value never got passed to `setPluginState`, but accidentally when adding a type declaration, the `Object` constructor was passed as value to the state.

Reviewed By: jknoxville, passy

Differential Revision: D17282822

fbshipit-source-id: 6fc64960ee2405ea5a705504969c36a27ac62f2c
2019-09-10 06:10:38 -07:00
John Knox
6e8b31e2ed PluginContainer.tsx
Reviewed By: passy

Differential Revision: D17258340

fbshipit-source-id: 26ce421345f6152efe7da07daf649395e299af14
2019-09-09 06:54:36 -07:00
Daniel Büchele
0ec48d4fc9 index
Summary:
This converts the index file to TypeScript which is used as an export for all plugins. Alongside, I had to fix a couple of errors in various files to make sure everything works correctly.

For plugins using flow, we define an interface which uses the type definition for FlipperPlugin and types all UI components as `any`.

Reviewed By: passy

Differential Revision: D16936890

fbshipit-source-id: dacd9a63a82b9f0bbb530b06072186874cba7b6f
2019-08-22 10:02:27 -07:00
Daniel Büchele
d0da0d66a5 main folder
Summary: _typescript_

Reviewed By: passy

Differential Revision: D16762117

fbshipit-source-id: b6ee32e0bb3fc686fc69cfccab703e2ef4989571
2019-08-15 03:33:06 -07:00