Commit Graph

17 Commits

Author SHA1 Message Date
Adam Cmiel
a64d493875 - xplat sonar (#5091)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/5091

https://developer.apple.com/documentation/foundation/nsstring/1497289-stringwithcstring

[Changelog]:[Fixed] Remove usage of deprecated stringWithCString function

Reviewed By: lblasa

Differential Revision: D48692608

fbshipit-source-id: 683d6f8656fe6183cb02faab6261f1b6a61cc3a2
2023-09-06 13:09:09 -07:00
Fúlvio Abrahão de Paula
4cf63cee71 Create IGSQLiteDatabaseDriver and integrate it with instamadillo e2ee flow.
Summary: IGSQLiteDatabaseDriver implements the DatabaseDriver protocol that is required to flipper send requests from desktop app to the client.

Differential Revision: D48172578

fbshipit-source-id: 09ac9415dd1b98c347984228def617f27d2e1aa0
2023-08-21 08:15:11 -07:00
Fúlvio Abrahão de Paula
7210c8944b Implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' error + Add missing import.
Summary:
This diff fixes this compilation error that appear in the next diff (in case I don't fix it before).

```
Action failed: fbsource//xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin:FlipperKitDatabasesPlugin (cxx_compile FlipperKitDatabasesPlugin/DatabasesManager.m (pic))
Local command returned non-zero exit code 1
Reproduce locally: `env -- "BUCK_SCRATCH_PATH=buck-out/v2/tmp/fbsource/4f538045b2fada5e/xplat/sonar/iOS/Plugins/FlipperK ...<omitted>... erKitDatabasesPlugin__/__dep_files_intermediaries__/FlipperKitDatabasesPlugin/DatabasesManager.m.pic (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:121:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
                                stringByAppendingString:exception.reason]];
                                                        ^
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:157:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
                                stringByAppendingString:exception.reason]];
                                                        ^
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:191:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
                                stringByAppendingString:exception.reason]];
                                                        ^
3 errors generated.
```

Differential Revision: D48438432

fbshipit-source-id: acba91ec8e4fdab2c09a1e98387c203aa0d49489
2023-08-21 08:15:11 -07:00
Fúlvio Abrahão de Paula
9728155cbf Consider NSNull object as type=null in ObjectMapper.
Summary: nil objects from sqlite is NSNull object, so we need to consider this case in the ObjectMapper as well.

Differential Revision: D48394360

fbshipit-source-id: 61bcdb03cb4cbf17a2fef000a5a61ac2f2c035dd
2023-08-17 11:19:50 -07:00
Fúlvio Abrahão de Paula
fb47b70d36 Parse NSDictionary in ObjectMapper.
Summary: Some objects returned from sqlite in json blob is a NSDictionary, we need to parse data at this case.

Differential Revision: D48394361

fbshipit-source-id: c977ebdd33c392fca77741cdacdeb0c975e2ca36
2023-08-17 11:19:50 -07:00
Fúlvio Abrahão de Paula
2f5f4911e5 Refactor FlipperKitDatabasePlugin to accept multiple database drivers.
Reviewed By: lblasa

Differential Revision: D48316901

fbshipit-source-id: 0eb7b93f53ce115a0a031a58ecef3db963b35f09
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
661ed9eb44 Isolate duplicated code in DatabasesManager.
Reviewed By: lblasa

Differential Revision: D48316900

fbshipit-source-id: 2ae984f0d6f10b9cb843a74f335c77428d2229ef
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
d102ae263c Fix mocks to return correct expected results.
Reviewed By: lblasa

Differential Revision: D48315430

fbshipit-source-id: 3a9210b6c4ce8192ff5489d2616e6a37264309b2
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
d9b34e7880 Return right format for databaseGetTableStructureResponseToDictionary method.
Reviewed By: lblasa

Differential Revision: D48315431

fbshipit-source-id: fc4ca1bc20e691162dfbe61a90a5ab9bf8df2466
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
7ba548d6e7 Implement executeSql command.
Reviewed By: lblasa

Differential Revision: D48310925

fbshipit-source-id: 136b7f09a3a1b886111b6e3cb0e377b73b126e59
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
42fb6f09f7 Implement getTableData command.
Reviewed By: lblasa

Differential Revision: D48267029

fbshipit-source-id: a2ee02d3d0c465c83acd99fd7093e0abb5c7c2de
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
a0510ad1bf Implement getTableInfo command.
Reviewed By: lblasa

Differential Revision: D48266744

fbshipit-source-id: 79f2fd3c4718d6bf7be4a0538ec0d1eb92503eb7
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
453b8f7b96 Implement getTableStructure command.
Reviewed By: lblasa

Differential Revision: D48191484

fbshipit-source-id: 6838590f4e10b4613074e9e9d112a62d4688f739
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
ce85f44a33 Create commands data models and add ObjectMapper.
Reviewed By: lblasa

Differential Revision: D48188172

fbshipit-source-id: 10c99250f993c71976c693a691586385d111a4fd
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
9db2c74632 Implement databaseList command and Add MockDatabaseDriver.
Reviewed By: lblasa

Differential Revision: D48172577

fbshipit-source-id: 10d6301041b3a4b3ab83b19e9afd3eac7ad7004c
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
fea326be79 Implement similar structure we have in Java plugin.
Reviewed By: lblasa

Differential Revision: D48172579

fbshipit-source-id: b2127507b04cdb85f426313e71405a81103e42bd
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
3003330067 Create initial databases plugin structure.
Reviewed By: lblasa

Differential Revision: D48172580

fbshipit-source-id: d000329c2fe8ebc12f59e3165861b1e8033ddbbe
2023-08-14 11:07:07 -07:00