Summary:
If a flipper file is imported, from now on we will show that fact in the sidebar to make it more clear we are looking at an imported device. Beyond that, those devices are marked as `(imported)` rather than `(offline)` to distinguish between offline and imported devices.
This should help with future feature like cross device applicable actions.
Reviewed By: jknoxville
Differential Revision: D18448190
fbshipit-source-id: 560084f010207c99cecd616e43a6cc02e62cbc7a
Summary: Tabs have a weird negative offsite in the mobile config section (they have everywhere by default, to escape their containers in a mac-style but it does hide them in this specific case)
Reviewed By: priteshrnandgaonkar
Differential Revision: D18448191
fbshipit-source-id: 792daa5a3ef1aa91df730bd185124076471e42d3
Summary:
Currently flipper export exports all connected the clients. This causes a few problems
1. This might often be unintended by the user, causing accidentally sharing (sensitive) information in the trace
2. This slows down things unnecesary. Especially if there is connected application, which is expensive, but not needed. See the attached video for the impact on exporting flipper: Export size reduzed from 11 to 0.5 mb. Export time from 20 seconds down to 1. (Flipper might not be a representative example, but imagine working on fb4a and having instagram on the emulator as well).
Reviewed By: priteshrnandgaonkar
Differential Revision: D18448194
fbshipit-source-id: f4de4c6dd89bda20251eb5f7423f7996339c8f2d
Summary: Optional chaining was not actually usuable, since prettier and eslint weren't updated yet. Since they are released now, this diff fixes that
Reviewed By: jknoxville
Differential Revision: D18449890
fbshipit-source-id: 722110c6cfe328ef5a7e8d9d0cc42e5117e9f796
Summary:
## The dependency [mem](https://github.com/sindresorhus/mem) was updated from `5.1.1` to `6.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT
[Find out more about this release](https://github.com/sindresorhus/mem).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/635
Reviewed By: jknoxville
Differential Revision: D18449137
Pulled By: passy
fbshipit-source-id: 2ca358574ef710e0113e092d2d887ef2c2ac8047
Summary:
## The dependency [chalk](https://github.com/chalk/chalk) was updated from `2.4.2` to `3.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT
[Find out more about this release](https://github.com/chalk/chalk).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/632
Reviewed By: jknoxville
Differential Revision: D18449136
Pulled By: passy
fbshipit-source-id: 066878bbce1c0bdeed8da497c07af97756a13439
Summary: I have made a new release for Flipper-Folly with the changes in the base diff
Reviewed By: jknoxville
Differential Revision: D18449493
fbshipit-source-id: bdb60d2a5b16cd0e3fc8d2e135d6d52b97c61fd0
Summary:
- This removes `folly/**/*.h` in `source_files` which causes all headers to be included. Instead we include only the headers needed to build. In my case this caused a conflict with folly's "Zlib.h" getting included instead of the system "zlib.h" (apparently paths are not case sensitive).
- Remove duplicates in `public_header_files`, we can just keep `"folly/**/*.h"` to make all headers public.
- Remove `preserve_paths`, this is not be needed anymore.
## Changelog
Cleanup Flipper-Folly.podspec included headers
Pull Request resolved: https://github.com/facebook/flipper/pull/518
Test Plan: Tested in an app that everything build using the modified podspec.
Reviewed By: jknoxville
Differential Revision: D16918216
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 81cc9891c67bcb019580eb21d1b8e6d7318a4e03
Summary:
Take the low level execution details out of the healthchecks.
The xcode-select change is sound because `xcode-select -p` returns status code > 0 when not set, so exec will throw, so no need to inspect stdout.
Reviewed By: passy
Differential Revision: D18449564
fbshipit-source-id: b2e2797a51aca45cfd78e707e99341798401897c
Summary:
Basic check for some xcode-path
There'll be a separate connected device check that looks at the current simulators and sees if they are running the same xcode version.
Reviewed By: mweststrate
Differential Revision: D18427090
fbshipit-source-id: 5e202d8920cae1ffce444e81a0c138a97936f758
Summary: Checks for xcode. We'll be able to do some version comparisons here if we find incompatible versions going forward, but for now, just check if it exists.
Reviewed By: mweststrate
Differential Revision: D18425284
fbshipit-source-id: 4a35a40de17f168f409c86264c5c3e172d7d1569
Summary:
Rework the healthchecks.
* Makes them healthcheck run api async so they can do more.
* Adds isRequired to the top level categories - this specifies if the category itself is required. The isRequired attributes of its constituent checks specifies if they are required within that category.
* Move isRequired outside the result of the healthcheck functions, because its static.
Reviewed By: mweststrate
Differential Revision: D18425189
fbshipit-source-id: 9d5c136a426732375d32cd27a758d9c92d123214
Summary:
This diff adds commit hash field in the support form v2 and we prefill the information.
If changes are not pushed to phabricator we will populate it with commit hash or else we will populate it with Diff number.
See the demo to understand the flow.
{F222000517}
Reviewed By: jknoxville
Differential Revision: D18427044
fbshipit-source-id: 80a58baca381e21203da5670e29144a7e8c2eeed
Summary: Since most employees use flipper in development mode, the current error bar might be overly obtrusive, so we collapse it by default
Reviewed By: priteshrnandgaonkar
Differential Revision: D18448192
fbshipit-source-id: 9aa211df6c9a519860dffdced3619119e0ee8e22
Summary:
This diff moves the selection storage from local state to the Redux store.
This makes the state available to the export data functionality (next diff)
Reviewed By: priteshrnandgaonkar
Differential Revision: D18448193
fbshipit-source-id: b1cce083ac7805c539de22aca0bd05c18e1b66e0
Summary:
This diff fixes the broken sample app for xcode 11. Followed the remediation mentioned in the following links
https://github.com/Carthage/Carthage/issues/2825https://twitter.com/krzyzanowskim/status/1151549874653081601?s=21
Remediation:
Adding Dummy swift file and assigning `"LD_VERIFY_BITCODE": "NO"` solves the problem as suggested in the above links
Reviewed By: jknoxville
Differential Revision: D18420954
fbshipit-source-id: e87930790329ffb2bb92c40aa197552efeedecd3
Summary:
Before this diff, plugins made with createTablePlugin would not be exportable as it uses ImmutableJS's Map which is not serializable. In the custom serializer we just handle the normal map, not the immutableJS one. Thus to tackle this I overrode the serializer and deserializer methods to handle it.
Before this diff the funnellogger import didn't work.
{F221607733}
Reviewed By: mweststrate
Differential Revision: D18352298
fbshipit-source-id: 57d4f3e19f38c12a30e75167646ae43ac8690e08
Summary:
Added more telemetry events for the following events
- Time taken for each plugin to fetch meta data
- Overall time taken for fetching all meta data
- Overall time taken for serializing plugins
- Time taken to serialize individual plugins with overridden serializer and deserializer methods
Reviewed By: passy
Differential Revision: D18349588
fbshipit-source-id: 2b3a6b663a9df4da45580fc0be5651a27ca4093d
Summary:
Random observations
1. RN already generates the Flipper initialization code out of the box
2. This code assumes a prefixed namespace: `facebook.flipper`. Maybe it would be better if that were `appname`, but that seems an unnecessary burden at this point, preventing direct copy / paste possibilities
3. Out of the box, the generated code by RN doesn't align with the code provided here, because no `ReactInstanceManager` argument is passed in (nor does it seem to be available in a straight-forward way)
4. patch MainApplication.java with `getReactNativeHost().getReactInstanceManager()`
5. turn this into an explicit section: https://fbflipper.com/docs/tutorial/js-table.html#dynamic-plugin-loading. Also explain that when using `node_modules`, config doesn't need to be changed?
6. xcode 10! sudo xcode-select -s /Applications/Xcode_10.XXX/Contents/Developer/
7. Also tried to install Reactotron plugins by Infinite Red, got that compilable in the end, but the andoid / ios implementations still seems to be stub, so I'll try to follow up with them later, to be notified when they actually have something
Reviewed By: passy
Differential Revision: D18349098
fbshipit-source-id: 233bbe20a37c57c7dfe08c8fccdd4508bdefe96f
Summary: Missed two the previous time
Reviewed By: jknoxville
Differential Revision: D18372147
fbshipit-source-id: 015f1aa93706134a8a1aacffb4812cfb284c5527
Summary: Quite a few releases behind, but all fwd-compatible.
Reviewed By: jknoxville
Differential Revision: D18371601
fbshipit-source-id: 72e94ed4a92ea0358db44310cf14f611ad95db37
Summary: The Flipper codebase was recently converted to TypeScript. Plugins should be converted as well to maintain type safety.
Reviewed By: passy
Differential Revision: D18347730
fbshipit-source-id: be63e8bac677c13fa5c0fa4f964dda8e7ba6251d
Summary: This diff sets up the create form for the new support request project. The current screen is very basic. I will be iterating through it in the upcoming diffs.
Reviewed By: passy
Differential Revision: D18327464
fbshipit-source-id: af01fc10f68a135f32f0ae98551986852019e8aa
Summary: Used by rating, I think.
Reviewed By: mweststrate
Differential Revision: D18347585
fbshipit-source-id: bbc84a42c34aae9805515c82f8d24cfd0817d8ed
Summary: Moving some things around for the upcoming update support.
Reviewed By: jknoxville
Differential Revision: D18347572
fbshipit-source-id: b614fe3a87f8e7fdc0c11c0d3bfe4787c0914d17
Summary:
The prep work paid off. Seems to Just Work.
Now goeth ahead, little flock, and spread the good word of Optional Chaining.
More stuff here: https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/
allow-large-files
Reviewed By: mweststrate
Differential Revision: D18347372
fbshipit-source-id: 735d4a1e2d33bffaa47761f86eb4f43a044c3d3b
Summary: I don't know why we left this for so long, it doesn't make a good first impression.
Reviewed By: mweststrate
Differential Revision: D18348908
fbshipit-source-id: b8b0e5fe8f6ab81281d6ea1a1299ebdaaf0b9c43
Summary: Look client names were unreadable due to line wrapping
Reviewed By: jknoxville
Differential Revision: D18348602
fbshipit-source-id: 682c3b17ef73ca0bf0f8193f71a608ada5cdfbf2
Summary: Fix an issue where we accidentally show all plugins for all clients, causing client crashes if an unsupported plugin is selected
Reviewed By: jknoxville
Differential Revision: D18347907
fbshipit-source-id: 5416f29b8eae2daed64869380f9e9382e90261d7
Summary: Currently the app keeps to find iOS devices if when the tooling isn't properly set up, causing an error to appear every three secs. This change makes sure that happens only once. It also takes care of some run-away promises
Reviewed By: jknoxville
Differential Revision: D18346619
fbshipit-source-id: 12b581bee0d522b37b9e0c5d5b8dad0e4d2058d9
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/626
This is the step that keeps failing because of some libuv
nonsense. It's faster and more reliable on Linux, so
there's really no good reason for running it on Mac.
No guarantee that this will fix it, but in the worst case
manually pressing "Rerun" will be faster.
Reviewed By: jknoxville
Differential Revision: D18324723
fbshipit-source-id: d1cd0c7195a4bcbd4c5df6ad39676f12f135a0f9
Summary:
When the CPU or kaois plugins are started, they show a buffer deprecated warning, caused by the fact that they ship their own adbkit version, which is unpatched.
This diff makes sure that the adbkit as shipped with Flipper is used instead.
Reviewed By: jknoxville
Differential Revision: D18327441
fbshipit-source-id: 9cab23b9701adc070210cc4133fc8760031bd1d7
