Commit Graph

9136 Commits

Author SHA1 Message Date
Luke De Feo
708db9003a Fix broken icon
Summary: it isnt showing up in prod,

Reviewed By: lblasa

Differential Revision: D49639706

fbshipit-source-id: 952a4580ecb102f8a765d63c702e80ae384b88a7
2023-09-26 09:38:07 -07:00
Lorenzo Blasa
7048c470b2 Add flipper-server tag to log
Summary: ^

Reviewed By: passy

Differential Revision: D49594331

fbshipit-source-id: 9bf8c65274a92d6f505c92572135b5f803b4a336
2023-09-26 08:47:43 -07:00
Lorenzo Blasa
d971820609 Improve node export
Summary: ^

Reviewed By: antonk52

Differential Revision: D49634301

fbshipit-source-id: a7e27d3f370a17f5eb3740772f572135e586e0c7
2023-09-26 04:38:59 -07:00
Lorenzo Blasa
6e97e73cf1 Better shutdown
Summary: ^

Reviewed By: ivanmisuno

Differential Revision: D49593599

fbshipit-source-id: 196e98653cc0cdda4fdf11e366e5d3ab5debe6e2
2023-09-25 09:59:24 -07:00
Lorenzo Blasa
1c4224d716 Running/shutdown utilities
Summary: Create utilities to check for existing running instances and shutdown.

Reviewed By: ivanmisuno

Differential Revision: D49593321

fbshipit-source-id: 10acdb4f340f2f24f9ebd3203153906b34623178
2023-09-25 08:46:43 -07:00
Lorenzo Blasa
c1b0d9d753 Export node as JSON
Summary:
There has been multiple requests to incorporate an export to plain text functionality for a while.

This diff adds it.

It will export a node and optionally its chidren as JSON.

Reviewed By: antonk52

Differential Revision: D49596476

fbshipit-source-id: 3681bc0c2d02e1ea64ff589e0e272f6d54ad0524
2023-09-25 08:44:37 -07:00
generatedunixname89002005306973
5accf039c9 Flipper Snapshot Bump: v0.222.1-SNAPSHOT
Summary: Releasing snapshot version 0.222.1-SNAPSHOT

Reviewed By: lblasa

Differential Revision: D49593014

fbshipit-source-id: 2a0be972b3e216c0fece50fadc6b63817063564c
2023-09-25 06:30:50 -07:00
generatedunixname89002005306973
6b9adfe130 Flipper Release: v0.222.0
Summary: Releasing version 0.222.0

Reviewed By: lblasa

Differential Revision: D49593015

fbshipit-source-id: 9fd4b4f42134f2fb244ddeabff6b83748151e36a
2023-09-25 06:30:50 -07:00
Lorenzo Blasa
9e98391151 Publish server dmg to release artifacts
Summary: ^

Reviewed By: passy

Differential Revision: D49544230

fbshipit-source-id: 908a5d7c759bcbcef34c262ab588500fc87cb463
2023-09-25 03:59:38 -07:00
Luke De Feo
a4933373b5 accessability toggle button
Summary:
Should be more discoverable

changelog: UIDebugger accessibility mode for iOS launched, look for icon to the right of the search bar

Reviewed By: zats

Differential Revision: D49547952

fbshipit-source-id: 3befdffedb34907d9824bb66b86e20fd4a1a42ff
2023-09-25 02:02:26 -07:00
Luke De Feo
10d5a2933a handle error when device disconected
Summary: Log views were being generated, this seems like a reasonable solution.

Reviewed By: zats

Differential Revision: D49547368

fbshipit-source-id: 575dd81a7c9b9a831d1dfb46088c2f5e1d731f22
2023-09-25 02:02:26 -07:00
Sash Zats
f2e402e6e9 Enable voice over mode on device while running in accessibility exploration mode
Summary:
All the FoA have different logic depending on whether device is running in  VoiceOver mode or not. This results in incorrect accessibility being reported through the Flipper plugin.

For example on Instagram we fetch the image descriptions, in Facebook app we group individual elements into the accessibility groups to simplify traversing the screen

This tells device that it is in a voice over mode while inspecting accessibility mode is on meaning that it will be the closest approximation to the

Reviewed By: nscoding

Differential Revision: D49579241

fbshipit-source-id: f3be9057007ee6eefbe3b448f0f97c1fcd2c8f46
2023-09-24 12:24:19 -07:00
Lorenzo Blasa
7d77be1c9d Remove 'exec' debug logs
Summary: These are quite verbose even when debugging, so remove.

Reviewed By: ivanmisuno

Differential Revision: D49538582

fbshipit-source-id: 089027390a825dde3d3d53b67e3f920f2f1f75f2
2023-09-22 10:36:43 -07:00
Lorenzo Blasa
ddf348faa5 Immediately close server if no clients are connected
Summary: ^

Reviewed By: ivanmisuno

Differential Revision: D49539483

fbshipit-source-id: ffbcffe0f0b0f31bc26ba5881b30ae27960c283e
2023-09-22 10:31:15 -07:00
generatedunixname89002005325672
6251c58154 Daily arc lint --take KTFMT
Reviewed By: hick209

Differential Revision: D49534542

fbshipit-source-id: 122e7e2ca3070176dc9b510b6deefbb9fe71de11
2023-09-22 08:50:37 -07:00
Anton Kastritskiy
a37b04737c Move default actions and extra actions next to the search
Summary: Having default and extra actions at the bottom is not actionable. Users are used to haveing table controls on the top.

Reviewed By: LukeDefeo, aigoncharov

Differential Revision: D49538205

fbshipit-source-id: 724a31dc44de79cb0e09efae48dd2135450b34ae
2023-09-22 08:25:24 -07:00
Lorenzo Blasa
b8950a2298 Kill with -9 flag
Summary: There are reports in which kill as is doesn't kill the process. Using the '-9' flag does, so update troubleshoot message.

Reviewed By: LukeDefeo

Differential Revision: D49537427

fbshipit-source-id: a062c92528589cecf0f41e1c344c5d0ae1c3345d
2023-09-22 08:17:48 -07:00
Lorenzo Blasa
1d29e06b76 Use better API to return JSON from endpoint
Summary: ^

Reviewed By: antonk52

Differential Revision: D49537411

fbshipit-source-id: d5cabcf1c22d57fc47e1e80cbf0edb70effee308
2023-09-22 08:17:48 -07:00
Lorenzo Blasa
bdf5065f10 Expose info endpoint
Summary:
Expose an endpoint to retrieve server environment information.

We can use version information and process number to aid engineers with troubleshooting Flipper.

Reviewed By: antonk52

Differential Revision: D49537325

fbshipit-source-id: 511fe4441638f91cd35f13706ceeeb515051416b
2023-09-22 08:17:48 -07:00
Lorenzo Blasa
db07297e2d Create DMG
Summary: Add an option to archive the server build inside a DMG.

Reviewed By: antonk52

Differential Revision: D49504225

fbshipit-source-id: 3c34e6f0e4c9a685d36771199a6e20394f68baef
2023-09-22 07:14:52 -07:00
Andrey Goncharov
bb35c7cbb9 Fix intern graph request override return
Reviewed By: passy, lblasa

Differential Revision: D49538074

fbshipit-source-id: bab45624f8115ca5df38510d3c4330fbe2ec7550
2023-09-22 06:34:11 -07:00
Pascal Hartig
fcd21111a0 Do not prefer ipv4 dns results
Summary: This is the default from Node 17 onwards and should unblock problems we're seeing on some people's machines.

Reviewed By: lblasa

Differential Revision: D49415859

fbshipit-source-id: c15ab82e69db4916838228324a9739c95f3562f3
2023-09-22 06:25:35 -07:00
Anton Kastritskiy
412b05ad8d fix lint CI check on windows
Reviewed By: lblasa

Differential Revision: D49503462

fbshipit-source-id: c047e72edda644d42cf4454a3a8b2023eca8d2ea
2023-09-21 10:36:50 -07:00
Sash Zats
21d86c09af Preload accessibility framework if not already loaded
Summary:
It looks like there are some edge cases when app did not load private accessibility framework (probably if it never set any accessibility values?)

This diff makes calls to accessibility hierarchy safer and ensures to preload framework if available

Reviewed By: lblasa

Differential Revision: D49501064

fbshipit-source-id: b46216b58bf6c9c63f900e199fea035e3262afb2
2023-09-21 10:14:43 -07:00
Anton Kastritskiy
947cc819e3 remove unneccessary console.log
Reviewed By: lblasa

Differential Revision: D49502424

fbshipit-source-id: 674eb165871da43427ea5605b4aa74ec3297dd33
2023-09-21 09:43:22 -07:00
Luke De Feo
eb86eb910f quieten some errors
Summary:
message format has changed slightly
T164418118

Reviewed By: lblasa

Differential Revision: D49502179

fbshipit-source-id: 205ebf5bfe444fb0ce768fa635f9de5371d82a03
2023-09-21 08:50:36 -07:00
Luke De Feo
2ff91170e0 increase highlight time and random colours for event monitoring
Summary:
1. makes it easier to tellwhen a parent and child hightlight together
2. Longer times means you have more time to click it and see

changelog: UIDebugger event debugger - increased highlight time. Nodes get random highlight color

Reviewed By: lblasa

Differential Revision: D49501954

fbshipit-source-id: 9456c00e0df77c40934eb95b4b48b566c7715181
2023-09-21 08:50:36 -07:00
generatedunixname89002005306973
796fb161dc Flipper Snapshot Bump: v0.221.1-SNAPSHOT
Summary: Releasing snapshot version 0.221.1-SNAPSHOT

Reviewed By: lblasa

Differential Revision: D49500419

fbshipit-source-id: 5ffb1fad04a81d9031c96bea2e52f74b038deb34
2023-09-21 08:37:28 -07:00
generatedunixname89002005306973
d4aed4eb30 Flipper Release: v0.221.0
Summary: Releasing version 0.221.0

Reviewed By: lblasa

Differential Revision: D49500418

fbshipit-source-id: 3e9acccf130782aff2bca2c4f4cfaf8537158acd
2023-09-21 08:37:28 -07:00
Lorenzo Blasa
b856180530 Use HTTP shutdown instead
Summary: Use the newly exposed HTTP shutdown API. It is simpler.

Reviewed By: antonk52

Differential Revision: D49499264

fbshipit-source-id: 2d81db1d1a66c0b7550ee1245e51d8f1a8671aa6
2023-09-21 06:59:22 -07:00
Lorenzo Blasa
6df27824b7 Expose HTTP shutdown API
Summary: Expose the shutdown API via the HTTP server.

Reviewed By: ivanmisuno

Differential Revision: D49496840

fbshipit-source-id: df2045edc89e9feabe74b4b513f973d137323d0f
2023-09-21 06:09:19 -07:00
Lorenzo Blasa
1db90f9187 Fix bug preventing display of PWA wizard
Summary: ^

Reviewed By: LukeDefeo

Differential Revision: D49496590

fbshipit-source-id: 912be66e3c6c7ef5aaf356815a43439c43d78b24
2023-09-21 05:10:57 -07:00
Luke De Feo
3b8e03e94d fix open source
Summary: these constants are not in the latest release and has broken the build

Reviewed By: adityasharat

Differential Revision: D49455455

fbshipit-source-id: d84b3d214907de197e166130d1c8911a5e0db3c2
2023-09-21 05:10:03 -07:00
Andrey Goncharov
f4a286d9c7 Override intern graph calls in flipper-ui-core
Summary:
> "Hi, kids, do you like violence?"

Alrighty, in flipper-frontend-core we have the **base** implmenetation of flipperLib (the thing exposed to the plugins). This base implementation is never used directly by the plugins, rather it is shared code used by the  real consumers - flipper-ui-core (regular Flipper with UI) and flipper-server-companion (the thing that allows hosting plugins on the server).
These real consumers actually run the plugins and expose flipperLib to the plugins.
In flipper-ui-core we have a more sophisticated logic of calling the intern graph - we check for VPN connection and authn. Therefore, to expose the same way of handling intern graph requests we **override** intern graph calls provided by flipper-frontend-core.
*Ideally*, we should move checking for VPN connection and authn to flipper-frontend-core, but currently it is a lot of effort for very little gains:
1. flipper-frontend-core does not have a notion of a user
2. Even if we move the authn-related logic there the only real consumer of that effort if flipper-server-companion that is used only by UIQR (which in its turn is barely used in the headless mode and do not require authn-related logic).

Thus, we just override intern graph request on the flipper-ui-core side since it is the simplest and the most impactful thing to do at the moment.

Reviewed By: LukeDefeo

Differential Revision: D49494922

fbshipit-source-id: 6f1d521af7ca5bd50549b7bc328d6b8fcab98389
2023-09-21 03:15:10 -07:00
Sash Zats
550b49e690 Capture accessibility hierarchy and package it for the sonar plugin
Summary: In this diff we load and call a private API enabling voiceover hierarchy and pass it over via existing channel when client is in the accessibility mode

Reviewed By: lblasa

Differential Revision: D49393813

fbshipit-source-id: 437af1131547218cd52f4a56797707411787d7cf
2023-09-20 12:41:38 -07:00
Sash Zats
3f0e1f76d5 Send and receive current debugger mode
Summary:
Make sure mobile client and sonar desktop app keep debugger mode in sync

Desktop client listens to available modes and currently selected mode which is what we use here.

Later we can tweak the logic to try to restore last mode if desktop or mobile clients crash / disconnect etc

Reviewed By: lblasa

Differential Revision: D49384358

fbshipit-source-id: 5bc1f4240253b68a746dfa5feba4b352f4e261a2
2023-09-20 12:41:38 -07:00
Sash Zats
60364eadca Add runthrough index for accessibility mode
Summary:
In accessibility mode it is important to be visually aware of the order of the elements on the screen aside from the list on the left

To enable this let's show the indices on the elements
Voice over assumes single continuous list of objects so it is okay to pass index of children we should never have nested lists in accessibility mode

Reviewed By: lblasa

Differential Revision: D49440400

fbshipit-source-id: e6878b4b33952053823451ad76993259f0794067
2023-09-20 11:37:12 -07:00
Sash Zats
1c3720fd5c Add ui-debugger modes
Summary:
## This diff: Add debugger mode infrastructure

We want to enable infrastructure allowing adding modes in the future without branching client and plugin code

This infra allows for the client to send a message informing flipper about the supported modes (following diffs)

Currently broadcasting mode change event over to the client

Reviewed By: lblasa

Differential Revision: D49385860

fbshipit-source-id: 2db6f65064d1ff7e1f57b2da93c3ed195400fb7f
2023-09-20 11:37:12 -07:00
Luke De Feo
c3ad4f7180 Send warning when bloks tree not prepared
Summary: Give the user something actionable when tree is not ready due to flipper connected check failing

Reviewed By: lblasa

Differential Revision: D49455254

fbshipit-source-id: 8869cacde5b65260f4615f5ba2ba34f967d7d27f
2023-09-20 05:45:30 -07:00
Luke De Feo
a033f96725 Add support for warnings from client
Summary:
THis is useful for bloks where fliper needs to be open before hand,

We might also be able to replace some of the annoying notification bubles with these sleeker inline warnings

Reviewed By: lblasa

Differential Revision: D49454977

fbshipit-source-id: fca4fbd3258a68d93c75655cfff247adfa3e6bb2
2023-09-20 05:43:49 -07:00
Andrey Goncharov
a35708989c Add metrics
Reviewed By: antonk52

Differential Revision: D49455605

fbshipit-source-id: 00b4de3106d2497b43708623c410ca262e931059
2023-09-20 05:39:33 -07:00
Andrey Goncharov
fc5fa4a349 Fix styles of non-interactive elements
Summary: Make non-interactive elements non-focusable and disable hover styles for them

Reviewed By: LukeDefeo

Differential Revision: D49455532

fbshipit-source-id: a047e1a149ab4131feef70b80a4995b455441701
2023-09-20 05:39:33 -07:00
Andrey Goncharov
f3bff735cc Simplify search term renderer matching
Summary: Each search term renderer handles its "editing" state internally now. As a result, we can simplify switch-case

Reviewed By: antonk52

Differential Revision: D49454252

fbshipit-source-id: 297ce73f53772b0112ed338c6aac0583f3807ec8
2023-09-20 04:36:57 -07:00
Andrey Goncharov
e031032b93 Make date term editable
Reviewed By: lblasa

Differential Revision: D49453947

fbshipit-source-id: b6959c6ac74d8966e21fb91f7dcbdf186253b93b
2023-09-20 04:36:57 -07:00
Andrey Goncharov
e180a1ed4b Make float term editable
Summary: For the purposes of the demo I added power search config for a float field to the summary field

Reviewed By: lblasa

Differential Revision: D49452844

fbshipit-source-id: 26aaadd07a1a8a67dfcf3cb9d8e487f8f4ee2214
2023-09-20 04:36:57 -07:00
Andrey Goncharov
31e93ff3fe Make integer term editable
Summary: For the purposes of the demo I added power search config for an integer field to the summary field

Reviewed By: lblasa

Differential Revision: D49452729

fbshipit-source-id: 78b8fdccfd799a0f71f652d90d10e11db237cbae
2023-09-20 04:36:57 -07:00
Andrey Goncharov
b3fe4c9650 Make enum term editable
Reviewed By: lblasa

Differential Revision: D49452483

fbshipit-source-id: e9bef3c5499a91231f6025e403c132b924491def
2023-09-20 04:36:57 -07:00
Andrey Goncharov
09cb48a3e3 Make string term editable
Summary:
At the end of the stack we are going to unify two branches of the switch-case in PowerSearchTerm.tsx.
Each search term is going to handle the finalized and "editing" mode internally

Reviewed By: lblasa

Differential Revision: D49451975

fbshipit-source-id: 587ba332d1fbfbaefb368e37965543575e64062f
2023-09-20 04:36:57 -07:00
Lorenzo Blasa
0540d240c0 Remove usage of server enabled
Summary: Used last year to GK server usage. This is obsolete so is safe to remove.

Reviewed By: ivanmisuno

Differential Revision: D49414625

fbshipit-source-id: 9eeff932c59c90dff829e4c6c83bad43a0fd74e3
2023-09-20 04:10:39 -07:00
Lorenzo Blasa
f897203a32 Better name for showing troubleshooting steps
Summary: Better name for toggling troubleshoot/main UI

Reviewed By: antonk52

Differential Revision: D49411916

fbshipit-source-id: 1e5bd4e3e5742abef1fca41349bc8b16cf1229bf
2023-09-20 04:10:39 -07:00