Summary: Since the functionality is now available as part of DataTable, the HoC doesn't seem to be needed as generic abstraction. it is used in handful places outside datatable / datalist, but those can be localized in the future or should datatable / datalist.
Reviewed By: fabiomassimo
Differential Revision: D28993836
fbshipit-source-id: 3e6da7c7b48348faa0c4f7281868196f5585a065
Summary:
The current desktop plugin tutorial was outdated as it has several steps that are now automated, and still referred to old APIs. This has been updated now.
Additionally left the intermediate code of the tutorial in the plugin, but splitting `index.tsx` into `index_table.tsx` and `index_custom.tsx` (which will be updated in the next diff)
Clarified the tutorial page labels a little bit to show that 3 pages are covering the Desktop plugin development process.
Changelog: Updated the Desktop plugin tutorial
Reviewed By: jknoxville
Differential Revision: D28990029
fbshipit-source-id: a06a7a774ceca3daf10f8e8fbd4e03191dbfd1cc
Summary: Github says dns-packet < 5.2.2 is vulnerable, so pinning it to ensure we use fixed version
Reviewed By: passy
Differential Revision: D28714350
fbshipit-source-id: 836061216826948d2fe9320137a91f4fbdad4211
Summary: Because of the `postcss` vulnerability, I tried to update postcss directly. However, forcing version 8 with previous version of docusaurus threw error. Hence, I upgraded docusaurus instead.
Reviewed By: jknoxville
Differential Revision: D28350050
fbshipit-source-id: ce37a01e3ec817fb006100691bc1d9b1cc33db17
Summary: This diff adds documentation and matrix explaining the supported iOS builds. It also tells about the way to enable www cert exchange.
Reviewed By: mweststrate
Differential Revision: D27676056
fbshipit-source-id: 5c8b1d0e73dd95c3ebc534fb0df7505151a6e6be
Summary:
This PR adds missing Objective-C entry to the Docusaurus config, fixes Objective-C code blocks label and adds or replaces several code block labels to improve the currently highlighted blocks.
Prism in Docusaurus by default also includes syntax highlight for `jsx` and `tsx`, which improves the nodes and props highlight, so I have used those syntaxes in few places too.
I have also fixed one typo that I have spotted and my IDE made a cleanup of whitespaces in edited files.
## Changelog
* [website] improve docs code blocks highlighting
Pull Request resolved: https://github.com/facebook/flipper/pull/2049
Test Plan:
The changes have been tested running Flipper website on `localhost`.
## Preview
<img width="650" alt="Screenshot 2021-03-12 150934" src="https://user-images.githubusercontent.com/719641/110951135-fff20d00-8344-11eb-96db-1bdc82c8d5ea.png">
<img width="649" alt="Screenshot 2021-03-12 151022" src="https://user-images.githubusercontent.com/719641/110951268-2ca62480-8345-11eb-9d3b-1a48f1267776.png">
Reviewed By: priteshrnandgaonkar
Differential Revision: D27336599
Pulled By: passy
fbshipit-source-id: c2dfb3d8cad4675da0f5e1270cada1e56a0175c0
Summary: Cleaning up the `resolutions` before going through the next batch of vulns.
Reviewed By: jknoxville, mweststrate
Differential Revision: D27337444
fbshipit-source-id: 5f042b200ac7a6f50efc7faf3c31770c263e401b
Summary: Upgrading docusaurus to fix react-dev-utils vulnerability which is a transitive dependency.
Reviewed By: mweststrate
Differential Revision: D27010446
fbshipit-source-id: 3caf73029de57067c6060c34874539079721eb59
Summary:
Currently failing OSS validation because we have a GitHub
security alert.
Reviewed By: fabiomassimo
Differential Revision: D26944823
fbshipit-source-id: 3075639aae97b1d68b19e5149ebd7a7f7ac419e1
Summary:
Noticed this when building the site. Shame it only warns and doesn't fail the build.
Just fixing it while I'm here.
{F479009268}
Reviewed By: nikoant
Differential Revision: D26911725
fbshipit-source-id: 6440a4b8aee4a6bc053ae771a3b148fd70ffc298
Summary:
This small PR aims to tweak a bit website appearance and fix small UI issue:
* footer background has been changed to reversed splash gradient
<img width="1104" alt="Screenshot 2021-03-04 131823" src="https://user-images.githubusercontent.com/719641/109964907-8cba1c80-7cee-11eb-8905-2fa82533cfd7.png">
* GitHub link in the Navbar has been moved to the tight and text was replaced with icon (like on few other Docusaurus sites)
<img width="557" alt="Screenshot 2021-03-04 133112" src="https://user-images.githubusercontent.com/719641/109965233-f9351b80-7cee-11eb-84d6-30788f662fbf.png">
* Navbar brand title ("Flipper") hover color issues has been fixed, now hover effect is the same as other navbar links
## Changelog
N/A
Pull Request resolved: https://github.com/facebook/flipper/pull/1998
Test Plan: Flipper website run on `localhost`.
Reviewed By: mweststrate
Differential Revision: D26888499
Pulled By: passy
fbshipit-source-id: e8abeace8c1d6ae8dcc46c2381009c2bd2500005
Summary: As reported a few times in the internal chat
Reviewed By: passy
Differential Revision: D26813161
fbshipit-source-id: 8b834c7807a7634f23c3ab922bb43e288ea4bd68
Summary: This diff adds documentation for using physical devices to connect to Flipper. It also talks about simulators and emulators
Reviewed By: jknoxville
Differential Revision: D26780077
fbshipit-source-id: 47a08cec55c510abd36c2fc776f4ce05ff0ea4d0
Summary: Not allowed within an iframe.
Reviewed By: jknoxville
Differential Revision: D26779338
fbshipit-source-id: e201002cb705ca890d6a8fa8470a391e71d8d46c
Summary:
The previous attempt kept the vulnerable dependency around in `yarn.lock`. Now
it's being resolved to the "fixed" version.
Reviewed By: mweststrate
Differential Revision: D26778354
fbshipit-source-id: 17d8e2f1bbcd28939d85e5a976da0bd074ea25e2
Summary:
Upgrade the static docs plugin.
You no longer need to import OssOnly and FbInternalOnly in markdown files, so removed those imports too.
Reviewed By: passy
Differential Revision: D26580059
fbshipit-source-id: 2763de2f5fbef41ec2ac7f7bdd147418badb78b6
Summary:
Upgrades the FB-internal documentation plugin, to no longer call the internal api that requires auth, for external viewers.
Context: https://fb.workplace.com/groups/654274975334601/permalink/1288672008171584/
Reviewed By: justintrudell
Differential Revision: D26252469
fbshipit-source-id: 31068534ce79a7959c38c6e66e6a9cf12371e228
Summary:
I found a `CFBundleURLTypes` in the .app. Turns out that Munki has
a bunch of hard-to-discover deeplinks: https://github.com/munki/munki/wiki/Munki-Links
Reviewed By: mweststrate
Differential Revision: D26125684
fbshipit-source-id: 3a470360e3df287bd9a07d2e587094cbf7879e33
Summary: Also removed a weird href on a paragraph.
Reviewed By: mweststrate
Differential Revision: D26125630
fbshipit-source-id: b3fab87cf295f8fdbfe142e8c0a32909ce828a57
Summary:
The redirects we added inline in the deleted pages don't work when there's a baseUrl.
This is because it's the standard react-router Redirect component, which knows nothing about docusaurus sites.
We could get around that by adding `useBaseUrl()` calls around all of them, but that's not great.
So changing to using declarative redirects instead, where they are all put in config. This automatically takes care of base urls, and reduces copy-pasted code.
Reviewed By: passy
Differential Revision: D25780599
fbshipit-source-id: c67d3643ab28f0fcd440904baf54c67687781686
Summary: Makes it a bit more obvious where this link goes.
Reviewed By: passy
Differential Revision: D25639460
fbshipit-source-id: d2eed6bf2bcb0ac3b6cb9de148e62e65ab61266a
Summary:
Give the sdk installation pages a bit more structure.
To me it's much clearer now what they are.
Happy to hear differing opinions so we get it right :)
Reviewed By: passy
Differential Revision: D25638164
fbshipit-source-id: 86b7fecd8aba0068336b15a308f4a9433817c68e
Summary:
The installation instructions didn't flow very well.
"Using flipper at Facebook" is now gone. It's installation steps have been moved into the desktop app page, with internal/external switching.
I've also removed the "Updating Flipper" internal page, and put equivalent info in the installation section.
Reviewed By: nikoant
Differential Revision: D25637831
fbshipit-source-id: 2af2abf57793d54804f5c45e3335b8641743e1c8
Summary:
I think there's a need for an "implementation details" section of the site. Especially as we're moving the rest of our wiki content there.
I see it as a good thing, because now we have a place for implementation details relevant to OSS contributors too, it's not all fb-specific.
Reviewed By: nikoant
Differential Revision: D25614909
fbshipit-source-id: 5ec081e6450a9ad1c30785ae4cca74b6fa0d2630
Summary:
Ran the wiki migration script on the Flipper_Internals wiki.
Deleted the pages mentioned in https://www.internalfb.com/tasks/?t=81712504
Also deleted hacking-launcher, which is now succeeded by the new "hacking-on-launcher".
Reviewed By: nikoant
Differential Revision: D25613387
fbshipit-source-id: b57b3e20f37b556774d7748477a1dbb7fe844812
Summary: This diff unifies setup and workflow information that was scattered a bit around into one cohesive 'Development workflow' subsection in the 'creating plugins' section of Flipper.
Reviewed By: nikoant
Differential Revision: D25612288
fbshipit-source-id: 5fa7f2d000fb7ab3e1b5c5a4fc8cc1f209252f41
Summary: There were 3 pages describing how to obtain a plugin instance, public, ios and android. iOS didn't differ from the public one, and android only in the fact that internally DI is available. So combined the pages with just an optional section for DI inside FB on Android.
Reviewed By: jknoxville
Differential Revision: D25588057
fbshipit-source-id: 3a54ae699130a4c5ba018220708f844a35a8d6a9
Summary: There was one public page for testing client plugins, and two internal ones. Combined it into a one pager, that has tabs per target, with separate content for internal versus external (didn't combine those as the testing frameworks recommended differ)
Reviewed By: nikoant
Differential Revision: D25588058
fbshipit-source-id: afa151ec0c3a5de26142938d3d389627716f1ff7
Summary: send data was documented twice, in the general client API, and in the internal docs where it was specifically combined with obtaining a plugin instance. However, that is a proper public API as well, so combined those two.
Reviewed By: nikoant
Differential Revision: D25588059
fbshipit-source-id: 7135a74b64a87d0c8c3f8f20f7f260469f52d41c
Summary:
Updated the release ent diagram using mermaid lib added in the previous diff.
nocommit until "docusaurus-plugin-internaldocs-fb" re-pointed back to npm in package.json.
Reviewed By: jknoxville
Differential Revision: D25594333
fbshipit-source-id: fd0b961c5265b8284d3c2e56e17b56fc38cc72c5
Summary:
Moving this file outside of the "FB Internal section" so we can get rid of it.
I think this file can probably be replaced by the "flipper marketplace" at some point, driven programatically by package.json files etc, but I'm not sure if such a page exists at the moment.
Reviewed By: passy
Differential Revision: D25588707
fbshipit-source-id: 0809c21b30410252ef146cfcd161b836849dbbf0
