c8c40bca17183fcdf0ac11ec78e2f5d2af4dd7c2
2296 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Lawrence Lomax
|
9973014116 |
Fix error message when there's no xcode-select'ed Xcode
Summary: This error messaging is confusing for device only users. These users may only be running against a device **without xcode installed**, which is supported. However, we also need to handle the case where a user has a sim running and they haven't xcode-select'd as this will mean that the sim is working fine, but the user has no way of knowing why Flipper is not working. Reviewed By: passy Differential Revision: D34140277 fbshipit-source-id: f9b035b6c7918424d6131d1dfcdba10acf438fa8 |
||
Flipper Bot
|
60c353e16e |
Flipper Release: v0.133.1
Summary: Releasing version 0.133.1 Reviewed By: aigoncharov Differential Revision: D34143395 fbshipit-source-id: e1df1abee6ac46a33a383f6350e7529f329b1c56 |
||
|
Lawrence Lomax
|
2a9983b1ef |
Use Promise.all for checking xcode-select and apps in parallel
Summary: These can be batched together rather nicely Reviewed By: lblasa Differential Revision: D34139753 fbshipit-source-id: 7388630dcae34d40308d54f18a37215cf18e5904 |
||
|
Lawrence Lomax
|
84fac685ac |
Actually use unit tested function in wrapped xcode check
Summary: Accidentally tested a function that should have been called from the internals. This makes the internal function use the check. Reviewed By: lblasa Differential Revision: D34139589 fbshipit-source-id: fac13f7b54ffb0b6f501fb9237f55766706e975a |
||
Andrey Goncharov
|
3871755064 |
Fix extracting device ID from the path for iOS simulators
Summary: Changelog: Fix extracting device ID from the path for iOS simulators Reviewed By: lblasa, antonk52 Differential Revision: D34142876 fbshipit-source-id: 57d3bffcda7bb7b4bf88ea837eb9bf2dc8405764 |
||
|
Andrey Goncharov
|
c33a5f9bef |
Fix cert exchange on iOS with multiple devices connected
Reviewed By: lblasa, nikoant Differential Revision: D34142119 fbshipit-source-id: e5edc4962e75f2e6f91d9ed304ffd080fd29ff27 |
||
Liam Jones
|
8696349593 |
Fix Xcode version check (#3428)
Summary: Fixes https://github.com/facebook/flipper/issues/3396 - the Xcode version mismatch check has been broken since 0.132.0. ## Changelog Fixed Xcode version mismatch check Pull Request resolved: https://github.com/facebook/flipper/pull/3428 Test Plan: No existing test, manually tested locally on macOS 11.6.3 via `yarn start` when launching the Simulator directly or via `yarn react-native run-ios` in an RN project Reviewed By: lblasa, mweststrate Differential Revision: D34139471 Pulled By: lawrencelomax fbshipit-source-id: 97920de5c463b366ef7ecaef0441ee37debe5d46 |
||
|
Flipper Bot
|
47f41b83af |
Flipper Release: v0.133.0
Summary: Releasing version 0.133.0 Reviewed By: nikoant Differential Revision: D34104731 fbshipit-source-id: ea198388d852e4bc3fbed5e4a517cc07d117ca89 |
||
Michel Weststrate
|
d81a9909e0 |
Fix error that is logged when device disconnected quickly
Summary: If a device disconnects quickly, trying to determine whether screenshots and alike are supported would throw, showing up in our monitoring (see attached tasks). This change fixes that Reviewed By: nikoant Differential Revision: D34105451 fbshipit-source-id: 8d3d6dd4c2c82f70cdff710722d789e7c1d73693 |
||
|
Michel Weststrate
|
597f679ed3 |
Propagate errors properly when cert exchange fails
Summary: Certificate exchange errors should be communicated back to the user, as they are often actionable, and otherwise leave users in a stuck state. Also removed the ServerController interface, upgraded the listener types to get at the necessary internal apis typewise that were already available. Removed that error wrapping utility complaining about idb installation, this is rarely ever the problem anymore, and it hides the underlying error. Reviewed By: nikoant Differential Revision: D34105452 fbshipit-source-id: 3b3cd0b99cecbda26dfd0744a90690fe568a5ea5 |
||
dependabot[bot]
|
5805d03091 |
Bump algoliasearch from 4.12.0 to 4.12.1 in /desktop (#3419)
Summary: Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 4.12.0 to 4.12.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases">algoliasearch's releases</a>.</em></p> <blockquote> <h2>4.12.1</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.12.0...4.12.1">v4.12.1</a></h2> <ul> <li>fix(types): allow mix of strings and arrays in facetFilters (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1384">https://github.com/facebook/flipper/issues/1384</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/dfc2a09">dfc2a09</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1384">https://github.com/facebook/flipper/issues/1384</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md">algoliasearch's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.12.0...4.12.1">v4.12.1</a></h2> <ul> <li>fix(types): allow mix of strings and arrays in facetFilters (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1384">https://github.com/facebook/flipper/issues/1384</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/dfc2a09">dfc2a09</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1384">https://github.com/facebook/flipper/issues/1384</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
2d2b214fb7 |
Bump pretty-format from 27.4.6 to 27.5.0 in /desktop (#3414)
Summary: Bumps [pretty-format](https://github.com/facebook/jest/tree/HEAD/packages/pretty-format) from 27.4.6 to 27.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">pretty-format's releases</a>.</em></p> <blockquote> <h2>v27.5.0</h2> <h2>Features</h2> <ul> <li><code>[expect]</code> Add asymmetric matcher <code>expect.closeTo</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12243">#12243</a>)</li> <li><code>[jest-mock]</code> Added <code>mockFn.mock.lastCall</code> to retrieve last argument (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12285">#12285</a>)</li> </ul> <h2>Fixes</h2> <ul> <li><code>[expect]</code> Add a fix for <code>.toHaveProperty('')</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12251">#12251</a>)</li> <li><code>[jest-each, jest/globals]</code> Allow passing <code>ReadonlyArray</code> type of a table to <code>describe.each</code> and <code>test.each</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12297">#12297</a>)</li> <li><code>[jest/globals]</code> Add missing <code>options</code> argument to <code>jest.doMock</code> typing (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12292">#12292</a>)</li> <li><code>[jest-environment-node]</code> Add <code>atob</code> and <code>btoa</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12269">#12269</a>)</li> <li><code>[jest-matcher-utils]</code> Correct diff for expected asymmetric matchers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12264">#12264</a>)</li> <li><code>[jest-message-util]</code> Fix <code>.getTopFrame()</code> (and <code>toMatchInlineSnapshot()</code>) with <code>mjs</code> files (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12277">#12277</a>)</li> </ul> <h2>Chore & Maintenance</h2> <ul> <li><code>[*]</code> Update <code>graceful-fs</code> to <code>^4.2.9</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11749">#11749</a>)</li> </ul> <h2>Performance</h2> <ul> <li><code>[jest-resolve]</code> perf: skip error creation on not found <code>stat</code> calls (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11749">#11749</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/markjm"><code>@markjm</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11749">facebook/jest#11749</a></li> <li><a href="https://github.com/benjamingr"><code>@benjamingr</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12266">facebook/jest#12266</a></li> <li><a href="https://github.com/aduh95"><code>@aduh95</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12269">facebook/jest#12269</a></li> <li><a href="https://github.com/piranna"><code>@piranna</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12272">facebook/jest#12272</a></li> <li><a href="https://github.com/od-c0d3r"><code>@od-c0d3r</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12234">facebook/jest#12234</a></li> <li><a href="https://github.com/davidnormo"><code>@davidnormo</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12264">facebook/jest#12264</a></li> <li><a href="https://github.com/mshima"><code>@mshima</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12277">facebook/jest#12277</a></li> <li><a href="https://github.com/Cambuchi"><code>@Cambuchi</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12246">facebook/jest#12246</a></li> <li><a href="https://github.com/vladsholokhov"><code>@vladsholokhov</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12185">facebook/jest#12185</a></li> <li><a href="https://github.com/robdy"><code>@robdy</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12254">facebook/jest#12254</a></li> <li><a href="https://github.com/Michael-M-Judd"><code>@Michael-M-Judd</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12212">facebook/jest#12212</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.7...v27.5.0">https://github.com/facebook/jest/compare/v27.4.7...v27.5.0</a></p> <h2>v27.4.7</h2> <h2>Fixes</h2> <ul> <li><code>jest-config</code> Add missing <code>babel/core</code> dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12216">#12216</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.6...v27.4.7">https://github.com/facebook/jest/compare/v27.4.6...v27.4.7</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">pretty-format's changelog</a>.</em></p> <blockquote> <h2>27.5.0</h2> <h3>Features</h3> <ul> <li><code>[expect]</code> Add asymmetric matcher <code>expect.closeTo</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12243">#12243</a>)</li> <li><code>[jest-mock]</code> Added <code>mockFn.mock.lastCall</code> to retrieve last argument (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12285">#12285</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[expect]</code> Add a fix for <code>.toHaveProperty('')</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12251">#12251</a>)</li> <li><code>[jest-each, jest/globals]</code> Allow passing <code>ReadonlyArray</code> type of a table to <code>describe.each</code> and <code>test.each</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12297">#12297</a>)</li> <li><code>[jest/globals]</code> Add missing <code>options</code> argument to <code>jest.doMock</code> typing (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12292">#12292</a>)</li> <li><code>[jest-environment-node]</code> Add <code>atob</code> and <code>btoa</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12269">#12269</a>)</li> <li><code>[jest-matcher-utils]</code> Correct diff for expected asymmetric matchers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12264">#12264</a>)</li> <li><code>[jest-message-util]</code> Fix <code>.getTopFrame()</code> (and <code>toMatchInlineSnapshot()</code>) with <code>mjs</code> files (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12277">#12277</a>)</li> </ul> <h3>Chore & Maintenance</h3> <ul> <li><code>[*]</code> Update <code>graceful-fs</code> to <code>^4.2.9</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11749">#11749</a>)</li> </ul> <h3>Performance</h3> <ul> <li><code>[jest-resolve]</code> perf: skip error creation on not found <code>stat</code> calls (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11749">#11749</a>)</li> </ul> <h2>27.4.7</h2> <h3>Fixes</h3> <ul> <li><code>jest-config</code> Add missing <code>babel/core</code> dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12216">#12216</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
7481c1fece |
Bump @typescript-eslint/experimental-utils from 5.10.1 to 5.10.2 in /desktop (#3411)
Summary: Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 5.10.1 to 5.10.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p> <blockquote> <h2>v5.10.2</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.1...v5.10.2">5.10.2</a> (2022-01-31)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-restricted-imports] allow relative type imports with patterns configured (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4494">#4494</a>) (<a href=" |
||
|
dependabot[bot]
|
2f678f42d5 |
Bump @typescript-eslint/parser from 5.10.0 to 5.10.2 in /desktop (#3420)
Summary: Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.10.0 to 5.10.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v5.10.2</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.1...v5.10.2">5.10.2</a> (2022-01-31)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-restricted-imports] allow relative type imports with patterns configured (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4494">#4494</a>) (<a href=" |
||
|
dependabot[bot]
|
8a25eddf3b |
Bump metro-cache from 0.66.2 to 0.67.0 in /desktop (#3418)
Summary: Bumps [metro-cache](https://github.com/facebook/metro) from 0.66.2 to 0.67.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-cache's releases</a>.</em></p> <blockquote> <h2>Release v0.67.0</h2> <ul> <li><strong>[Breaking]</strong> Use custom resolvers (<code>resolver.resolveRequest</code>) before checking the Haste map. (96fb6e904e1660b37f4d1f5353ca1e5477c4afbf)</li> <li><strong>[Feature]</strong> Update React Native lazy imports list with the removal of <code>StatusBarIOS</code>. (2a0f77925e3299e01c2bfe82d0356145a643adc0)</li> <li><strong>[Feature]</strong> Allow configuring the path of the canonical empty module, which now lives in <code>metro-runtime</code> by default. (bd5f9323337b03a77bc219636937bb75cd8c18ca, 6e3e789b685b95ea59a58364a751e8010d536e8b, 7723be545795c936cb81cad214ee202f72e169b3)</li> <li><strong>[Feature]</strong> Add <code>initialize_done</code>, <code>transformer_loading</code>, and <code>transformer_loaded</code> events to the <code>Reporter</code> interface. (d19cf5d7e88207a8d46c17b570f14a239dae8926)</li> <li><strong>[Feature]</strong> Add <code>waitForBundler</code> option to the <code>runServer()</code> and <code>runMetro()</code> APIs. (57d8a92583185a97dffcdc1c95fef7780be9104d)</li> <li><strong>[Feature]</strong> Add <code>resolver.disableHierarchicalLookup</code> option. (01416f1bc41a3d557b24e4b508fed5f158990108)</li> <li><strong>[Feature]</strong> Remove confusing troubleshooting steps from missing module errors. (1fa45c21f7508cc3a852071b775f592873700ad0)</li> <li><strong>[Feature]</strong> Infer names for anonymous functions in optional calls. (4ced2a1be8a42a9c7df71b566918a457bad207c1)</li> <li><strong>[Feature]</strong> Infer names for anonymous functions memoized with useCallback. (2611f618b245fd2bd2c3558d2536011269bb5a68)</li> <li><strong>[Feature]</strong> Update terser to v5 in <code>metro-minify-terser</code>. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/754">facebook/metro#754</a> by <a href="https://github.com/rockwotj"><code>@rockwotj</code></a>, <a href="https://github-redirect.dependabot.com/facebook/metro/pull/606">facebook/metro#606</a> by <a href="https://github.com/janicduplessis"><code>@janicduplessis</code></a>)</li> <li><strong>[Fix]</strong> Fix a caching issue with custom resolvers. (793b1a03c1f0b5e63869b471adab3f1ad61b199b)</li> <li><strong>[Fix]</strong> Specify UTF-8 encoding when serving bundles. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/695">facebook/metro#695</a> by <a href="https://github.com/zhiqingchen"><code>@zhiqingchen</code></a>)</li> <li><strong>[Fix]</strong> Support <a href="https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced">package.json module replacements</a> for requires with implicit extensions. (41522a25bec9325d1df5981b55d4672db7126895)</li> <li><strong>[Fix]</strong> Resolve <a href="https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced">package.json module replacements</a> when the replaced module isn't a physical file. (171393a6319e507935eeb3d40561e908c1a2abfe)</li> <li><strong>[Fix]</strong> Fix stack trace symbolication when input files have non-Unix line endings. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/691">facebook/metro#691</a> by <a href="https://github.com/danielsmc"><code>@danielsmc</code></a>)</li> <li><strong>[Fix]</strong> Decrease the precedence of <code>resolver.nodeModulesPaths</code> to respect transitive dependencies. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/738">facebook/metro#738</a> by <a href="https://github.com/sharmilajesupaul"><code>@sharmilajesupaul</code></a>)</li> <li><strong>[Fix]</strong> Respect <code>mangle: false</code> & <code>sourceMap: false</code> in <code>minifierConfig</code>. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/749">facebook/metro#749</a> by <a href="https://github.com/mfbx9da4"><code>@mfbx9da4</code></a>)</li> <li><strong>[Fix]</strong> Update hash function from MD4 to MD5 for Node 17 compatibility. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/752">facebook/metro#752</a> by <a href="https://github.com/tobua"><code>@tobua</code></a>)</li> </ul> <blockquote> <p>NOTE: Experimental features are not covered by semver and can change at any time.</p> </blockquote> <ul> <li><strong>[Experimental]</strong> Add <code>server.unstable_serverRoot</code> option to allow serving bundles from folders outside the project root. (026a66cf40df1bd05da2afc1660efa1d9605c55a, ca86682012eb836e2b6aeb001f2b3112129e38c3, e061cf342505f3d07fb21f85f22925e3d05557c9, 70e98882ad24d7c25c9b73eaf347e60f2a74c8ca, baacea28635dae7fea3bd30dd485252ae59a937e)</li> <li><strong>[Experimental]</strong> Update <code>metro-hermes-compiler</code>. (e80434cf329619e1a0c6c56ae7be6c88cb350c99)</li> <li><strong>[Experimental]</strong> Provide safe access to assets outside the project root using <code>/assets?unstable_path=...</code>. (f3d1157bacc341dff82efea2f70b634141105fc0)</li> <li><strong>[Experimental]</strong> Add <code>resolver.unstable_hasteMapModulePath</code> option. (e8c0de0411148bd31e3decb6a5c4c1dc1d645666)</li> </ul> <p>Thanks to all the contributors mentioned above for helping improve Metro! 🚇</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
f85a233c60 |
Bump cli-ux from 5.6.7 to 6.0.9 in /desktop (#3409)
Summary: Bumps [cli-ux](https://github.com/oclif/cli-ux) from 5.6.7 to 6.0.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/oclif/cli-ux/releases">cli-ux's releases</a>.</em></p> <blockquote> <h2>v6.0.9</h2> <h3><a href="https://github.com/oclif/cli-ux/compare/v6.0.8...v6.0.9">6.0.9</a> (2022-01-31)</h3> <h3>Bug Fixes</h3> <ul> <li>deprecate cli ux (<a href="https://github-redirect.dependabot.com/oclif/cli-ux/issues/477">https://github.com/facebook/flipper/issues/477</a>) (<a href=" |
||
Allon Freedman
|
1db061e609 |
Added CMS tab to flipper plugin
Reviewed By: zaxy78 Differential Revision: D34033159 fbshipit-source-id: 41be3361b9b19c00c041979c0b9f142a312b7c94 |
||
|
Michel Weststrate
|
4f9cec718e |
Suppress recurring 'still connecting' errors
Summary: https://fb.workplace.com/groups/flippersupport/permalink/1304868459993809/ Changelog: Don't show errors for clients that fail to connect in a timely fashion repeatedly. I think this change is fine, as even once the error is supressed, the clients will show up as 'still connecting...' in the app selector dropdown, which gives the same signal, but a bit less in the face. Reviewed By: lawrencelomax Differential Revision: D33976460 fbshipit-source-id: 7c5a02f3cd645ed1cbda47d186798857a05906f1 |
||
|
Michel Weststrate
|
762267bccc |
Fix name casing to make plugin more easily findable
Summary: Noticed in https://fb.workplace.com/groups/flippersupport/permalink/1305583723255616/ that always shows at the end of the plugin list. Fixed this on two levels: 1. uppercase the title for consistency 2. Make sorting case insensitive Differential Revision: D33985518 fbshipit-source-id: 70bed519e1ae5b3251b103931472844b2b55a512 |
||
|
Michel Weststrate
|
c97cf6eaf8 |
Add logging for "Attempted to build clientId with invalid app" event
Summary: The `Error: Attempted to build clientId with invalid app: "` event shows up in our monitoring regularly, but it is unclear which kind of app is trying to connect, so adding some more info to the error, to be able to pin point it better a next time Reviewed By: lawrencelomax Differential Revision: D33982871 fbshipit-source-id: 34c2612a9fe86a6815f1cc655f6def1f734e4b1e |
||
|
Michel Weststrate
|
e4a3696fd5 |
Don't create always rejecting promises for timeout
Summary: Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`. This implementation has a few problems 1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless. 2. Throwing exceptions is in principle an expensive process (due to the stack trace generation) 3. Not cancelling the timeout used by sleep is a bit of a waste as well Reviewed By: lawrencelomax Differential Revision: D33982717 fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6 |
||
|
Michel Weststrate
|
704e14a91a |
Fix watchman missing error spawning logs
Summary: "Watchman not in PATH" shows up in our error monitoring, because the underlying implementation first logs an error, and then throw it (which we properly catch). So patch-package once again to the rescue to make sure we don't error log an error we actually handle. Reviewed By: antonk52 Differential Revision: D33982047 fbshipit-source-id: 64384b034b1991e30b2651b3ebf66cd26d519edc |
||
|
Michel Weststrate
|
d0d0b68e0b |
Fixes NPE in page.columns
Summary: From stack trace seems that we don't always get columns from the plugin, in which case we can't display anything Reviewed By: lawrencelomax Differential Revision: D33981285 fbshipit-source-id: 0d6bf2d9364f7dac93e2179e372308da51699bd3 |
||
Andres Orozco Gonzalez
|
4b6fcb6aaf |
new look up for adb path
Summary: Look up for the path of the adb may sometimes fail when looking for the folder platform-tools because the adb configuration wasn't done by android studio Reviewed By: aigoncharov Differential Revision: D33888687 fbshipit-source-id: 4d0cad2f6b19717e45422632f5d459813a7b7ee0 |
||
Bartosz Kaszubowski
|
6639b547dd |
UI: fix hover effect of LeftRail icons with badge (#3372)
Summary: This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge. To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button). The file has been formatted after the changes with ESLint. **Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button: <img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png"> ## Changelog [desktop] UI: fix hover effect of LeftRail icons with badge Pull Request resolved: https://github.com/facebook/flipper/pull/3372 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Before <img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png"> #### After > I have used mocked indicator values locally to ensure that the Badges are displayed correctly. <img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png"> <img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png"> Reviewed By: aigoncharov Differential Revision: D33975324 Pulled By: mweststrate fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa |
||
|
Michel Weststrate
|
a31494f321 |
Fix unnecessary 'still authorizing' error
Summary: When connection to Android, I always get an error popup with 'device still authorizing', which disappears itself and the device connects fine. It seems that this was a case we handled gracefully before, but the error message we check for has changed. Also updated the log message so that we get it in our monitoring I don't silently get stuck in this state. Changelog: Fixed 'device still authorizing' errors showing up while connecting to an Android device Reviewed By: aigoncharov Differential Revision: D33976028 fbshipit-source-id: dbb055bbbd43bad129b10ffee4a8dbb50be8e87a |
||
|
Michel Weststrate
|
ccea9058ef |
Fix build failure on OSS master (#3394)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3394 This diff caused OSS builds failing due to a FB plugin that requires emotion, instead of using it as peer dep. This introduced a duplicate dep, which doesn't get installed in OSS, causing patch-package for that package to fail. Changed it to a peer dep and removed the patch. Reviewed By: aigoncharov Differential Revision: D33975202 fbshipit-source-id: 1e82964988e944a28ecb46a10127ad9e13f743f7 |
||
|
Andrey Goncharov
|
7376774a95 |
Add RSocket deprecation warning
Reviewed By: lblasa Differential Revision: D33976369 fbshipit-source-id: c100c145d7c77369347200d32448015ad971d585 |
||
Harold Martin
|
cdb72db5a9 |
Fix LeakCanary plugin UI, Upgrade LC dependency and make it compile only (#3367)
Summary: **Currently, the Leak Canary plugins is broken, see this screenshot (unable to expand):** <img width="1359" alt="Screen Shot 2022-01-29 at 2 06 33 PM" src="https://user-images.githubusercontent.com/745166/151679662-9d8e8eb6-c19c-4008-9821-1c2c1af92351.png"> **This fix repairs and improves the UI:** <img width="1350" alt="Screen Shot 2022-01-29 at 2 06 03 PM" src="https://user-images.githubusercontent.com/745166/151679677-7965604c-dd04-4ee5-bc8e-d53a82da1bd7.png"> ## Changelog - Fixes UI to enable showing leak trace - Upgrades LackCanary dependency from 2.6 to 2.8.1 - Makes Kotlin and LC `compileOnly` dependencies in order to prevent conflict for the users - Updates documentation Pull Request resolved: https://github.com/facebook/flipper/pull/3367 Test Plan: See demo at https://github.com/hbmartin/leakcanary/tree/flipper-demo/leakcanary-android-sample **Static Docs Preview: flipper** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33915179/V3/flipper/)| |**Modified Pages**| Reviewed By: passy Differential Revision: D33915179 Pulled By: cekkaewnumchai fbshipit-source-id: 9698dba23ab475c8cd84e4c222dfc41712b05a1e |
||
|
dependabot[bot]
|
eb4ececb9f |
Bump typescript from 4.5.4 to 4.5.5 in /desktop (#3375)
Summary: Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/TypeScript/releases">typescript's releases</a>.</em></p> <blockquote> <h2>TypeScript 4.5.5</h2> <p>This <a href="https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+milestone%3A%22TypeScript+4.5.5%22+is%3Aclosed">patch release</a> includes a number of fixes to language service crashes and assertion violations, along with improvements to JSX attribute snippets.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.0%22+">fixed issues query for Typescript 4.5.0 (Beta)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.1%22+">fixed issues query for Typescript 4.5.1 (RC)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.2%22+">fixed issues query for Typescript 4.5.2 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.3%22+">fixed issues query for Typescript 4.5.3 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.4%22+">fixed issues query for Typescript 4.5.4 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.5%22+">fixed issues query for Typescript 4.5.5 (Stable)</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
5253d0750e |
Bump @typescript-eslint/experimental-utils from 5.9.1 to 5.10.1 in /desktop (#3380)
Summary: Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 5.9.1 to 5.10.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p> <blockquote> <h2>v5.10.1</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <h2>v5.10.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.9.1...v5.10.0">5.10.0</a> (2022-01-17)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-function-return-type] support AllowTypedFunctionExpression within AllowHigherOrderFunction (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4250">#4250</a>) (<a href=" |
||
|
dependabot[bot]
|
1f41f1dc2d |
Bump @adobe/node-fetch-retry from 2.0.0 to 2.1.0 in /desktop (#3384)
Summary: Bumps [adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry) from 2.0.0 to 2.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases"><code>@adobe/node-fetch-retry</code>'s releases</a>.</em></p> <blockquote> <h2>v2.1.0</h2> <h1><a href="https://github.com/adobe/node-fetch-retry/compare/v2.0.0...v2.1.0">2.1.0</a> (2022-01-24)</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
a0ec82c981 |
Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop (#3388)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.6.0 to 11.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.7.1</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577">https://github.com/facebook/flipper/issues/2577</a> <a href=" |
||
|
dependabot[bot]
|
e26540ddd7 |
Bump axios from 0.24.0 to 0.25.0 in /desktop (#3383)
Summary: Bumps [axios](https://github.com/axios/axios) from 0.24.0 to 0.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>v0.25.0</h2> <h3>0.25.0 (January 18, 2022)</h3> <p>Breaking changes:</p> <ul> <li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470">#3470</a>)</li> <li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791">#3791</a>)</li> <li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809">#3809</a>)</li> <li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836">#3836</a>)</li> <li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967">#3967</a>)</li> </ul> <p>Fixes and Functionality:</p> <ul> <li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916">#3916</a>)</li> <li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144">#4144</a>)</li> <li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153">https://github.com/facebook/flipper/issues/3153</a>)</li> <li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342">https://github.com/facebook/flipper/issues/3342</a>)</li> <li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321">https://github.com/facebook/flipper/issues/3321</a>)</li> <li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422">#3422</a>)</li> <li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757">#3757</a>)</li> <li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918">#3918</a>)</li> </ul> <p>Internal and Tests:</p> <ul> <li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546">#3546</a>)</li> <li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564">#3564</a>)</li> <li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379">#4379</a>)</li> </ul> <p>Documentation:</p> <ul> <li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219">#4219</a>)</li> <li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604">#3604</a>)</li> </ul> <p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p> <ul> <li><a href="https://github.com/axios/axios/blob/HEAD/mailto:jasonsaayman@gmail.com">Jay</a></li> <li><a href="https://github.com/rijkvanzanten">Rijk van Zanten</a></li> <li><a href="https://github.com/koh110">Kohta Ito</a></li> <li><a href="https://github.com/bfaulk96">Brandon Faulkner</a></li> <li><a href="https://github.com/NoriSte">Stefano Magni</a></li> <li><a href="https://github.com/fanguangyi">enofan</a></li> <li><a href="https://github.com/puzpuzpuz">Andrey Pechkurov</a></li> <li><a href="https://github.com/doowonee">Doowonee</a></li> <li><a href="https://github.com/emilbroman-eqt">Emil Broman</a></li> <li><a href="https://github.com/remcohaszing">Remco Haszing</a></li> <li><a href="https://github.com/BlackHole1">Black-Hole</a></li> <li><a href="https://github.com/wolframkriesing">Wolfram Kriesing</a></li> <li><a href="https://github.com/repl-andrew-ovens">Andrew Ovens</a></li> <li><a href="https://github.com/PauloRSF">Paulo Renato</a></li> <li><a href="https://github.com/carpben">Ben Carp</a></li> <li><a href="https://github.com/wafuwafu13">Hirotaka Tagawa</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/master/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h3>0.25.0 (January 18, 2022)</h3> <p>Breaking changes:</p> <ul> <li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470">#3470</a>)</li> <li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791">#3791</a>)</li> <li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809">#3809</a>)</li> <li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836">#3836</a>)</li> <li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967">#3967</a>)</li> </ul> <p>Fixes and Functionality:</p> <ul> <li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916">#3916</a>)</li> <li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144">#4144</a>)</li> <li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153">https://github.com/facebook/flipper/issues/3153</a>)</li> <li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342">https://github.com/facebook/flipper/issues/3342</a>)</li> <li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321">https://github.com/facebook/flipper/issues/3321</a>)</li> <li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422">#3422</a>)</li> <li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757">#3757</a>)</li> <li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918">#3918</a>)</li> </ul> <p>Internal and Tests:</p> <ul> <li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546">#3546</a>)</li> <li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564">#3564</a>)</li> <li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379">#4379</a>)</li> </ul> <p>Documentation:</p> <ul> <li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219">#4219</a>)</li> <li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604">#3604</a>)</li> </ul> <p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p> <ul> <li><a href="https://github.com/axios/axios/blob/master/mailto:jasonsaayman@gmail.com">Jay</a></li> <li><a href="https://github.com/rijkvanzanten">Rijk van Zanten</a></li> <li><a href="https://github.com/koh110">Kohta Ito</a></li> <li><a href="https://github.com/bfaulk96">Brandon Faulkner</a></li> <li><a href="https://github.com/NoriSte">Stefano Magni</a></li> <li><a href="https://github.com/fanguangyi">enofan</a></li> <li><a href="https://github.com/puzpuzpuz">Andrey Pechkurov</a></li> <li><a href="https://github.com/doowonee">Doowonee</a></li> <li><a href="https://github.com/emilbroman-eqt">Emil Broman</a></li> <li><a href="https://github.com/remcohaszing">Remco Haszing</a></li> <li><a href="https://github.com/BlackHole1">Black-Hole</a></li> <li><a href="https://github.com/wolframkriesing">Wolfram Kriesing</a></li> <li><a href="https://github.com/repl-andrew-ovens">Andrew Ovens</a></li> <li><a href="https://github.com/PauloRSF">Paulo Renato</a></li> <li><a href="https://github.com/carpben">Ben Carp</a></li> <li><a href="https://github.com/wafuwafu13">Hirotaka Tagawa</a></li> <li><a href="https://github.com/lzxb">狼族小狈</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
a63f3d9ee5 |
Bump @typescript-eslint/eslint-plugin from 5.10.0 to 5.10.1 in /desktop (#3382)
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="
|
||
Anton Kastritskiy
|
f2abbf63db |
ban interface usage for component props and state
Summary: another eslint rule for flipper codebase Reviewed By: passy Differential Revision: D33917213 fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee |
||
|
Flipper Bot
|
34d2a5fa59 |
Flipper Release: v0.132.0
Summary: Releasing version 0.132.0 Reviewed By: mweststrate Differential Revision: D33939899 fbshipit-source-id: 54617c126600230b41e45bed6cea449b67b81503 |
||
|
Andrey Goncharov
|
c238cef5b0 |
Verify certificate provider medium
Reviewed By: antonk52 Differential Revision: D33917041 fbshipit-source-id: 91a9554397063d53a903a5b1406b46ddf07360b2 |
||
|
Andrey Goncharov
|
c7492a83c7 |
Remove global access to adb client and idb config
Summary: Idb and adb sholuld not really be accessed out side of Adnroid and iOS device managers Reviewed By: lawrencelomax Differential Revision: D33915162 fbshipit-source-id: 0d1bb028b9a53254cf5b0ce6289ae76339c5a254 |
||
|
Andrey Goncharov
|
51ef1810b2 |
Defer initialization of Android and iOS device managers
Summary: Remove hidden async initialization of adb and idb. Make it explicit. Remove nullable fields in Android and iOS device managers. Reviewed By: lawrencelomax Differential Revision: D33915177 fbshipit-source-id: 882f79310410e0dfde6169abf343ab808644e4a2 |
||
|
Andrey Goncharov
|
fd13399cb9 |
Extract WWW certificate provider
Summary: Extract WWW certificate provider from the iOS certificate provider. Hide its implementation from OSS since it is not relevant for OSS folks. Reviewed By: mweststrate Differential Revision: D33895378 fbshipit-source-id: 376afda3b5fa3857c0eb280b92555314eb1a0d1f |
||
|
Andrey Goncharov
|
29f6d0e711 |
Add device-specific Certificate Providers
Reviewed By: mweststrate Differential Revision: D33821880 fbshipit-source-id: c75c71db4d7dc680f75cf41ba2d5dad009a5fd03 |
||
|
Andrey Goncharov
|
b9aeaa9339 |
Enhance iOS device manager tests
Reviewed By: lawrencelomax Differential Revision: D33915694 fbshipit-source-id: fc4bfd30b8f504f2f242f94e61967ee68cc83100 |
||
|
Andrey Goncharov
|
7bf89a840a |
Remove a circular dependency between KeytarManager and FlipperServerImpl
Reviewed By: passy Differential Revision: D33846051 fbshipit-source-id: c83f5609308ad732a02b2ee55466f5ed0918d733 |
||
|
Andrey Goncharov
|
b1f19ecd68 |
Extract certificate utils
Summary: Extract utilities for certificate server-side certificate handling Reviewed By: lawrencelomax Differential Revision: D33820263 fbshipit-source-id: 21f1a9ed5f3b83b8350151bdf6d8862aa0b18e8f |
||
|
Andrey Goncharov
|
e686766e5f |
Simplify CertificateProvider setup
Summary:
Currently, certificateSetup is called in two places:
- processCertificateSigningRequest
- loadSecureServerConfig
`loadSecureServerConfig` is a mandatory step of Flipper server initialization ([ServerController.init](https://www.internalfb.com/code/flipper/[24785758018a2ffbd4751ad2b9093b5ef97c611d]/src/fbsource/xplat/sonar/desktop/flipper-server-core/src/comms/ServerController.tsx?lines=118)). Flipper cannot start without executing it.
As a result, calling `certificateSetup` in `processCertificateSigningRequest` always results in the early return.
This diff removes executing `certificateSetup` from `processCertificateSigningRequest`. Since it's called only during server setup (so only once), it no longer makes sense to use `didCertificateSetup`.
Next steps:
- Extract Android and iOS certificate utils. Remove the dependency on accessing adb/idb dynamically. See D33711652 (
|
||
|
Anton Kastritskiy
|
05a3bb69dc |
rename left ts files to tsx and ban ts file extension
Summary: mass files rename Reviewed By: passy Differential Revision: D33890304 fbshipit-source-id: c057ac9fe87dd7659597c85d640619b93e1ff0e6 |
||
|
Lawrence Lomax
|
ed03f1b107 |
Use idb to record devices
Summary: `idb` has supported video recording on devices for quite some time now. We even have the implementation in `iOSDevice`, but it's currently unused. As a result, we just need to remove the check within `iOSDevice` that the target is an "emulator" and it will use the `idb` implementation. Removing this check means that the button is now selectable within the UI. Reviewed By: passy Differential Revision: D33913383 fbshipit-source-id: b3d6b4c480c79b54f0d2c206c68092ab62bf71ed |
||
|
Lawrence Lomax
|
3a9c875e03 |
Avoid double recording in iOSDevice
Summary: This should in theory never happen since the state of the recording is also managed within the UI. However, it's better to ensure that if `startRecording` is called twice, without calling `stopRecording` first it will error rather than leak a recording (the first process will still run but the object representing it is oprhaned) Reviewed By: passy Differential Revision: D33913298 fbshipit-source-id: f8fa6b0e4fdbdf4282633fa29a736d3e7dedf3bb |
||
|
Lawrence Lomax
|
7d34c86f78 |
Remove recording invariants
Summary: The state of the destination and the process are coupled together. As a result it makes sense to move these to an object type. This prevents destination and process being independently settable. No change in behaviour, just a removal of invariants that need to be checked Reviewed By: passy Differential Revision: D33913213 fbshipit-source-id: ed18650cac4f72d40e82d20254674f7fa12cbb48 |
