c8a22f598e7779efb09e67ff739ccf9f1337400c
197 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Pascal Hartig
|
1910d3b713 |
Bump dependencies in /desktop
Summary: Combining green-ticked upgrades from GitHub into one push. Reviewed By: lblasa Differential Revision: D34212788 fbshipit-source-id: 12b207a05b9df08eac5b5c58fe1025932c448258 |
||
Michel Weststrate
|
762267bccc |
Fix name casing to make plugin more easily findable
Summary: Noticed in https://fb.workplace.com/groups/flippersupport/permalink/1305583723255616/ that always shows at the end of the plugin list. Fixed this on two levels: 1. uppercase the title for consistency 2. Make sorting case insensitive Differential Revision: D33985518 fbshipit-source-id: 70bed519e1ae5b3251b103931472844b2b55a512 |
||
|
Michel Weststrate
|
e4a3696fd5 |
Don't create always rejecting promises for timeout
Summary: Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`. This implementation has a few problems 1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless. 2. Throwing exceptions is in principle an expensive process (due to the stack trace generation) 3. Not cancelling the timeout used by sleep is a bit of a waste as well Reviewed By: lawrencelomax Differential Revision: D33982717 fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6 |
||
Bartosz Kaszubowski
|
6639b547dd |
UI: fix hover effect of LeftRail icons with badge (#3372)
Summary: This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge. To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button). The file has been formatted after the changes with ESLint. **Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button: <img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png"> ## Changelog [desktop] UI: fix hover effect of LeftRail icons with badge Pull Request resolved: https://github.com/facebook/flipper/pull/3372 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Before <img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png"> #### After > I have used mocked indicator values locally to ensure that the Badges are displayed correctly. <img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png"> <img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png"> Reviewed By: aigoncharov Differential Revision: D33975324 Pulled By: mweststrate fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa |
||
dependabot[bot]
|
a0ec82c981 |
Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop (#3388)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.6.0 to 11.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.7.1</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577">https://github.com/facebook/flipper/issues/2577</a> <a href=" |
||
Anton Kastritskiy
|
f2abbf63db |
ban interface usage for component props and state
Summary: another eslint rule for flipper codebase Reviewed By: passy Differential Revision: D33917213 fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee |
||
|
Anton Kastritskiy
|
c5dd1fc350 |
rename files from ts to tsx in flipper-* packages
Summary: mass files rename Reviewed By: nikoant Differential Revision: D33890252 fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db |
||
|
dependabot[bot]
|
e9da574720 |
Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346)
Summary: Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.18.5</h2> <ul> <li>Cascader <ul> <li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> <li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> </ul> </li> <li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <hr /> <ul> <li>Cascader <ul> <li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> <li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> </ul> </li> <li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <h2>4.18.4</h2> <ul> <li>Typography <ul> <li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li> <li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> <li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li> <li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@toSayNothing</code></a></li> <li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a></li> <li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li> <li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> </ul> <hr /> <ul> <li>Typography <ul> <li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 修复 <code><Icon component={HomeOutlined} /></code> 和 <code><HomeOutlined /></code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li> <li>🐞 修复 <code><Icon component={SyncOutlined} spin /></code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.18.5</h2> <p><code>2022-01-24</code></p> <ul> <li>Cascader <ul> <li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> <li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> </ul> </li> <li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <h2>4.18.4</h2> <p><code>2022-01-18</code></p> <ul> <li>Typography <ul> <li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li> <li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> <li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li> <li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@toSayNothing</code></a></li> <li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a></li> <li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li> <li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> </ul> <h2>4.18.3</h2> <p><code>2022-01-10</code></p> <ul> <li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@dartamonov-vertex</code></a></li> <li>Table <ul> <li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li> <li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@hemengke1997</code></a></li> <li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> </ul> </li> <li>Form <ul> <li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li> <li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li> </ul> </li> <li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@developit</code></a></li> <li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@wuifdesign</code></a></li> <li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
1262ee05f1 |
Bump react-debounce-render from 7.0.0 to 7.0.1 in /desktop (#3351)
Summary: Bumps [react-debounce-render](https://github.com/podefr/react-debounce-render) from 7.0.0 to 7.0.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/podefr/react-debounce-render/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/3351 Reviewed By: mweststrate Differential Revision: D33741785 Pulled By: lblasa fbshipit-source-id: 4ceee9922dd80ec2ec47b9826fd8da09cd551122 |
||
|
Simek
|
f08bcb2a2c |
tweak dark mode theme colors, improve LeftRail UI (#3335)
Summary: Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode. The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode. I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂 ## Changelog * tweak dark mode theme colors, improve LeftRail UI Pull Request resolved: https://github.com/facebook/flipper/pull/3335 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png"> <img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png"> Reviewed By: antonk52 Differential Revision: D33741513 Pulled By: lblasa fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f |
||
|
Simek
|
903476bdad |
use centered prop for variable height modals (#3334)
Summary: Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small. Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced. ## Changelog * use `centered` prop for variable height modals to improve UI in small app window Pull Request resolved: https://github.com/facebook/flipper/pull/3334 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Small App Window <img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png"> <img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png"> #### Maximised App Window <img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png"> Reviewed By: mweststrate Differential Revision: D33741484 Pulled By: lblasa fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8 |
||
|
dependabot[bot]
|
3764b5aa2d |
Bump immer from 9.0.7 to 9.0.12 in /desktop (#3345)
Summary: Bumps [immer](https://github.com/immerjs/immer) from 9.0.7 to 9.0.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p> <blockquote> <h2>v9.0.12</h2> <h2><a href="https://github.com/immerjs/immer/compare/v9.0.11...v9.0.12">9.0.12</a> (2022-01-11)</h2> <h3>Bug Fixes</h3> <ul> <li>produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a> (<a href=" |
||
|
Simek
|
1c91d28390 |
improve dev perf canvas readability (#3333)
Summary: This PR updates the performance Canvas widgets readability in Dev mode. Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text. Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text. ## Changelog * improve the performance canvas widgets readability in Development mode Pull Request resolved: https://github.com/facebook/flipper/pull/3333 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Dark Mode <img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png"> <img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png"> #### Light Mode <img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png"> <img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png"> Reviewed By: aigoncharov Differential Revision: D33738722 Pulled By: lblasa fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775 |
||
|
Simek
|
1fef844878 |
fix ReleaseChannel info in WelcomeScreen in dark mode (#3328)
Summary: This PR fixes the color of ReleaseChannel information in the WelcomeScreen, when user uses dark mode. I have decided to switch to `textColorSecondary` instead of `textColorPrimary` to emphasise a bit more the information, but I can change it to the primary color if you think it will fit there better. Also the font size has been adjusted to match the paragraph font size. ## Changelog * fix ReleaseChannel info in WelcomeScreen in dark mode Pull Request resolved: https://github.com/facebook/flipper/pull/3328 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview #### Dark Mode (before & after) <img width="333" alt="Screenshot 2022-01-23 at 15 14 12" align="left" src="https://user-images.githubusercontent.com/719641/150682951-6e256054-d8d9-4293-8f76-4d67b654482f.png"> <img width="333" alt="Screenshot 2022-01-23 at 15 09 58" src="https://user-images.githubusercontent.com/719641/150682954-942eda7a-443d-4ca1-be51-b6d0036548cd.png"> #### Light Mode <img width="333" alt="Screenshot 2022-01-23 at 15 22 42" src="https://user-images.githubusercontent.com/719641/150683094-62983788-646e-4745-b9c0-3c7f7bea9787.png"> Reviewed By: aigoncharov Differential Revision: D33738596 Pulled By: lblasa fbshipit-source-id: 2fdd18871fbf9d1c215b58173932d57d5731948a |
||
|
Simek
|
f1b83a96fd |
do not add GrayedOutOverlay if there is no children (#3329)
Summary: Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children. Current approach was causing UI issue in the Settings Modal in dark mode. ## Changelog * do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children Pull Request resolved: https://github.com/facebook/flipper/pull/3329 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png"> Reviewed By: aigoncharov Differential Revision: D33738627 Pulled By: lblasa fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d |
||
|
Pascal Hartig
|
7135456434 |
Dep bump
Summary: Get ahead of dependabot by bundling a few small bumps. Reviewed By: nikoant Differential Revision: D33739602 fbshipit-source-id: 1482c062493a4214da81cbf5daf408aa382fb0ac |
||
|
Simek
|
4b0091df0f |
fix Plugins table UI glitch in dark mode, add column name (#3332)
Summary: Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table. I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns). ## Changelog * fix Plugins table UI glitch in dark mode, add column name Pull Request resolved: https://github.com/facebook/flipper/pull/3332 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png"> <img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png"> Reviewed By: aigoncharov Differential Revision: D33738705 Pulled By: lblasa fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8 |
||
|
Simek
|
41950946a2 |
tweak Doctor modal footer UI, replace deprecated UI components (#3331)
Summary: This PR fixes the unaligned checkbox in the Doctor modal (I have based the solution of the Settings modal code) and also replaces deprecated components `FlexRow` and `FlexColumn` in Settings modal. ## Changelog * fix checkbox placement in the Doctor modal footer Pull Request resolved: https://github.com/facebook/flipper/pull/3331 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="596" alt="Screenshot 2022-01-23 at 16 01 48" src="https://user-images.githubusercontent.com/719641/150685091-ce494847-eea6-4263-900a-2b5541d3d897.png"> <img width="596" alt="Screenshot 2022-01-23 at 16 01 44" src="https://user-images.githubusercontent.com/719641/150685096-29723d14-6cfc-42aa-9564-431a61b1061d.png"> Reviewed By: aigoncharov Differential Revision: D33738683 Pulled By: lblasa fbshipit-source-id: 900657d6cb095d6d32dd412205e714a46e64a564 |
||
|
Simek
|
d897cfd765 |
fix Settings modal UI glitch with overlow in dark mode (#3330)
Summary: This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting. ## Changelog * fix Settings modal UI glitch with content overflow setting in dark mode Pull Request resolved: https://github.com/facebook/flipper/pull/3330 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### No scrollbar <img width="390" alt="Screenshot 2022-01-23 at 15 45 47" align="left" src="https://user-images.githubusercontent.com/719641/150684278-b09031bd-9b8c-4c9c-9ac2-2dba3c1af63d.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 45 39" src="https://user-images.githubusercontent.com/719641/150684279-151b83d6-c819-45e0-a662-3d294f4f6a77.png"> #### With scrollbar <img width="390" alt="Screenshot 2022-01-23 at 15 51 40" align="left" src="https://user-images.githubusercontent.com/719641/150684331-a8f27623-9a2b-4ffe-b4c1-3fb06a6362a2.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 51 47" src="https://user-images.githubusercontent.com/719641/150684330-57434f21-0d4d-4ef6-be41-fdd88d082d1b.png"> Reviewed By: aigoncharov Differential Revision: D33738647 Pulled By: lblasa fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec |
||
|
dependabot[bot]
|
a93d4aee71 |
Bump antd from 4.18.0 to 4.18.2 in /desktop (#3233)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.0 to 4.18.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.18.2</h2> <ul> <li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> to Table onChange being invoked infinitely.</li> </ul> <hr /> <ul> <li>🐞 回滚 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> 以修复 Table 死循环调用 onChange 的问题。</li> </ul> <h2>4.18.1</h2> <ul> <li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> <hr /> <ul> <li>🐞 修复 Popconfirm 在某些情况下会出现 <code>Can't perform a React state update on an unmounted component.</code> 的错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 修复 Input 配置 <code>suffix</code> 时 <code>value</code> 为数字类型会崩溃的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 修复 Divider with text dashed 的边框颜色错误问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 修复 Dropdown.Button 不支持 <code>destroyPopupOnHide</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 修复 Table 的 Pagination 在 <code>current</code> 改变时不触发 <code>pagination.onChange</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.18.2</h2> <p><code>2021-12-30</code></p> <ul> <li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> to Table <code>onChange</code> being invoked infinitely.</li> </ul> <h2>4.18.1</h2> <p><code>2021-12-29</code></p> <ul> <li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Lorenzo Blasa
|
e8dd7ffcc0 |
Adresses an issue with menu mutation
Summary: A Logview issue was raised for the following error: Cannot assign to read only property '0' of object '[object Array]'. Analysis: Currently, the menuEntries are stored by reference in the reducer, and made read only to protect it against accidental writes. Tha's probably why the '0' assignment fails, and the fix is that the reducer should only get a defensive copy as config about the current menu entries to show. Reviewed By: mweststrate Differential Revision: D33454514 fbshipit-source-id: 2faf3036eb6ae4fbe9a8d0253fde27cf389d3e4c |
||
|
Michel Weststrate
|
9267a19c89 |
Fix settings not being saved before restart
Summary: 2022 New years intention: don't fix problems with arbitrarily timeouts In production builds, settings weren't saved if apply + restart was used (apply and manual restart did work). I suspect a bug in redux-persist, since we do await a flush, but anyway a little delay seems to fix it consistently. Changelog: Fixed an issue where changing settings wasn't persisted when using "Apply + Restart P.S. I won't accept any insinuations that this was my new years intention of 2015, 2017, 2018, 2020 and 2021 as well. Reviewed By: cekkaewnumchai Differential Revision: D33377718 fbshipit-source-id: 3a9ec58b4f8208603d786342ddaf6bf02b3887c7 |
||
|
Michel Weststrate
|
b77b234e98 |
fix table header column widths deviating from rows
Summary: changelog: Improved column widths in data tables This diff fixes two issues: 1) dynamic width columns became invisible if there is too much else, and therefor it was hard to make them bigger or even notice them 2) column headers could be out of sync with the actually rendered rows, due to minor styling differences Reviewed By: cekkaewnumchai Differential Revision: D33364781 fbshipit-source-id: c3d47bb8db4af521859a5cbdf525d8ce39c71d00 |
||
|
Michel Weststrate
|
b6c884f011 |
Make sure flipper server initialization errors are propagated properly
Summary: This diff makes sure that errors are propagated similarly in flipper desktop and browser version, and that they are shown in either case. Since in the browser version, the UI loads after the error happened, we'll store the error so that any client connecting in the future will read and report it. Also added a `--failFast` flag to flipper-server, so that the process exits immediately if misconfigured, which is convenient in CI use cases and such Reviewed By: nikoant Differential Revision: D33348922 fbshipit-source-id: 0f584104f881141fde38da3f0031748415343ea2 |
||
|
dependabot[bot]
|
4e11458655 |
Bump antd from 4.16.8 to 4.18.0 in /desktop (#3222)
Summary: Bumps [antd](https://github.com/ant-design/ant-design) from 4.16.8 to 4.18.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.18.0</h2> <ul> <li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li> <li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li> <li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li> <li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Table <ul> <li>🆕 Table <code>colSpan</code> & <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li> <li>🆕 Table support Table.EXPAND_COLUMN & Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li> </ul> </li> <li>Form <ul> <li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li> <li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li> </ul> </li> <li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@seaSuper</code></a></li> <li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@Austaras</code></a></li> <li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@kaysonwu</code></a></li> <li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Typography <ul> <li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> <li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> </ul> </li> <li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@neotan</code></a></li> <li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@RiteshMakan</code></a></li> <li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@1040961807</code></a></li> <li>🏴 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@ZzGGitter</code></a></li> <li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@ZakarFin</code></a></li> <li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> <li>TypeScript <ul> <li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@MichalPodeszwa</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>🐞 修复 Skeleton 不支持 <code>style</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li> <li>🐞 修复 Descriptions 内使用其他组件会被切割的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li> <li>🆕 统一类 Select 组件泛型定义为 OptionType 以支持自定义 FieldNames 匹配。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li> <li>🐞 修复 Slider 禁用时 <code>hover</code> 色彩的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Table <ul> <li>🆕 Table <code>colSpan</code> 与 <code>rowSpan</code> 迁移至 <code>onCell</code> 方法中，以优化渲染性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li> <li>🆕 Table 支持 Table.EXPAND_COLUMN 和 Table.SELECTION_COLUMN 以实现自定义列排序。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li> </ul> </li> <li>Form <ul> <li>🔥 Form.List 嵌套使用 Form.Item 时不再需要手工指定 <code>fieldKey</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li> <li>🆕 Form 现在支持通过 <code>labelWrap</code> 开启标签可换行。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li> </ul> </li> <li>🆕 ConfigProvider 支持 Form 的 colon 配置。<a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@seaSuper</code></a></li> <li>🆕 <code>InputNumber</code> 增加 <code>prefix</code> 属性支持。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@Austaras</code></a></li> <li>🆕 Modal 静态方法支持 <code>wrapClassName</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Popconfirm 新增是否显示取消按钮。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Dropdown.Button 新增 <code>loading</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@kaysonwu</code></a></li> <li>🆕 Input 新增 <code>showCount</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Alert 支持 <code>closeIcon</code> 自定义关闭图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Typography <ul> <li>🆕 对于可编辑段落，可以通过配置 <code>triggerType</code> 配置触发编辑状态。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> <li>🆕 Typography 支持 <code>enterIcon</code> 以设置编辑确认图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.18.0</h2> <p><code>2021-12-27</code></p> <ul> <li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li> <li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li> <li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li> <li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Table <ul> <li>🆕 Table <code>colSpan</code> & <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li> <li>🆕 Table support Table.EXPAND_COLUMN & Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li> </ul> </li> <li>Form <ul> <li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li> <li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li> </ul> </li> <li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@seaSuper</code></a></li> <li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@Austaras</code></a></li> <li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@kaysonwu</code></a></li> <li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@cwjTerrace</code></a></li> <li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>Typography <ul> <li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> <li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@kachanovskiy</code></a></li> </ul> </li> <li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@neotan</code></a></li> <li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@RiteshMakan</code></a></li> <li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@1040961807</code></a></li> <li>🏴 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@ZzGGitter</code></a></li> <li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@ZakarFin</code></a></li> <li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> <li>TypeScript <ul> <li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@MichalPodeszwa</code></a></li> </ul> </li> </ul> <h2>4.17.4</h2> <p><code>2021-12-19</code></p> <ul> <li>🐞 Fix a bug that Form.Item name is "parentNode" casue endless loop and memory leak. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31846">#31846</a> <a href="https://github.com/DaoxingHuang"><code>@DaoxingHuang</code></a></li> <li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32448">#32448</a> to fix emoji input at Input.TextArea. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33312">#33312</a></li> </ul> <h2>4.17.3</h2> <p><code>2021-12-08</code></p> <ul> <li>🐞 Fix Drawer broken style caused by title width. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33205">#33205</a></li> <li>🐞 Fix Badge flash style when switch from <code>display:none</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33083">#33083</a> <a href="https://github.com/songlinn"><code>@songlinn</code></a></li> <li>💄 Change Anchor className form <code>.fixed</code> to <code>.ant-anchor-fixed</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33085">#33085</a> <a href="https://github.com/tangjinzhou"><code>@tangjinzhou</code></a></li> <li>💄 Fix Button loading style missing in Firefox. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33199">#33199</a></li> <li>Select <ul> <li>🐞 Fix Select width became small when searching. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32988">#32988</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Andres Suarez
|
79023ee190 |
Update copyright headers from Facebook to Meta
Reviewed By: bhamodi Differential Revision: D33331422 fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01 |
||
Anton Nikolaev
|
dd4d7bbe7f |
API for creating pastes without showing notifications
Reviewed By: mweststrate Differential Revision: D33277470 fbshipit-source-id: 2ec9ad7d9fc48d7d2da64be3bfc1a66bb5b3a347 |
||
Andrey Goncharov
|
debf872806 |
Allow to start only one instance of log listener and crash watcher
Summary: Changelog: Allow only a single crash watcher and a single log listener per device. Start log listener and crash watcher for every device upon connection. Remove commands to start/stop them externally. Monitored CPU load for a physical Android device with the log listener on and off. Did not notice any real difference. Resolved crashing adbkit-logcat by forcing the usage of 2.0.1. A proper fix would be to unify babel transforms for browser flipper and electron flipper, but we might re-think how we distribute flipper in the next half, so a simple hot fix might be a better use of time and resources. Reviewed By: mweststrate Differential Revision: D33132506 fbshipit-source-id: 39d422682a10a64830ac516e30f43f32f416819d |
||
|
Andrey Goncharov
|
731749b41f |
Move crash reporting listener to the server
Summary: Changelog: Move crash watcher to the server. Add 'device-crash' event. Add 'device-start-crash-watcher', 'device-stop-crash-watcher' commands. Add 'onDeviceCrash' method to Plugin Client. Reviewed By: mweststrate Differential Revision: D33089810 fbshipit-source-id: ed62ee7c1129e5e25af18b444744b0796f567b72 |
||
|
Andrey Goncharov
|
3f771c05dd |
Remove fs usage from Navigator plugin
Reviewed By: mweststrate Differential Revision: D33019873 fbshipit-source-id: 6d48971dc04161b64fdd32ac4e658b56aa98b7ec |
||
|
dependabot[bot]
|
9085fc6f72 |
Bump immer from 9.0.6 to 9.0.7 in /desktop (#3138)
Summary: Bumps [immer](https://github.com/immerjs/immer) from 9.0.6 to 9.0.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p> <blockquote> <h2>v9.0.7</h2> <h2><a href="https://github.com/immerjs/immer/compare/v9.0.6...v9.0.7">9.0.7</a> (2021-11-24)</h2> <h3>Bug Fixes</h3> <ul> <li>Append to array when key is "-" (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/872">https://github.com/facebook/flipper/issues/872</a>) (<a href=" |
||
|
Michel Weststrate
|
e46fcba0b2 |
Make sure that test stuff doesn't end up in bundles
Summary: When bundling a production bundle of flipper-ui / flipper-server, noticed that a lot of irrelevant stuff ends up. Like: `jest`, `metro`, `testing-library`. The whole jungle basically. Will add safety checks in the next diffs that this no longer happens Reviewed By: passy Differential Revision: D33186531 fbshipit-source-id: 1e2034153c8c4a3fac02cd9ce27d99224223df7a |
||
|
Michel Weststrate
|
d9488f06ac |
Clean up flipper-ui-core deps
Summary: Noticed that flipper-ui-core bundled quite some unused / node based deps. No longer Reviewed By: aigoncharov Differential Revision: D33184489 fbshipit-source-id: a180f9b8f3eb00ffa6c91e0cca654d4b9b609692 |
||
|
Michel Weststrate
|
cea7be7fde |
Clean up globals
Summary: This diff is some boyscouting on cleaning up our globals, and stop using them inconsistently icmw global or window Reviewed By: aigoncharov Differential Revision: D33171108 fbshipit-source-id: 400893e5f31523631a7ab6fda428524c751901f1 |
||
|
Michel Weststrate
|
8f40949bb0 |
clean slate package resolutions
Summary: Over time we collected a lot of harcoded resolutions, but it is really hard to get signal about their sanity: * some resolutions generate a lot of yarn warnings as they resolve with a different major than required, and it's really hard to tell whether they actually make things worse or better * some resolutions are for package we don't even use any more * some resolutions were there to fix type incompatibilities which have been solved now by keeping them uniquely required * some resolutions are there to fix "security issues" or security issues in transient dependencies that might have been upgraded int he mean time So this diff radically removes all of them, trusting Github to propose restoring the sane ones of them :). In terms of functionality everything seems to be working at least Reviewed By: timur-valiev Differential Revision: D33158981 fbshipit-source-id: 83e74cdbc8e47ccbf554b97620cf7caa2c6599ce |
||
|
Michel Weststrate
|
5df34a337c |
Unshare global types
Summary: This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package. This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup. As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same. Reviewed By: lawrencelomax Differential Revision: D33124441 fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7 |
||
|
Andrey Goncharov
|
af3757dcae |
Add left margin for app names in app selector
Summary: Changelog: Add left margin for app names in app selector Reviewed By: timur-valiev Differential Revision: D33162189 fbshipit-source-id: 4eb1a565e5cbcdfb44b0dfcaa4b0988c8a69d200 |
||
|
Michel Weststrate
|
dcfeb4a4d5 |
Clean up packages and types
Summary:
This diff removes most deps from the root package.json, which now only contains electron and shared build / test infra structure: lint, prettier, jest, typescript.
This makes it possible to control much better which packages are used where, as all sub packages now have their deps explicitly in their package.json instead of incidentally shared. This allows for example to disable DOM types for all packages by default (flipper-plugin, ui(-core) and app still request it), and in the next diff I hope to add to this that nodeJS types are no longer shared either, so that UI oriented packages will generate compile errors when using Node built-ins
This diff removes most deps that were currently unused, and dedupes a bunch of other ones, so the build should probably be a bit smaller now as well:
{F686704253}
{F686704295}
Reviewed By: antonk52
Differential Revision: D33062859
fbshipit-source-id: 5afaa4f2103d055188382a3370c1fffa295a298a
|
||
|
Michel Weststrate
|
78413c1ecf |
Register shortcuts on window instead of globally
Summary: Changelog: Register shortcuts only for Flipper application instead of globally. Fixes https://github.com/facebook/flipper/issues/3090 As reported, during decapitation we accidentally started registering shortcuts globally, rather per app as it used to be in the menu's. This diff fixes that and also makes sure shortcuts are supported in the browser version of flipper Reviewed By: lawrencelomax Differential Revision: D33158445 fbshipit-source-id: 8371e5b96e772152eeb93ba990e1f5edb9e67085 |
||
|
Anton Nikolaev
|
2c976546c7 |
Redirect to Support Entry Point
Reviewed By: mweststrate Differential Revision: D33091179 fbshipit-source-id: da0c3e5fc21eef1693f7da2d00d90347bf2e0b51 |
||
|
Michel Weststrate
|
5ce5d897c8 |
Make loading of bundled plugins working and robust
Summary: Bundled plugins so far didn't load because the defaultPlugins was not generated yet. Fixed follow up errors that resulted from node modules not being available in the browser, and made the process more robust so that one plugin that fails to initialise doesn't kill all bundled plugins from being loaded. Cleaned up the server scripts, and reused the BUILTINS list that is already maintained in the babel transformer. Report errors during the build process if modules are referred that are stubbed out (later on we could maybe error on that) Reviewed By: aigoncharov Differential Revision: D33020243 fbshipit-source-id: 3ce13b0049664b5fb19c1f45f0b33c1d7fdbea4c |
||
|
Michel Weststrate
|
9e09c0d5f7 |
Stop exposing adbkit and crc32 as globals
Summary: Since no plugin directly uses adbkit or crc32 anymore, we removed them from the globals. They wouldn't work in the browser anyway Reviewed By: aigoncharov Differential Revision: D33019084 fbshipit-source-id: 66ab0756399fdb401c63f5e8271bdd62cb79ab4a |
||
|
Michel Weststrate
|
ac9080abac |
Remove 'process' usage
Summary: Removed process, adbkit and electron usages that were still remaining. Verified changes by disabling the built-in module stubbing (will be cleaned up further later in this stack). Reviewed By: aigoncharov Differential Revision: D33019083 fbshipit-source-id: 8bfce31f4b5ed349cb4fd86d34c9b41b9b8b8360 |
||
|
Michel Weststrate
|
accef856fc |
Remove remaining Node imports from core
Summary: Removed remaining path / fs imports from Flipper core. `expand-tide` needed replacement too, but noticed that it never actually rewrites paths since all use cases were already using absolute paths, so removed it instead. Reviewed By: aigoncharov Differential Revision: D33017654 fbshipit-source-id: e12f66ef68b5f9e4279411c94445a2fb87249e9a |
||
|
Michel Weststrate
|
d95b15094f |
Implement fs.readFile / fs.writeFile
Summary: Per title. Made an explicit distinction between binary and non binary files, since they need to be encoded differently. This keeps both the implementation and API simpler (in terms of overloading / type checking) Reviewed By: aigoncharov Differential Revision: D33016031 fbshipit-source-id: 3c99956eb016849a908a171d88a7a64a88b76268 |
||
|
Michel Weststrate
|
34a1da3345 |
Implement fs.stat and fs.readlink
Summary: Fixes issue for the stackTraceMapper Reviewed By: aigoncharov Differential Revision: D32987161 fbshipit-source-id: 660f49a1bdf61b2fd2963874ef23dfd284f71128 |
||
|
Michel Weststrate
|
0510786dec |
Fixed relilability issues in running health checks
Summary: Run doctor checks remained pending when the socket disonnected during a check. This Reviewed By: aigoncharov Differential Revision: D32984539 fbshipit-source-id: 277005e78803afaaa220cc5ca7fdc9cca6254453 |
||
|
Michel Weststrate
|
c1f6ca84b6 |
Fix overflow issue in WelcomeScreen
Summary: Noticed that the welcome screen started bleeding in the sidebar when the screen is too small. Unlike the plugin container it lacked an overflow: hidden. Reviewed By: timur-valiev, aigoncharov Differential Revision: D32987160 fbshipit-source-id: be324247cdb4abfeec12c40624d65f9fa1e86eff |
||
|
Michel Weststrate
|
fa67c21def |
Fix bug where client plugins weren't always started
Summary: Changelog: Fixed issue where occasionally a plugin wouldn't open after starting Flipper This fixes a long standing issue where rarely Flipper wouldn't show the selected plugin. This turned out to be a raise condition, that was easy to reproduce in the Flipper browser version; if a client register before all the plugins are loaded, the plugins that are enabled for that client, but not loaded yet, will not instantiate and hence not show up. This diff fixes that Reviewed By: timur-valiev, aigoncharov Differential Revision: D32987162 fbshipit-source-id: f3179cd9b6f2e4e79d05be1f2236f63acdf50495 |
||
|
Michel Weststrate
|
bb23b36051 |
Fixed flipper settings not being loaded / saved on fresh install
Summary: I was running flipper-server on a fresh machine without Flipper installed and discovered that reading / writing settings failed since `~/.flipper` wasn't existing, due to using `access` instead of `pathExists`. Added a warning about needing to restart the server after making changes, since that is tricky to do from the UI. Fixed an issue in the settings screen, which would fs.stat as part of rendering, causing the Settings UI not to load. Reviewed By: timur-valiev, aigoncharov Differential Revision: D32984538 fbshipit-source-id: 2b2011ad9d84c72ac824d92a8c96f636237b8771 |
