Commit Graph

6 Commits

Author SHA1 Message Date
Pascal Hartig
c84d16334b Remove redundant flow suppression
Summary: Per title.

Reviewed By: jknoxville

Differential Revision: D17341999

fbshipit-source-id: 181de3fd49c7dc48c4dc0b5f2e83e760f4cf873d
2019-09-12 08:12:42 -07:00
Mihaela Ogrezeanu
d77b5f0062 Custom button for expand/collapse node in Tree
Summary: When clicking a node in the tree, currently it expands or collapses the subtree under it. This adds a chevron button which only handles the expansion functionality, and clicking on the label with the Section name will show info about that Section in the side panel.

Reviewed By: fabiomassimo

Differential Revision: D17165150

fbshipit-source-id: ac6b6c127b68274f53523b3ea62422ff96116e9b
2019-09-04 10:50:41 -07:00
Pascal Hartig
2dd580f24a Fix flow errors (#502)
Summary:
We had a brief moment without Flow coverage, where this must have snuck
in. Not sure if there's a better type for `node` given the current
structure, but the rest should be obvious.
Pull Request resolved: https://github.com/facebook/flipper/pull/502

Test Plan: flow

Reviewed By: jknoxville

Differential Revision: D16533248

Pulled By: passy

fbshipit-source-id: 51e493208050e4af531e161fb49eda77fdf2494e
2019-07-29 06:08:37 -07:00
Mihaela Ogrezeanu
11198e003e Display data model in side panel
Summary:
This displays the data models passed to the Sections in the side panel when a data node is clicked. This does not change the collapse behaviour when a Section node is clicked.
To make it easier to associate a section with its changesets, appended the global indexes a Section is responsible for to the node label.

Reviewed By: passy

Differential Revision: D16283820

fbshipit-source-id: f1149f47dff448de05d919f7f8d16a2aba53bbb0
2019-07-17 06:29:22 -07:00
Mihaela Ogrezeanu
42c887e634 Add more fields on the Tree nodes
Summary:
Add fields for colouring the changeset operation that was performed on a node in the tree.
Changesets are not ordered by type of operation, they need to be displayed in order

Reviewed By: danielbuechele

Differential Revision: D16121158

fbshipit-source-id: 411557170b16ada9d1d72fb617b1aaf583e0f0e7
2019-07-16 07:33:12 -07:00
Mihaela Ogrezeanu
353f65cd7f Move Sections Plugin to OS folder
Summary: as title; we'd like to reuse this for the Litho sections plugin but not having it in OS makes setting up deps more difficult than it should be.

Reviewed By: danielbuechele

Differential Revision: D16052298

fbshipit-source-id: cd965688eff4fedbe57264e6676b6ca09b9deb45
2019-07-01 07:06:39 -07:00