Summary:
Flipper Launcher downloads, unpacks, launches Flipper, and closes itself.
This is fine except for the fact that Flipper may be initiating and thus there's a gap of a few seconds until engineers see the main Flipper UI.
This change improves this by launching earlier, even if just showing a loading page until Flipper is actually ready.
Reviewed By: passy, aigoncharov
Differential Revision: D48824479
fbshipit-source-id: aa6147a09f313d80592c9b08d089660ba73773a4
Summary: Make it more clear what are we checking about.
Reviewed By: aigoncharov
Differential Revision: D48781145
fbshipit-source-id: c3c03b407dc7f47730a3fb80de769243768b34ec
Summary: Comes from Electron. Will go away with PWA.
Reviewed By: lblasa
Differential Revision: D48778132
fbshipit-source-id: 0cecdc38e76b663315434aec995635afca2959dc
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5078
Reviewed By: aigoncharov
Differential Revision: D48778220
Pulled By: passy
fbshipit-source-id: 31f63b9f129f3d0c9914d9c4aba499e8cc7455dc
Summary: Changelog: Don't throw an error if Watchman was not found
Reviewed By: aigoncharov
Differential Revision: D48778121
fbshipit-source-id: bfe3599e41d8c6fbe4ea89393ace5213914a2611
Summary: Updating the remaining tsconfigs to build for an ES2021 target.
Reviewed By: antonk52
Differential Revision: D48687661
fbshipit-source-id: 2761704d251f701594ca5d362a17731f287088ed
Summary:
A little hacky because we currently have too many implementations for getting devices but lblasa is working on cleaning this up. Once that's done, we should add some tests for this.
Changelog: Show the iOS version of simulators in the launcher window
Reviewed By: lblasa
Differential Revision: D48777923
fbshipit-source-id: 18846520feba8eb10b6417f87bd802ffaabb1dff
Summary:
Starting small as this will unblock D48642120.
If it works without causing any issues, I'll update the remaining ones.
We're on Node v18 everywhere now, so this should be compatible. According to https://node.green/ that should cover nearly everything.
Reviewed By: lblasa
Differential Revision: D48683680
fbshipit-source-id: 26d2788468b673793b70b6339d1845c1dcf7e05d
Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.183 to 1.0.185.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.185</h2>
<ul>
<li>Fix error <em>"cannot move out of <code>*self</code> which is behind a shared reference"</em> deriving Serialize on a non_exhaustive enum (<a href="https://redirect.github.com/serde-rs/serde/issues/2591">https://github.com/facebook/flipper/issues/2591</a>)</li>
</ul>
<h2>v1.0.184</h2>
<ul>
<li>Restore from-source <code>serde_derive</code> build on all platforms — eventually we'd like to use a first-class precompiled macro if such a thing becomes supported by cargo / crates.io</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3c7dd6fc1e"><code>3c7dd6f</code></a> Release 1.0.185</li>
<li><a href="8b196ea1c8"><code>8b196ea</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2592">https://github.com/facebook/flipper/issues/2592</a> from dtolnay/remotenonexhaustive</li>
<li><a href="1f8c8ad5a3"><code>1f8c8ad</code></a> Fix "cannot move out of <code>*self</code> which is behind a shared reference"</li>
<li><a href="870925d503"><code>870925d</code></a> Add repro of issue 2591</li>
<li><a href="d593215ef7"><code>d593215</code></a> No need for slow macOS CI if there is no platform-specific code</li>
<li><a href="110af31b48"><code>110af31</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2590">https://github.com/facebook/flipper/issues/2590</a> from pinkforest/phase-out-precompiled</li>
<li><a href="360606b9a6"><code>360606b</code></a> Following consensus on: <a href="https://redirect.github.com/serde-rs/serde/issues/2580">https://github.com/facebook/flipper/issues/2580</a> (review)</li>
<li><a href="151b45ae36"><code>151b45a</code></a> Release 1.0.184</li>
<li><a href="4617c957b9"><code>4617c95</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2587">https://github.com/facebook/flipper/issues/2587</a> from wucke13/master</li>
<li><a href="2547ed83ca"><code>2547ed8</code></a> fix shebang in build.sh</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.183...v1.0.185">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5057
Reviewed By: lblasa
Differential Revision: D48685679
Pulled By: passy
fbshipit-source-id: dcc7e87ce7ee151a4946ed3dc59de405d48b936d
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.74 to 1.0.75.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.75</h2>
<ul>
<li>Partially work around rust-analyzer bug (<a href="https://redirect.github.com/rust-lang/rust-analyzer/issues/9911">rust-lang/rust-analyzer#9911</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6485caebde"><code>6485cae</code></a> Release 1.0.75</li>
<li><a href="238223af99"><code>238223a</code></a> Work around ridiculous rust-analyzer behavior</li>
<li>See full diff in <a href="https://github.com/dtolnay/anyhow/compare/1.0.74...1.0.75">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5055
Reviewed By: lblasa
Differential Revision: D48685685
Pulled By: passy
fbshipit-source-id: a30912de6677237fb2ad11bd3648f1d9862898eb
Summary:
[flipper] Don't break the build if the reactdevtools patching fails
There seems to be a bug in yarn workspaces on Windows:
```
Error: Cannot find module 'D:\\a\\flipper\\flipper\\desktop\\plugins\\public\\node_modules\\node_modules\\ts-node\\dist\\bin.js
```
Pull Request resolved: https://github.com/facebook/flipper/pull/5070
Test Plan: Let's see if CI will be happy again.
Reviewed By: lblasa
Differential Revision: D48681388
Pulled By: passy
fbshipit-source-id: d41f21be09c9d060e3c68e36466cfc54b3272325
Summary:
Symmetry with D48642974.
Changelog: Don't throw in C++ if a plugin gets added/removed multiple times.
Reviewed By: lblasa
Differential Revision: D48643116
fbshipit-source-id: cc6638061b1dee2a6f7deb1fab1093906decc24a
Summary: Removing this information from the error as it will cause duplicated error tasks.
Reviewed By: passy
Differential Revision: D48646678
fbshipit-source-id: 26e5525318b4720568275a5086df00f21b7d2836
Summary:
This change adds the necessary scaffolding to enable deep-link for PWA.
1. Registers the protocol/scheme in the manifest.json
2. Add a skeleton handler that parses the received arguments
Notes for reviewers:
PWA cannot reuse the 'flipper://' scheme as is not allowed. PWA schemes are limited. The only extension point is 'web+...' which is the one that is used.
Reviewed By: antonk52
Differential Revision: D48562301
fbshipit-source-id: e191fcb1a6604d20a55c1acdadf6a8eb0194895b
Summary:
The sessionId is just uuid() which is held by the config. This changes moves that to a single place.
This achieves two goals:
1) Makes it very clear where is created and what value it holds
2) It allows us to know the sessionId even before the config is available. This becomes useful as we can start logging to Scribe earlier.
Reviewed By: passy
Differential Revision: D48601829
fbshipit-source-id: c54d86d76f0b58d2b59f8dd1c45d7f345c4a84c3
Summary:
This change replaces the existing logging infra with the one defined and exposed in flipper-server-core.
Functionality remains the same with the addition of having support for Scribe.
Reviewed By: aigoncharov
Differential Revision: D48515246
fbshipit-source-id: 7970f6ad069821ee4f15136adc8da40d0b1fb0c7
Summary:
Gets rid of
{F1074904830}
See D48603710 for some more information.
This patches the bundle which includes the reference to silence the error.
Changelog: No longer show importFile.worker.worker.js warning on startup
Reviewed By: lblasa
Differential Revision: D48605129
fbshipit-source-id: 20dc292191742400c8c390a75b1e53f11630ad5a
Summary: The one-off hack for slog makes this hard to refactor, so I've added a headers field, putting the caller in charge of this.
Reviewed By: LukeDefeo
Differential Revision: D48564065
fbshipit-source-id: f8e78e9b8597fd3131bf3741197e6179807ad5da
Summary: As the type is now defined in flipper-common, it can be used.
Reviewed By: antonk52
Differential Revision: D48557043
fbshipit-source-id: 3838a189e431718cd1438d2dad5d7034d34bb93b
Summary: It removes the ScribeLogger found in flipper-ui-core and also updates its references to point to the type defined in flipper-common.
Reviewed By: passy
Differential Revision: D48556328
fbshipit-source-id: 525d9e8ee9a80f68aecb8b8b2e25ffd4714649bd
Summary:
Given that we have to retry aggressively to fetch reduciton traces the blok augmentation can take a longer time. For cases like embedded bloks this can slow down the ui debugger even if you arent debuggin bloks. To avoid this we display the frame immediatley and then asynchronously augment it.
There is a possibility that you might see bloks bound tree nodes with no name briefly since this is this the state they come from the client as.
This isnt the ideal solution as the better way would be to do the unminification first and then add the derived components (which depends on reduction trace) after. This avoid this qurik but is a much bigger refactor so will do it another time if needed
Reviewed By: lblasa
Differential Revision: D48600897
fbshipit-source-id: 06fc5c5ecc6fe575f815d3ebca685f363275c84c
Summary: Use the visualiser as a reference for the event table
Reviewed By: antonk52
Differential Revision: D48562105
fbshipit-source-id: 8707efdcb0631e9716dd0a06e01518480ca2edc1
Summary: Now when entering framework event table from a tree root we filter that so you can see all tree events. Also we use exact matches to avoid and nasty substring bugs
Reviewed By: lblasa
Differential Revision: D48560169
fbshipit-source-id: 1df375a2b8c5035003d82c210b55adebda8bd4ec
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5054
Reviewed By: ivanmisuno
Differential Revision: D48559248
Pulled By: passy
fbshipit-source-id: 8dc0741c63c43ed177769ce9e9bac46f40f3728a
Summary: There's nothing specific nor private about the ScribeLogger, so it is moved to flipper-common.
Reviewed By: LukeDefeo
Differential Revision: D48556074
fbshipit-source-id: aa9446036fd07fe6e6debc5a978a42308fc93fe0
Summary: The log tailer is already defined in flipper-common, use that instead.
Reviewed By: passy
Differential Revision: D48524909
fbshipit-source-id: 1c0674276f08893ea80dc2fc9f8b45679f33e93e
