Summary:
In newer builds of react-native if you passed parameters PRODUCTION=1, flipper pods won't get installed
you can see that in their codebase here [react_native_pods.rb](6a43fafd78/scripts/react_native_pods.rb (L140))
so when building ios `react-native-flipper` set `compiler_flags = '-DFB_SONARKIT_ENABLED=1'` in the podspec file
which initializeFlipper and lead to the following error:
`node_modules/react-native-flipper/ios/FlipperReactNativeJavaScriptPluginManager.h:12:9: 'FlipperKit/FlipperClient.h' file not found`
## Changelog
use same condition as react-native to wrap `s.compiler_flags = compiler_flags`
and conditionally pass `compiler_flags = '-DFB_SONARKIT_ENABLED=1'` to compiler_flags to avoid build problems
Pull Request resolved: https://github.com/facebook/flipper/pull/4275
Test Plan:
To reproduce
- create new react-native app
- install react-native-flipper `yarn add react-native-flipper`
- run `env PRODUCTION=1 npx pod-install `
- run `yarn ios`
Before patch:
```sh
node_modules/react-native-flipper/ios/FlipperReactNativeJavaScriptPluginManager.h:12:9: 'FlipperKit/FlipperClient.h' file not found
```
After patch:
```sh
▸ Build Succeeded
success Successfully built the app
```
Reviewed By: jknoxville
Differential Revision: D41298345
Pulled By: mweststrate
fbshipit-source-id: fb46772d46b8105fccb1abb673502bca428eea1d
Summary:
Latest Xcode 12 fails to build while without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. For more details please check: https://github.com/facebook/react-native/issues/29633#issuecomment-694187116
## Changelog
React Native Xcode 12 compatibility
Pull Request resolved: https://github.com/facebook/flipper/pull/1847
Test Plan: Use this branch to install with an app running on Xcode 12.
Reviewed By: mweststrate
Differential Revision: D25963723
Pulled By: priteshrnandgaonkar
fbshipit-source-id: a9642e242b5605f0f748f8f3b962af8455756ff4
Summary:
In line with, https://github.com/facebook/flipper/pull/874/files, the package should promote itself as iOS 9.0 compatibe, to prevent errors and warnings like:
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] CocoaPods could not find compatible versions for pod "react-native-flipper":
In Podfile:
react-native-flipper (from `../node_modules/react-native-flipper`)
Specs satisfying the `react-native-flipper (from `../node_modules/react-native-flipper`)` dependency were found, but they required a higher minimum deployment target.
```
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Downloading dependencies
Installing react-native-flipper 0.33.1
Generating Pods project
Integrating client project
Pod installation complete! There are 34 dependencies from the Podfile and 38 total pods installed.
[!] The platform of the target `ReactNativeFlipperExample` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
[!] The platform of the target `ReactNativeFlipperExampleTests` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
mweststrate-mbp:ios mweststrate$ cd ..
mweststrate-mbp:ReactNativeFlipperExample
```
Reviewed By: passy
Differential Revision: D20362156
fbshipit-source-id: 766d033f2ea2e5559a72a3473115bc4a470a284f
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.
## Changelog
[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795
Test Plan:
Tested using the RN TicTacToe example app
{F228406333}
Reviewed By: mweststrate
Differential Revision: D19853017
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
Summary:
This diff is part of the bigger task T60496135
This diff is based on D18706643, extracting only the react native module parts
It implements the entire Android client api for JavaScript, so that there is feature parity. However this implementation is happy path only, and edge cases will be handled in separate diffs
Reviewed By: jknoxville
Differential Revision: D19310265
fbshipit-source-id: 589716fe059952bdde98df84ed250c5c6feaa118
