Roman Karpenko
2be631ea4d
Fix Flipper lints #18
...
Summary: Fixed several lint errors mainly related to Warning/node/no-sync.
Reviewed By: passy
Differential Revision: D31795894
fbshipit-source-id: 020597d93232a8e84b25ea11a87d9481a6d2616f
2021-10-21 03:44:31 -07:00
Andrey Goncharov
37498ad5a9
Refactor server implementation for WebSockets
...
Summary:
Standardize WS implementation for JS environments.
Why do we need a separate server implementation for browsers?
Browser targets cannot authenticate via the default certificate exchange flow. For browser targets we verify the origin instead.
Moreover, for already forgotten reasons the initial implementation of the WS server for browsers used a different kind of message structure and added extra `connect`/`disconnect` messages. After examination, it seems the `connect`/`disconnect` flow is redundant.
Major changes:
1. Updated class hierarchy for WS server implementations.
2. Updated browser WS server to support the modern and the legacy protocols.
3. Now a websocket connection with the device is closed on error. The idea is it is highly unlikely to handle any subsequent messages properly once we observe an error. It is better to bail and reconnect. What do you think?
Reviewed By: mweststrate
Differential Revision: D31532172
fbshipit-source-id: f86aa63a40efe4d5263353cc124fac8c63b80e45
2021-10-21 03:34:15 -07:00
Flipper Bot
3a233129b3
Flipper Release: v0.116.0
...
Summary: Releasing version 0.116.0
Reviewed By: cekkaewnumchai
Differential Revision: D31789901
fbshipit-source-id: f714fa7195f5e07be72d8039074e8b745b657e72
2021-10-20 03:54:57 -07:00
Juan Tejada
0e91f8562a
Update React DevTools v4.20.1
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.20.1`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.20.1
Reviewed By: lunaruan
Differential Revision: D31762360
fbshipit-source-id: 9269a49afb263c78916852f51ebbd48ceaf531b0
2021-10-19 10:00:41 -07:00
Anton Kastritskiy
6facf5ed0f
Fix eslint warning for communist-spelling/communist-spelling rule
...
Summary: Fixes eslint warnings
Reviewed By: passy
Differential Revision: D31760180
fbshipit-source-id: 635e842d626c58a2a8d2ea2543bf171237e93dc4
2021-10-19 09:40:49 -07:00
Pascal Hartig
bd66928464
Fix Flipper lints #11
...
Summary: Turning off irrelevant lints for pkg/.
Reviewed By: nikoant
Differential Revision: D31734972
fbshipit-source-id: 845c4c0b0dea22973bc875ad0f86b5344a30280a
2021-10-19 09:21:36 -07:00
Pascal Hartig
b3fa8dd6c1
Dep bump
...
Summary:
Took a few iterations to make offline mirror happy, but everything is green now.
allow-large-files
Reviewed By: nikoant
Differential Revision: D31690614
fbshipit-source-id: 38d0d6cb5e3f63b3707d917a1ed6fc6144762731
2021-10-19 09:21:36 -07:00
Zack Brody
9d34c90b9a
Fix Date Label In Crashes Plugin
...
Summary: The date type for crash reports was updated in D29327501 (aff02b2ca1
2021-10-18 12:21:52 -07:00
Juan Tejada
b4647eaa13
Update React DevTools v4.20.0
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.20.0`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.20.0
Reviewed By: bvaughn
Differential Revision: D31694359
fbshipit-source-id: d05d75e9473878828617c5cd0db8d6008b6abd4d
2021-10-15 12:56:43 -07:00
Ananya Arun
df7bb59e9a
Add screenshots for in app debugging with preview
...
Summary:
Added ss for in app diagnostics using FB app as an example.
Image can be previewed as well if user wants more clarity.
Reviewed By: mweststrate
Differential Revision: D31679937
fbshipit-source-id: 550de8099c8912d2d6caa58c6c9c4c90ba78fabe
2021-10-15 02:48:59 -07:00
dependabot[bot]
5a795ad52a
Bump eslint-plugin-react from 7.25.1 to 7.26.1 in /desktop ( #2942 )
...
Summary:
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react ) from 7.25.1 to 7.26.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/yannickcr/eslint-plugin-react/releases ">eslint-plugin-react's releases</a>.</em></p>
<blockquote>
<h2>v7.26.0</h2>
<h3>Added</h3>
<ul>
<li>add [<code>no-namespace</code>] rule (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a> <a href="https://github.com/yacinehmito "><code>@yacinehmito</code></a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li><a href="docs/rules/jsx-max-props-per-line.md"><code>jsx-max-props-per-line</code></a>: add <code>single</code> and <code>multi</code> options (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a> <a href="https://github.com/SIL0RAK "><code>@SIL0RAK</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li><a href="docs/rules/display-name.md"><code>display-name</code></a>: Get rid of false position on component detection (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a> <a href="https://github.com/iiison "><code>@iiison</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[<code>no-access-state-in-setstate</code>]: passing test for “don't error if it's not a React Component” (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a> <a href="https://github.com/kentcdodds "><code>@kentcdodds</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3078 ">yannickcr/eslint-plugin-react#3078</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2640 ">yannickcr/eslint-plugin-react#2640</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2759 ">yannickcr/eslint-plugin-react#2759</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/1873 ">yannickcr/eslint-plugin-react#1873</a>
[<code>react/jsx-runtime</code>]: <a href="https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L163-L176 ">https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L163-L176 </a></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md ">eslint-plugin-react's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.26.0...v7.26.1 ">7.26.1</a> - 2021.09.29</h2>
<h3>Fixed</h3>
<ul>
<li>[<code>no-namespace</code>]: fix crash on non-string React.createElement name (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3082 ">#3082</a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>no-namespace</code>]: avoid crash on non-string createElement values (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3085 ">#3085</a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>jsx-no-target-blank</code>]: improve error messages (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3088 ">#3088</a> <a href="https://github.com/cutiful "><code>@cutiful</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[Docs] [<code>jsx-max-props-per-line</code>]: fix options example (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3083 ">#3083</a> <a href="https://github.com/MrRaiter "><code>@MrRaiter</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3088 ">#3088</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3088 ">yannickcr/eslint-plugin-react#3088</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3085 ">#3085</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issue/3085 ">yannickcr/eslint-plugin-react#3085</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3083 ">#3083</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3083 ">yannickcr/eslint-plugin-react#3083</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3082 ">#3082</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3082 ">yannickcr/eslint-plugin-react#3082</a></p>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.3...v7.26.0 ">7.26.0</a> - 2021.09.20</h2>
<h3>Added</h3>
<ul>
<li>add [<code>no-namespace</code>] rule (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a> <a href="https://github.com/yacinehmito "><code>@yacinehmito</code></a> <a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
<li>[<code>jsx-max-props-per-line</code>]: add <code>single</code> and <code>multi</code> options (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a> <a href="https://github.com/SIL0RAK "><code>@SIL0RAK</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>[<code>display-name</code>]: Get rid of false position on component detection (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a> <a href="https://github.com/iiison "><code>@iiison</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[<code>no-access-state-in-setstate</code>]: passing test for “don't error if it's not a React Component” (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a> <a href="https://github.com/kentcdodds "><code>@kentcdodds</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3078 ">#3078</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3078 ">yannickcr/eslint-plugin-react#3078</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2640 ">https://github.com/facebook/flipper/issues/2640 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2640 ">yannickcr/eslint-plugin-react#2640</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2759 ">https://github.com/facebook/flipper/issues/2759 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2759 ">yannickcr/eslint-plugin-react#2759</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/1873 ">https://github.com/facebook/flipper/issues/1873 </a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/1873 ">yannickcr/eslint-plugin-react#1873</a></p>
<h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.2...v7.25.3 ">7.25.3</a> - 2021.09.19</h2>
<h3>Fixed</h3>
<ul>
<li>[<code>prop-types</code>], <code>propTypes</code>: bail out unknown generic types inside func params (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3076 ">#3076</a> <a href="https://github.com/vedadeepta "><code>@vedadeepta</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[readme] Update broken link for configuration files (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3071 ">#3071</a> <a href="https://github.com/prateek3255 "><code>@prateek3255</code></a>)</li>
<li>[Refactor] create/extract <code>isCreateElement</code> and <code>isDestructuredFromPragmaImport</code> utils (<a href="https://github.com/ljharb "><code>@ljharb</code></a>)</li>
</ul>
<p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3076 ">#3076</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3076 ">yannickcr/eslint-plugin-react#3076</a>
<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/3071 ">#3071</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/3071 ">yannickcr/eslint-plugin-react#3071</a></p>
<h2>[7.25.2] - 2021.09.16</h2>
<h3>Fixed</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="119a7f3c737844d8ecbb8785c169c2a8ecd54b74a4bf7dad85eeb0144f148cf47a8ac2e4acd07cd483eb22651c95a8a4eb53https://github.com/yannickcr/eslint-plugin-react/compare/v7.25.1...v7.26.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2942
Reviewed By: passy
Differential Revision: D31390485
Pulled By: jknoxville
fbshipit-source-id: 92909bb967d0b0a62e3e5a927257d2d1e2cc53d4
2021-10-14 06:27:59 -07:00
dependabot[bot]
16e3a9cb3d
Bump axios from 0.21.4 to 0.22.0 in /desktop ( #2940 )
...
Summary:
Bumps [axios](https://github.com/axios/axios ) from 0.21.4 to 0.22.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/releases ">axios's releases</a>.</em></p>
<blockquote>
<h2>v0.22.0</h2>
<h3>0.22.0 (October 01, 2021)</h3>
<p>Fixes and Functionality:</p>
<ul>
<li>Caseless header comparing in HTTP adapter (<a href="https://github-redirect.dependabot.com/axios/axios/pull/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li>Avoid package.json import fixing issues and warnings related to this (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4041 ">#4041</a>), (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4065 ">#4065</a>)</li>
<li>Fixed cancelToken leakage and added AbortController support (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3305 ">#3305</a>)</li>
<li>Updating CI to run on release branches</li>
<li>Bump follow redirects version</li>
<li>Fixed default transitional config for custom Axios instance; (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4052 ">#4052</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/HEAD/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/mastermatt ">Matt R. Wilson</a></li>
<li><a href="https://github.com/chinesedfan ">Xianming Zhong</a></li>
<li><a href="https://github.com/DigitalBrainJS ">Dmitriy Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/blob/master/CHANGELOG.md ">axios's changelog</a>.</em></p>
<blockquote>
<h3>0.22.0 (October 01, 2021)</h3>
<p>Fixes and Functionality:</p>
<ul>
<li>Caseless header comparing in HTTP adapter (<a href="https://github-redirect.dependabot.com/axios/axios/pull/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li>Avoid package.json import fixing issues and warnings related to this (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4041 ">#4041</a>), (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4065 ">#4065</a>)</li>
<li>Fixed cancelToken leakage and added AbortController support (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3305 ">#3305</a>)</li>
<li>Updating CI to run on release branches</li>
<li>Bump follow redirects version</li>
<li>Fixed default transitional config for custom Axios instance; (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4052 ">#4052</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/master/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/mastermatt ">Matt R. Wilson</a></li>
<li><a href="https://github.com/chinesedfan ">Xianming Zhong</a></li>
<li><a href="https://github.com/DigitalBrainJS ">Dmitriy Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="72f14ceef73e016002086100f694b3https://github-redirect.dependabot.com/axios/axios/issues/4052 ">#4052</a>)</li>
<li><a href="ac10a254ef9bcff10dfahttps://github-redirect.dependabot.com/axios/axios/issues/3305 ">#3305</a>)</li>
<li><a href="fffa02cd2chttps://github-redirect.dependabot.com/axios/axios/issues/4065 ">#4065</a>)</li>
<li><a href="66d188d590https://github-redirect.dependabot.com/axios/axios/issues/4041 ">#4041</a>)</li>
<li><a href="f3ca6371cahttps://github-redirect.dependabot.com/axios/axios/issues/2880 ">https://github.com/facebook/flipper/issues/2880 </a>)</li>
<li><a href="4091b075f6https://github-redirect.dependabot.com/axios/axios/issues/4025 ">#4025</a>)</li>
<li>See full diff in <a href="https://github.com/axios/axios/compare/v0.21.4...v0.22.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2940
Reviewed By: passy
Differential Revision: D31390489
Pulled By: jknoxville
fbshipit-source-id: 3abea61aaa89e2320b81af78a3d6d02018c5f158
2021-10-14 06:27:59 -07:00
Lucas Bento
8b270ed204
Fix Settings window hotkeys alignment and colors ( #2961 )
...
Summary:
This PR fixes a few color issues (mainly on dark mode) and the alignment of the `React Native keyboard shortcuts` hotkeys.
I also took the liberty of changing the color of a few other icons.
### Light mode
|Before|After|
|---|---|
|||
### Dark mode
|Before|After|
|---|---|
|||
## Changelog
Fix `Settings` window hotkeys alignment and colors.
Pull Request resolved: https://github.com/facebook/flipper/pull/2961
Test Plan:
1. Run the app;
1. Press `⌘` + `,`;
2. Profit.
Reviewed By: mweststrate
Differential Revision: D31546032
Pulled By: passy
fbshipit-source-id: 5f7c73826cf6a367afb1ad758d1fd0451aaeb6cf
2021-10-14 06:07:46 -07:00
Pascal Hartig
91cc0ef3c0
Dep bump
...
Summary: Lots of open security warnings so I'm trying to catch a few that are behind patch releases at once.
Reviewed By: mweststrate
Differential Revision: D31574708
fbshipit-source-id: 5a4f2b18b50a3752b4986c4196a4bcda1e8a298c
2021-10-14 03:56:43 -07:00
dependabot[bot]
d3e28aa724
Bump @ant-design/icons from 4.6.3 to 4.7.0 in /desktop ( #2944 )
...
Summary:
Bumps [ant-design/icons](https://github.com/ant-design/ant-design-icons ) from 4.6.3 to 4.7.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/ant-design/ant-design-icons/commits ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2944
Reviewed By: timur-valiev
Differential Revision: D31390474
Pulled By: jknoxville
fbshipit-source-id: d918dc9d3f7a49376784d9e93ddea7321d31c772
2021-10-14 03:36:37 -07:00
Michel Weststrate
d4eb618cdd
change to zero exit if target app disconnects
...
Summary: Per yesterdays review, consider target app exiting as a signal to end the dump process.
Reviewed By: passy
Differential Revision: D31609065
fbshipit-source-id: fbd92f6c5344245d0bdae3f21be1a5d235aa1fa1
2021-10-14 03:17:47 -07:00
Michel Weststrate
a51c8caa09
Fix layout issue on plugin container
...
Summary: Reverted a change in D30192002 (9e5575cf69
2021-10-14 03:17:47 -07:00
Michel Weststrate
6589eb86c5
Improve port forwarding logging
...
Summary: Port forwarding tool was logging the child process object. Made the logging cleaner and more useful.
Reviewed By: nikoant
Differential Revision: D31608867
fbshipit-source-id: 1c2ae7c926ed4e1b44d51db5415874600acde7ae
2021-10-14 03:17:47 -07:00
Michel Weststrate
f43ff73591
Addressed some earlier diff comments
...
Summary: Async processed review feedback from stack D31474919 (cfd44b592a
2021-10-14 03:17:47 -07:00
Aaron Coplan
eba328e2a1
Implement screens list UI and copy action
...
Summary: TSIA, implementation for delete button coming in next diff. Note that Flipper doesn't seem to have a good Toast I could find so this is the best we have at the moment.
Reviewed By: nscoding
Differential Revision: D31496628
fbshipit-source-id: b9f94b3b2e757907b36e93b32d7f61448473a304
2021-10-13 14:23:16 -07:00
Flipper Bot
bee907fab4
Flipper Release: v0.115.0
...
Summary: Releasing version 0.115.0
Reviewed By: passy
Differential Revision: D31612162
fbshipit-source-id: 34f54f6cd7e6f67086081db982cafcc8cccea89c
2021-10-13 11:57:59 -07:00
Lorenzo Blasa
423a2c6c06
Alt ports to be reversed on Android
...
Summary: This change adds the alt ports to the list of ports to be reversed on Android
Reviewed By: mweststrate
Differential Revision: D31607559
fbshipit-source-id: 4e1201c7255fcd3a437c743f827ae4bceb746348
2021-10-13 10:31:41 -07:00
Anton Nikolaev
976e53ff9b
Avoid logging csr
...
Summary: I unintentionally added logging of csr certificates in my previous diff. This diff makes sure we're not logging them anymore.
Reviewed By: mweststrate
Differential Revision: D31609709
fbshipit-source-id: e43b348dbd62653f8a6e9089930c2a3699b29a12
2021-10-13 08:38:56 -07:00
dependabot[bot]
1c363cc5db
Bump ansi-to-html from 0.7.1 to 0.7.2 in /desktop ( #2969 )
...
Summary:
Bumps [ansi-to-html](https://github.com/rburns/ansi-to-html ) from 0.7.1 to 0.7.2.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/rburns/ansi-to-html/commits ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2969
Reviewed By: nikoant
Differential Revision: D31545803
Pulled By: passy
fbshipit-source-id: 113cb89b90819801668623b407d40fe18db6da38
2021-10-13 07:36:09 -07:00
dependabot[bot]
e97f335c31
Bump @typescript-eslint/experimental-utils from 4.31.0 to 4.33.0 in /desktop ( #2971 )
...
Summary:
Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils ) from 4.31.0 to 4.33.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases "><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.33.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0 ">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [lines-between-class-members] fix <code>exceptAfterOverload</code> for abstract methods (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3943 ">#3943</a>) (<a href="240fc65c30https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3937 ">#3937</a>) (<a href="c40dd13df7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3947 ">#3947</a>) (<a href="edaa3c10ebhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3940 ">#3940</a>) (<a href="40760f98dahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3944 ">#3944</a>) (<a href="f8f534e42bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3946 ">#3946</a>) (<a href="0868725713https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3934 ">#3934</a>) (<a href="ee5dfd4989https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3949 ">#3949</a>) (<a href="f022fb14c7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3837 ">#3837</a>) (<a href="214f898178https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0 ">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [consistent-type-definitions] correct fix for <code>export default</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3899 ">#3899</a>) (<a href="ebb33ed8bchttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3871 ">#3871</a>) (<a href="8aa87a136ehttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3868 ">#3868</a>) (<a href="dda9cee68ahttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3884 ">#3884</a>) (<a href="ed5e45983fhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3869 ">#3869</a>) (<a href="186135698bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3855 ">#3855</a>) (<a href="ffdb5ff990https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3852 ">#3852</a>) (<a href="9e98b8f43chttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3805 ">#3805</a>) (<a href="bdb8f0be14https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3887 ">#3887</a>) (<a href="806eaac6afhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3865 ">#3865</a>) (<a href="4195919973https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3349 ">#3349</a>) (<a href="4e999614e9https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3775 ">#3775</a>) (<a href="ec5d50696bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3916 ">#3916</a>) (<a href="13b7de508ehttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3873 ">#3873</a>) (<a href="25a42c0bbehttps://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2 ">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/experimental-utils/CHANGELOG.md "><code>@typescript-eslint/experimental-utils</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0 ">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>experimental-utils:</strong> add <code>getPhysicalFilename()</code> to <code>RuleContext</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3934 ">#3934</a>) (<a href="ee5dfd4989https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3949 ">#3949</a>) (<a href="f022fb14c7https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3837 ">#3837</a>) (<a href="214f898178https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0 ">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>experimental-utils:</strong> add missing signature for <code>isParenthesized</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3887 ">#3887</a>) (<a href="806eaac6afhttps://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2 ">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/experimental-utils</code></p>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.0...v4.31.1 ">4.31.1</a> (2021-09-13)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/experimental-utils</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="7bf8c9cb02f022fb14c7https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils/issues/3949 ">#3949</a>)</li>
<li><a href="ee5dfd4989https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils/issues/3934 ">#3934</a>)</li>
<li><a href="214f89817802c6ff3c5a806eaac6afhttps://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils/issues/3887 ">#3887</a>)</li>
<li><a href="eee47d0f902006056ad3https://github.com/typescript-eslint/typescript-eslint/commits/v4.33.0/packages/experimental-utils ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2971
Reviewed By: nikoant
Differential Revision: D31545788
Pulled By: passy
fbshipit-source-id: a5933b3832d3a234aeef8bd6722ff069ea8b8ae4
2021-10-13 07:36:09 -07:00
dependabot[bot]
8f9ecd6b2d
Bump node-fetch from 2.6.1 to 2.6.5 in /desktop ( #2970 )
...
Summary:
Bumps [node-fetch](https://github.com/node-fetch/node-fetch ) from 2.6.1 to 2.6.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/releases ">node-fetch's releases</a>.</em></p>
<blockquote>
<h2>v2.6.2</h2>
<p>fixed main path in package.json</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/v2.6.5/CHANGELOG.md ">node-fetch's changelog</a>.</em></p>
<blockquote>
<h2>v2.6.5</h2>
<ul>
<li>Fix: import <code>whatwg-url</code> in a way compatible with ESM</li>
</ul>
<h2>v2.6.4</h2>
<ul>
<li>Hotfix: fix v2.6.3 that did not sending query params</li>
</ul>
<h2>v2.6.3</h2>
<ul>
<li>Fix: properly encode url with unicode characters</li>
</ul>
<h2>v2.6.2</h2>
<ul>
<li>Fix: used full filename for main in package.json</li>
<li>Other: pinned codecov & teeny-request (had one breaking change with spread operators)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b5417aea6ahttps://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1303 ">https://github.com/facebook/flipper/issues/1303 </a>)</li>
<li><a href="18193c5922https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1301 ">https://github.com/facebook/flipper/issues/1301 </a>)</li>
<li><a href="ace7536c95https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1291 ">https://github.com/facebook/flipper/issues/1291 </a>)</li>
<li><a href="152214ca2fhttps://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1274 ">https://github.com/facebook/flipper/issues/1274 </a>)</li>
<li>See full diff in <a href="https://github.com/node-fetch/node-fetch/compare/v2.6.1...v2.6.5 ">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~endless ">endless</a>, a new releaser for node-fetch since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2970
Reviewed By: mweststrate
Differential Revision: D31545798
Pulled By: passy
fbshipit-source-id: b72c0fdefb821d3a5806c5421333c570497edf54
2021-10-13 07:36:08 -07:00
dependabot[bot]
342b5f7a12
Bump app-builder-lib from 22.11.1 to 22.14.4 in /desktop ( #2967 )
...
Summary:
Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib ) from 22.11.1 to 22.14.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases ">app-builder-lib's releases</a>.</em></p>
<blockquote>
<h2>22.14.4</h2>
<h1><a href="https://github.com/electron-userland/electron-builder/compare/v22.14.3...v22.14.4 ">electron-builder@22.14 .4</a> (2021-10-03)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>add appCannotBeClosed text for zh_CN (<a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6287 ">#6287</a>) (<a href="10b47273c3https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6308 ">#6308</a>) (<a href="fce1a1fab6https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6293 ">#6293</a>) (<a href="8ebfc96276https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6309 ">#6309</a>) (<a href="e29a6b8b36https://github.com/electron-userland/electron-builder/compare/v22.14.2...v22.14.3 ">v22.14.3</a> (2021-09-25)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>msi:</strong> fix broken shortcut icon when using msi target, adding msi option <code>iconId</code> (<a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6247 ">#6247</a>) (<a href="a9ec90d539https://github.com/electron-userland/electron-builder/compare/v22.13.1...v22.14.2 ">electron-builder@22.14 .2</a> (2021-09-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>(mac) Fix intel mac upgrade flow when both x64 and arm64 published (<a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6212 ">#6212</a>) (<a href="0c21cd6966https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6234 ">#6234</a>) (<a href="369f1fa793https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6229 ">#6229</a></li>
</ul>
<h3>Features</h3>
<ul>
<li>adding Bitbucket publisher and autoupdater (<a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6228 ">#6228</a>) (<a href="a945321647https://github.com/electron-userland/electron-builder/compare/v22.13.0...v22.13.1 ">electron-builder@22.13 .1</a> (2021-08-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>Adding snapStore to AllPublishOptions for generating Configuration schema (<a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6193 ">#6193</a>) (<a href="7f933d0004https://github-redirect.dependabot.com/electron-userland/electron-builder/issues/6185 ">#6185</a>) (<a href="f6a3053563https://github.com/electron-userland/electron-builder/compare/v22.12.1...v22.13.0 ">electron-builder@22.13 .0</a> (2021-08-25)</h1>
<h3>Features</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md ">app-builder-lib's changelog</a>.</em></p>
<blockquote>
<h2>22.14.4</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6308 ">#6308</a> <a href="fce1a1fab6https://github.com/sr258 "><code>@sr258</code></a>! - The filename of the app icon in macOS is now always 'icon.icns' instead of a derivate of the product name. The reason for this change is that macOS doesn't display icons with non-ASCII characters in their names, which is quite possible in languages other than English.</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6287 ">#6287</a> <a href="10b47273c3https://github.com/nonesand "><code>@nonesand</code></a>! - fix: add appCannotBeClosed text for zh_CN</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6300 ">#6300</a> <a href="b7e4c38298https://github.com/indutny-signal "><code>@indutny-signal</code></a>! - chore(nsis): fix i18n of appCannotBeClosed</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6309 ">#6309</a> <a href="e29a6b8b36https://github.com/GCKPaulYang "><code>@GCKPaulYang</code></a>! - fix: update assistedMessages.yml</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6293 ">#6293</a> <a href="8ebfc96276https://github.com/sr258 "><code>@sr258</code></a>! - Introduced env var to allow custom username for Bitbucket publish. This allows you to user a username different from the owner. No changes to interfaces or signatures that require changes in consumers.</li>
</ul>
<h2>22.14.3</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6247 ">#6247</a> <a href="a9ec90d539https://github.com/erikrz "><code>@erikrz</code></a>! - fix (msi): broken shortcut icon for desktop and startup entry (<a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/5965 ">#5965</a>)</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6277 ">#6277</a> <a href="b83d4ea778https://github.com/indutny-signal "><code>@indutny-signal</code></a>! - chore(nsis): internationalize appCannotBeClosed</li>
</ul>
<h2>22.14.2</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6248 ">#6248</a> <a href="f3590355c6https://github.com/mmaietta "><code>@mmaietta</code></a>! - fix: dmg-license as an optional dependency while still enabling docs site to build properly</li>
</ul>
<h2>22.14.1</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6244 ">#6244</a> <a href="8ccb2da5d4https://github.com/mmaietta "><code>@mmaietta</code></a>! - fix: dmg-license optional dependency</li>
</ul>
<h2>22.14.0</h2>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6228 ">#6228</a> <a href="a945321647https://github.com/mmaietta "><code>@mmaietta</code></a>! - feat: adding Bitbucket publisher and autoupdater</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies [<a href="a945321647builder-util@22.14 .0</li>
<li>electron-publish@22.14 .0</li>
</ul>
</li>
</ul>
<h2>22.13.1</h2>
<h3>Patch Changes</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="286d76818fhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6301 ">#6301</a>)</li>
<li><a href="fce1a1fab6https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6308 ">#6308</a>)</li>
<li><a href="e29a6b8b36https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6309 ">#6309</a>)</li>
<li><a href="8ebfc96276https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6293 ">#6293</a>)</li>
<li><a href="b7e4c38298https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6300 ">#6300</a>)</li>
<li><a href="10b47273c3https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6287 ">#6287</a>)</li>
<li><a href="d017cd7de3https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6251 ">#6251</a>)</li>
<li><a href="b83d4ea778https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6277 ">#6277</a>)</li>
<li><a href="62dd0829c5https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6270 ">#6270</a>)</li>
<li><a href="a9ec90d539https://github.com/electron-userland/electron-builder/commits/v22.14.4/packages/app-builder-lib ">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~onegoldfishh ">onegoldfishh</a>, a new releaser for app-builder-lib since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2967
Reviewed By: nikoant
Differential Revision: D31545917
Pulled By: passy
fbshipit-source-id: 6a5e8f65f619eee8af5af6fb16c12ce51794dafd
2021-10-13 07:36:08 -07:00
Michel Weststrate
598bdeb12a
Created a proof of concept flipper-dump
...
Summary: Created a quick-and-dirty flipper-dump command, to verify that the stand alone flipper-server-core can do it's job without the Electron Flipper
Reviewed By: passy
Differential Revision: D31543516
fbshipit-source-id: ce8e37316ab5f09700421bcf1c7830266e02c999
2021-10-12 16:00:53 -07:00
Michel Weststrate
d88b28330a
Move app/server to flipper-server-core
...
Summary: moved `app/src/server` to `flipper-server-core/src` and fixed any fallout from that (aka integration points I missed on the preparing diffs).
Reviewed By: passy
Differential Revision: D31541378
fbshipit-source-id: 8a7e0169ebefa515781f6e5e0f7b926415d4b7e9
2021-10-12 16:00:52 -07:00
Michel Weststrate
3e7a6b1b4b
Move metrics / tracking / error analysis to flipper-common package
...
Summary:
what else can I say
move_complexity
Reviewed By: passy
Differential Revision: D31483414
fbshipit-source-id: 1692c792121a3aae0843eb238040cae0445cdf54
2021-10-12 16:00:52 -07:00
Michel Weststrate
51bfc8f05d
Cleanup logger
...
Summary: Some cleanup around Logger, like renaming `getInstance` -> `getLogger`
Reviewed By: aigoncharov
Differential Revision: D31480828
fbshipit-source-id: d2fa9dc2b45bc34d846d45e396a74b80906d3ad5
2021-10-12 16:00:52 -07:00
Michel Weststrate
91d96774f6
Move files to flipper-common
...
Summary: Moved Logger, sleep, timeout and server contract types to flipper-common packages.
Reviewed By: passy
Differential Revision: D31475790
fbshipit-source-id: 42d2147698875f9e919ad5250f9953f3bff3ec2d
2021-10-12 16:00:52 -07:00
Michel Weststrate
cfd44b592a
Further decouple server from UI
...
Summary: Further decoupling of `server/` from the rest of the code base. Also fixed a problem with promise chaining causing promises to create unhandled rejection errors.
Reviewed By: passy
Differential Revision: D31474919
fbshipit-source-id: 027cccbe9b57d856c94d63c093d39b6cb3e53312
2021-10-12 16:00:52 -07:00
Anton Nikolaev
1fae3a24c9
Convert all connectivity logs from "log" to "info"
...
Summary: In a diff down the stack I introduced sending of info/warn/error logs to Scuba. Here I'm just changing level of all connectivity-related logging to "info" as they often required for investigations.
Reviewed By: mweststrate
Differential Revision: D31532770
fbshipit-source-id: 956d6712918291579b3beb12cb91ab69ce1e3859
2021-10-12 07:19:41 -07:00
Anton Nikolaev
64ce2e6f69
Show all plugins in the list even if there is no selected device / app
...
Summary: Just a small fix to ensure all plugins are shown in the list even if no device / app is connected to Flipper. We show them under "Unavailable plugins" with explanation why they not available. This allows user to check plugin documentation even without connecting anything to Flipper.
Reviewed By: passy
Differential Revision: D31532732
fbshipit-source-id: 4e481b3d6923bb073a1478b2bd283db25a374c72
2021-10-12 07:19:41 -07:00
Anton Nikolaev
5e3bddc08e
Fold warnings about plugins in legacy mode into a single message
...
Summary: As we now send warn logs to server - it better to reduce their count. This diff folds all the warnings for plugins using the legacy API into one warning.
Reviewed By: passy
Differential Revision: D31532559
fbshipit-source-id: 0621a170e11e9d9645964dd8ecf2f9e753273225
2021-10-12 07:19:41 -07:00
Pascal Hartig
dd190ef2e0
Big dep bump
...
Summary: Conservatively bumping only patch versions (except the ones we know break stuff).
Reviewed By: nikoant
Differential Revision: D31511737
fbshipit-source-id: 5b55b4689e71975824577f0ac43d806ca37ea232
2021-10-11 02:32:44 -07:00
Pascal Hartig
26ed0875cb
Change adb path resolution
...
Summary:
Quick drive-by change.
`path.resolve` accepts var-args so we don't resolve
to the wrong path on non-Unix systems.
Reviewed By: mweststrate
Differential Revision: D31502481
fbshipit-source-id: a963cd37d13eb8ef68bccf375f3e074fa8961a9e
2021-10-08 09:45:27 -07:00
Pascal Hartig
92ec974040
Update adb failure logging
...
Summary:
This is not actionable on our end because this will get
triggered for anyone setting a wrong ANDROID_HOME path.
Reviewed By: mweststrate
Differential Revision: D31502390
fbshipit-source-id: 529f1ba940cf6e38363933f706d167196116231a
2021-10-08 09:45:27 -07:00
Flipper Bot
e7b3ea9344
Flipper Release: v0.114.1
...
Summary: Releasing version 0.114.1
Reviewed By: passy
Differential Revision: D31501455
fbshipit-source-id: bfc85cf82b140364badff4a73069285f66b89b9f
2021-10-08 04:39:30 -07:00
Michel Weststrate
c3ff0ff355
Set up Flipper decapitated packages
...
Summary:
This diff introduces the packages necessary for Flipper decapitated.
* flipper-common: utilities & types shared between client, server, flipper-plugin
* flipper-server-core: all device & client management goes in here. Basically flipper's backend
* flipper-ui-core: all UI goes in here, as far as it doesn't depend on Electron
* desktop: the Electron app, will load server-core and ui-core, and glue them together, providing implementations for some electron specific stuff like dialgos
* flipper-server: A node process hosting flipper-server-core, that can be connected to over websockets. And probably can serve a browser version of the UI as well.
* flipper-ui-browser: thin wrapper around flipper-ui-core, providing some browser specific behavior / stubs.
* flipper-dump: (might remove later), but want to hack a quick and dirt flipper dump in here, as alternative way to test flipper-server-core.
This diff just creates the packages, but doesn't move any code, so it can be summarized as:
restoftheowl
Reviewed By: nikoant
Differential Revision: D30218646
fbshipit-source-id: 735598a1261a98e584f52504b5eba01ec0afa162
2021-10-08 01:33:03 -07:00
Michel Weststrate
d56375970d
Cleaning up sheet abstraction to use Ant/flipper-plugin dialogs instead
...
Summary:
This diff cleans up order remaining dialogs, the ones involved in exporting to file or url. Includes some legacy component cleanup boyscouting, but not too much.
This removes a lot of code where state of the wizard was stored globally, and makes it locally instead.
Other code that was removed involves interaction with the old UI, which allowed import / export to be running in the background as well. (which is no longer needed since we optimised the process)
Reviewed By: timur-valiev
Differential Revision: D30192000
fbshipit-source-id: 13be883c5bf217a3d58b610b78516359e9bd0ebc
2021-10-06 09:10:19 -07:00
Michel Weststrate
9e5575cf69
Dialog management cleanup
...
Summary:
This diff moves the dialogs
* Settings
* Plugin Manager
* Doctor
* Sign in
* Changelog
To use the imperative dialog APIs, rather then organising them through reducers which adds a lot of indirection which isn't really needed but hard to follow.
Reviewed By: passy
Differential Revision: D30192002
fbshipit-source-id: ba38b2e700da3e442653786448fcbf85074981ad
2021-10-06 09:10:19 -07:00
Michel Weststrate
89b193b438
Clean up Sheet abstraction
...
Summary: This stack gets rid of Flippers old sheet abstraction that relies on native (Electron) overlays, and implements it using Ant dialogs instead. Also removes a lot of code by making dialog API imperative, rather than reducer organised, like done in the deeplink handling.
Reviewed By: passy
Differential Revision: D30192001
fbshipit-source-id: 9bca3274bd039207e58f8f9394027515e391671d
2021-10-06 09:10:19 -07:00
Michel Weststrate
740093d0d9
Separate Client in server and client part
...
Summary: This diff separates the concept of a Client as now on the UI, from the concept of a Client as known on the server, and makes all interactions with client and vice versa async.
Reviewed By: timur-valiev
Differential Revision: D31235682
fbshipit-source-id: 99089e9b390b4c5359f97f6f2b15bf4b182b6cb9
2021-10-06 09:10:19 -07:00
Juan Tejada
eab4804792
Update React DevTools from 4.13.0 -> 4.19.1
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Sonar, etc.
`js1 upgrade react-devtools -v 4.19.1`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.19.1
Reviewed By: bvaughn
Differential Revision: D31345135
fbshipit-source-id: dae06a18699df19a6e8422460effd48f715e395b
2021-10-06 08:36:00 -07:00
Flipper Bot
49d41f15e3
Flipper Release: v0.114.0
...
Summary: Releasing version 0.114.0
Reviewed By: passy
Differential Revision: D31430620
fbshipit-source-id: fce3d83479199d27352c3b05d92fa6c5f0a69051
2021-10-06 08:09:30 -07:00
Pascal Hartig
37529af074
Track plugin selection steps
...
Summary: Sets up some logging for the various drop-out points when going through the deeplink flow.
Reviewed By: lblasa
Differential Revision: D31345623
fbshipit-source-id: a06ca97c1e687e39ea97a1f47fd8bb614149056f
2021-10-05 11:41:58 -07:00
Michel Weststrate
026f8fc308
Store clients as Map rather than array
...
Summary: Refactor clients storage: array -> map. A lot of logic looks up clients by their id, which is currently done with an array.find operation, which is pretty inefficient. This diff changes it to a map, that is pretty important, as in the next diff the decoupled client message handing will need to find the client again for every message that arrives.
Reviewed By: timur-valiev
Differential Revision: D31303536
fbshipit-source-id: ca3f540a3de7665930d2354436d37cb0fbfd5546
2021-10-04 07:27:24 -07:00
Michel Weststrate
c9a34d3cc2
Fix inconsistent handling of app id and name
...
Summary:
Changelog: Improved plugin / device / app selection handing.
During some refactorings I discovered that the `connetions.selectedApp` field contained sometimes an application id, and sometimes just the name. This caused inconsistent behavior especially in unit tests.
I've cleaned that up, and renamed it to `selectedAppId` where applicable, to make the distinction more clear.
And, in contrast, userPreferredApp now always has a name, not an id.
During refactoring our existing selection update logic was quite in the way, which was overcomplicated still, since during the sandy chrome migration, the reducers needed to be able to handle both the old UI, and the new application selection UI. That logic has been simplified now, and a lot of tests were added.
As a further simplification the preferredApp/Device/Plugin are now only read and used when updating selection, but not when running selectors.
Reviewed By: timur-valiev
Differential Revision: D31305180
fbshipit-source-id: 2dbd9f9c33950227cc63aa29cc4a98bdd0db8e7a
2021-10-04 07:27:24 -07:00
