Summary: Need a Fresco release including the previous diff first.
Reviewed By: danielbuechele
Differential Revision: D15762090
fbshipit-source-id: ec30778ffc1cd3e48dcfc4d514a9ba13fb26fd75
Summary: Includes the LeakTracker interface change. Restores the temporarily deleted tracker, wires it back up. Requires Fresco 0.14.2 being released which has yet to happen.
Reviewed By: oprisnik
Differential Revision: D15655667
fbshipit-source-id: ab4361be35101efe7564dfdd7a69cba93135eb7e
Summary: Required for the next diff as we make use of the new CloseableReference interface.
Reviewed By: oprisnik
Differential Revision: D15558423
fbshipit-source-id: 98ce5bf3f01a6f0e7ca568544709656c41093505
Summary:
This matches the latest stable Android Studio version which will loudly
complain unless you accept this modification.
Reviewed By: danielbuechele
Differential Revision: D15520117
fbshipit-source-id: 81301722d85cbcb07fc1b17b6ce7418d03103874
Summary:
Fresco plugin on the desktop side used to ask for all the image list along with the metadata when it was mounted. The mobile side never sent the image list and other information if not requested from it. That means, although Fresco plugin is a background plugin, there weren't any messages sent from the mobile side. Thus there was no trace available for Images plugin when the trace was exported. This diff, adds a hook which gets called before the export, where we request all the metadata from the mobile SDK.
BUG:
{F159305887}
Reviewed By: passy
Differential Revision: D15407962
fbshipit-source-id: 0012de2ab29d0f62e92d00f4926b04b1e394b62a
Summary: Noticed that this is still spamming the warning logs during build.
Reviewed By: danielbuechele
Differential Revision: D15354006
fbshipit-source-id: f34b99267d946ccb9ae0704beebbd48d39e9723a
Summary:
A very basic app with a scrolling list backed by a static data source. It also covers two bases that we hadn't before: Sections and Kotlin; the latter being the better choice for a modern Android tutorial anyway.
Missing right now: BUCK support (likely not going to come anytime soon due to the kapt limitations), the actual Flipper plugin integration (that's up next).
Reviewed By: jknoxville
Differential Revision: D15166195
fbshipit-source-id: 3cfaa1d243548279cabc4f244c13363f1bcaa36c
Summary:
Updating some deps and starting with the thing
that helps identify outdated things.
Reviewed By: jknoxville
Differential Revision: D14933477
fbshipit-source-id: 3a0f84abf97f9327ecab72388e114a1fb533504b
Summary:
as title.
Refactored the getPropsData from DebugComponentDescriptor and extracted it to separate class so we can use it for SectionComponentDescriptor as well.
Will follow up with adding state info
Reviewed By: passy
Differential Revision: D14386744
fbshipit-source-id: c6b9887aa9d0c8d2333e7e64fa0954e56b505e51
Summary:
Split off objecthelper into a (future) public and an fb-only version. This also open-sources the very first bit which is pretty useless on its own, but will already compile as its neatly stand-alone.
Note that this blocks releases until we have a stable version of Fresco to depend on.
Reviewed By: oprisnik
Differential Revision: D14149645
fbshipit-source-id: 0020d7ceccf89999695414ce389106ca6325ab7e
Summary:
We need this to continue to build with Fresco and
in preparation of AndroidX.
Reviewed By: muraziz
Differential Revision: D14149811
fbshipit-source-id: dd227f85ead23b8412706905f8723b3c153b28b7
Summary:
Last one that's available through the DSL. The Android
plugin still isn't.
Reviewed By: jknoxville
Differential Revision: D13176791
fbshipit-source-id: 6684812bb4fee1dcd9db1503e660fb019160224e
Summary:
Doesn't change how it works, but using the new recommended mechanism for loading plugins.
Pull Request resolved: https://github.com/facebook/flipper/pull/331
Reviewed By: jknoxville
Differential Revision: D13167476
Pulled By: passy
fbshipit-source-id: ac0ae925f5780136ce5c1fcb666faa79c19e049c
Summary:
Just a quick startup test that can save you the time of manually
opening the app.
I don't have any plans of hooking this up in Circle, but it's
still kinda useful to have.
Reviewed By: jknoxville
Differential Revision: D12901590
fbshipit-source-id: a16a1814574d9f27770dcf98c6b238517c589930
Summary: This is actually the new minimum required version for the gradle plugin we use.
Reviewed By: jknoxville
Differential Revision: D10505346
fbshipit-source-id: ce331851b74997369325f27f050efae07e4bf00c
Summary:
This allows breaking changes in Litho to be landed.
I'm also adding some helpers to determine if Flipper itself
is currently in a release or snapshot release train.
N.B. We don't publish snapshot releases for Flipper
right now, but will in the future where this will come in
handy.
Reviewed By: jknoxville
Differential Revision: D9359035
fbshipit-source-id: d21b607eca5d57caf4cc34234f6ba3cb0d8f307d
Summary: We don't use it, so we shouldn't download it.
Reviewed By: jknoxville
Differential Revision: D9262618
fbshipit-source-id: 56aef9abc788cc75790e1f70da6cc2a513e5f18b
Summary:
Made sure it builds with both buck and Gradle.
Follow-up to D8865149.
Reviewed By: danielbuechele
Differential Revision: D9178885
fbshipit-source-id: 46efaa532efdc1d59ce76e04be6680e233084881
Summary:
Important because we still run into soloader incompatibilities due
to the transitive dependency of Litho on Yoga on SoLoader. Sigh.
Reviewed By: priteshrnandgaonkar
Differential Revision: D8931213
fbshipit-source-id: 7e2de85deb5975dbe3f25e8145a9226d6684357c
Summary:
This moves the native setup to a separate gradle file and unpacks everything outside the build folder. That way we don't throw everything away on every incremental build.
This is an intermediate step to get to a more declarative setup like Fresco has it and get rid of the individual hacks we have for every download.
Pull Request resolved: https://github.com/facebook/Sonar/pull/154
Reviewed By: jknoxville
Differential Revision: D8833812
Pulled By: passy
fbshipit-source-id: 2424c9d6e22e6092c04af344e06939b4a6aba041
Summary:
Update some build dependencies (gradle, android plugin) and make some
minor cleanups in the gradle files along the way.
Pull Request resolved: https://github.com/facebook/Sonar/pull/151
Reviewed By: priteshrnandgaonkar
Differential Revision: D8818841
Pulled By: passy
fbshipit-source-id: 78b6592dbf967553aadead57a60023a0b5ae79b6
Summary:
There's been a new stable release and we no longer need to depend on the
snapshot releases.
Closes https://github.com/facebook/Sonar/pull/112
Reviewed By: danielbuechele
Differential Revision: D8659035
Pulled By: passy
fbshipit-source-id: 83763e521ffd53e031664e3b1d2714df769d1557
Summary:
The support libraries where out of sync between the projects, causing
the sample build to fail with
```
> Android dependency 'com.android.support:appcompat-v7' has different version for the compile (26.1.0) and runtime (27.1.1) classpath. You should manually set the same version via DependencyResolution
```
This makes sure that the sample submodule uses the top-level
dependencies and same versions.
Closes https://github.com/facebook/Sonar/pull/77
Reviewed By: emilsjolander
Differential Revision: D8447186
Pulled By: passy
fbshipit-source-id: e391501edd97fdbe6456b32cd7305d8be26e20db
