Commit Graph

1816 Commits

Author SHA1 Message Date
Benjamin Elo
c4a89da960 Automatically filtler out optional parameters from uri
Summary:
When a user enters a uri with optional parameters in the nav bar, I chose to automatically filter these out, yet still show the parameters in the nav bar.

The device receive uri's with no optional parameters, but the user will still see the parameters in the UI.

Reviewed By: danielbuechele

Differential Revision: D16762529

fbshipit-source-id: e3bbdf886dca7fba793b140b5fb303c4a77926ba
2019-08-12 07:17:02 -07:00
Benjamin Elo
9c80021d7c Removed duplicated functions after migration
Summary:
Pritesh and I both decided to re-add these functions without knowing that the other person had already re-added them.

Got through to master and now master won't build.

Reviewed By: priteshrnandgaonkar

Differential Revision: D16762774

fbshipit-source-id: 4a05d9e03cb043a6f398f57f2652a3ec15bd8985
2019-08-12 07:03:03 -07:00
Benjamin Elo
13fc0bec27 Minor improvements to Timeline view
Summary: Fixed issue with the timeline not having a key prop, and added some text when there are no navigation events.

Reviewed By: jknoxville, passy

Differential Revision: D16762034

fbshipit-source-id: 8f4618c8365c1a8b5a18b6176e1d80fc401f3ca5
2019-08-12 06:13:29 -07:00
Benjamin Elo
4305aba816 Migrate Sheet from js to ts
Summary: Migrated Sheet.js to Sheet.tsx

Reviewed By: passy

Differential Revision: D16735685

fbshipit-source-id: f910b38c9d0a8ac5d77203385599a03d0a4bc5bd
2019-08-12 06:06:43 -07:00
Benjamin Elo
7fd7a26d7d Migrate SignInSheet from js to ts
Summary: Migrated SignInSheet.js to SignInSheet.tsx

Reviewed By: danielbuechele

Differential Revision: D16735194

fbshipit-source-id: a7e039bf34b2784c55e6ebd4c8c17298a2f380cf
2019-08-12 06:06:43 -07:00
Benjamin Elo
4f47f73e5e Migrated ShareSheetExportFile from js to ts
Summary: Migrated ShareSheetExportFile.js to ShareSheetExportFile.tsx

Reviewed By: danielbuechele

Differential Revision: D16734995

fbshipit-source-id: 4528b27be0bfbefe9ddbd371c0bfc8950be6fe1f
2019-08-12 06:06:43 -07:00
Benjamin Elo
223cfe53d7 Migrate ShareSheetErrorList from js to ts
Summary: Migrated ShareSheetErrorList.js to ShareSheetErrorList.tsx

Reviewed By: jknoxville

Differential Revision: D16734553

fbshipit-source-id: ed608d5b171deda1caa284c27527e2f63af67ebb
2019-08-12 06:06:43 -07:00
Benjamin Elo
3e11e8887d Migrate ShareSheet from js to ts
Summary: Migrated ShareSheet.js to ShareSheet.tsx

Reviewed By: jknoxville

Differential Revision: D16734361

fbshipit-source-id: a6c050be19892f1650c1652536a62e4324ad949a
2019-08-12 06:06:42 -07:00
Benjamin Elo
d9cb55c8ae Migrate SelectPluginSheet from js to tsx
Summary: Migrated SelectPluginSheet.js to SelectPluginSheet.tsx

Reviewed By: jknoxville

Differential Revision: D16733361

fbshipit-source-id: c48e921761f4008a76a5000dd58aa2dd1aa42d2c
2019-08-12 06:06:42 -07:00
Benjamin Elo
11e817e1f2 Migrate ScreenCaptureButtons from js to ts
Summary: Migrated ScreenCaptureButtons.js to ScreenCaptureButtons.ts

Reviewed By: jknoxville

Differential Revision: D16733189

fbshipit-source-id: aabb7a82746609797c0448e441bbc79e65249191
2019-08-12 06:06:42 -07:00
Benjamin Elo
5c8be8f360 Migrate RatingButton from js to ts
Summary: Migrated RatingButton from RatingButton.js to RatingButton.tsx

Reviewed By: jknoxville

Differential Revision: D16732775

fbshipit-source-id: 380c8916f628115f474b575aef1b8a6e0c8863f9
2019-08-12 06:06:41 -07:00
Benjamin Elo
afe8ba65f0 Migrate Popover from js to ts
Summary: Migrated Popover.js to Popover.tsx

Reviewed By: passy

Differential Revision: D16732630

fbshipit-source-id: a7d44c7191972cd15ecb9530f6a146e7118c2b15
2019-08-12 06:06:41 -07:00
Benjamin Elo
e4b071e867 Migrate PluginDebugger from js to tsx
Summary: Migrated PluginDebugger.js to PluginDebugger.tsx

Reviewed By: passy

Differential Revision: D16732025

fbshipit-source-id: c4ff5586f823e90eba14eef5a8dac114a058763b
2019-08-12 06:06:41 -07:00
Benjamin Elo
8bbc03e138 Migrate MainSidebar from JS to TS
Summary: Migrated MainSidebar.js to MainSidebar.tsx

Reviewed By: passy

Differential Revision: D16731621

fbshipit-source-id: 57be95bf96c63105d05562cf0175e46c7f83aafa
2019-08-12 06:06:41 -07:00
Benjamin Elo
46b032d5ed Migrated ExportDataPluginSheet from js to ts
Summary: Migrated ExportDataPluginSheet.js to ExportDataPluginSheet.tsx

Reviewed By: passy

Differential Revision: D16731274

fbshipit-source-id: 5025f6eb34465d84e276f21855ee78cb98e8cd8d
2019-08-12 06:06:40 -07:00
Benjamin Elo
b5c01bdf36 Migrated BugReporterDialog from js to ts
Summary: Migrated BugReporterDialog.js to BugReporterDialog.tsx

Reviewed By: passy

Differential Revision: D16731216

fbshipit-source-id: 9ba70feed170eb1d017db88b980a3b449527f043
2019-08-12 06:06:40 -07:00
Benjamin Elo
dcda5741b9 Migrated LocationsButton from js to ts
Summary:
This isn't used anywher at the moment but I plan to add it in once we are finished with TS migration.

Migrated this file from LocationsButton.js to LocationsButton.ts

Reviewed By: jknoxville

Differential Revision: D16730904

fbshipit-source-id: d357785c462b1f5f6017b4c00a2d2467d905b895
2019-08-12 06:06:40 -07:00
Benjamin Elo
beaf4997fe Migrated DevicesButton from js to ts
Summary: Migrated DevicesButton from JS to TS

Reviewed By: passy

Differential Revision: D16730841

fbshipit-source-id: 3bfdb7945d82661f03d6a5b44b5404541a1b2c33
2019-08-12 06:06:39 -07:00
Benjamin Elo
c07fdd0485 Remove DevicesList as it is not used anywhere
Summary: This file is not used in the project and has been replaced by different logic in the DevicesButton.

Reviewed By: passy

Differential Revision: D16730618

fbshipit-source-id: b41c9dcef44690fee1331da2e3d66aa9e1394bad
2019-08-12 06:06:39 -07:00
Benjamin Elo
f7896a1f2b Migrate ErrorBar from .js to .tsx
Summary: Migrated the ErrorBar from JS to TS.

Reviewed By: passy

Differential Revision: D16730539

fbshipit-source-id: 3fd8c90f218f7a1d666c3d47380d56868c1cd23f
2019-08-12 06:06:39 -07:00
Benjamin Elo
12704269d7 Migrate DetailSidebar from js to tsx
Summary: Migrated DetailSidebar.js to DetailSidebar.tsx

Reviewed By: passy

Differential Revision: D16708503

fbshipit-source-id: 13090d6d44dbd01b162194c66724059d8e86a4c8
2019-08-12 06:06:39 -07:00
Benjamin Elo
8344b79fd4 Migrated CancellableExportStatus from js to ts
Summary: Moved CancellableExportStatus.js to CancellableExportStatus.tsx

Reviewed By: passy

Differential Revision: D16708431

fbshipit-source-id: 11eb4f5dbb851a9690a6abd136c1f144ed8a4b1a
2019-08-12 06:06:38 -07:00
Pritesh Nandgaonkar
47197f9552 Adding the deleted functions in application reducer
Summary:
Bug:

{F175972811}

Reviewed By: passy

Differential Revision: D16738491

fbshipit-source-id: 0f2675ed6d054d33ee9dbc7c4db9c34a2379abcf
2019-08-12 05:17:27 -07:00
Pascal Hartig
6c7aeef7ed Migrate exportMetrics
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16712087

fbshipit-source-id: 63dc45a26eb8112aef2b1bfa0d67bf57aa9ec72a
2019-08-12 03:53:16 -07:00
Pascal Hartig
99ca6aa7e8 Migrate exportData
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16711940

fbshipit-source-id: 2e0e5cd0440fe1cdb7bd29af94e22c7f6b9137f8
2019-08-12 03:53:15 -07:00
Pascal Hartig
8c05c73c5f Migrate launcher
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16711748

fbshipit-source-id: e874b5b6197e64ab7db1d8daecf42a4b52b8c2a8
2019-08-12 03:53:15 -07:00
Pascal Hartig
85aeaa0e47 Migrate geometry/snap
Summary: Seemed quite related.

Reviewed By: jknoxville

Differential Revision: D16711573

fbshipit-source-id: 3c6b355a5ed6fae5cb5bac824b57adcc2b28024a
2019-08-12 03:53:15 -07:00
Pascal Hartig
fcf99fda4b Migrate is{Headless,Production}
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16711115

fbshipit-source-id: 174e1d3057182c35a6e3493612ddcb3d6ba1ee54
2019-08-12 03:53:14 -07:00
Pascal Hartig
712669e800 Migrate electronCrashReporter
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16711091

fbshipit-source-id: e77e2d209998b847e467d353cccb64ccaab2718b
2019-08-12 03:53:14 -07:00
Benjamin Elo
0d5850d723 Added URI validation functions and UI for correcting errors
Summary:
Some uris parsed from the device contain required parameters. Here we parse the uri and check if there is a required parameter on navigation. If there is we alert the user to correct the error.

In the next diff, I will strip away non-required parameters if they are present but not filled in.

Reviewed By: danielbuechele

Differential Revision: D16710944

fbshipit-source-id: ea32cfe60e2bb5e4f395caebf585ba1b220dcefe
2019-08-12 03:17:22 -07:00
John Knox
ce34c20506 Convert utils/pluginUtils to TS
Reviewed By: danielbuechele

Differential Revision: D16710689

fbshipit-source-id: 8da309810f633af27759286521c784ac665531b9
2019-08-12 03:11:16 -07:00
John Knox
882d7e1a39 Convert utils/processConfig to TS
Reviewed By: danielbuechele

Differential Revision: D16710602

fbshipit-source-id: 3dbccdb0aedd3d5415487d690fb943aafdafa0f0
2019-08-12 03:11:16 -07:00
John Knox
fda506086f Convert utils/promiseTimeout to TS
Reviewed By: danielbuechele

Differential Revision: D16710520

fbshipit-source-id: 146ec33537de038d59e6f13647ee0de7b9edbcb8
2019-08-12 03:11:16 -07:00
John Knox
aab92446b4 Convert utils/reduxDevToolsConfig to TS
Reviewed By: danielbuechele

Differential Revision: D16710475

fbshipit-source-id: 8b2a9e9592354702f6ea5bfb777635fff4e0220b
2019-08-12 03:11:16 -07:00
John Knox
9b6f3684cb Convert utils/snap to TS
Reviewed By: danielbuechele

Differential Revision: D16710422

fbshipit-source-id: 2f907904a7df24f6972952d0c7a63d7e6506e2ff
2019-08-12 03:11:15 -07:00
John Knox
a522afd64f Convert utils/textContent.tsx to TS
Summary: Convert utils/textContent.tsx to TS

Reviewed By: danielbuechele

Differential Revision: D16710386

fbshipit-source-id: 225d66965d915fc1c36e382e3c06c7b2dad5d973
2019-08-12 03:11:15 -07:00
Pascal Hartig
fd9b83eac3 rm LRUCache
Summary: Appears to be unused.

Reviewed By: danielbuechele

Differential Revision: D16710463

fbshipit-source-id: 00ba195689ffc96700ae623fd02fb806b9730272
2019-08-09 10:47:15 -07:00
Pascal Hartig
7bb241bf63 Migrate androidContainerUtility*
Summary: Both util and internals.

Reviewed By: danielbuechele

Differential Revision: D16710453

fbshipit-source-id: e98972920084ce4d6bf083a48a442ab44c8e5f3e
2019-08-09 10:47:15 -07:00
Pascal Hartig
beba2799d2 Migrate errors
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16710217

fbshipit-source-id: a6596f84d6002f1972ae17170f9decaed853f991
2019-08-09 10:47:15 -07:00
Pascal Hartig
9e423e4bef Migrate environmentVariables
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16709690

fbshipit-source-id: efa0431ab1ab0e2fc81ae4a9155d2f0a3ab9e4c5
2019-08-09 10:47:14 -07:00
Pascal Hartig
8135727f5a Migrate crashReporterUtility
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16709553

fbshipit-source-id: 90d7d9bda703e650b5922f5c609bb884feaebf40
2019-08-09 10:47:14 -07:00
Pascal Hartig
b60a3fcfe9 Migrate CertificateProvider
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D16709300

fbshipit-source-id: ced6d2a40607f2eefe121463f47056e8e0e3b806
2019-08-09 10:47:14 -07:00
Pascal Hartig
b292ecec71 Migrate argvUtils
Summary:
_typescript_

Quite happy that the stupid check for `remote` can finally go away.

Reviewed By: jknoxville

Differential Revision: D16709217

fbshipit-source-id: 94bc035d2a7bbc3131e35febd48723760841f6b4
2019-08-09 10:47:13 -07:00
Pascal Hartig
c191514d68 Migrate adbConfig
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D16708956

fbshipit-source-id: 040421bfcd68821f3567b47104f1c0c678015f3f
2019-08-09 10:47:13 -07:00
Pascal Hartig
cf7e692620 Migrate adbClient
Summary:
Per title. Eliminated an attempt to catch an error
which never actually worked, but flow couldn't work out
how `promisify` works.

Reviewed By: danielbuechele

Differential Revision: D16708932

fbshipit-source-id: c1e98afd671ffd9bd8be25222366870ddf849ce3
2019-08-09 10:47:13 -07:00
Pascal Hartig
2e1dc7d40d Migrate ScribeLogger
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D16691033

fbshipit-source-id: 19da8bea4032e33a9bd219476aa12e2154dc3103
2019-08-09 10:47:13 -07:00
Pascal Hartig
b42abcbb59 Migrate logger
Summary:
Removed defunct log filtering functionality, but we probably want to rebuild that.
Funny that tsc caught this as non functioning but Flow happily accepted it.

Reviewed By: danielbuechele

Differential Revision: D16690959

fbshipit-source-id: b079dd6faba83ca0c443d00cbb69c8ff95c4fa69
2019-08-09 10:47:12 -07:00
Pascal Hartig
e56d3a4c6d Migrate user
Summary: Migrate user and introduce a global declarations file.

Reviewed By: danielbuechele

Differential Revision: D16690480

fbshipit-source-id: be4e5218715dcae4b403b24cdbc2f3e89728dd59
2019-08-09 10:47:12 -07:00
John Knox
4afc417ea5 Convert iOSDevice dispatcher to TS
Summary: Convert iOSDevice dispatcher to TS

Reviewed By: passy

Differential Revision: D16690183

fbshipit-source-id: 629ac178e91b4774449503529df7e07cee6741c5
2019-08-09 09:05:10 -07:00
John Knox
6da09fa381 Convert plugins dispatcher to TS
Summary: Convert plugins dispatcher to TS

Reviewed By: passy

Differential Revision: D16689874

fbshipit-source-id: afdac7960e267ebed350fcb170795689bd327807
2019-08-09 09:05:10 -07:00